aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAurimas Liutikas <aurimas@google.com>2021-05-05 12:39:30 -0700
committerAurimas Liutikas <aurimas@google.com>2021-05-07 22:33:22 +0000
commit6e914b3fe586f61c24e5add5e903a375be94f756 (patch)
tree0ba1896045b67bf6dd1fb8f2470fc79a13b68fcc
parenta2ce1af71555e552e468d68102b2145dd6d53ac7 (diff)
downloadtrebuchet-6e914b3fe586f61c24e5add5e903a375be94f756.tar.gz
Fix usage of minBy to unblock Kotlin 1.5 upgrade
Test: make traceviewer traceutils Change-Id: Id46f64aad971aa61456a73013cb5c268a3a01f32
-rw-r--r--core/common/src/main/kotlin/trebuchet/queries/SliceQueries.kt2
-rw-r--r--trebuchet/startup-common/src/StartupCommon.kt4
2 files changed, 3 insertions, 3 deletions
diff --git a/core/common/src/main/kotlin/trebuchet/queries/SliceQueries.kt b/core/common/src/main/kotlin/trebuchet/queries/SliceQueries.kt
index 79a9183..00f9953 100644
--- a/core/common/src/main/kotlin/trebuchet/queries/SliceQueries.kt
+++ b/core/common/src/main/kotlin/trebuchet/queries/SliceQueries.kt
@@ -113,7 +113,7 @@ fun ThreadModel.selectAll(predicate: (Slice) -> Boolean): List<Slice> {
* @param predicate The predicate used to test slices
*/
fun Model.selectFirst(predicate: (Slice) -> Boolean) : Slice? {
- return this.processes.values.mapNotNull { it.selectFirst(predicate) }.minBy { it.startTime }
+ return this.processes.values.mapNotNull { it.selectFirst(predicate) }.minByOrNull { it.startTime }
}
diff --git a/trebuchet/startup-common/src/StartupCommon.kt b/trebuchet/startup-common/src/StartupCommon.kt
index 75ed400..2cf4793 100644
--- a/trebuchet/startup-common/src/StartupCommon.kt
+++ b/trebuchet/startup-common/src/StartupCommon.kt
@@ -115,7 +115,7 @@ fun Model.findProcess(queryName: String,
map { it.slices }.
filter { it.isNotEmpty() }.
map { it.first().startTime }.
- min() ?: throw MissingProcessInfoException(process.id)
+ minOrNull() ?: throw MissingProcessInfoException(process.id)
if (firstSliceStart in lowerBound..upperBound) {
return process
@@ -142,7 +142,7 @@ fun Model.getStartupEvents() : List<StartupEvent> {
val newProc = this.findProcess(newProcName, systemServerSlice.startTime, systemServerSlice.endTime)
val startProcSlice = systemServerProc.findFirstSlice(SLICE_NAME_PROC_START, newProcName, systemServerSlice.startTime, systemServerSlice.endTime)
val rfdSlice = systemServerProc.findFirstSliceOrNull(SLICE_NAME_REPORT_FULLY_DRAWN, newProcName, systemServerSlice.startTime)
- val firstSliceTime = newProc.threads.map { it.slices.firstOrNull()?.startTime ?: Double.POSITIVE_INFINITY }.min()!!
+ val firstSliceTime = newProc.threads.map { it.slices.firstOrNull()?.startTime ?: Double.POSITIVE_INFINITY }.minOrNull()!!
val schedSliceInfo : MutableMap<SchedulingState, Double> = mutableMapOf()
newProc.threads.first().schedSlices.forEach schedLoop@ { schedSlice ->