diff options
author | Evgeniy Stepanov <eugeni.stepanov@gmail.com> | 2014-07-14 09:35:27 +0000 |
---|---|---|
committer | Evgeniy Stepanov <eugeni.stepanov@gmail.com> | 2014-07-14 09:35:27 +0000 |
commit | 01ed54b80ea0c0b149ebe16a37f4ebd5480f96d1 (patch) | |
tree | b0bb78515f4cb2487f435d445161f8b2a47e7bd2 | |
parent | c04e5a27a95288d5641826b637f070fd69d00554 (diff) | |
download | compiler-rt-01ed54b80ea0c0b149ebe16a37f4ebd5480f96d1.tar.gz |
[msan] Stop demangling function name in the stack origin report.
This was done by calling __cxa_demangle directly, which is bad
when c++abi library is instrumented. The following line always
contains the demangled name (when running with a symbolizer) anyway.
git-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk@212929 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r-- | lib/msan/msan_report.cc | 4 | ||||
-rw-r--r-- | test/msan/report-demangling.cc | 19 |
2 files changed, 21 insertions, 2 deletions
diff --git a/lib/msan/msan_report.cc b/lib/msan/msan_report.cc index 85e61e214..28dce8526 100644 --- a/lib/msan/msan_report.cc +++ b/lib/msan/msan_report.cc @@ -46,8 +46,8 @@ static void DescribeStackOrigin(const char *so, uptr pc) { Printf( " %sUninitialized value was created by an allocation of '%s%s%s'" " in the stack frame of function '%s%s%s'%s\n", - d.Origin(), d.Name(), s, d.Origin(), d.Name(), - Symbolizer::Get()->Demangle(sep + 1), d.Origin(), d.End()); + d.Origin(), d.Name(), s, d.Origin(), d.Name(), sep + 1, d.Origin(), + d.End()); InternalFree(s); if (pc) { diff --git a/test/msan/report-demangling.cc b/test/msan/report-demangling.cc new file mode 100644 index 000000000..e6d5c27ec --- /dev/null +++ b/test/msan/report-demangling.cc @@ -0,0 +1,19 @@ +// Test that function name is mangled in the "created by an allocation" line, +// and demangled in the single-frame "stack trace" that follows. + +// RUN: %clangxx_msan -fsanitize-memory-track-origins -m64 -O0 %s -o %t && not %run %t >%t.out 2>&1 +// RUN: FileCheck %s < %t.out && FileCheck %s < %t.out + +__attribute__((noinline)) +int f() { + int x; + int *volatile p = &x; + return *p; +} + +int main(int argc, char **argv) { + return f(); + // CHECK: WARNING: MemorySanitizer: use-of-uninitialized-value + // CHECK: Uninitialized value was created by an allocation of 'x' in the stack frame of function '_Z1fv' + // CHECK: #0 {{.*}} in f() {{.*}}report-demangling.cc:[[@LINE-10]] +} |