aboutsummaryrefslogtreecommitdiff
path: root/lld/MinGW
diff options
context:
space:
mode:
authorNico Weber <nicolasweber@gmx.de>2019-07-05 12:31:32 +0000
committerNico Weber <nicolasweber@gmx.de>2019-07-05 12:31:32 +0000
commita78027630133ac39a8edf09a91ca203a6a980dbe (patch)
tree4694158a3a0abbd3d5471a0bce4f8bc076bed178 /lld/MinGW
parent2478b62098415c2958ca5ec1354748fed8413ad2 (diff)
downloadllvm-project-a78027630133ac39a8edf09a91ca203a6a980dbe.tar.gz
lld, llvm-dlltool, llvm-lib: Use getAsString() instead of getSpelling() for printing unknown args
Since OPT_UNKNOWN args never have any values and consist only of spelling (and are never aliased), this doesn't make any difference in practice, but it's more consistent with Arg's guidance to use getAsString() for diagnostics, and it matches what clang does. Also tweak two tests to use an unknown option that contains '=' for additional coverage while here. (The new tests pass fine with the old code too though.) llvm-svn: 365200
Diffstat (limited to 'lld/MinGW')
-rw-r--r--lld/MinGW/Driver.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/lld/MinGW/Driver.cpp b/lld/MinGW/Driver.cpp
index 979d3091f6ad..62d8982403ae 100644
--- a/lld/MinGW/Driver.cpp
+++ b/lld/MinGW/Driver.cpp
@@ -105,7 +105,7 @@ opt::InputArgList MinGWOptTable::parse(ArrayRef<const char *> Argv) {
if (MissingCount)
fatal(StringRef(Args.getArgString(MissingIndex)) + ": missing argument");
for (auto *Arg : Args.filtered(OPT_UNKNOWN))
- fatal("unknown argument: " + Arg->getSpelling());
+ fatal("unknown argument: " + Arg->getAsString(Args));
return Args;
}