From 47c95702ee9a6154b412ecbe04d75daf49dff94b Mon Sep 17 00:00:00 2001 From: Martin Fick Date: Tue, 15 Jun 2010 11:54:30 -0700 Subject: Summarize the number of inline comments when publishing a review We always include a short message indicating the number of draft comments that were published, this triggers Gerrit to always display a top-level change message even though no scores were modified and no cover letter was written by the reviewer. Bug: issue 396 Change-Id: I1f7a1854b1a12d0ff5e5d27a5e077247b0fb4c71 --- .../com/google/gerrit/server/patch/PublishComments.java | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/patch/PublishComments.java b/gerrit-server/src/main/java/com/google/gerrit/server/patch/PublishComments.java index a4cc13f7..5b920331 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/patch/PublishComments.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/patch/PublishComments.java @@ -220,6 +220,8 @@ public class PublishComments implements Callable { db.patchSetApprovals().update(upd); db.patchSetApprovals().insert(ins); + + summarizeInlineComments(msgbuf); message(msgbuf.toString()); } @@ -298,4 +300,17 @@ public class PublishComments implements Callable { hooks.doCommentAddedHook(change, user.getAccount(), patchSet, messageText, changed); } + + private void summarizeInlineComments(StringBuilder in) { + if (!drafts.isEmpty()) { + if (in.length() != 0) { + in.append("\n\n"); + } + if (drafts.size() == 1) { + in.append("(1 inline comment)"); + } else { + in.append("(" + drafts.size() + " inline comments)"); + } + } + } } -- cgit v1.2.3