aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJosh Bartel <josh.bartel@garmin.com>2023-11-10 15:49:42 -0600
committerLUCI <gerrit-scoped@luci-project-accounts.iam.gserviceaccount.com>2023-11-13 20:51:19 +0000
commit6d821124e0f7fa2b6d9a5154851354cf4af70d9d (patch)
tree7c36a66ac1631d83f21244a0a915c76fbe928d4a
parent560a79727f5c9ec9ff16544159b444eeb42295ee (diff)
downloadrepo-6d821124e0f7fa2b6d9a5154851354cf4af70d9d.tar.gz
repo_logging: Ensure error details are printed
This updates RepoLogger.log_aggregated_errors to print out the error message the RepoExitError when there is not a list of aggregated errors. Previously it would log out: ======================================================================= Repo command failed: ManifestParseError This told us what class of error occurred but missed the helpful error message that developers put in the error. After this change it will now print out the error message: ======================================================================= Repo command failed: ManifestParseError error parsing manifest /path/to/manifest.xml: no element found: line 197, column 0 Change-Id: I4805540fddb5fa9171dbc8912becfa7fdfb1ba67 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/392614 Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com> Tested-by: Joshua Bartel <josh.bartel@garmin.com> Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
-rw-r--r--repo_logging.py1
1 files changed, 1 insertions, 0 deletions
diff --git a/repo_logging.py b/repo_logging.py
index 49f0ee8..20a5342 100644
--- a/repo_logging.py
+++ b/repo_logging.py
@@ -77,6 +77,7 @@ class RepoLogger(logging.Logger):
if not err.aggregate_errors:
self.error("Repo command failed: %s", type(err).__name__)
+ self.error("\t%s", str(err))
return
self.error(