summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-03-10gatekeeper: scudo: Increase heapHEADplatform-tools-35.0.1simpleperf-releasesdk-releasemastermain-16kmainbusytown-mac-infra-releaseMike McTernan
Storage requires a ~4K buffer to set the pin. Increase the heap to accomodate when using scudo (4x overhead of dlmalloc). Bug: 272705599 Test: adb shell locksettings set-password 1234567890 Change-Id: Ifbde0d6359f39080e671ee03dffb872b46160790
2023-02-07add manifest for scudoMarco Nelissen
Change-Id: Ia12499b06add59b24173d26d3c417d3d25b35db2
2022-12-03properly use return value of storage_delete_fileArmelle Laine
Bug: 244777939 Change-Id: I3ce7de7a2faa82ee73c4850807c96a4b813d1dfb
2022-01-26Fix race condition in gatekeeper ipcArmelle Laine
Current trusty ipc logic (trusty/kernel/lib/trusty/tipc_virtio_dev.c) drops a message on a channel when its receive fifo is full (the receive fifo size is determined by the argument `recv_buf_size` passed in the port_create api). Filling the receive fifo can only happen when a new message is received while the previous one has not been retired yet (via a call to put_msg). HAL to TA IPC won't hit this issue when following the recommended pattern: - HAL: - send a message - wait for its response - send the next message. - TA: - receive a message - retire it from the receive fifo - then send the response. Prior to this fix, gatekeeper TA used to send the response THEN retire the message, while having a receive fifo size of 1. This creates the race condition where the message would be dropped. The fix consists in retiring the message (put_msg) prior to sending the response. Bug: 211378534 Change-Id: I957e72183d92131adb37316f29d7e2963679df29
2021-04-19Update references to trusty-specific libc headersStephen Crane
Trusty-specific libc headers have moved to trusty/*. Updates references to these headers with the new path. Test: build.py qemu-generic-arm64-test-debug Bug: 169448829 Change-Id: Id2beaf5bad4853c235cdce68c4b6baea966d73ad
2021-04-19Add gatekeeper app to userspace library build systemStephen Crane
Switch to building gatekeeper with the trusted_app.mk system instead of as a generic lk module. This allows the app to depend on common userspace static libraries. Test: build.py qemu-generic-arm64-test-debug Bug: 169448829 Change-Id: I1798bd8ae04d6c748a6e5fa038965496e43a7745
2021-04-10Change TLOGI calls in normal execution path to TLOGDArmelle Laine
The log statements clutter the early boot log. Bug: 184759599 Change-Id: Ibe5b286a440fe11c94ded2b5db357623fa589799
2021-02-16Allow setting gatekeeper storage port at build timeMarco Nelissen
Default to STORAGE_CLIENT_TD_PORT which is what was used so far, but allow overriding by setting the GATEKEEPER_STORAGE_PORT variable. Bug: 160731903 Test: build, run Change-Id: I2ff5ba068874fabe316c429aeae7027f83964fff
2021-02-01Implement DeleteUser/DeleteAllUsersMarco Nelissen
Implement DeleteUser/DeleteAllUsers and fix some inconsistencies between failure records in secure storage and memory storage: - attempting to read a missing storage record was treated as an error, whereas reading a missing memory record created a new one (now they're both errors) - storage records were keyed by uid, but memory records were keyed by SID, which made it possible to have multiple memory records with different passwords for the same uid (now they're both keyed by uid, and re-enrolling replaces the previous record for both storage and memory) Bug: 160731903 Test: "atest VtsHalGatekeeperV1_0TargetTest" manual testing with added instrumentation Change-Id: Icf28f3add488a35dfca3f0d05ab4911daf3546ba
2021-01-25Add DeleteUser and DeleteAllUsers to gatekeeperMarco Nelissen
Also fix a few places where gatekeeper error codes were interpreted as tipc error codes Bug: 160731903 Test: "atest VtsHalGatekeeperV1_0TargetTest" manual testing with added instrumentation Change-Id: I020464eb784a6dec698867f731760616ae945bc1
2020-07-27Rename "master key" => "password key"Nick Bray
Both names were used in the codebase and "password" was a clearer name and also a better fit with inclusive language guidence. https://source.android.com/setup/contribute/respectful-code Bug: 161896447 Change-Id: I55a2e3538da7271fe59c0542191433b78bfa0cd4
2020-03-10Switch from manifest.c to manifest.json configRajesh Nyamagoud
Bug: 130560272 Change-Id: I008eed87f78d46f74bc9c8f9ad1def0deb8cf17c
2019-09-04Avoid GK memory leakMatthew Maurer
GetAuthTokenKey is intended to retain ownership of the returned key. To follow this, we cache the result of speaking to keymaster. Bug: 129768470 Bug: 140434850 Bug: 131618642 Change-Id: I36965eed01296c0f13d93f9dac7520bdc8006fb3
2019-04-10Use INFINITE_TIME instead of -1Matthew Maurer
Bug: 129300035 Change-Id: Id157dd014768680c3fc2ef373eaa6fd3ad1b1afa
2019-02-26Refactor use of iovec struct.Nick Bray
Use "struct iovec" instead of "iovec_t". Prefix field names with iov_ Bug: 110161494 Change-Id: I9e759de36b65ef8e3a1cd6a4d370e8b3d0d486e5
2018-12-14Make logging statements portable.Nick Bray
uint64_t is not guaranteed to be a long long double, use %PRIu64 instead of %lld. Bug: 110161494 Change-Id: If6fed2c108471cc4fa5391a7b7ff2dfe52303ed7
2018-12-04Clean up gatekeeper app in preparation for 64-bit appsMichael Ryleev
Bug: 120497636 Change-Id: Ica85723262d2bfa94a35b2dc90a589eeb71f19f4
2018-11-30Update logging to use new TLOGX marcosMichael Ryleev
Bug: 119891603 Change-Id: Ib34676e62097492209bcf2278706ba992f0914fc
2018-11-12Prefix gettime and nanosleep with trusty_.Nick Bray
Bug: 110161494 Change-Id: If93151657aa5fdd755046075a13fd339db93355c
2018-10-30Eliminate the use of status_t.Nick Bray
status_t is a kernel type that should not be used in userspace. Bug: 110161494 Change-Id: Idf54e319d715f452a8f6a757ace972b752f4bc70
2018-10-10Whitelist variable-length arrays for gatekeeper.Nick Bray
This will allow -Wvla to be turned on for the rest of the code base. In the future the use of VLAs in gatekeeper should be eliminated. Bug: 114232578 Change-Id: If5027563dea26039fa06c573ccf93ed17394c748
2018-08-16Remove dependency on app/trusty moduleMichael Ryleev
Bug: 111521896 Change-Id: Ie1f0f84750edebada72f981f976c204518f9547d
2018-08-15Update references to libc-trusty and libstdc++-trustyMichael Ryleev
Update makefiles to reference libc-trusty and libc++-trusty modules relative to the top of the tree. Bug: 111521896 Change-Id: Ie7a25e8d3815e48081a7dd8cc6b8131dcaf75b72
2018-08-15Update references to interface modules and client librariesMichael Ryleev
All interface modules and client libraries mapped under trusty/user/base should be referenced relative to top of the tree. Bug: 111521896 Change-Id: I175fda20dbb146eeff0bdcb3b3b10dc0a2cad12c
2018-07-26Enable pre-upload clang formatting.Nick Bray
Also re-format the code with clang format. Bug: 110489128 Change-Id: I56075cab57be2d929d6481c92934fb94f839c81e
2018-07-18Switch to use TRUSTY_TOP to reference external modulesMichael Ryleev
In preparation for restructuring of Trusty source tree, switch to reference hardware/libhardware/include directory relative to the top of the source tree designated by TRUSTY_TOP variable instead of using LOCAL_DIR. Change-Id: Iaf1828ce1f4c2718f903299e53bffacc89b1dfe0
2018-06-15Remove references to trusty_std.h.Nick Bray
Explicitly include the required header files instead. Also eliminate unneeded 'extern "C"' declarations. Also opportunistically reorder includes. Bug: 110159511 Change-Id: I6c99b86e3ecf32c2a216a91a6c3b68bcbc5d5369
2018-02-13Use new include paths.Nick Bray
Also make libhardware header include path explicit. This will make it possible to remove libhardware as a global overlay. Change-Id: Id21968e8b2dbb63e074ca247979530a4d876681e
2016-04-28trusty_gatekeeper: fix compile warningsMichael Ryleev
Change-Id: I1d02ed31d451f0385cdc70649bdbcc04704b9d98
2016-04-15trusty_gatekeeper: fixup to accomodate changes with secure storage APIMichael Ryleev
Fix potential storage session leak. Fixup couple warnings Change-Id: I1a4fb82a070bce55e201ccc8895f68900aaec922
2016-03-25trusty_gatekeeper: Specify port to use for storage sessionArve Hjønnevåg
Change-Id: Icd1fdcbafc42963f23867a6b73929361c1240901
2016-02-10Switch to use proper flag calling storage_open_fileMichael Ryleev
Change-Id: I152aa9a66df9a9c012fc6723af8d7b1e85fc344a
2016-02-10Fix white space formattingMichael Ryleev
Change-Id: If8dfe5a39d3fbbae81cd7bc5aa75e138a93e856b
2015-10-09Initial TrustyGateKeeperBill Yi