diff options
| author | Hyunwoo Kim <imv4bel@gmail.com> | 2022-06-20 07:17:46 -0700 |
|---|---|---|
| committer | Lee Jones <joneslee@google.com> | 2022-12-22 23:00:28 +0000 |
| commit | 9cf3f714b41f4b68d03be7d94ccd2ba933bc6757 (patch) | |
| tree | 96cd26bd4a23e258919f51cfc43a25a4cb00b0f4 | |
| parent | 35ef3b94dcc2dd8a3f2979aa039426be054afe7b (diff) | |
| download | common-android13-5.10-2022-07.tar.gz | |
UPSTREAM: video: fbdev: pxa3xx-gcu: Fix integer overflow in pxa3xx_gcu_writeandroid13-5.10-2022-07_r5deprecated/android13-5.10-2022-07android13-5.10-2022-07
[ Upstream commit a09d2d00af53b43c6f11e6ab3cb58443c2cac8a7 ]
In pxa3xx_gcu_write, a count parameter of type size_t is passed to words of
type int. Then, copy_from_user() may cause a heap overflow because it is used
as the third argument of copy_from_user().
Bug: 245928838
Signed-off-by: Hyunwoo Kim <imv4bel@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Lee Jones <joneslee@google.com>
Change-Id: I9e21917a52e2cb78cc640a77a6eba21838aa8655
Signed-off-by: Lee Jones <joneslee@google.com>
| -rw-r--r-- | drivers/video/fbdev/pxa3xx-gcu.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/video/fbdev/pxa3xx-gcu.c b/drivers/video/fbdev/pxa3xx-gcu.c index 4279e13a3b58..3f2306419947 100644 --- a/drivers/video/fbdev/pxa3xx-gcu.c +++ b/drivers/video/fbdev/pxa3xx-gcu.c @@ -381,7 +381,7 @@ pxa3xx_gcu_write(struct file *file, const char *buff, struct pxa3xx_gcu_batch *buffer; struct pxa3xx_gcu_priv *priv = to_pxa3xx_gcu_priv(file); - int words = count / 4; + size_t words = count / 4; /* Does not need to be atomic. There's a lock in user space, * but anyhow, this is just for statistics. */ |