diff options
| author | Arve Hjønnevåg <arve@android.com> | 2011-01-07 19:00:01 -0800 |
|---|---|---|
| committer | Colin Cross <ccross@android.com> | 2011-01-10 16:16:39 -0800 |
| commit | 5947e496b6dea68354785458a3bb07b5ca78ae85 (patch) | |
| tree | a07633dd841c4b25178db07d73e4b932078b46c5 | |
| parent | 77fc4228f72d803cace13cfec6a4076b38601bd5 (diff) | |
| download | qemu-5947e496b6dea68354785458a3bb07b5ca78ae85.tar.gz | |
rtc: alarm: Update hrtimer if alarm at the head of the queue is reprogrammed
If an alarm was restarted with a value that moved it away from the head
of a queue, the hrtimer would not be updated. This would cause unnecessary
wakeups.
Change-Id: If379f8dd92b0bdb3173bd8d057adfe0dc1d15259
Signed-off-by: Arve Hjønnevåg <arve@android.com>
| -rw-r--r-- | drivers/rtc/alarm.c | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/drivers/rtc/alarm.c b/drivers/rtc/alarm.c index 1250edfbdf3..b445a867585 100644 --- a/drivers/rtc/alarm.c +++ b/drivers/rtc/alarm.c @@ -109,12 +109,15 @@ static void alarm_enqueue_locked(struct alarm *alarm) struct rb_node *parent = NULL; struct alarm *entry; int leftmost = 1; + bool was_first = false; pr_alarm(FLOW, "added alarm, type %d, func %pF at %lld\n", alarm->type, alarm->function, ktime_to_ns(alarm->expires)); - if (base->first == &alarm->node) + if (base->first == &alarm->node) { base->first = rb_next(&alarm->node); + was_first = true; + } if (!RB_EMPTY_NODE(&alarm->node)) { rb_erase(&alarm->node, &base->alarms); RB_CLEAR_NODE(&alarm->node); @@ -134,10 +137,10 @@ static void alarm_enqueue_locked(struct alarm *alarm) leftmost = 0; } } - if (leftmost) { + if (leftmost) base->first = &alarm->node; - update_timer_locked(base, false); - } + if (leftmost || was_first) + update_timer_locked(base, was_first); rb_link_node(&alarm->node, parent, link); rb_insert_color(&alarm->node, &base->alarms); |