diff options
| author | Colin Cross <ccross@android.com> | 2024-05-07 16:55:00 -0700 |
|---|---|---|
| committer | Colin Cross <ccross@android.com> | 2024-05-15 23:02:29 +0000 |
| commit | 3f3ac2c75b1cef76ef2af73371880cce8ec43455 (patch) | |
| tree | 41bf31be76db0293dc1926c224881958baffc309 /PREUPLOAD.cfg | |
| parent | a57f3e98e7ef099e491785bfa5935374ce116b03 (diff) | |
| download | art-3f3ac2c75b1cef76ef2af73371880cce8ec43455.tar.gz | |
Use isolated: true instead of test_per_src: true in libnativebridge_tests
libnativebridge_tests uses test_per_src: true to avoid running
multiple tests in the same process. gtest_isolated uses separate
processes for each test, but without the various incompatibilities
caused by test_per_src. Switch to isolated: true instead.
Create a temporary directory in the constructor of the shared
NativeBridgeTest base class instead and put the code_cache directory
inside it to keep the tests from trying to modify the current
directory.
Also add the tests to TEST_MAPPING and remove the preupload check.
Bug: 189484095
Test: atest --host libnativebridge_tests
Test: atest libnativebridge_tests
Flag: TEST_ONLY
Change-Id: Iea522c1895f1f5996b10e545c44d6b00bda1ee3d
Diffstat (limited to 'PREUPLOAD.cfg')
| -rw-r--r-- | PREUPLOAD.cfg | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/PREUPLOAD.cfg b/PREUPLOAD.cfg index c5b3c9c18d..d43a1e90ba 100644 --- a/PREUPLOAD.cfg +++ b/PREUPLOAD.cfg @@ -3,10 +3,6 @@ check_generated_tests_up_to_date = tools/test_presubmit.py hidden_api_txt_checksorted_hook = ${REPO_ROOT}/tools/platform-compat/hiddenapi/checksorted_sha.sh ${PREUPLOAD_COMMIT} ${REPO_ROOT} -# TODO(b/189484095): Port libnativebridge tests to atest and enable in presubmit -# so we don't need the custom runtests script and this check. -check_libnativebridge_test_field = libnativebridge/tests/preupload_check_test_tag.sh ${PREUPLOAD_COMMIT_MESSAGE} ${PREUPLOAD_FILES} - check_expectation_jsons = tools/check_presubmit_json_expectations.sh ${REPO_ROOT} ${PREUPLOAD_FILES} [Builtin Hooks] |