diff options
author | Nick Desaulniers <ndesaulniers@google.com> | 2024-04-17 21:19:27 +0000 |
---|---|---|
committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2024-04-17 21:19:27 +0000 |
commit | 0be8f184c2de976b1370e668ce2bf2e49d6c8a5b (patch) | |
tree | d769b0e768d83cff261f72eefb6cb4e7ddb382cc | |
parent | 0b1161d9b560b69d387b678de5a9c27af8c6cda9 (diff) | |
parent | 58f06e11122723d68c5cb393aeb4ed1c7a2e7bfe (diff) | |
download | bionic-0be8f184c2de976b1370e668ce2bf2e49d6c8a5b.tar.gz |
Merge "Use inline keyword without underscores consistently" into main
-rw-r--r-- | libc/bionic/sys_statvfs.cpp | 2 | ||||
-rw-r--r-- | libc/dns/resolv/res_cache.c | 4 | ||||
-rw-r--r-- | libc/include/android/api-level.h | 2 | ||||
-rw-r--r-- | libc/include/android/legacy_stdlib_inlines.h | 6 | ||||
-rw-r--r-- | libc/include/android/legacy_termios_inlines.h | 4 | ||||
-rw-r--r-- | libc/include/android/legacy_threads_inlines.h | 2 | ||||
-rw-r--r-- | libc/include/android/legacy_unistd_inlines.h | 2 | ||||
-rw-r--r-- | libc/include/bits/stdatomic.h | 12 | ||||
-rw-r--r-- | libc/include/bits/swab.h | 2 | ||||
-rw-r--r-- | libc/include/bits/termios_inlines.h | 4 | ||||
-rw-r--r-- | libc/include/bits/termios_winsize_inlines.h | 2 | ||||
-rw-r--r-- | libc/include/bits/threads_inlines.h | 2 | ||||
-rw-r--r-- | libc/include/ctype.h | 2 | ||||
-rw-r--r-- | libc/include/strings.h | 6 | ||||
-rw-r--r-- | libc/include/sys/cdefs.h | 6 | ||||
-rwxr-xr-x | libc/kernel/tools/cpp.py | 4 |
16 files changed, 31 insertions, 31 deletions
diff --git a/libc/bionic/sys_statvfs.cpp b/libc/bionic/sys_statvfs.cpp index b3a0aca0c..3a05c3fa6 100644 --- a/libc/bionic/sys_statvfs.cpp +++ b/libc/bionic/sys_statvfs.cpp @@ -17,7 +17,7 @@ #include <sys/statfs.h> #include <sys/statvfs.h> -static __inline void __bionic_statfs_to_statvfs(const struct statfs* src, struct statvfs* dst) { +static inline void __bionic_statfs_to_statvfs(const struct statfs* src, struct statvfs* dst) { dst->f_bsize = src->f_bsize; dst->f_frsize = src->f_frsize; dst->f_blocks = src->f_blocks; diff --git a/libc/dns/resolv/res_cache.c b/libc/dns/resolv/res_cache.c index f4c590f60..d6416e5c5 100644 --- a/libc/dns/resolv/res_cache.c +++ b/libc/dns/resolv/res_cache.c @@ -1166,14 +1166,14 @@ entry_free( Entry* e ) } } -static __inline__ void +static inline void entry_mru_remove( Entry* e ) { e->mru_prev->mru_next = e->mru_next; e->mru_next->mru_prev = e->mru_prev; } -static __inline__ void +static inline void entry_mru_add( Entry* e, Entry* list ) { Entry* first = list->mru_next; diff --git a/libc/include/android/api-level.h b/libc/include/android/api-level.h index 77ec6530b..113897c97 100644 --- a/libc/include/android/api-level.h +++ b/libc/include/android/api-level.h @@ -191,7 +191,7 @@ int android_get_application_target_sdk_version() __INTRODUCED_IN(24); #if __ANDROID_API__ < 29 /* android_get_device_api_level is a static inline before API level 29. */ -#define __BIONIC_GET_DEVICE_API_LEVEL_INLINE static __inline +#define __BIONIC_GET_DEVICE_API_LEVEL_INLINE static inline #include <bits/get_device_api_level_inlines.h> #undef __BIONIC_GET_DEVICE_API_LEVEL_INLINE diff --git a/libc/include/android/legacy_stdlib_inlines.h b/libc/include/android/legacy_stdlib_inlines.h index f0985fe61..0ca1022e8 100644 --- a/libc/include/android/legacy_stdlib_inlines.h +++ b/libc/include/android/legacy_stdlib_inlines.h @@ -38,15 +38,15 @@ __BEGIN_DECLS -static __inline double strtod_l(const char* _Nonnull __s, char* _Nullable * _Nullable __end_ptr, locale_t _Nonnull __l) { +static inline double strtod_l(const char* _Nonnull __s, char* _Nullable * _Nullable __end_ptr, locale_t _Nonnull __l) { return strtod(__s, __end_ptr); } -static __inline float strtof_l(const char* _Nonnull __s, char* _Nullable * _Nullable __end_ptr, locale_t _Nonnull __l) { +static inline float strtof_l(const char* _Nonnull __s, char* _Nullable * _Nullable __end_ptr, locale_t _Nonnull __l) { return strtof(__s, __end_ptr); } -static __inline long strtol_l(const char* _Nonnull __s, char* _Nullable * _Nullable __end_ptr, int __base, locale_t _Nonnull __l) { +static inline long strtol_l(const char* _Nonnull __s, char* _Nullable * _Nullable __end_ptr, int __base, locale_t _Nonnull __l) { return strtol(__s, __end_ptr, __base); } diff --git a/libc/include/android/legacy_termios_inlines.h b/libc/include/android/legacy_termios_inlines.h index a816b4048..e557525ab 100644 --- a/libc/include/android/legacy_termios_inlines.h +++ b/libc/include/android/legacy_termios_inlines.h @@ -39,14 +39,14 @@ #include <sys/ioctl.h> #include <sys/types.h> -#define __BIONIC_TERMIOS_INLINE static __inline +#define __BIONIC_TERMIOS_INLINE static inline #include <bits/termios_inlines.h> #endif #if __ANDROID_API__ < 35 -#define __BIONIC_TERMIOS_WINSIZE_INLINE static __inline +#define __BIONIC_TERMIOS_WINSIZE_INLINE static inline #include <bits/termios_winsize_inlines.h> #endif diff --git a/libc/include/android/legacy_threads_inlines.h b/libc/include/android/legacy_threads_inlines.h index c614cd01a..06e743813 100644 --- a/libc/include/android/legacy_threads_inlines.h +++ b/libc/include/android/legacy_threads_inlines.h @@ -32,7 +32,7 @@ #if __ANDROID_API__ < 30 -#define __BIONIC_THREADS_INLINE static __inline +#define __BIONIC_THREADS_INLINE static inline #include <bits/threads_inlines.h> #endif diff --git a/libc/include/android/legacy_unistd_inlines.h b/libc/include/android/legacy_unistd_inlines.h index 4a5206b88..ac9f3b354 100644 --- a/libc/include/android/legacy_unistd_inlines.h +++ b/libc/include/android/legacy_unistd_inlines.h @@ -32,7 +32,7 @@ #if __ANDROID_API__ < 28 -#define __BIONIC_SWAB_INLINE static __inline +#define __BIONIC_SWAB_INLINE static inline #include <bits/swab.h> #endif diff --git a/libc/include/bits/stdatomic.h b/libc/include/bits/stdatomic.h index fe3d68d09..bd94b2d85 100644 --- a/libc/include/bits/stdatomic.h +++ b/libc/include/bits/stdatomic.h @@ -138,11 +138,11 @@ typedef enum { * 7.17.4 Fences. */ -static __inline void atomic_thread_fence(memory_order __order __attribute__((unused))) { +static inline void atomic_thread_fence(memory_order __order __attribute__((unused))) { __c11_atomic_thread_fence(__order); } -static __inline void atomic_signal_fence(memory_order __order __attribute__((unused))) { +static inline void atomic_signal_fence(memory_order __order __attribute__((unused))) { __c11_atomic_signal_fence(__order); } @@ -269,18 +269,18 @@ typedef struct { #define ATOMIC_FLAG_INIT { ATOMIC_VAR_INIT(false) } -static __inline bool atomic_flag_test_and_set_explicit(volatile atomic_flag * _Nonnull __object, memory_order __order) { +static inline bool atomic_flag_test_and_set_explicit(volatile atomic_flag * _Nonnull __object, memory_order __order) { return (atomic_exchange_explicit(&__object->__flag, 1, __order)); } -static __inline void atomic_flag_clear_explicit(volatile atomic_flag * _Nonnull __object, memory_order __order) { +static inline void atomic_flag_clear_explicit(volatile atomic_flag * _Nonnull __object, memory_order __order) { atomic_store_explicit(&__object->__flag, 0, __order); } -static __inline bool atomic_flag_test_and_set(volatile atomic_flag * _Nonnull __object) { +static inline bool atomic_flag_test_and_set(volatile atomic_flag * _Nonnull __object) { return (atomic_flag_test_and_set_explicit(__object, memory_order_seq_cst)); } -static __inline void atomic_flag_clear(volatile atomic_flag * _Nonnull __object) { +static inline void atomic_flag_clear(volatile atomic_flag * _Nonnull __object) { atomic_flag_clear_explicit(__object, memory_order_seq_cst); } diff --git a/libc/include/bits/swab.h b/libc/include/bits/swab.h index 9591c2ede..ebb7c7406 100644 --- a/libc/include/bits/swab.h +++ b/libc/include/bits/swab.h @@ -33,7 +33,7 @@ #include <sys/types.h> #if !defined(__BIONIC_SWAB_INLINE) -#define __BIONIC_SWAB_INLINE static __inline +#define __BIONIC_SWAB_INLINE static inline #endif __BEGIN_DECLS diff --git a/libc/include/bits/termios_inlines.h b/libc/include/bits/termios_inlines.h index a884b595f..702f43346 100644 --- a/libc/include/bits/termios_inlines.h +++ b/libc/include/bits/termios_inlines.h @@ -37,7 +37,7 @@ #include <linux/termios.h> #if !defined(__BIONIC_TERMIOS_INLINE) -#define __BIONIC_TERMIOS_INLINE static __inline +#define __BIONIC_TERMIOS_INLINE static inline #endif __BEGIN_DECLS @@ -45,7 +45,7 @@ __BEGIN_DECLS // Supporting separate input and output speeds would require an ABI // change for `struct termios`. -static __inline speed_t cfgetspeed(const struct termios* _Nonnull s) { +static inline speed_t cfgetspeed(const struct termios* _Nonnull s) { return __BIONIC_CAST(static_cast, speed_t, s->c_cflag & CBAUD); } diff --git a/libc/include/bits/termios_winsize_inlines.h b/libc/include/bits/termios_winsize_inlines.h index ae246e401..0d188e75e 100644 --- a/libc/include/bits/termios_winsize_inlines.h +++ b/libc/include/bits/termios_winsize_inlines.h @@ -36,7 +36,7 @@ #include <linux/termios.h> #if !defined(__BIONIC_TERMIOS_WINSIZE_INLINE) -#define __BIONIC_TERMIOS_WINSIZE_INLINE static __inline +#define __BIONIC_TERMIOS_WINSIZE_INLINE static inline #endif __BEGIN_DECLS diff --git a/libc/include/bits/threads_inlines.h b/libc/include/bits/threads_inlines.h index 5878e0acc..074e1ca98 100644 --- a/libc/include/bits/threads_inlines.h +++ b/libc/include/bits/threads_inlines.h @@ -38,7 +38,7 @@ __BEGIN_DECLS -static __inline int __bionic_thrd_error(int __pthread_code) { +static inline int __bionic_thrd_error(int __pthread_code) { switch (__pthread_code) { case 0: return 0; case ENOMEM: return thrd_nomem; diff --git a/libc/include/ctype.h b/libc/include/ctype.h index c15ee5618..5cad412d6 100644 --- a/libc/include/ctype.h +++ b/libc/include/ctype.h @@ -42,7 +42,7 @@ * also provide actual symbols for any caller that needs them. */ #if !defined(__BIONIC_CTYPE_INLINE) -#define __BIONIC_CTYPE_INLINE static __inline +#define __BIONIC_CTYPE_INLINE static inline #endif /** Internal implementation detail. Do not use. */ diff --git a/libc/include/strings.h b/libc/include/strings.h index 2f4f7641a..6ec3bdf58 100644 --- a/libc/include/strings.h +++ b/libc/include/strings.h @@ -50,7 +50,7 @@ #include <bits/strcasecmp.h> #if !defined(__BIONIC_STRINGS_INLINE) -#define __BIONIC_STRINGS_INLINE static __inline +#define __BIONIC_STRINGS_INLINE static inline #endif #undef ffs @@ -61,13 +61,13 @@ __BEGIN_DECLS /** Deprecated. Use memmove() instead. */ #define bcopy(b1, b2, len) __bionic_bcopy((b1), (b2), (len)) -static __inline__ __always_inline void __bionic_bcopy(const void* _Nonnull b1, void* _Nonnull b2, size_t len) { +static inline __always_inline void __bionic_bcopy(const void* _Nonnull b1, void* _Nonnull b2, size_t len) { __builtin_memmove(b2, b1, len); } /** Deprecated. Use memset() instead. */ #define bzero(b, len) __bionic_bzero((b), (len)) -static __inline__ __always_inline void __bionic_bzero(void* _Nonnull b, size_t len) { +static inline __always_inline void __bionic_bzero(void* _Nonnull b, size_t len) { __builtin_memset(b, 0, len); } diff --git a/libc/include/sys/cdefs.h b/libc/include/sys/cdefs.h index a8fb6240a..a19ce2619 100644 --- a/libc/include/sys/cdefs.h +++ b/libc/include/sys/cdefs.h @@ -260,7 +260,7 @@ * them available externally. FORTIFY'ed functions try to be as close to possible as 'invisible'; * having stack protectors detracts from that (b/182948263). */ -# define __BIONIC_FORTIFY_INLINE static __inline__ __attribute__((no_stack_protector)) \ +# define __BIONIC_FORTIFY_INLINE static inline __attribute__((no_stack_protector)) \ __always_inline __VERSIONER_FORTIFY_INLINE /* * We should use __BIONIC_FORTIFY_VARIADIC instead of __BIONIC_FORTIFY_INLINE @@ -268,7 +268,7 @@ * The __always_inline attribute is useless, misleading, and could trigger * clang compiler bug to incorrectly inline variadic functions. */ -# define __BIONIC_FORTIFY_VARIADIC static __inline__ +# define __BIONIC_FORTIFY_VARIADIC static inline /* Error functions don't have bodies, so they can just be static. */ # define __BIONIC_ERROR_FUNCTION_VISIBILITY static __attribute__((unused)) #else @@ -327,7 +327,7 @@ #define __size_mul_overflow(a, b, result) __builtin_umul_overflow(a, b, result) #endif #else -extern __inline__ __always_inline __attribute__((gnu_inline)) +extern inline __always_inline __attribute__((gnu_inline)) int __size_mul_overflow(__SIZE_TYPE__ a, __SIZE_TYPE__ b, __SIZE_TYPE__ *result) { *result = a * b; static const __SIZE_TYPE__ mul_no_overflow = 1UL << (sizeof(__SIZE_TYPE__) * 4); diff --git a/libc/kernel/tools/cpp.py b/libc/kernel/tools/cpp.py index 08b786ac5..0fd6e46f9 100755 --- a/libc/kernel/tools/cpp.py +++ b/libc/kernel/tools/cpp.py @@ -2345,11 +2345,11 @@ struct something_s { def test_function_keep_attribute_structs(self): text = """\ -static __inline__ struct some_struct1 * function(struct some_struct2 * e) { +static inline struct some_struct1 * function(struct some_struct2 * e) { } """ expected = """\ -static __inline__ struct some_struct1 * function(struct some_struct2 * e) { +static inline struct some_struct1 * function(struct some_struct2 * e) { } """ self.assertEqual(self.parse(text, set(["function"])), expected) |