diff options
author | Aart Bik <ajcbik@google.com> | 2016-05-02 21:46:54 +0000 |
---|---|---|
committer | android-build-merger <android-build-merger@google.com> | 2016-05-02 21:46:54 +0000 |
commit | 8e37aa191ff8c9099efa24800048c08afe0b53cf (patch) | |
tree | d690c457628e4ce0ee0176214297f7f18b552f08 | |
parent | ab01c96b3c21098dffbba03248f801486c76bdc7 (diff) | |
parent | 0e17e1849633b07c019daf89c0d2ededc1333f3b (diff) | |
download | dalvik-8e37aa191ff8c9099efa24800048c08afe0b53cf.tar.gz |
Fix potential buffer overrun. am: 38025bc7fa am: 805b415be6
am: 0e17e18496
* commit '0e17e1849633b07c019daf89c0d2ededc1333f3b':
Fix potential buffer overrun.
Change-Id: I2d0f7e326f21fd0fd2e8f03b2c7eda302730f4f9
-rw-r--r-- | libdex/OptInvocation.cpp | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/libdex/OptInvocation.cpp b/libdex/OptInvocation.cpp index 031ec9177..a9ea3a2d5 100644 --- a/libdex/OptInvocation.cpp +++ b/libdex/OptInvocation.cpp @@ -89,9 +89,9 @@ char* dexOptGenerateCacheFileName(const char* fileName, const char* subFileName) ALOGE("Can't get CWD while opening jar file"); return NULL; } - strncat(absoluteFile, "/", kBufLen); + strncat(absoluteFile, "/", kBufLen - strlen(absoluteFile)); } - strncat(absoluteFile, fileName, kBufLen); + strncat(absoluteFile, fileName, kBufLen - strlen(absoluteFile)); /* * Append the name of the Jar file entry, if any. This is not currently @@ -99,8 +99,8 @@ char* dexOptGenerateCacheFileName(const char* fileName, const char* subFileName) * in a Jar. */ if (subFileName != NULL) { - strncat(absoluteFile, "/", kBufLen); - strncat(absoluteFile, subFileName, kBufLen); + strncat(absoluteFile, "/", kBufLen - strlen(absoluteFile)); + strncat(absoluteFile, subFileName, kBufLen - strlen(absoluteFile)); } /* Turn the path into a flat filename by replacing @@ -138,7 +138,7 @@ char* dexOptGenerateCacheFileName(const char* fileName, const char* subFileName) /* Tack on the file name for the actual cache file path. */ - strncat(nameBuf, absoluteFile, kBufLen); + strncat(nameBuf, absoluteFile, kBufLen - strlen(nameBuf)); ALOGV("Cache file for '%s' '%s' is '%s'", fileName, subFileName, nameBuf); return strdup(nameBuf); |