diff options
author | Yu-Hsuan Hsu <yuhsuan@chromium.org> | 2019-11-19 16:48:25 +0800 |
---|---|---|
committer | Commit Bot <commit-bot@chromium.org> | 2019-11-23 18:00:00 +0000 |
commit | 2d61414a3b5bb0c2e74a09b820374081dffd0e4e (patch) | |
tree | ae3fe18ab71b4d194d90a49cbaa83a1da4d86523 /cras/src/tests/rstream_unittest.cc | |
parent | 543307a13e46ef790a913685d5ee0e76e5139e04 (diff) | |
download | adhd-2d61414a3b5bb0c2e74a09b820374081dffd0e4e.tar.gz |
CRAS: metrics - Refactor logging stream function
1. Use cras_server_metrics_stream_create and
cras_server_metrics_stream_destroy function instead of logging metrics
seperately when streams create and destroy.
2. Move cras_server_metrics_stream_create from
rclient_handle_client_stream_connect to cras_rstream_create so that we
can log streams created by CRAS server.
BUG=b:144819087
TEST=Server stream can be recorded correctly.
Change-Id: Ib6888f541a9e78af9d3db668766d3c05e699ae90
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/1925946
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>
Tested-by: Yu-Hsuan Hsu <yuhsuan@chromium.org>
Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org>
Diffstat (limited to 'cras/src/tests/rstream_unittest.cc')
-rw-r--r-- | cras/src/tests/rstream_unittest.cc | 15 |
1 files changed, 11 insertions, 4 deletions
diff --git a/cras/src/tests/rstream_unittest.cc b/cras/src/tests/rstream_unittest.cc index 69523f5f..f5487a93 100644 --- a/cras/src/tests/rstream_unittest.cc +++ b/cras/src/tests/rstream_unittest.cc @@ -16,6 +16,8 @@ extern "C" { #include "cras_shm.h" } +#include "metrics_stub.h" + namespace { class RstreamTestSuite : public testing::Test { @@ -392,6 +394,15 @@ unsigned int buffer_share_id_offset(const struct buffer_share* mix, void cras_system_state_stream_added(enum CRAS_STREAM_DIRECTION direction) {} void cras_system_state_stream_removed(enum CRAS_STREAM_DIRECTION direction) {} + +int cras_server_metrics_stream_create(const struct cras_rstream* stream) { + return 0; +} + +int cras_server_metrics_stream_destroy(const struct cras_rstream* stream) { + return 0; +} + #ifdef HAVE_WEBRTC_APM struct cras_apm_list* cras_apm_list_create(void* stream_ptr, uint64_t effects) { return NULL; @@ -409,8 +420,4 @@ struct cras_audio_format* cras_apm_list_get_format(struct cras_apm* apm) { return NULL; } #endif - -int cras_server_metrics_missed_cb_frequency(const struct cras_rstream* stream) { - return 0; -} } |