diff options
| author | Cody Northrop <cnorthrop@google.com> | 2024-04-17 15:52:27 -0700 |
|---|---|---|
| committer | Angle LUCI CQ <angle-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2024-04-18 01:07:23 +0000 |
| commit | 6861da63bb01592964789d531dd8a71a06057547 (patch) | |
| tree | aa5fe726eaa276a1608dfcea1a9edf1016476f95 | |
| parent | b2aad1bbb7ce8f333e0463744c919f5239edabe2 (diff) | |
| download | angle-6861da63bb01592964789d531dd8a71a06057547.tar.gz | |
Vulkan: Don't cache staging buffers on PowerVR
Seeing flakiness in simple tests. Narrowed it down to cached
coherent memory. There is likely something ANGLE is doing wrong
but broaden the workaround until it is root caused.
Test: angle_end2end_tests
Bug: b/315836169
Bug: b/324953979
Change-Id: I15e50781f746ffb24b0a12b1e28df04a3822b556
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5464283
Auto-Submit: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
| -rw-r--r-- | src/libANGLE/renderer/vulkan/vk_renderer.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/libANGLE/renderer/vulkan/vk_renderer.cpp b/src/libANGLE/renderer/vulkan/vk_renderer.cpp index c1bdae1bde..8f21b1c44f 100644 --- a/src/libANGLE/renderer/vulkan/vk_renderer.cpp +++ b/src/libANGLE/renderer/vulkan/vk_renderer.cpp @@ -4674,7 +4674,7 @@ void Renderer::initFeatures(const vk::ExtensionNameList &deviceExtensionNames, // For some reason, if we use cached staging buffer for read pixels, a lot of tests fail on ARM, // even though we do have invlaid() call there. Temporary keep the old behavior for ARM until we // can root cause it. - ANGLE_FEATURE_CONDITION(&mFeatures, requireCachedBitForStagingBuffer, !isARM); + ANGLE_FEATURE_CONDITION(&mFeatures, requireCachedBitForStagingBuffer, !isARM && !isPowerVR); // Multiple dynamic state issues on ARM have been fixed. // http://issuetracker.google.com/285124778 |