diff options
| author | Charlie Lao <cclao@google.com> | 2024-04-12 16:15:42 -0700 |
|---|---|---|
| committer | Angle LUCI CQ <angle-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2024-04-13 02:27:34 +0000 |
| commit | e229afada1d2af012b7ec55395d10f53f1ebfe60 (patch) | |
| tree | 18e75d417671b77dc7702aaec71a45652490a02b | |
| parent | 08d9d5cc1c3cb5902d5ea462af94eaaae6fcd46a (diff) | |
| download | angle-e229afada1d2af012b7ec55395d10f53f1ebfe60.tar.gz | |
Vulkan: Disable setting_sync_queue_submit
In this CL we basically ignored all SyncVal errors from VkQueueSubmit.
https://chromium-review.googlesource.com/c/angle/angle/+/5137081 But
this validation is still enabled. This validation is super slow right
now (tracked by
https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/7285).
There is no need to waset bots time to do this validation and then
ignore its result.
Bug: b/316013423
Bug: b/334183919
Change-Id: I1f6c53f484c088e684d2686422f33539b31b8b7a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5450955
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
| -rw-r--r-- | src/libANGLE/renderer/vulkan/vk_renderer.cpp | 16 |
1 files changed, 7 insertions, 9 deletions
diff --git a/src/libANGLE/renderer/vulkan/vk_renderer.cpp b/src/libANGLE/renderer/vulkan/vk_renderer.cpp index 80d47a8100..202f6a897e 100644 --- a/src/libANGLE/renderer/vulkan/vk_renderer.cpp +++ b/src/libANGLE/renderer/vulkan/vk_renderer.cpp @@ -478,13 +478,6 @@ constexpr vk::SkippedSyncvalMessage kSkippedSyncvalMessages[] = { "store with storeOp VK_ATTACHMENT_STORE_OP_STORE. Access info (usage: " "SYNC_LATE_FRAGMENT_TESTS_DEPTH_STENCIL_ATTACHMENT_WRITE, prior_usage: " "SYNC_FRAGMENT_SHADER_SHADER_"}, - // b/316013423 - {"SYNC-HAZARD-READ-AFTER-WRITE", "type = VK_OBJECT_TYPE_QUEUE", - "vkQueueSubmit(): Hazard READ_AFTER_WRITE for entry 0"}, - {"SYNC-HAZARD-WRITE-AFTER-READ", "type = VK_OBJECT_TYPE_QUEUE", - "vkQueueSubmit(): Hazard WRITE_AFTER_READ for entry 0"}, - {"SYNC-HAZARD-WRITE-AFTER-WRITE", "type = VK_OBJECT_TYPE_QUEUE", - "vkQueueSubmit(): Hazard WRITE_AFTER_WRITE for entry 0"}, }; // Messages that shouldn't be generated if storeOp=NONE is supported, otherwise they are expected. @@ -1913,12 +1906,17 @@ angle::Result Renderer::initialize(vk::Context *context, const VkBool32 setting_validate_sync = IsAndroid() ? VK_FALSE : VK_TRUE; const VkBool32 setting_thread_safety = VK_TRUE; // http://anglebug.com/7050 - Shader validation caching is broken on Android - const VkBool32 setting_check_shaders = IsAndroid() ? VK_FALSE : VK_TRUE; - const VkLayerSettingEXT layerSettings[] = { + const VkBool32 setting_check_shaders = IsAndroid() ? VK_FALSE : VK_TRUE; + // http://b/316013423 Disable QueueSubmit Synchronization Validation. Lots of failures and some + // test timeout due to https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/7285 + const VkBool32 setting_sync_queue_submit = VK_FALSE; + const VkLayerSettingEXT layerSettings[] = { {name, "validate_core", VK_LAYER_SETTING_TYPE_BOOL32_EXT, 1, &setting_validate_core}, {name, "validate_sync", VK_LAYER_SETTING_TYPE_BOOL32_EXT, 1, &setting_validate_sync}, {name, "thread_safety", VK_LAYER_SETTING_TYPE_BOOL32_EXT, 1, &setting_thread_safety}, {name, "check_shaders", VK_LAYER_SETTING_TYPE_BOOL32_EXT, 1, &setting_check_shaders}, + {name, "sync_queue_submit", VK_LAYER_SETTING_TYPE_BOOL32_EXT, 1, + &setting_sync_queue_submit}, }; VkLayerSettingsCreateInfoEXT layerSettingsCreateInfo = { VK_STRUCTURE_TYPE_LAYER_SETTINGS_CREATE_INFO_EXT, nullptr, |