diff options
| author | Szabolcs Nagy <szabolcs.nagy@arm.com> | 2018-07-09 17:36:39 +0100 |
|---|---|---|
| committer | Szabolcs Nagy <szabolcs.nagy@arm.com> | 2018-07-10 17:21:45 +0100 |
| commit | fce099747ac4f43f34f3cd13853937449e6911a5 (patch) | |
| tree | 978797077187438defe470f07628e63e7045976f | |
| parent | ae8bc7d00ce47bd9271594d58441e06a74943ea7 (diff) | |
| download | arm-optimized-routines-fce099747ac4f43f34f3cd13853937449e6911a5.tar.gz | |
Remove float compare option from sincosf
PREFER_FLOAT_COMPARISON setting was not correct as it could raise
spurious exceptions. Fixing it is easy: just use ISLESS(x, y) instead
of abstop12(x) < abstop12(y) with appropriate non-signaling definition
for ISLESS. However it seems this setting is not very useful (there is
only minor performance difference on various architectures), so remove
this option for now.
| -rw-r--r-- | math/sincosf.h | 11 |
1 files changed, 1 insertions, 10 deletions
diff --git a/math/sincosf.h b/math/sincosf.h index 1dd50e2..4aced58 100644 --- a/math/sincosf.h +++ b/math/sincosf.h @@ -36,21 +36,12 @@ extern const sincos_t __sincosf_table[2] HIDDEN; extern const uint32_t __inv_pio4[] HIDDEN; -/* abstop12 assumes floating point reinterpret is fast by default. - If floating point comparisons are faster, define PREFER_FLOAT_COMPARISON. */ -#if PREFER_FLOAT_COMPARISON -static inline float -abstop12 (float x) -{ - return fabsf (x); -} -#else +/* Top 12 bits of the float representation with the sign bit cleared. */ static inline uint32_t abstop12 (float x) { return (asuint (x) >> 20) & 0x7ff; } -#endif /* Compute the sine and cosine of inputs X and X2 (X squared), using the polynomial P and store the results in SINP and COSP. N is the quadrant, |