aboutsummaryrefslogtreecommitdiff
path: root/config
diff options
context:
space:
mode:
authorvasilyeva <vasilyeva@rutarget.ru>2017-07-01 00:21:52 +0300
committerRoman Ivanov <romani@users.noreply.github.com>2017-06-30 16:34:31 -0700
commit0e653d27de8a75bd201363b641664c9f9bf43b08 (patch)
treef5917dc8f70a2a21b75554073c5261c4d8cee780 /config
parentb9974120694a57e84892228ac793116a11cc9795 (diff)
downloadcheckstyle-0e653d27de8a75bd201363b641664c9f9bf43b08.tar.gz
Issue #4567: fix AccessorClassGeneration and JUnitTestsShouldIncludeAssert violations
Diffstat (limited to 'config')
-rw-r--r--config/pmd-test.xml8
1 files changed, 2 insertions, 6 deletions
diff --git a/config/pmd-test.xml b/config/pmd-test.xml
index 586f8cdda..6639ac13e 100644
--- a/config/pmd-test.xml
+++ b/config/pmd-test.xml
@@ -40,9 +40,7 @@
<exclude name="NPathComplexity"/>
<!--conflicts with checkstyle rule-->
<exclude name="JUnitUseExpected"/>
- <!--tentative-->
- <exclude name="AccessorClassGeneration"/>
- <!--tentative-->
+ <!--will be addressed in https://github.com/checkstyle/checkstyle/projects/5-->
<exclude name="NonThreadSafeSingleton"/>
</rule>
@@ -77,7 +75,7 @@
<!-- in ImportControlCheckTest pmd does not find asserts in private methods of the test class called from the test method -->
<!-- in AstRegressionTest pmd does not find asserts in inner classes methods called from the test method -->
<!-- in AllChecksTest pmd does not find asserts in lambdas -->
- <!-- Starting from CheckstyleAntTaskTest tests should be rewrited-->
+ <!-- TreeWalkerTest should be rewrited-->
<property name="violationSuppressXPath" value="//ClassOrInterfaceDeclaration[@Image='SuppressionFilterTest']//MethodDeclarator[@Image='testEqualsAndHashCode']
| //ClassOrInterfaceDeclaration[@Image='SuppressionCommentFilterTest']//MethodDeclarator[@Image='testEqualsAndHashCodeOfTagClass']
| //ClassOrInterfaceDeclaration[@Image='SuppressWithNearbyCommentFilterTest']//MethodDeclarator[@Image='testEqualsAndHashCodeOfTagClass']
@@ -88,8 +86,6 @@
| /ClassOrInterfaceDeclaration[@Image='AstRegressionTest']//MethodDeclarator[@Image='testImpossibleExceptions']
| //ClassOrInterfaceDeclaration[@Image='AstRegressionTest']//MethodDeclarator[@Image='testImpossibleValid']
| //ClassOrInterfaceDeclaration[@Image='AllChecksTest']//MethodDeclarator[@Image='testAllModulesAreReferencedInConfigFile']
- | //ClassOrInterfaceDeclaration[@Image='CheckstyleAntTaskTest']//MethodDeclarator[@Image='testConfigurationByUrl']
- | //ClassOrInterfaceDeclaration[@Image='CheckstyleAntTaskTest']//MethodDeclarator[@Image='testConfigurationByResource']
| //ClassOrInterfaceDeclaration[@Image='TreeWalkerTest']//MethodDeclarator[@Image='testProcessNonJavaFiles']
"/>
</properties>