diff options
| author | vasilyeva <vasilyeva@rutarget.ru> | 2017-07-21 21:13:46 +0300 |
|---|---|---|
| committer | Roman Ivanov <romani@users.noreply.github.com> | 2017-07-22 06:51:44 -0700 |
| commit | 488808066ab1ccc6df84623cf95c60d6b62cc0c6 (patch) | |
| tree | 70333022ebb780235eeebea6fcff5ee8d2b1b5c5 /config | |
| parent | c805cf5e1deef1679a97438095b16c1c1bec223e (diff) | |
| download | checkstyle-488808066ab1ccc6df84623cf95c60d6b62cc0c6.tar.gz | |
Issue #4707: fixed remained violations for the nineth part of idea violations
Diffstat (limited to 'config')
| -rw-r--r-- | config/intellij-idea-inspections.xml | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/config/intellij-idea-inspections.xml b/config/intellij-idea-inspections.xml index 2d8ff17d1..3e82f45f1 100644 --- a/config/intellij-idea-inspections.xml +++ b/config/intellij-idea-inspections.xml @@ -698,6 +698,7 @@ <inspection_tool class="FacesModelInspection" enabled="true" level="WARNING" enabled_by_default="true" /> <inspection_tool class="FallThroughInSwitchStatementJS" enabled="true" level="ERROR" enabled_by_default="true" /> <inspection_tool class="FallthruInSwitchStatement" enabled="true" level="ERROR" enabled_by_default="true" /> + <!-- we use DetailAST heavily and that that is on purpose and not a problem, no ways to adjust this inspection --> <inspection_tool class="FeatureEnvy" enabled="false" level="ERROR" enabled_by_default="false"> <option name="ignoreTestCases" value="false" /> </inspection_tool> @@ -1111,6 +1112,8 @@ <option name="ignoreInstanceofOnLibraryClasses" value="true" /> </inspection_tool> <inspection_tool class="InstanceofIncompatibleInterface" enabled="true" level="WARNING" enabled_by_default="true" /> + <!-- unfortunate , but there are multiple cases where instanceof is required due to loading classes + from config file and usage of reflection --> <inspection_tool class="InstanceofInterfaces" enabled="false" level="ERROR" enabled_by_default="false" /> <inspection_tool class="InstanceofThis" enabled="true" level="ERROR" enabled_by_default="true" /> <inspection_tool class="InstantiatingObjectToGetClassObject" enabled="true" level="ERROR" enabled_by_default="true" /> @@ -1681,6 +1684,7 @@ <option name="m_minLength" value="1" /> <option name="m_maxLength" value="32" /> </inspection_tool> + <!-- we like implementation to be concrete, we do not like a lot of abstractions --> <inspection_tool class="ParameterOfConcreteClass" enabled="false" level="ERROR" enabled_by_default="false" /> <inspection_tool class="ParameterTypePreventsOverriding" enabled="true" level="ERROR" enabled_by_default="true" /> <inspection_tool class="ParameterizedParametersStaticCollection" enabled="true" level="ERROR" enabled_by_default="true" /> @@ -1749,6 +1753,7 @@ <!-- we like to use them as we not always ready to make class top level, for Checks it is better to keep all in one class. --> <inspection_tool class="PublicInnerClass" enabled="false" level="WARNING" enabled_by_default="false" /> + <!-- we are not fanatics of interfaces, we use concept 'the less abstractions the better --> <inspection_tool class="PublicMethodNotExposedInInterface" enabled="false" level="ERROR" enabled_by_default="false"> <option name="ignorableAnnotations"> <value /> @@ -2247,6 +2252,7 @@ <inspection_tool class="TryWithIdenticalCatches" enabled="true" level="ERROR" enabled_by_default="true" /> <inspection_tool class="TsLint" enabled="false" level="WARNING" enabled_by_default="false" /> <inspection_tool class="TypeCustomizer" enabled="true" level="ERROR" enabled_by_default="true" /> + <!-- we like implementation to be concrete, we do not like a lot of abstractions --> <inspection_tool class="TypeMayBeWeakened" enabled="false" level="ERROR" enabled_by_default="false"> <option name="useRighthandTypeAsWeakestTypeInAssignments" value="true" /> <option name="useParameterizedTypeForCollectionMethods" value="true" /> |