diff options
| author | rnveach <rveach02@gmail.com> | 2015-10-23 21:11:00 -0400 |
|---|---|---|
| committer | Roman Ivanov <ivanov-jr@mail.ru> | 2015-10-24 06:43:37 -0700 |
| commit | 3a2cb4d787e3c626bb0e2e02915cc1c37deb9d0b (patch) | |
| tree | 8896b9c0b7d29974ea6904e22500ba83435e189b /src/test/java | |
| parent | 9316d20698a52bd68060947b8567577e47351b9a (diff) | |
| download | checkstyle-3a2cb4d787e3c626bb0e2e02915cc1c37deb9d0b.tar.gz | |
Issue #2421: enabled final local variable for test folder
Diffstat (limited to 'src/test/java')
181 files changed, 1262 insertions, 1244 deletions
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/AllChecksTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/AllChecksTest.java index 0a8fc4afd..f52c240d7 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/AllChecksTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/AllChecksTest.java @@ -91,7 +91,7 @@ public class AllChecksTest extends BaseCheckTestSupport { @Test public void testDefaultTokensAreSubsetOfAcceptableTokens() throws Exception { - Set<Class<?>> checkstyleChecks = getCheckstyleChecks(); + final Set<Class<?>> checkstyleChecks = getCheckstyleChecks(); for (Class<?> check : checkstyleChecks) { if (Check.class.isAssignableFrom(check)) { @@ -100,7 +100,7 @@ public class AllChecksTest extends BaseCheckTestSupport { final int[] acceptableTokens = testedCheck.getAcceptableTokens(); if (!isSubset(defaultTokens, acceptableTokens)) { - String errorMessage = String.format(Locale.ROOT, + final String errorMessage = String.format(Locale.ROOT, "%s's default tokens must be a subset" + " of acceptable tokens.", check.getName()); Assert.fail(errorMessage); @@ -111,7 +111,7 @@ public class AllChecksTest extends BaseCheckTestSupport { @Test public void testRequiredTokensAreSubsetOfAcceptableTokens() throws Exception { - Set<Class<?>> checkstyleChecks = getCheckstyleChecks(); + final Set<Class<?>> checkstyleChecks = getCheckstyleChecks(); for (Class<?> check : checkstyleChecks) { if (Check.class.isAssignableFrom(check)) { @@ -120,7 +120,7 @@ public class AllChecksTest extends BaseCheckTestSupport { final int[] acceptableTokens = testedCheck.getAcceptableTokens(); if (!isSubset(requiredTokens, acceptableTokens)) { - String errorMessage = String.format(Locale.ROOT, + final String errorMessage = String.format(Locale.ROOT, "%s's required tokens must be a subset" + " of acceptable tokens.", check.getName()); Assert.fail(errorMessage); @@ -131,7 +131,7 @@ public class AllChecksTest extends BaseCheckTestSupport { @Test public void testRequiredTokensAreSubsetOfDefaultTokens() throws Exception { - Set<Class<?>> checkstyleChecks = getCheckstyleChecks(); + final Set<Class<?>> checkstyleChecks = getCheckstyleChecks(); for (Class<?> check : checkstyleChecks) { if (Check.class.isAssignableFrom(check)) { @@ -140,7 +140,7 @@ public class AllChecksTest extends BaseCheckTestSupport { final int[] requiredTokens = testedCheck.getRequiredTokens(); if (!isSubset(requiredTokens, defaultTokens)) { - String errorMessage = String.format(Locale.ROOT, + final String errorMessage = String.format(Locale.ROOT, "%s's required tokens must be a subset" + " of default tokens.", check.getName()); Assert.fail(errorMessage); @@ -159,7 +159,7 @@ public class AllChecksTest extends BaseCheckTestSupport { for (String check : checksNames) { if (!checksReferencedInConfig.contains(check)) { - String errorMessage = String.format(Locale.ROOT, + final String errorMessage = String.format(Locale.ROOT, "%s is not referenced in checkstyle_checks.xml", check); Assert.fail(errorMessage); } @@ -325,7 +325,7 @@ public class AllChecksTest extends BaseCheckTestSupport { final NodeList nodeList = document.getElementsByTagName("module"); - Set<String> checksReferencedInCheckstyleChecksXML = new HashSet<>(); + final Set<String> checksReferencedInCheckstyleChecksXML = new HashSet<>(); for (int i = 0; i < nodeList.getLength(); i++) { final Node currentNode = nodeList.item(i); if (currentNode.getNodeType() == Node.ELEMENT_NODE) { diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/BaseCheckTestSupport.java b/src/test/java/com/puppycrawl/tools/checkstyle/BaseCheckTestSupport.java index 8234c47a1..bf0fc342f 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/BaseCheckTestSupport.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/BaseCheckTestSupport.java @@ -241,7 +241,7 @@ public class BaseCheckTestSupport { * @param arguments the arguments of message in 'messages.properties' file. */ protected String getCheckMessage(String messageKey, Object... arguments) { - Properties pr = new Properties(); + final Properties pr = new Properties(); try { pr.load(getClass().getResourceAsStream("messages.properties")); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/CheckerTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/CheckerTest.java index 612d28a27..746d908ec 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/CheckerTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/CheckerTest.java @@ -176,9 +176,9 @@ public class CheckerTest { public void testFileExtensions() throws Exception { final Checker checker = new Checker(); final List<File> files = new ArrayList<>(); - File file = new File("file.pdf"); + final File file = new File("file.pdf"); files.add(file); - File otherFile = new File("file.java"); + final File otherFile = new File("file.java"); files.add(otherFile); final String[] fileExtensions = {"java", "xml", "properties"}; checker.setFileExtensions(fileExtensions); @@ -198,7 +198,7 @@ public class CheckerTest { checker.setBasedir("some"); checker.setSeverity("ignore"); - PackageObjectFactory factory = new PackageObjectFactory( + final PackageObjectFactory factory = new PackageObjectFactory( new HashSet<String>(), Thread.currentThread().getContextClassLoader()); checker.setModuleFactory(factory); @@ -240,7 +240,7 @@ public class CheckerTest { public void testFinishLocalSetupFullyInitialized() throws Exception { final Checker checker = new Checker(); checker.setModuleClassLoader(Thread.currentThread().getContextClassLoader()); - PackageObjectFactory factory = new PackageObjectFactory( + final PackageObjectFactory factory = new PackageObjectFactory( new HashSet<String>(), Thread.currentThread().getContextClassLoader()); checker.setModuleFactory(factory); @@ -250,11 +250,11 @@ public class CheckerTest { @Test public void testSetupChildExceptions() throws Exception { final Checker checker = new Checker(); - PackageObjectFactory factory = new PackageObjectFactory( + final PackageObjectFactory factory = new PackageObjectFactory( new HashSet<String>(), Thread.currentThread().getContextClassLoader()); checker.setModuleFactory(factory); - Configuration config = new DefaultConfiguration("java.lang.String"); + final Configuration config = new DefaultConfiguration("java.lang.String"); try { checker.setupChild(config); fail("Exception is expected"); @@ -267,11 +267,12 @@ public class CheckerTest { @Test public void testSetupChildListener() throws Exception { final Checker checker = new Checker(); - PackageObjectFactory factory = new PackageObjectFactory( + final PackageObjectFactory factory = new PackageObjectFactory( new HashSet<String>(), Thread.currentThread().getContextClassLoader()); checker.setModuleFactory(factory); - Configuration config = new DefaultConfiguration(DebugAuditAdapter.class.getCanonicalName()); + final Configuration config = new DefaultConfiguration( + DebugAuditAdapter.class.getCanonicalName()); checker.setupChild(config); } } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/CommitValidationTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/CommitValidationTest.java index f8b452641..a62cf8763 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/CommitValidationTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/CommitValidationTest.java @@ -109,9 +109,9 @@ public class CommitValidationTest { @Test public void testCommitMessageHasProperStructure() throws Exception { for (RevCommit commit : filterValidCommits(lastCommits)) { - String commitId = commit.getId().getName(); - String commitMessage = commit.getFullMessage(); - Matcher matcher = ACCEPTED_COMMIT_MESSAGE_PATTERN.matcher(commitMessage); + final String commitId = commit.getId().getName(); + final String commitMessage = commit.getFullMessage(); + final Matcher matcher = ACCEPTED_COMMIT_MESSAGE_PATTERN.matcher(commitMessage); assertTrue(getInvalidCommitMessageFormattingError(commitId, commitMessage), matcher.matches()); } @@ -120,16 +120,16 @@ public class CommitValidationTest { @Test public void testCommitMessageHasSingleLine() throws Exception { for (RevCommit commit : filterValidCommits(lastCommits)) { - String commitId = commit.getId().getName(); - String commitMessage = commit.getFullMessage(); - Matcher matcher = NEWLINE_PATTERN.matcher(commitMessage); + final String commitId = commit.getId().getName(); + final String commitMessage = commit.getFullMessage(); + final Matcher matcher = NEWLINE_PATTERN.matcher(commitMessage); if (matcher.find()) { /** * Git by default put newline character at the end of commit message. To check * if commit message has a single line we have to make sure that the only * newline character found is in the end of commit message. */ - boolean isFoundNewLineCharacterAtTheEndOfMessage = + final boolean isFoundNewLineCharacterAtTheEndOfMessage = matcher.end() == commitMessage.length(); assertTrue(getInvalidCommitMessageFormattingError(commitId, commitMessage), isFoundNewLineCharacterAtTheEndOfMessage); @@ -140,7 +140,7 @@ public class CommitValidationTest { private static List<RevCommit> getCommitsToCheck() throws Exception { List<RevCommit> commits; try (Repository repo = new FileRepositoryBuilder().findGitDir().build()) { - RevCommitsPair revCommitsPair = resolveRevCommitsPair(repo); + final RevCommitsPair revCommitsPair = resolveRevCommitsPair(repo); if (COMMITS_RESOLUTION_MODE == CommitsResolutionMode.BY_COUNTER) { commits = getCommitsByCounter(revCommitsPair.getFirst()); commits.addAll(getCommitsByCounter(revCommitsPair.getSecond())); @@ -154,9 +154,9 @@ public class CommitValidationTest { } private static List<RevCommit> filterValidCommits(List<RevCommit> revCommits) { - List<RevCommit> filteredCommits = new LinkedList<>(); + final List<RevCommit> filteredCommits = new LinkedList<>(); for (RevCommit commit : revCommits) { - String commitAuthor = commit.getAuthorIdent().getName(); + final String commitAuthor = commit.getAuthorIdent().getName(); if (!USERS_EXCLUDED_FROM_VALIDATION.contains(commitAuthor)) { filteredCommits.add(commit); } @@ -170,12 +170,12 @@ public class CommitValidationTest { try (RevWalk revWalk = new RevWalk(repo)) { Iterator<RevCommit> first; Iterator<RevCommit> second; - ObjectId headId = repo.resolve(Constants.HEAD); - RevCommit headCommit = revWalk.parseCommit(headId); + final ObjectId headId = repo.resolve(Constants.HEAD); + final RevCommit headCommit = revWalk.parseCommit(headId); if (isMergeCommit(headCommit)) { - RevCommit firstParent = headCommit.getParent(0); - RevCommit secondParent = headCommit.getParent(1); + final RevCommit firstParent = headCommit.getParent(0); + final RevCommit secondParent = headCommit.getParent(1); try (Git git = new Git(repo)) { first = git.log().add(firstParent).call().iterator(); @@ -212,18 +212,18 @@ public class CommitValidationTest { private static List<RevCommit> getCommitsByLastCommitAuthor( Iterator<RevCommit> previousCommitsIterator) { - List<RevCommit> commits = new LinkedList<>(); + final List<RevCommit> commits = new LinkedList<>(); if (previousCommitsIterator.hasNext()) { - RevCommit lastCommit = previousCommitsIterator.next(); - String lastCommitAuthor = lastCommit.getAuthorIdent().getName(); + final RevCommit lastCommit = previousCommitsIterator.next(); + final String lastCommitAuthor = lastCommit.getAuthorIdent().getName(); commits.add(lastCommit); boolean wasLastCheckedCommitAuthorSameAsLastCommit = true; while (previousCommitsIterator.hasNext() && wasLastCheckedCommitAuthorSameAsLastCommit) { - RevCommit currentCommit = previousCommitsIterator.next(); - String currentCommitAuthor = currentCommit.getAuthorIdent().getName(); + final RevCommit currentCommit = previousCommitsIterator.next(); + final String currentCommitAuthor = currentCommit.getAuthorIdent().getName(); if (currentCommitAuthor.equals(lastCommitAuthor)) { commits.add(currentCommit); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/ConfigurationLoaderTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/ConfigurationLoaderTest.java index 2aa70e505..ab16824b2 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/ConfigurationLoaderTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/ConfigurationLoaderTest.java @@ -351,30 +351,30 @@ public class ConfigurationLoaderTest { @Test public void testIncorrectTag() throws Exception { try { - Class<?> aClassParent = ConfigurationLoader.class; + final Class<?> aClassParent = ConfigurationLoader.class; Constructor<?> ctorParent = null; - Constructor<?>[] parentConstructors = aClassParent.getDeclaredConstructors(); + final Constructor<?>[] parentConstructors = aClassParent.getDeclaredConstructors(); for (Constructor<?> parentConstructor: parentConstructors) { parentConstructor.setAccessible(true); ctorParent = parentConstructor; } - Class<?> aClass = Class.forName("com.puppycrawl.tools.checkstyle." + final Class<?> aClass = Class.forName("com.puppycrawl.tools.checkstyle." + "ConfigurationLoader$InternalLoader"); Constructor<?> constructor = null; - Constructor<?>[] constructors = aClass.getDeclaredConstructors(); + final Constructor<?>[] constructors = aClass.getDeclaredConstructors(); for (Constructor<?> constr: constructors) { constr.setAccessible(true); constructor = constr; } - Class<?>[] param = new Class<?>[4]; + final Class<?>[] param = new Class<?>[4]; param[0] = String.class; param[1] = String.class; param[2] = String.class; param[3] = Attributes.class; - Method method = aClass.getDeclaredMethod("startElement", param); - Object objParent = ctorParent.newInstance(null, true); - Object obj = constructor.newInstance(objParent); + final Method method = aClass.getDeclaredMethod("startElement", param); + final Object objParent = ctorParent.newInstance(null, true); + final Object obj = constructor.newInstance(objParent); method.invoke(obj, "", "", "hello", null); @@ -473,9 +473,9 @@ public class ConfigurationLoaderTest { @Test public void testReplacePropertiesDefault() throws Exception { final Properties props = new Properties(); - String defaultValue = "defaultValue"; + final String defaultValue = "defaultValue"; - String value = ConfigurationLoader.replaceProperties("${checkstyle.basedir}", + final String value = ConfigurationLoader.replaceProperties("${checkstyle.basedir}", new PropertiesExpander(props), defaultValue); assertEquals(defaultValue, value); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/DefaultConfigurationTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/DefaultConfigurationTest.java index bbafcb1f2..d4cd2a62e 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/DefaultConfigurationTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/DefaultConfigurationTest.java @@ -27,8 +27,8 @@ public class DefaultConfigurationTest { @Test public void testRemoveChild() { - DefaultConfiguration config = new DefaultConfiguration("MyConfig"); - DefaultConfiguration configChild = new DefaultConfiguration("childConfig"); + final DefaultConfiguration config = new DefaultConfiguration("MyConfig"); + final DefaultConfiguration configChild = new DefaultConfiguration("childConfig"); assertEquals(0, config.getChildren().length); config.addChild(configChild); assertEquals(1, config.getChildren().length); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/DefaultLoggerTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/DefaultLoggerTest.java index cd5722353..2279c9aa9 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/DefaultLoggerTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/DefaultLoggerTest.java @@ -30,17 +30,17 @@ public class DefaultLoggerTest { @Test public void testCtor() { - OutputStream infoStream = new ByteArrayOutputStream(); - OutputStream errorStream = new ByteArrayOutputStream(); - DefaultLogger dl = new DefaultLogger(infoStream, true, errorStream, true); + final OutputStream infoStream = new ByteArrayOutputStream(); + final OutputStream errorStream = new ByteArrayOutputStream(); + final DefaultLogger dl = new DefaultLogger(infoStream, true, errorStream, true); dl.addException(new AuditEvent(5000, "myfile"), new IllegalStateException("upsss")); dl.auditFinished(new AuditEvent(6000, "myfile")); } @Test public void testCtorWithTwoParameters() { - OutputStream infoStream = new ByteArrayOutputStream(); - DefaultLogger dl = new DefaultLogger(infoStream, true); + final OutputStream infoStream = new ByteArrayOutputStream(); + final DefaultLogger dl = new DefaultLogger(infoStream, true); dl.addException(new AuditEvent(5000, "myfile"), new IllegalStateException("upsss")); dl.auditFinished(new AuditEvent(6000, "myfile")); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/MainTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/MainTest.java index 708576aab..97af3de44 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/MainTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/MainTest.java @@ -90,7 +90,7 @@ public class MainTest { exit.checkAssertionAfterwards(new Assertion() { @Override public void checkAssertion() { - String usage = String.format(Locale.ROOT, "Unrecognized option: -w%n" + final String usage = String.format(Locale.ROOT, "Unrecognized option: -w%n" + "usage: java com.puppycrawl.tools.checkstyle.Main [options] -c <config.xml>%n" + " file...%n" + " -c <arg> Sets the check configuration file to use.%n" @@ -232,10 +232,11 @@ public class MainTest { exit.checkAssertionAfterwards(new Assertion() { @Override public void checkAssertion() throws IOException { - String expectedPath = getFilePath("InputMain.java"); + final String expectedPath = getFilePath("InputMain.java"); final ResourceBundle compilationProperties = ResourceBundle.getBundle("checkstylecompilation"); - String version = compilationProperties.getString("checkstyle.compile.version"); + final String version = compilationProperties + .getString("checkstyle.compile.version"); assertEquals(String.format(Locale.ROOT, "<?xml version=\"1.0\" encoding=\"UTF-8\"?>%n" + "<checkstyle version=\"%s\">%n" @@ -272,7 +273,7 @@ public class MainTest { exit.checkAssertionAfterwards(new Assertion() { @Override public void checkAssertion() throws IOException { - String expectedPath = getFilePath("InputMain.java"); + final String expectedPath = getFilePath("InputMain.java"); assertEquals(String.format(Locale.ROOT, "Starting audit...%n" + "%1$s:3:14: " + "warning: Name 'InputMain' must match pattern" @@ -296,7 +297,7 @@ public class MainTest { exit.checkAssertionAfterwards(new Assertion() { @Override public void checkAssertion() throws IOException { - String expectedPath = getFilePath("InputMain.java"); + final String expectedPath = getFilePath("InputMain.java"); assertEquals(String.format(Locale.ROOT, "Starting audit...%n" + "%1$s:3:14: error: " + "Name 'InputMain' must match pattern '^[a-z0-9]*$'.%n" @@ -451,15 +452,15 @@ public class MainTest { @Test public void testLoadPropertiesIOException() throws Exception { - Class<?>[] param = new Class<?>[1]; + final Class<?>[] param = new Class<?>[1]; param[0] = File.class; - Method method = Main.class.getDeclaredMethod("loadProperties", param); + final Method method = Main.class.getDeclaredMethod("loadProperties", param); method.setAccessible(true); try { if (System.getProperty("os.name").toLowerCase(Locale.ENGLISH).startsWith("windows")) { // https://support.microsoft.com/en-us/kb/177506 but this only for NTFS // WindowsServer 2012 use Resilient File System (ReFS), so any name is ok - File file = new File(File.separator + ":invalid"); + final File file = new File(File.separator + ":invalid"); if (file.exists()) { file.delete(); } @@ -483,7 +484,8 @@ public class MainTest { @Test public void testCreateListenerIllegalStateException() throws Exception { - Method method = Main.class.getDeclaredMethod("createListener", String.class, String.class); + final Method method = Main.class.getDeclaredMethod("createListener", String.class, + String.class); method.setAccessible(true); try { method.invoke(null, "myformat", null); @@ -497,9 +499,10 @@ public class MainTest { @Test public void testCreateListenerWithLocationIllegalStateException() throws Exception { - Method method = Main.class.getDeclaredMethod("createListener", String.class, String.class); + final Method method = Main.class.getDeclaredMethod("createListener", String.class, + String.class); method.setAccessible(true); - String outDir = "myfolder123"; + final String outDir = "myfolder123"; try { method.invoke(null, "myformat", outDir); fail(); @@ -524,13 +527,13 @@ public class MainTest { exit.checkAssertionAfterwards(new Assertion() { @Override public void checkAssertion() throws IOException { - String expectedPath = getFilePath("checks/metrics") + File.separator; - StringBuilder sb = new StringBuilder(); + final String expectedPath = getFilePath("checks/metrics") + File.separator; + final StringBuilder sb = new StringBuilder(); sb.append("Starting audit...").append(System.getProperty("line.separator")); - String format = "%s.java:%s: warning: File length is %s lines " + final String format = "%s.java:%s: warning: File length is %s lines " + "(max allowed is 170)."; for (String[] outputValue : outputValues) { - String line = String.format(Locale.ROOT, format, + final String line = String.format(Locale.ROOT, format, expectedPath + outputValue[0], outputValue[1], outputValue[2]); sb.append(line).append(System.getProperty("line.separator")); @@ -548,30 +551,30 @@ public class MainTest { @Test @SuppressWarnings("unchecked") public void testListFilesNotFile() throws Exception { - Method method = Main.class.getDeclaredMethod("listFiles", File.class); + final Method method = Main.class.getDeclaredMethod("listFiles", File.class); method.setAccessible(true); - File fileMock = mock(File.class); + final File fileMock = mock(File.class); when(fileMock.canRead()).thenReturn(true); when(fileMock.isDirectory()).thenReturn(false); when(fileMock.isFile()).thenReturn(false); - List<File> result = (List<File>) method.invoke(null, fileMock); + final List<File> result = (List<File>) method.invoke(null, fileMock); assertEquals(0, result.size()); } @Test @SuppressWarnings("unchecked") public void testListFilesDirectoryWithNull() throws Exception { - Method method = Main.class.getDeclaredMethod("listFiles", File.class); + final Method method = Main.class.getDeclaredMethod("listFiles", File.class); method.setAccessible(true); - File fileMock = mock(File.class); + final File fileMock = mock(File.class); when(fileMock.canRead()).thenReturn(true); when(fileMock.isDirectory()).thenReturn(true); when(fileMock.listFiles()).thenReturn(null); - List<File> result = (List<File>) method.invoke(null, fileMock); + final List<File> result = (List<File>) method.invoke(null, fileMock); assertEquals(0, result.size()); } } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/PackageNamesLoaderTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/PackageNamesLoaderTest.java index 4a6d5a582..25ba73e6a 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/PackageNamesLoaderTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/PackageNamesLoaderTest.java @@ -94,19 +94,19 @@ public class PackageNamesLoaderTest { @SuppressWarnings("unchecked") public void testPackagesWithDots() throws Exception { - Constructor<PackageNamesLoader> constructor = + final Constructor<PackageNamesLoader> constructor = PackageNamesLoader.class.getDeclaredConstructor(); constructor.setAccessible(true); - PackageNamesLoader loader = constructor.newInstance(); + final PackageNamesLoader loader = constructor.newInstance(); - Attributes attributes = mock(Attributes.class); + final Attributes attributes = mock(Attributes.class); when(attributes.getValue("name")).thenReturn("coding."); loader.startElement("", "", "package", attributes); loader.endElement("", "", "package"); - Field field = PackageNamesLoader.class.getDeclaredField("packageNames"); + final Field field = PackageNamesLoader.class.getDeclaredField("packageNames"); field.setAccessible(true); - Set<String> list = (Set<String>) field.get(loader); + final Set<String> list = (Set<String>) field.get(loader); assertEquals("coding.", list.iterator().next()); } @@ -118,13 +118,13 @@ public class PackageNamesLoaderTest { when(mockConnection.getInputStream()).thenReturn( new ByteArrayInputStream(EMPTY_BYTE_ARRAY)); - URL url = getMockUrl(mockConnection); + final URL url = getMockUrl(mockConnection); - Enumeration<URL> enumeration = (Enumeration<URL>) mock(Enumeration.class); + final Enumeration<URL> enumeration = (Enumeration<URL>) mock(Enumeration.class); when(enumeration.hasMoreElements()).thenReturn(true); when(enumeration.nextElement()).thenReturn(url); - ClassLoader classLoader = mock(ClassLoader.class); + final ClassLoader classLoader = mock(ClassLoader.class); when(classLoader.getResources("checkstyle_packages.xml")).thenReturn(enumeration); try { @@ -143,13 +143,13 @@ public class PackageNamesLoaderTest { final URLConnection mockConnection = Mockito.mock(URLConnection.class); when(mockConnection.getInputStream()).thenReturn(null); - URL url = getMockUrl(mockConnection); + final URL url = getMockUrl(mockConnection); - Enumeration<URL> enumer = (Enumeration<URL>) mock(Enumeration.class); + final Enumeration<URL> enumer = (Enumeration<URL>) mock(Enumeration.class); when(enumer.hasMoreElements()).thenReturn(true); when(enumer.nextElement()).thenReturn(url); - ClassLoader classLoader = mock(ClassLoader.class); + final ClassLoader classLoader = mock(ClassLoader.class); when(classLoader.getResources("checkstyle_packages.xml")).thenReturn(enumer); try { @@ -166,7 +166,7 @@ public class PackageNamesLoaderTest { @SuppressWarnings("unchecked") public void testPackagesWithIoExceptionGetResources() throws Exception { - ClassLoader classLoader = mock(ClassLoader.class); + final ClassLoader classLoader = mock(ClassLoader.class); when(classLoader.getResources("checkstyle_packages.xml")).thenThrow(IOException.class); try { diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/PropertyCacheFileTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/PropertyCacheFileTest.java index 31265ad1a..20acc4cda 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/PropertyCacheFileTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/PropertyCacheFileTest.java @@ -52,7 +52,7 @@ public class PropertyCacheFileTest { @Test public void testNonAccessibleFile() throws IOException { - Configuration config = new DefaultConfiguration("myName"); + final Configuration config = new DefaultConfiguration("myName"); final File file = temporaryFolder.newFile("file.output"); file.setReadable(true, false); file.setWritable(false, false); @@ -69,7 +69,7 @@ public class PropertyCacheFileTest { assertEquals("config can not be null", ex.getMessage()); } try { - Configuration config = new DefaultConfiguration("myName"); + final Configuration config = new DefaultConfiguration("myName"); new PropertyCacheFile(config, null); } catch (IllegalArgumentException ex) { @@ -79,9 +79,9 @@ public class PropertyCacheFileTest { @Test public void testInCache() throws IOException { - Configuration config = new DefaultConfiguration("myName"); + final Configuration config = new DefaultConfiguration("myName"); final String filePath = temporaryFolder.newFile().getPath(); - PropertyCacheFile cache = new PropertyCacheFile(config, filePath); + final PropertyCacheFile cache = new PropertyCacheFile(config, filePath); cache.put("myFile", 1); assertTrue(cache.isInCache("myFile", 1)); assertFalse(cache.isInCache("myFile", 2)); @@ -92,18 +92,18 @@ public class PropertyCacheFileTest { @SuppressWarnings("unchecked") public void testExceptionNoSuchAlgorithmException() throws Exception { - Configuration config = new DefaultConfiguration("myName"); + final Configuration config = new DefaultConfiguration("myName"); final String filePath = temporaryFolder.newFile().getPath(); - PropertyCacheFile cache = new PropertyCacheFile(config, filePath); + final PropertyCacheFile cache = new PropertyCacheFile(config, filePath); cache.put("myFile", 1); mockStatic(MessageDigest.class); when(MessageDigest.getInstance("SHA-1")) .thenThrow(NoSuchAlgorithmException.class); - Class<?>[] param = new Class<?>[1]; + final Class<?>[] param = new Class<?>[1]; param[0] = Serializable.class; - Method method = PropertyCacheFile.class.getDeclaredMethod("getConfigHashCode", param); + final Method method = PropertyCacheFile.class.getDeclaredMethod("getConfigHashCode", param); method.setAccessible(true); try { method.invoke(cache, config); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/TreeWalkerTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/TreeWalkerTest.java index 722cfba77..6f0ecfc39 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/TreeWalkerTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/TreeWalkerTest.java @@ -93,7 +93,7 @@ public class TreeWalkerTest extends BaseCheckTestSupport { fail(); } catch (CheckstyleException e) { - String errorMsg = e.getMessage(); + final String errorMsg = e.getMessage(); assertTrue(errorMsg.contains("cannot initialize module" + " com.puppycrawl.tools.checkstyle.TreeWalker - Token \"IMPORT\"" + " was not found in Acceptable tokens list in check" @@ -140,7 +140,7 @@ public class TreeWalkerTest extends BaseCheckTestSupport { .toLowerCase(Locale.ENGLISH).startsWith("windows")) { // https://support.microsoft.com/en-us/kb/177506 but this only for NTFS // WindowsServer 2012 use Resilient File System (ReFS), so any name is ok - File file = new File("C\\:invalid"); + final File file = new File("C\\:invalid"); treeWalker.setCacheFile(file.getAbsolutePath()); } else { @@ -195,7 +195,7 @@ public class TreeWalkerTest extends BaseCheckTestSupport { checkerConfig.addAttribute("charset", "UTF-8"); checkerConfig.addChild(treeWalkerConfig); - Checker checker = new Checker(); + final Checker checker = new Checker(); final Locale locale = Locale.ROOT; checker.setLocaleCountry(locale.getCountry()); checker.setLocaleLanguage(locale.getLanguage()); @@ -212,7 +212,7 @@ public class TreeWalkerTest extends BaseCheckTestSupport { //checker.destroy(); //checker.configure(checkerConfig); - Checker otherChecker = new Checker(); + final Checker otherChecker = new Checker(); otherChecker.setLocaleCountry(locale.getCountry()); otherChecker.setLocaleLanguage(locale.getLanguage()); otherChecker.setModuleClassLoader(Thread.currentThread().getContextClassLoader()); @@ -245,7 +245,7 @@ public class TreeWalkerTest extends BaseCheckTestSupport { treeWalker.setTabWidth(1); treeWalker.configure(new DefaultConfiguration("default config")); treeWalker.setCacheFile(temporaryFolder.newFile().getPath()); - File file = new File("src/main/resources/checkstyle_packages.xml"); + final File file = new File("src/main/resources/checkstyle_packages.xml"); treeWalker.processFiltered(file, new ArrayList<String>()); } @@ -253,13 +253,13 @@ public class TreeWalkerTest extends BaseCheckTestSupport { public void testWithCacheWithNoViolation() throws Exception { final TreeWalker treeWalker = new TreeWalker(); treeWalker.configure(createCheckConfig(TypeNameCheck.class)); - PackageObjectFactory factory = new PackageObjectFactory( + final PackageObjectFactory factory = new PackageObjectFactory( new HashSet<String>(), Thread.currentThread().getContextClassLoader()); treeWalker.setModuleFactory(factory); treeWalker.setCacheFile(temporaryFolder.newFile().getPath()); treeWalker.setupChild(createCheckConfig(TypeNameCheck.class)); final File file = temporaryFolder.newFile("file.java"); - List<String> lines = new ArrayList<>(); + final List<String> lines = new ArrayList<>(); lines.add(" class a {} "); treeWalker.processFiltered(file, lines); } @@ -268,13 +268,13 @@ public class TreeWalkerTest extends BaseCheckTestSupport { public void testProcessWithParserThrowable() throws Exception { final TreeWalker treeWalker = new TreeWalker(); treeWalker.configure(createCheckConfig(TypeNameCheck.class)); - PackageObjectFactory factory = new PackageObjectFactory( + final PackageObjectFactory factory = new PackageObjectFactory( new HashSet<String>(), Thread.currentThread().getContextClassLoader()); treeWalker.setModuleFactory(factory); treeWalker.setCacheFile(temporaryFolder.newFile().getPath()); treeWalker.setupChild(createCheckConfig(TypeNameCheck.class)); final File file = temporaryFolder.newFile("file.java"); - List<String> lines = new ArrayList<>(); + final List<String> lines = new ArrayList<>(); lines.add(" classD a {} "); try { @@ -290,13 +290,13 @@ public class TreeWalkerTest extends BaseCheckTestSupport { public void testProcessWithRecognitionException() throws Exception { final TreeWalker treeWalker = new TreeWalker(); treeWalker.configure(createCheckConfig(TypeNameCheck.class)); - PackageObjectFactory factory = new PackageObjectFactory( + final PackageObjectFactory factory = new PackageObjectFactory( new HashSet<String>(), Thread.currentThread().getContextClassLoader()); treeWalker.setModuleFactory(factory); treeWalker.setCacheFile(temporaryFolder.newFile().getPath()); treeWalker.setupChild(createCheckConfig(TypeNameCheck.class)); final File file = temporaryFolder.newFile("file.java"); - List<String> lines = new ArrayList<>(); + final List<String> lines = new ArrayList<>(); lines.add(" class a%$# {} "); try { diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/XMLLoggerTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/XMLLoggerTest.java index 80f612bc0..6b39f8226 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/XMLLoggerTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/XMLLoggerTest.java @@ -249,7 +249,7 @@ public class XMLLoggerTest { assertEquals("first line.", "<?xml version=\"1.0\" encoding=\"UTF-8\"?>", lines[0]); - Pattern checkstyleOpenTag = Pattern.compile("^<checkstyle version=\".*\">$"); + final Pattern checkstyleOpenTag = Pattern.compile("^<checkstyle version=\".*\">$"); assertTrue("second line.", checkstyleOpenTag.matcher(lines[1]).matches()); for (int i = 0; i < expectedLines.length; i++) { assertEquals("line " + i + ".", expectedLines[i], lines[i + 2]); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/api/AbstractViolationReporterTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/api/AbstractViolationReporterTest.java index f2aa4e170..9643dc17c 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/api/AbstractViolationReporterTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/api/AbstractViolationReporterTest.java @@ -57,16 +57,16 @@ public class AbstractViolationReporterTest extends BaseCheckTestSupport { @Test public void testCustomMessage() throws Exception { - DefaultConfiguration config = createCheckConfig(emptyCheck.getClass()); + final DefaultConfiguration config = createCheckConfig(emptyCheck.getClass()); config.addMessage("msgKey", "This is a custom message."); emptyCheck.configure(config); - LocalizedMessages collector = new LocalizedMessages(); + final LocalizedMessages collector = new LocalizedMessages(); emptyCheck.setMessages(collector); emptyCheck.log(0, "msgKey"); - SortedSet<LocalizedMessage> messages = collector.getMessages(); + final SortedSet<LocalizedMessage> messages = collector.getMessages(); assertEquals(1, messages.size()); assertEquals("This is a custom message.", messages.first() .getMessage()); @@ -74,16 +74,16 @@ public class AbstractViolationReporterTest extends BaseCheckTestSupport { @Test public void testCustomMessageWithParameters() throws Exception { - DefaultConfiguration config = createCheckConfig(emptyCheck.getClass()); + final DefaultConfiguration config = createCheckConfig(emptyCheck.getClass()); config.addMessage("msgKey", "This is a custom message with {0}."); emptyCheck.configure(config); - LocalizedMessages collector = new LocalizedMessages(); + final LocalizedMessages collector = new LocalizedMessages(); emptyCheck.setMessages(collector); emptyCheck.log(0, "msgKey", "TestParam"); - SortedSet<LocalizedMessage> messages = collector.getMessages(); + final SortedSet<LocalizedMessage> messages = collector.getMessages(); assertEquals(1, messages.size()); assertEquals("This is a custom message with TestParam.", @@ -92,16 +92,16 @@ public class AbstractViolationReporterTest extends BaseCheckTestSupport { @Test(expected = IllegalArgumentException.class) public void testCustomMessageWithParametersNegative() throws Exception { - DefaultConfiguration config = createCheckConfig(emptyCheck.getClass()); + final DefaultConfiguration config = createCheckConfig(emptyCheck.getClass()); config.addMessage("msgKey", "This is a custom message {0."); emptyCheck.configure(config); - LocalizedMessages collector = new LocalizedMessages(); + final LocalizedMessages collector = new LocalizedMessages(); emptyCheck.setMessages(collector); emptyCheck.log(0, "msgKey", "TestParam"); - SortedSet<LocalizedMessage> messages = collector.getMessages(); + final SortedSet<LocalizedMessage> messages = collector.getMessages(); assertEquals(1, messages.size()); //we expect an exception here because of the bogus custom message diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/api/AutomaticBeanTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/api/AutomaticBeanTest.java index 1ee7a7061..56d19a61c 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/api/AutomaticBeanTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/api/AutomaticBeanTest.java @@ -70,7 +70,7 @@ public class AutomaticBeanTest { @Test public void testContextualizeInvocationTargetException() { final TestBean testBean = new TestBean(); - DefaultContext context = new DefaultContext(); + final DefaultContext context = new DefaultContext(); context.add("exceptionalMethod", 123.0f); try { testBean.contextualize(context); @@ -85,7 +85,7 @@ public class AutomaticBeanTest { @Test public void testContextualizeConversionException() { final TestBean testBean = new TestBean(); - DefaultContext context = new DefaultContext(); + final DefaultContext context = new DefaultContext(); context.add("val", "some string"); try { testBean.contextualize(context); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/api/CheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/api/CheckTest.java index b985e6bf2..21a73d811 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/api/CheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/api/CheckTest.java @@ -27,7 +27,7 @@ public class CheckTest { @Test public void testGetRequiredTokens() { - Check check = new Check() { + final Check check = new Check() { @Override public int[] getDefaultTokens() { return ArrayUtils.EMPTY_INT_ARRAY; @@ -40,7 +40,7 @@ public class CheckTest { @Test public void testGetAcceptable() { - Check check = new Check() { + final Check check = new Check() { @Override public int[] getDefaultTokens() { return ArrayUtils.EMPTY_INT_ARRAY; @@ -53,7 +53,7 @@ public class CheckTest { @Test public void testVisitToken() { - Check check = new Check() { + final Check check = new Check() { @Override public int[] getDefaultTokens() { return ArrayUtils.EMPTY_INT_ARRAY; diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/api/DetailASTTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/api/DetailASTTest.java index e7fa6736e..6e4facf8a 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/api/DetailASTTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/api/DetailASTTest.java @@ -112,7 +112,7 @@ public class DetailASTTest { } private static void checkDir(File dir) throws Exception { - File[] files = dir.listFiles(new FileFilter() { + final File[] files = dir.listFiles(new FileFilter() { @Override public boolean accept(File file) { return (file.getName().endsWith(".java") @@ -145,16 +145,16 @@ public class DetailASTTest { final DetailAST prev, final String filename, final DetailAST root) { - Object[] params = { + final Object[] params = { node, parent, prev, filename, root, }; - MessageFormat badParentFormatter = new MessageFormat( + final MessageFormat badParentFormatter = new MessageFormat( "Bad parent node={0} parent={1} filename={3} root={4}", Locale.ROOT); - String badParentMsg = badParentFormatter.format(params); + final String badParentMsg = badParentFormatter.format(params); assertEquals(badParentMsg, parent, node.getParent()); - MessageFormat badPrevFormatter = new MessageFormat( + final MessageFormat badPrevFormatter = new MessageFormat( "Bad prev node={0} prev={2} parent={1} filename={3} root={4}", Locale.ROOT); - String badPrevMsg = badPrevFormatter.format(params); + final String badPrevMsg = badPrevFormatter.format(params); assertEquals(badPrevMsg, prev, node.getPreviousSibling()); if (node.getFirstChild() != null) { diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/api/FileContentsTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/api/FileContentsTest.java index cae044069..838a155f3 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/api/FileContentsTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/api/FileContentsTest.java @@ -33,14 +33,14 @@ public class FileContentsTest { @SuppressWarnings("deprecation") public void testDeprecatedCtor() { // just to make UT coverage 100% - FileContents o = new FileContents("filename.java", "1", "2"); + final FileContents o = new FileContents("filename.java", "1", "2"); o.getFilename(); } @Test public void testCppCommentNotIntersect() { // just to make UT coverage 100% - FileContents o = new FileContents( + final FileContents o = new FileContents( FileText.fromLines(new File("filename"), Collections.singletonList(" // "))); o.reportCppComment(1, 2); assertFalse(o.hasIntersectionWithComment(1, 0, 1, 1)); @@ -49,7 +49,7 @@ public class FileContentsTest { @Test public void testCppCommentIntersect() { // just to make UT coverage 100% - FileContents o = new FileContents( + final FileContents o = new FileContents( FileText.fromLines(new File("filename"), Collections.singletonList(" // "))); o.reportCppComment(1, 2); assertTrue(o.hasIntersectionWithComment(1, 5, 1, 6)); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/api/FileTextTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/api/FileTextTest.java index 041611642..8ba76371d 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/api/FileTextTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/api/FileTextTest.java @@ -32,22 +32,22 @@ public class FileTextTest { @Test public void testUnsupportedCharset() throws IOException { // just to make UT coverage 100% - String charsetName = "STRANGE_CHARSET"; + final String charsetName = "STRANGE_CHARSET"; try { new FileText(new File("any name"), charsetName); fail(); } catch (UnsupportedEncodingException e) { - assertEquals(e.getMessage(), "Unsupported charset: " + charsetName); + assertEquals("Unsupported charset: " + charsetName, e.getMessage()); } } @Test public void testSupportedCharset() throws IOException { - String charsetName = "ISO-8859-1"; - FileText o = new FileText(new File("src/test/resources/com/puppycrawl/tools/" + final String charsetName = "ISO-8859-1"; + final FileText o = new FileText(new File("src/test/resources/com/puppycrawl/tools/" + "checkstyle/api/import-control_complete.xml"), charsetName); - assertEquals(o.getCharset().name(), charsetName); + assertEquals(charsetName, o.getCharset().name()); } } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/api/FullIdentTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/api/FullIdentTest.java index e700bb25a..bb5efd06c 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/api/FullIdentTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/api/FullIdentTest.java @@ -25,7 +25,7 @@ import org.junit.Test; public class FullIdentTest { public static void testToString() { - DetailAST ast = new DetailAST(); + final DetailAST ast = new DetailAST(); ast.setType(TokenTypes.LITERAL_NEW); ast.setColumnNo(14); ast.setLineNo(15); @@ -37,19 +37,19 @@ public class FullIdentTest { @Test public void testNonValidCoordinates() { - DetailAST ast = new DetailAST(); + final DetailAST ast = new DetailAST(); ast.setType(TokenTypes.DOT); ast.setColumnNo(1); ast.setLineNo(2); ast.setText("Root"); - DetailAST ast2 = new DetailAST(); + final DetailAST ast2 = new DetailAST(); ast2.setType(TokenTypes.LE); ast2.setColumnNo(-14); ast2.setLineNo(-15); ast2.setText("MyTestik"); - DetailAST ast1 = new DetailAST(); + final DetailAST ast1 = new DetailAST(); ast1.setType(TokenTypes.LITERAL_NEW); ast1.setColumnNo(14); ast1.setLineNo(15); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/api/LineColumnTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/api/LineColumnTest.java index 305d4f80f..2212dd4e3 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/api/LineColumnTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/api/LineColumnTest.java @@ -34,7 +34,7 @@ public class LineColumnTest { @Test public void testCompareToFirstLarger() { - LineColumn lineColumn = new LineColumn(0, 0); + final LineColumn lineColumn = new LineColumn(0, 0); assertEquals(1, new LineColumn(1, 0).compareTo(lineColumn)); assertEquals(1, new LineColumn(0, 1).compareTo(lineColumn)); @@ -42,7 +42,7 @@ public class LineColumnTest { @Test public void testCompareToFirstSmaller() { - Comparable<LineColumn> lineColumn = new LineColumn(0, 0); + final Comparable<LineColumn> lineColumn = new LineColumn(0, 0); assertEquals(-1, lineColumn.compareTo(new LineColumn(1, 0))); assertEquals(-1, lineColumn.compareTo(new LineColumn(0, 1))); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/api/LocalizedMessageTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/api/LocalizedMessageTest.java index 007f6c805..8fe03d580 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/api/LocalizedMessageTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/api/LocalizedMessageTest.java @@ -49,14 +49,14 @@ public class LocalizedMessageTest { @Test public void testGetModuleId() { - LocalizedMessage localizedMessage = createSampleLocalizedMessage(); + final LocalizedMessage localizedMessage = createSampleLocalizedMessage(); assertEquals("module", localizedMessage.getModuleId()); } @Test public void testMessageInEnglish() { - LocalizedMessage localizedMessage = createSampleLocalizedMessage(); + final LocalizedMessage localizedMessage = createSampleLocalizedMessage(); LocalizedMessage.setLocale(Locale.ENGLISH); assertEquals("Empty statement.", localizedMessage.getMessage()); @@ -64,7 +64,7 @@ public class LocalizedMessageTest { @Test public void testBundleReloadUrlNull() throws IOException { - LocalizedMessage.UTF8Control control = new LocalizedMessage.UTF8Control(); + final LocalizedMessage.UTF8Control control = new LocalizedMessage.UTF8Control(); control.newBundle("com.puppycrawl.tools.checkstyle.checks.coding.messages", Locale.ENGLISH, "java.class", Thread.currentThread().getContextClassLoader(), true); @@ -73,16 +73,17 @@ public class LocalizedMessageTest { @Test public void testBundleReloadUrlNotNull() throws IOException { - ClassLoader classloader = mock(ClassLoader.class); + final ClassLoader classloader = mock(ClassLoader.class); final URLConnection mockConnection = Mockito.mock(URLConnection.class); when(mockConnection.getInputStream()).thenReturn( new ByteArrayInputStream(EMPTY_BYTE_ARRAY)); - URL url = getMockUrl(mockConnection); - String resource = "com/puppycrawl/tools/checkstyle/checks/coding/messages_en.properties"; + final URL url = getMockUrl(mockConnection); + final String resource = + "com/puppycrawl/tools/checkstyle/checks/coding/messages_en.properties"; when(classloader.getResource(resource)).thenReturn(url); - LocalizedMessage.UTF8Control control = new LocalizedMessage.UTF8Control(); + final LocalizedMessage.UTF8Control control = new LocalizedMessage.UTF8Control(); control.newBundle("com.puppycrawl.tools.checkstyle.checks.coding.messages", Locale.ENGLISH, "java.class", classloader, true); @@ -91,13 +92,14 @@ public class LocalizedMessageTest { @Test public void testBundleReloadUrlNotNullStreamNull() throws IOException { - ClassLoader classloader = mock(ClassLoader.class); - String resource = "com/puppycrawl/tools/checkstyle/checks/coding/messages_en.properties"; + final ClassLoader classloader = mock(ClassLoader.class); + final String resource = + "com/puppycrawl/tools/checkstyle/checks/coding/messages_en.properties"; - URL url = getMockUrl(null); + final URL url = getMockUrl(null); when(classloader.getResource(resource)).thenReturn(url); - LocalizedMessage.UTF8Control control = new LocalizedMessage.UTF8Control(); + final LocalizedMessage.UTF8Control control = new LocalizedMessage.UTF8Control(); control.newBundle("com.puppycrawl.tools.checkstyle.checks.coding.messages", Locale.ENGLISH, "java.class", classloader, true); @@ -115,7 +117,7 @@ public class LocalizedMessageTest { @Test public void testMessageInFrench() { - LocalizedMessage localizedMessage = createSampleLocalizedMessage(); + final LocalizedMessage localizedMessage = createSampleLocalizedMessage(); LocalizedMessage.setLocale(Locale.FRENCH); assertEquals("Instruction vide.", localizedMessage.getMessage()); @@ -125,7 +127,7 @@ public class LocalizedMessageTest { public void testEnforceEnglishLanguageBySettingUnitedStatesLocale() { Locale.setDefault(Locale.FRENCH); LocalizedMessage.setLocale(Locale.US); - LocalizedMessage localizedMessage = createSampleLocalizedMessage(); + final LocalizedMessage localizedMessage = createSampleLocalizedMessage(); assertEquals("Empty statement.", localizedMessage.getMessage()); } @@ -134,7 +136,7 @@ public class LocalizedMessageTest { public void testEnforceEnglishLanguageBySettingRootLocale() { Locale.setDefault(Locale.FRENCH); LocalizedMessage.setLocale(Locale.ROOT); - LocalizedMessage localizedMessage = createSampleLocalizedMessage(); + final LocalizedMessage localizedMessage = createSampleLocalizedMessage(); assertEquals("Empty statement.", localizedMessage.getMessage()); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/api/ScopeTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/api/ScopeTest.java index d08feff21..632d20a07 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/api/ScopeTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/api/ScopeTest.java @@ -40,7 +40,7 @@ public class ScopeTest { */ @Test public void testScopeValueOf() { - Scope scope = Scope.valueOf("PRIVATE"); + final Scope scope = Scope.valueOf("PRIVATE"); assertEquals(Scope.PRIVATE, scope); } @@ -67,8 +67,8 @@ public class ScopeTest { @Test public void testMixedCaseSpacesWithDifferentLocales() { - Locale[] differentLocales = {new Locale("TR", "tr") }; - Locale defaultLocale = Locale.getDefault(); + final Locale[] differentLocales = {new Locale("TR", "tr") }; + final Locale defaultLocale = Locale.getDefault(); try { for (Locale differentLocale : differentLocales) { Locale.setDefault(differentLocale); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/api/SeverityLevelTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/api/SeverityLevelTest.java index 7a542e090..efeb59a0e 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/api/SeverityLevelTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/api/SeverityLevelTest.java @@ -38,7 +38,7 @@ public class SeverityLevelTest { */ @Test public void testSeverityLevelValueOf() { - SeverityLevel level = SeverityLevel.valueOf("INFO"); + final SeverityLevel level = SeverityLevel.valueOf("INFO"); assertEquals(SeverityLevel.INFO, level); } @@ -63,8 +63,8 @@ public class SeverityLevelTest { @Test public void testMixedCaseSpacesWithDifferentLocales() { - Locale[] differentLocales = {new Locale("TR", "tr") }; - Locale defaultLocale = Locale.getDefault(); + final Locale[] differentLocales = {new Locale("TR", "tr") }; + final Locale defaultLocale = Locale.getDefault(); try { for (Locale differentLocale : differentLocales) { Locale.setDefault(differentLocale); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/ArrayTypeStyleCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/ArrayTypeStyleCheckTest.java index bd3211b56..5a7ab9e8b 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/ArrayTypeStyleCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/ArrayTypeStyleCheckTest.java @@ -40,8 +40,8 @@ public class ArrayTypeStyleCheckTest @Test public void testGetRequiredTokens() { - ArrayTypeStyleCheck checkObj = new ArrayTypeStyleCheck(); - int[] expected = {TokenTypes.ARRAY_DECLARATOR}; + final ArrayTypeStyleCheck checkObj = new ArrayTypeStyleCheck(); + final int[] expected = {TokenTypes.ARRAY_DECLARATOR}; assertArrayEquals(expected, checkObj.getRequiredTokens()); } @@ -74,9 +74,9 @@ public class ArrayTypeStyleCheckTest @Test public void testGetAcceptableTokens() { - int[] expected = {TokenTypes.ARRAY_DECLARATOR }; - ArrayTypeStyleCheck check = new ArrayTypeStyleCheck(); - int[] actual = check.getAcceptableTokens(); + final int[] expected = {TokenTypes.ARRAY_DECLARATOR }; + final ArrayTypeStyleCheck check = new ArrayTypeStyleCheck(); + final int[] actual = check.getAcceptableTokens(); assertEquals(1, actual.length); assertArrayEquals(expected, actual); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/AvoidEscapedUnicodeCharactersCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/AvoidEscapedUnicodeCharactersCheckTest.java index 117a84d86..e05d793be 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/AvoidEscapedUnicodeCharactersCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/AvoidEscapedUnicodeCharactersCheckTest.java @@ -40,9 +40,9 @@ public class AvoidEscapedUnicodeCharactersCheckTest extends BaseCheckTestSupport @Test public void testGetRequiredTokens() { - AvoidEscapedUnicodeCharactersCheck checkObj = + final AvoidEscapedUnicodeCharactersCheck checkObj = new AvoidEscapedUnicodeCharactersCheck(); - int[] expected = { + final int[] expected = { TokenTypes.STRING_LITERAL, TokenTypes.CHAR_LITERAL, }; @@ -51,7 +51,7 @@ public class AvoidEscapedUnicodeCharactersCheckTest extends BaseCheckTestSupport @Test public void testDefault() throws Exception { - DefaultConfiguration checkConfig = + final DefaultConfiguration checkConfig = createCheckConfig(AvoidEscapedUnicodeCharactersCheck.class); final String[] expected = { "7: " + msg, @@ -86,7 +86,7 @@ public class AvoidEscapedUnicodeCharactersCheckTest extends BaseCheckTestSupport @Test public void testAllowEscapesForControlCharacterSet() throws Exception { - DefaultConfiguration checkConfig = + final DefaultConfiguration checkConfig = createCheckConfig(AvoidEscapedUnicodeCharactersCheck.class); checkConfig.addAttribute("allowEscapesForControlCharacters", "true"); final String[] expected = { @@ -119,7 +119,7 @@ public class AvoidEscapedUnicodeCharactersCheckTest extends BaseCheckTestSupport @Test public void testAllowByTailComment() throws Exception { - DefaultConfiguration checkConfig = + final DefaultConfiguration checkConfig = createCheckConfig(AvoidEscapedUnicodeCharactersCheck.class); checkConfig.addAttribute("allowByTailComment", "true"); final String[] expected = { @@ -147,7 +147,7 @@ public class AvoidEscapedUnicodeCharactersCheckTest extends BaseCheckTestSupport @Test public void testAllowAllCharactersEscaped() throws Exception { - DefaultConfiguration checkConfig = + final DefaultConfiguration checkConfig = createCheckConfig(AvoidEscapedUnicodeCharactersCheck.class); checkConfig.addAttribute("allowIfAllCharactersEscaped", "true"); final String[] expected = { @@ -166,7 +166,7 @@ public class AvoidEscapedUnicodeCharactersCheckTest extends BaseCheckTestSupport @Test public void allowNonPrintableEscapes() throws Exception { - DefaultConfiguration checkConfig = + final DefaultConfiguration checkConfig = createCheckConfig(AvoidEscapedUnicodeCharactersCheck.class); checkConfig.addAttribute("allowNonPrintableEscapes", "true"); final String[] expected = { @@ -188,9 +188,9 @@ public class AvoidEscapedUnicodeCharactersCheckTest extends BaseCheckTestSupport @Test public void testGetAcceptableTokens() { - AvoidEscapedUnicodeCharactersCheck check = new AvoidEscapedUnicodeCharactersCheck(); - int[] actual = check.getAcceptableTokens(); - int[] expected = {TokenTypes.STRING_LITERAL, TokenTypes.CHAR_LITERAL }; + final AvoidEscapedUnicodeCharactersCheck check = new AvoidEscapedUnicodeCharactersCheck(); + final int[] actual = check.getAcceptableTokens(); + final int[] expected = {TokenTypes.STRING_LITERAL, TokenTypes.CHAR_LITERAL }; assertArrayEquals(expected, actual); } } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/ClassResolverTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/ClassResolverTest.java index dfb196a33..facc7a034 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/ClassResolverTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/ClassResolverTest.java @@ -44,7 +44,7 @@ public class ClassResolverTest { imports.add("java.io.File"); imports.add("nothing.will.match.*"); imports.add("java.applet.*"); - ClassResolver classResolver = + final ClassResolver classResolver = new ClassResolver(Thread.currentThread().getContextClassLoader(), null, imports); assertNotNull(classResolver); @@ -68,11 +68,11 @@ public class ClassResolverTest { } imports.add("java.text.ChoiceFormat"); - ClassResolver newClassResolver = new ClassResolver( + final ClassResolver newClassResolver = new ClassResolver( Thread.currentThread().getContextClassLoader(), null, imports); newClassResolver.resolve("ChoiceFormat", ""); - ClassResolver javaUtilClassResolver = new ClassResolver( + final ClassResolver javaUtilClassResolver = new ClassResolver( Thread.currentThread().getContextClassLoader(), "java.util", imports); javaUtilClassResolver.resolve("List", ""); try { @@ -88,7 +88,7 @@ public class ClassResolverTest { public void testExistedImportCantBeResolved() throws Exception { final Set<String> imports = Sets.newHashSet(); imports.add("java.applet.someClass"); - ClassResolver classResolver = new ClassResolver( + final ClassResolver classResolver = new ClassResolver( Thread.currentThread().getContextClassLoader(), "", imports); @@ -105,18 +105,18 @@ public class ClassResolverTest { @Test public void testResolveInnerClass() throws Exception { final Set<String> imports = Sets.newHashSet(); - ClassResolver classResolver = new ClassResolver( + final ClassResolver classResolver = new ClassResolver( Thread.currentThread().getContextClassLoader(), "java.util", imports); - Class<?> entry = classResolver.resolve("Entry", "Map"); + final Class<?> entry = classResolver.resolve("Entry", "Map"); assertEquals("java.util.Map$Entry", entry.getName()); } @Test public void testResolveInnerClassWithEmptyPackage() throws Exception { final Set<String> imports = Sets.newHashSet(); - ClassResolver classResolver = new ClassResolver( + final ClassResolver classResolver = new ClassResolver( Thread.currentThread().getContextClassLoader(), "", imports); @@ -133,7 +133,7 @@ public class ClassResolverTest { final Set<String> imports = Sets.newHashSet(); imports.add("java.applet.someClass"); - ClassResolver classResolver = PowerMockito.spy(new ClassResolver(Thread + final ClassResolver classResolver = PowerMockito.spy(new ClassResolver(Thread .currentThread().getContextClassLoader(), "", imports)); PowerMockito.doThrow(new ClassNotFoundException("expected exception")) diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/DescendantTokenCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/DescendantTokenCheckTest.java index fedcb145f..c82947149 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/DescendantTokenCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/DescendantTokenCheckTest.java @@ -222,14 +222,14 @@ public class DescendantTokenCheckTest extends BaseCheckTestSupport { @Test public void testReturnFromCatch() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(DescendantTokenCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(DescendantTokenCheck.class); checkConfig.addAttribute("tokens", "LITERAL_CATCH"); checkConfig.addAttribute("limitedTokens", "LITERAL_RETURN"); checkConfig.addAttribute("maximumNumber", "0"); checkConfig.addAttribute("maximumMessage", "Return from catch is not allowed."); - String[] expected = { + final String[] expected = { "7:11: Return from catch is not allowed.", "15:11: Return from catch is not allowed.", }; @@ -239,14 +239,14 @@ public class DescendantTokenCheckTest extends BaseCheckTestSupport { @Test public void testReturnFromFinally() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(DescendantTokenCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(DescendantTokenCheck.class); checkConfig.addAttribute("tokens", "LITERAL_FINALLY"); checkConfig.addAttribute("limitedTokens", "LITERAL_RETURN"); checkConfig.addAttribute("maximumNumber", "0"); checkConfig.addAttribute("maximumMessage", "Return from finally is not allowed."); - String[] expected = { + final String[] expected = { "7:11: Return from finally is not allowed.", "15:11: Return from finally is not allowed.", }; @@ -256,21 +256,21 @@ public class DescendantTokenCheckTest extends BaseCheckTestSupport { @Test public void testNoSum() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(DescendantTokenCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(DescendantTokenCheck.class); checkConfig.addAttribute("tokens", "NOT_EQUAL,EQUAL"); checkConfig.addAttribute("limitedTokens", "LITERAL_THIS,LITERAL_NULL"); checkConfig.addAttribute("maximumNumber", "1"); checkConfig.addAttribute("maximumMessage", "What are you doing?"); - String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; + final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; verify(checkConfig, getPath("InputReturnFromFinally.java"), expected); } @Test public void testWithSumCustomMsg() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(DescendantTokenCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(DescendantTokenCheck.class); checkConfig.addAttribute("tokens", "NOT_EQUAL,EQUAL"); checkConfig.addAttribute("limitedTokens", "LITERAL_THIS,LITERAL_NULL"); checkConfig.addAttribute("maximumNumber", "1"); @@ -278,7 +278,7 @@ public class DescendantTokenCheckTest extends BaseCheckTestSupport { checkConfig.addAttribute("maximumMessage", "this cannot be null."); checkConfig.addAttribute("sumTokenCounts", "true"); - String[] expected = { + final String[] expected = { "22:32: this cannot be null.", "22:50: this cannot be null.", "23:33: this cannot be null.", @@ -290,14 +290,14 @@ public class DescendantTokenCheckTest extends BaseCheckTestSupport { @Test public void testWithSumDefaultMsg() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(DescendantTokenCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(DescendantTokenCheck.class); checkConfig.addAttribute("tokens", "NOT_EQUAL,EQUAL"); checkConfig.addAttribute("limitedTokens", "LITERAL_THIS,LITERAL_NULL"); checkConfig.addAttribute("maximumNumber", "1"); checkConfig.addAttribute("maximumDepth", "1"); checkConfig.addAttribute("sumTokenCounts", "true"); - String[] expected = { + final String[] expected = { "22:32: " + getCheckMessage(MSG_KEY_SUM_MAX, 2, 1, "EQUAL"), "22:50: " + getCheckMessage(MSG_KEY_SUM_MAX, 2, 1, "EQUAL"), "23:33: " + getCheckMessage(MSG_KEY_SUM_MAX, 2, 1, "NOT_EQUAL"), @@ -309,13 +309,13 @@ public class DescendantTokenCheckTest extends BaseCheckTestSupport { @Test public void testWithSumLessThenMinDefMsg() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(DescendantTokenCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(DescendantTokenCheck.class); checkConfig.addAttribute("tokens", "NOT_EQUAL,EQUAL"); checkConfig.addAttribute("limitedTokens", "LITERAL_THIS,LITERAL_NULL"); checkConfig.addAttribute("minimumNumber", "3"); checkConfig.addAttribute("sumTokenCounts", "true"); - String[] expected = { + final String[] expected = { "16:44: " + getCheckMessage(MSG_KEY_SUM_MIN, 0, 3, "EQUAL"), "22:32: " + getCheckMessage(MSG_KEY_SUM_MIN, 2, 3, "EQUAL"), "22:50: " + getCheckMessage(MSG_KEY_SUM_MIN, 2, 3, "EQUAL"), @@ -330,14 +330,14 @@ public class DescendantTokenCheckTest extends BaseCheckTestSupport { @Test public void testWithSumLessThenMinCustomMsg() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(DescendantTokenCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(DescendantTokenCheck.class); checkConfig.addAttribute("tokens", "NOT_EQUAL,EQUAL"); checkConfig.addAttribute("limitedTokens", "LITERAL_THIS,LITERAL_NULL"); checkConfig.addAttribute("minimumNumber", "3"); checkConfig.addAttribute("sumTokenCounts", "true"); checkConfig.addAttribute("minimumMessage", "custom message"); - String[] expected = { + final String[] expected = { "16:44: custom message", "22:32: custom message", "22:50: custom message", diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/FileSetCheckLifecycleTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/FileSetCheckLifecycleTest.java index 2666a8cb7..cff3839b9 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/FileSetCheckLifecycleTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/FileSetCheckLifecycleTest.java @@ -55,7 +55,7 @@ public class FileSetCheckLifecycleTest @Test public void testGetRequiredTokens() { - FileContentsHolder checkObj = new FileContentsHolder(); + final FileContentsHolder checkObj = new FileContentsHolder(); assertArrayEquals(ArrayUtils.EMPTY_INT_ARRAY, checkObj.getRequiredTokens()); } @@ -72,8 +72,8 @@ public class FileSetCheckLifecycleTest @Test public void testProcessCallsFinishBeforeCallingDestroy() throws Exception { - DefaultConfiguration dc = new DefaultConfiguration("configuration"); - DefaultConfiguration twConf = createCheckConfig(TreeWalker.class); + final DefaultConfiguration dc = new DefaultConfiguration("configuration"); + final DefaultConfiguration twConf = createCheckConfig(TreeWalker.class); dc.addAttribute("charset", "UTF-8"); dc.addChild(twConf); twConf.addChild(new DefaultConfiguration(FileContentsHolder.class.getName())); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/NewlineAtEndOfFileCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/NewlineAtEndOfFileCheckTest.java index de7ad22da..3b4d3bf9b 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/NewlineAtEndOfFileCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/NewlineAtEndOfFileCheckTest.java @@ -169,25 +169,26 @@ public class NewlineAtEndOfFileCheckTest @Test public void testWrongFile() throws Exception { final DefaultConfiguration checkConfig = createCheckConfig(NewlineAtEndOfFileCheck.class); - NewlineAtEndOfFileCheck check = new NewlineAtEndOfFileCheck(); + final NewlineAtEndOfFileCheck check = new NewlineAtEndOfFileCheck(); check.configure(checkConfig); - File impossibleFile = new File(""); - Set<LocalizedMessage> messages = check.process(impossibleFile, Lists.newArrayList("txt")); + final File impossibleFile = new File(""); + final Set<LocalizedMessage> messages = check.process(impossibleFile, + Lists.newArrayList("txt")); assertEquals(1, messages.size()); - Iterator<LocalizedMessage> iterator = messages.iterator(); + final Iterator<LocalizedMessage> iterator = messages.iterator(); assertEquals("Unable to open ''.", iterator.next().getMessage()); } @Test public void testWrongSeparatorLength() throws Exception { - NewlineAtEndOfFileCheck check = new NewlineAtEndOfFileCheck(); + final NewlineAtEndOfFileCheck check = new NewlineAtEndOfFileCheck(); final DefaultConfiguration checkConfig = createCheckConfig(NewlineAtEndOfFileCheck.class); check.configure(checkConfig); - Method method = NewlineAtEndOfFileCheck.class + final Method method = NewlineAtEndOfFileCheck.class .getDeclaredMethod("endsWithNewline", RandomAccessFile.class); method.setAccessible(true); - RandomAccessFile file = mock(RandomAccessFile.class); + final RandomAccessFile file = mock(RandomAccessFile.class); when(file.length()).thenReturn(2000000L); try { method.invoke(new NewlineAtEndOfFileCheck(), file); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/OuterTypeFilenameCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/OuterTypeFilenameCheckTest.java index 78573c554..8f5796408 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/OuterTypeFilenameCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/OuterTypeFilenameCheckTest.java @@ -44,8 +44,8 @@ public class OuterTypeFilenameCheckTest extends BaseCheckTestSupport { @Test public void testGetRequiredTokens() { - OuterTypeFilenameCheck checkObj = new OuterTypeFilenameCheck(); - int[] expected = { + final OuterTypeFilenameCheck checkObj = new OuterTypeFilenameCheck(); + final int[] expected = { TokenTypes.CLASS_DEF, TokenTypes.INTERFACE_DEF, TokenTypes.ENUM_DEF, @@ -72,9 +72,9 @@ public class OuterTypeFilenameCheckTest extends BaseCheckTestSupport { @Test public void testGetAcceptableTokens() { - OuterTypeFilenameCheck check = new OuterTypeFilenameCheck(); - int[] actual = check.getAcceptableTokens(); - int[] expected = { + final OuterTypeFilenameCheck check = new OuterTypeFilenameCheck(); + final int[] actual = check.getAcceptableTokens(); + final int[] expected = { TokenTypes.CLASS_DEF, TokenTypes.INTERFACE_DEF, TokenTypes.ENUM_DEF, @@ -115,7 +115,7 @@ public class OuterTypeFilenameCheckTest extends BaseCheckTestSupport { @Test public void testPackageAnnotation() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(OuterTypeFilenameCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(OuterTypeFilenameCheck.class); final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/SuppressWarningsHolderTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/SuppressWarningsHolderTest.java index ca642e6a0..734fcb919 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/SuppressWarningsHolderTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/SuppressWarningsHolderTest.java @@ -63,23 +63,23 @@ public class SuppressWarningsHolderTest extends BaseCheckTestSupport { @Test public void testGetRequiredTokens() { - SuppressWarningsHolder checkObj = new SuppressWarningsHolder(); - int[] expected = {TokenTypes.ANNOTATION}; + final SuppressWarningsHolder checkObj = new SuppressWarningsHolder(); + final int[] expected = {TokenTypes.ANNOTATION}; assertArrayEquals(expected, checkObj.getRequiredTokens()); } @Test public void testOnComplexAnnotations() throws Exception { - Configuration checkConfig = createCheckConfig(SuppressWarningsHolder.class); + final Configuration checkConfig = createCheckConfig(SuppressWarningsHolder.class); - String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; + final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; verify(checkConfig, getPath("InputSuppressWarningsHolder.java"), expected); } @Test public void testCustomAnnotation() throws Exception { - Configuration checkConfig = createCheckConfig(SuppressWarningsHolder.class); + final Configuration checkConfig = createCheckConfig(SuppressWarningsHolder.class); final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; @@ -94,20 +94,20 @@ public class SuppressWarningsHolderTest extends BaseCheckTestSupport { @Test public void testSetAliasListEmpty() { - SuppressWarningsHolder holder = new SuppressWarningsHolder(); + final SuppressWarningsHolder holder = new SuppressWarningsHolder(); holder.setAliasList(""); } @Test public void testSetAliasListCorrect() { - SuppressWarningsHolder holder = new SuppressWarningsHolder(); + final SuppressWarningsHolder holder = new SuppressWarningsHolder(); holder.setAliasList("alias=value"); assertEquals("value", SuppressWarningsHolder.getAlias("alias")); } @Test public void testSetAliasListWrong() { - SuppressWarningsHolder holder = new SuppressWarningsHolder(); + final SuppressWarningsHolder holder = new SuppressWarningsHolder(); try { holder.setAliasList("SomeAlias"); @@ -121,22 +121,22 @@ public class SuppressWarningsHolderTest extends BaseCheckTestSupport { @Test public void testIsSuppressed() throws Exception { - Class<?> entry = Class + final Class<?> entry = Class .forName("com.puppycrawl.tools.checkstyle.checks.SuppressWarningsHolder$Entry"); - Constructor<?> entryConstructor = entry.getDeclaredConstructor(String.class, int.class, - int.class, int.class, int.class); + final Constructor<?> entryConstructor = entry.getDeclaredConstructor(String.class, + int.class, int.class, int.class, int.class); entryConstructor.setAccessible(true); - Object entryInstance = entryConstructor.newInstance("MockEntry", 100, 100, 350, 350); + final Object entryInstance = entryConstructor.newInstance("MockEntry", 100, 100, 350, 350); - List<Object> entriesList = new ArrayList<>(); + final List<Object> entriesList = new ArrayList<>(); entriesList.add(entryInstance); - ThreadLocal<?> threadLocal = mock(ThreadLocal.class); + final ThreadLocal<?> threadLocal = mock(ThreadLocal.class); PowerMockito.doReturn(entriesList).when(threadLocal, "get"); - SuppressWarningsHolder holder = new SuppressWarningsHolder(); - Field entries = holder.getClass().getDeclaredField("ENTRIES"); + final SuppressWarningsHolder holder = new SuppressWarningsHolder(); + final Field entries = holder.getClass().getDeclaredField("ENTRIES"); entries.setAccessible(true); entries.set(holder, threadLocal); @@ -145,22 +145,22 @@ public class SuppressWarningsHolderTest extends BaseCheckTestSupport { @Test public void testIsSuppressedWithAllArgument() throws Exception { - Class<?> entry = Class + final Class<?> entry = Class .forName("com.puppycrawl.tools.checkstyle.checks.SuppressWarningsHolder$Entry"); - Constructor<?> entryConstr = entry.getDeclaredConstructor(String.class, int.class, + final Constructor<?> entryConstr = entry.getDeclaredConstructor(String.class, int.class, int.class, int.class, int.class); entryConstr.setAccessible(true); - Object entryInstance = entryConstr.newInstance("all", 100, 100, 350, 350); + final Object entryInstance = entryConstr.newInstance("all", 100, 100, 350, 350); - List<Object> entriesList = new ArrayList<>(); + final List<Object> entriesList = new ArrayList<>(); entriesList.add(entryInstance); - ThreadLocal<?> threadLocal = mock(ThreadLocal.class); + final ThreadLocal<?> threadLocal = mock(ThreadLocal.class); PowerMockito.doReturn(entriesList).when(threadLocal, "get"); - SuppressWarningsHolder holder = new SuppressWarningsHolder(); - Field entries = holder.getClass().getDeclaredField("ENTRIES"); + final SuppressWarningsHolder holder = new SuppressWarningsHolder(); + final Field entries = holder.getClass().getDeclaredField("ENTRIES"); entries.setAccessible(true); entries.set(holder, threadLocal); @@ -173,7 +173,7 @@ public class SuppressWarningsHolderTest extends BaseCheckTestSupport { @Test public void testAnnotationInTry() throws Exception { - Configuration checkConfig = createCheckConfig(SuppressWarningsHolder.class); + final Configuration checkConfig = createCheckConfig(SuppressWarningsHolder.class); final String[] expected = { "11: " + getCheckMessage("suppress.warnings.invalid.target"), @@ -184,7 +184,7 @@ public class SuppressWarningsHolderTest extends BaseCheckTestSupport { @Test public void testEmptyAnnotation() throws Exception { - Configuration checkConfig = createCheckConfig(SuppressWarningsHolder.class); + final Configuration checkConfig = createCheckConfig(SuppressWarningsHolder.class); final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; @@ -193,21 +193,21 @@ public class SuppressWarningsHolderTest extends BaseCheckTestSupport { @Test public void testGetAllAnnotationValuesWrongArg() throws ReflectiveOperationException { - SuppressWarningsHolder holder = new SuppressWarningsHolder(); - Method getAllAnnotationValues = holder.getClass() + final SuppressWarningsHolder holder = new SuppressWarningsHolder(); + final Method getAllAnnotationValues = holder.getClass() .getDeclaredMethod("getAllAnnotationValues", DetailAST.class); getAllAnnotationValues.setAccessible(true); - DetailAST methodDef = new DetailAST(); + final DetailAST methodDef = new DetailAST(); methodDef.setType(TokenTypes.METHOD_DEF); methodDef.setText("Method Def"); methodDef.setLineNo(0); methodDef.setColumnNo(0); - DetailAST lparen = new DetailAST(); + final DetailAST lparen = new DetailAST(); lparen.setType(TokenTypes.LPAREN); - DetailAST parent = new DetailAST(); + final DetailAST parent = new DetailAST(); parent.addChild(lparen); parent.addChild(methodDef); @@ -223,12 +223,12 @@ public class SuppressWarningsHolderTest extends BaseCheckTestSupport { @Test public void testGetAnnotationValuesWrongArg() throws ReflectiveOperationException { - SuppressWarningsHolder holder = new SuppressWarningsHolder(); - Method getAllAnnotationValues = holder.getClass() + final SuppressWarningsHolder holder = new SuppressWarningsHolder(); + final Method getAllAnnotationValues = holder.getClass() .getDeclaredMethod("getAnnotationValues", DetailAST.class); getAllAnnotationValues.setAccessible(true); - DetailAST methodDef = new DetailAST(); + final DetailAST methodDef = new DetailAST(); methodDef.setType(TokenTypes.METHOD_DEF); methodDef.setText("Method Def"); methodDef.setLineNo(0); @@ -247,16 +247,16 @@ public class SuppressWarningsHolderTest extends BaseCheckTestSupport { @Test public void testGetAnnotationTargetWrongArg() throws ReflectiveOperationException { - SuppressWarningsHolder holder = new SuppressWarningsHolder(); - Method getAnnotationTarget = holder.getClass() + final SuppressWarningsHolder holder = new SuppressWarningsHolder(); + final Method getAnnotationTarget = holder.getClass() .getDeclaredMethod("getAnnotationTarget", DetailAST.class); getAnnotationTarget.setAccessible(true); - DetailAST methodDef = new DetailAST(); + final DetailAST methodDef = new DetailAST(); methodDef.setType(TokenTypes.METHOD_DEF); methodDef.setText("Method Def"); - DetailAST parent = new DetailAST(); + final DetailAST parent = new DetailAST(); parent.setType(TokenTypes.ASSIGN); parent.setText("Parent ast"); parent.addChild(methodDef); @@ -275,8 +275,8 @@ public class SuppressWarningsHolderTest extends BaseCheckTestSupport { @Test public void testAstWithoutChildren() { - SuppressWarningsHolder holder = new SuppressWarningsHolder(); - DetailAST methodDef = new DetailAST(); + final SuppressWarningsHolder holder = new SuppressWarningsHolder(); + final DetailAST methodDef = new DetailAST(); methodDef.setType(TokenTypes.METHOD_DEF); try { @@ -291,7 +291,7 @@ public class SuppressWarningsHolderTest extends BaseCheckTestSupport { @Test public void testAnnotationWithFullName() throws Exception { - Configuration checkConfig = createCheckConfig(SuppressWarningsHolder.class); + final Configuration checkConfig = createCheckConfig(SuppressWarningsHolder.class); final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/TodoCommentCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/TodoCommentCheckTest.java index 63a23796c..5cba992e9 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/TodoCommentCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/TodoCommentCheckTest.java @@ -41,8 +41,8 @@ public class TodoCommentCheckTest @Test public void testGetRequiredTokens() { - TodoCommentCheck checkObj = new TodoCommentCheck(); - int[] expected = {TokenTypes.COMMENT_CONTENT}; + final TodoCommentCheck checkObj = new TodoCommentCheck(); + final int[] expected = {TokenTypes.COMMENT_CONTENT}; assertArrayEquals(expected, checkObj.getRequiredTokens()); } @@ -62,9 +62,9 @@ public class TodoCommentCheckTest @Test public void testGetAcceptableTokens() { - int[] expected = {TokenTypes.COMMENT_CONTENT }; - TodoCommentCheck check = new TodoCommentCheck(); - int[] actual = check.getAcceptableTokens(); + final int[] expected = {TokenTypes.COMMENT_CONTENT }; + final TodoCommentCheck check = new TodoCommentCheck(); + final int[] actual = check.getAcceptableTokens(); assertEquals(1, actual.length); assertArrayEquals(expected, actual); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/TrailingCommentCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/TrailingCommentCheckTest.java index 48b25a6fe..9ebe76834 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/TrailingCommentCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/TrailingCommentCheckTest.java @@ -50,13 +50,13 @@ public class TrailingCommentCheckTest extends BaseCheckTestSupport { @Test public void testGetRequiredTokens() { - TrailingCommentCheck checkObj = new TrailingCommentCheck(); + final TrailingCommentCheck checkObj = new TrailingCommentCheck(); assertArrayEquals(ArrayUtils.EMPTY_INT_ARRAY, checkObj.getRequiredTokens()); } @Test public void testGetAcceptableTokens() { - TrailingCommentCheck checkObj = new TrailingCommentCheck(); + final TrailingCommentCheck checkObj = new TrailingCommentCheck(); assertArrayEquals(ArrayUtils.EMPTY_INT_ARRAY, checkObj.getAcceptableTokens()); } @@ -88,7 +88,7 @@ public class TrailingCommentCheckTest extends BaseCheckTestSupport { @Test public void testCallVisitToken() throws Exception { - TrailingCommentCheck check = new TrailingCommentCheck(); + final TrailingCommentCheck check = new TrailingCommentCheck(); try { check.visitToken(new DetailAST()); Assert.fail(); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/TranslationCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/TranslationCheckTest.java index e12797666..3c09688cd 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/TranslationCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/TranslationCheckTest.java @@ -103,13 +103,13 @@ public class TranslationCheckTest //I can't put wrong file here. Checkstyle fails before check started. //I saw some usage of file or handling of wrong file in Checker, or somewhere //in checks running part. So I had to do it with reflection to improve coverage. - TranslationCheck check = new TranslationCheck(); - DefaultConfiguration checkConfig = createCheckConfig(TranslationCheck.class); + final TranslationCheck check = new TranslationCheck(); + final DefaultConfiguration checkConfig = createCheckConfig(TranslationCheck.class); check.configure(checkConfig); - Checker checker = createChecker(checkConfig); + final Checker checker = createChecker(checkConfig); check.setMessageDispatcher(checker); - Method loadKeys = check.getClass().getDeclaredMethod("loadKeys", File.class); + final Method loadKeys = check.getClass().getDeclaredMethod("loadKeys", File.class); loadKeys.setAccessible(true); loadKeys.invoke(check, new File("")); @@ -120,12 +120,12 @@ public class TranslationCheckTest //I can't put wrong file here. Checkstyle fails before check started. //I saw some usage of file or handling of wrong file in Checker, or somewhere //in checks running part. So I had to do it with reflection to improve coverage. - TranslationCheck check = new TranslationCheck(); - DefaultConfiguration checkConfig = createCheckConfig(TranslationCheck.class); + final TranslationCheck check = new TranslationCheck(); + final DefaultConfiguration checkConfig = createCheckConfig(TranslationCheck.class); check.configure(checkConfig); check.setMessageDispatcher(createChecker(checkConfig)); - Method logIOException = check.getClass().getDeclaredMethod("logIOException", + final Method logIOException = check.getClass().getDeclaredMethod("logIOException", IOException.class, File.class); logIOException.setAccessible(true); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/UncommentedMainCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/UncommentedMainCheckTest.java index 2f6a50ca6..a7619185e 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/UncommentedMainCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/UncommentedMainCheckTest.java @@ -71,7 +71,7 @@ public class UncommentedMainCheckTest @Test public void testTokens() throws Exception { - UncommentedMainCheck check = new UncommentedMainCheck(); + final UncommentedMainCheck check = new UncommentedMainCheck(); Assert.assertNotNull(check.getRequiredTokens()); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertArrayEquals(check.getDefaultTokens(), check.getAcceptableTokens()); @@ -101,8 +101,8 @@ public class UncommentedMainCheckTest @Test public void testIllegalStateException() throws Exception { - UncommentedMainCheck check = new UncommentedMainCheck(); - DetailAST ast = new DetailAST(); + final UncommentedMainCheck check = new UncommentedMainCheck(); + final DetailAST ast = new DetailAST(); ast.initialize(new CommonHiddenStreamToken(TokenTypes.CTOR_DEF, "ctor")); try { check.visitToken(ast); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/UniquePropertiesCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/UniquePropertiesCheckTest.java index af8c57ea7..ceca04395 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/UniquePropertiesCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/UniquePropertiesCheckTest.java @@ -67,7 +67,7 @@ public class UniquePropertiesCheckTest extends BaseFileSetCheckTestSupport { */ @Test public void testLineSeparatorOptionValueOf() { - LineSeparatorOption option = LineSeparatorOption.valueOf("CR"); + final LineSeparatorOption option = LineSeparatorOption.valueOf("CR"); assertEquals(LineSeparatorOption.CR, option); } @@ -129,20 +129,20 @@ public class UniquePropertiesCheckTest extends BaseFileSetCheckTestSupport { @Test public void testWrongKeyTypeInProperties() throws Exception { - Class<?> uniquePropertiesClass = Class + final Class<?> uniquePropertiesClass = Class .forName("com.puppycrawl.tools.checkstyle.checks." + "UniquePropertiesCheck$UniqueProperties"); - Constructor<?> constructor = uniquePropertiesClass.getDeclaredConstructor(); + final Constructor<?> constructor = uniquePropertiesClass.getDeclaredConstructor(); constructor.setAccessible(true); - Object uniqueProperties = constructor.newInstance(); - Method method = uniqueProperties.getClass().getDeclaredMethod("put", Object.class, + final Object uniqueProperties = constructor.newInstance(); + final Method method = uniqueProperties.getClass().getDeclaredMethod("put", Object.class, Object.class); - Object result = method.invoke(uniqueProperties, 1, "value"); - Map<Object, Object> table = new HashMap<>(); - Object expected = table.put(1, "value"); + final Object result = method.invoke(uniqueProperties, 1, "value"); + final Map<Object, Object> table = new HashMap<>(); + final Object expected = table.put(1, "value"); assertEquals(expected, result); - Object result2 = method.invoke(uniqueProperties, 1, "value"); - Object expected2 = table.put(1, "value"); + final Object result2 = method.invoke(uniqueProperties, 1, "value"); + final Object expected2 = table.put(1, "value"); assertEquals(expected2, result2); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/UpperEllCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/UpperEllCheckTest.java index ef666e170..7abfa0d66 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/UpperEllCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/UpperEllCheckTest.java @@ -41,8 +41,8 @@ public class UpperEllCheckTest @Test public void testGetRequiredTokens() { - UpperEllCheck checkObj = new UpperEllCheck(); - int[] expected = {TokenTypes.NUM_LONG}; + final UpperEllCheck checkObj = new UpperEllCheck(); + final int[] expected = {TokenTypes.NUM_LONG}; assertArrayEquals(expected, checkObj.getRequiredTokens()); } @@ -59,9 +59,9 @@ public class UpperEllCheckTest @Test public void testAcceptableTokens() { - int[] expected = {TokenTypes.NUM_LONG }; - UpperEllCheck check = new UpperEllCheck(); - int[] actual = check.getAcceptableTokens(); + final int[] expected = {TokenTypes.NUM_LONG }; + final UpperEllCheck check = new UpperEllCheck(); + final int[] actual = check.getAcceptableTokens(); assertEquals(1, actual.length); assertArrayEquals(expected, actual); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/AnnotationLocationCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/AnnotationLocationCheckTest.java index ff88ed45f..e3a5ecb2b 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/AnnotationLocationCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/AnnotationLocationCheckTest.java @@ -42,13 +42,13 @@ public class AnnotationLocationCheckTest extends BaseCheckTestSupport { @Test public void testGetRequiredTokens() { - AnnotationLocationCheck checkObj = new AnnotationLocationCheck(); + final AnnotationLocationCheck checkObj = new AnnotationLocationCheck(); assertArrayEquals(ArrayUtils.EMPTY_INT_ARRAY, checkObj.getRequiredTokens()); } @Test public void testCorrect() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(AnnotationLocationCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(AnnotationLocationCheck.class); final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; verify(checkConfig, getPath("InputCorrectAnnotationLocation.java"), expected); @@ -56,7 +56,7 @@ public class AnnotationLocationCheckTest extends BaseCheckTestSupport { @Test public void testIncorrect() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(AnnotationLocationCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(AnnotationLocationCheck.class); final String[] expected = { "6: " + getCheckMessage(MSG_KEY_ANNOTATION_LOCATION_ALONE, "MyAnnotation1"), "11: " + getCheckMessage(MSG_KEY_ANNOTATION_LOCATION_ALONE, "MyAnnotation1"), @@ -83,9 +83,9 @@ public class AnnotationLocationCheckTest extends BaseCheckTestSupport { @Test public void testGetAcceptableTokens() { - AnnotationLocationCheck constantNameCheckObj = new AnnotationLocationCheck(); - int[] actual = constantNameCheckObj.getAcceptableTokens(); - int[] expected = { + final AnnotationLocationCheck constantNameCheckObj = new AnnotationLocationCheck(); + final int[] actual = constantNameCheckObj.getAcceptableTokens(); + final int[] expected = { TokenTypes.CLASS_DEF, TokenTypes.INTERFACE_DEF, TokenTypes.ENUM_DEF, @@ -107,14 +107,14 @@ public class AnnotationLocationCheckTest extends BaseCheckTestSupport { @Test public void testWithoutAnnotations() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(AnnotationLocationCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(AnnotationLocationCheck.class); final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; verify(checkConfig, getPath("InputAnnotationLocation1.java"), expected); } @Test public void testWithParameters() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(AnnotationLocationCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(AnnotationLocationCheck.class); checkConfig.addAttribute("allowSamelineSingleParameterlessAnnotation", "true"); checkConfig.addAttribute("allowSamelineParameterizedAnnotation", "true"); checkConfig.addAttribute("allowSamelineMultipleAnnotations", "true"); @@ -138,7 +138,7 @@ public class AnnotationLocationCheckTest extends BaseCheckTestSupport { @Test public void testWithMultipleAnnotations() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(AnnotationLocationCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(AnnotationLocationCheck.class); checkConfig.addAttribute("allowSamelineSingleParameterlessAnnotation", "false"); final String[] expected = { "3: " + getCheckMessage(MSG_KEY_ANNOTATION_LOCATION_ALONE, "MyAnnotation11"), diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/AnnotationUseStyleTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/AnnotationUseStyleTest.java index 96761fba2..2f4d8bed5 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/AnnotationUseStyleTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/AnnotationUseStyleTest.java @@ -52,7 +52,7 @@ public class AnnotationUseStyleTest extends BaseCheckTestSupport { */ @Test public void testElementStyleValueOf() { - AnnotationUseStyleCheck.ElementStyle option = + final AnnotationUseStyleCheck.ElementStyle option = AnnotationUseStyleCheck.ElementStyle.valueOf("COMPACT"); assertEquals(AnnotationUseStyleCheck.ElementStyle.COMPACT, option); } @@ -63,7 +63,7 @@ public class AnnotationUseStyleTest extends BaseCheckTestSupport { */ @Test public void testTrailingArrayCommaValueOf() { - AnnotationUseStyleCheck.TrailingArrayComma option = + final AnnotationUseStyleCheck.TrailingArrayComma option = AnnotationUseStyleCheck.TrailingArrayComma.valueOf("ALWAYS"); assertEquals(AnnotationUseStyleCheck.TrailingArrayComma.ALWAYS, option); } @@ -74,7 +74,7 @@ public class AnnotationUseStyleTest extends BaseCheckTestSupport { */ @Test public void testClosingParensValueOf() { - AnnotationUseStyleCheck.ClosingParens option = + final AnnotationUseStyleCheck.ClosingParens option = AnnotationUseStyleCheck.ClosingParens.valueOf("ALWAYS"); assertEquals(AnnotationUseStyleCheck.ClosingParens.ALWAYS, option); } @@ -84,7 +84,7 @@ public class AnnotationUseStyleTest extends BaseCheckTestSupport { */ @Test public void testParensAlways() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(AnnotationUseStyleCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(AnnotationUseStyleCheck.class); checkConfig.addAttribute("closingParens", "ALWAYS"); checkConfig.addAttribute("elementStyle", "ignore"); checkConfig.addAttribute("trailingArrayComma", "ignore"); @@ -102,7 +102,7 @@ public class AnnotationUseStyleTest extends BaseCheckTestSupport { */ @Test public void testParensNever() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(AnnotationUseStyleCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(AnnotationUseStyleCheck.class); checkConfig.addAttribute("closingParens", "NEVER"); checkConfig.addAttribute("elementStyle", "ignore"); checkConfig.addAttribute("trailingArrayComma", "ignore"); @@ -117,7 +117,7 @@ public class AnnotationUseStyleTest extends BaseCheckTestSupport { @Test public void testStyleExpanded() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(AnnotationUseStyleCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(AnnotationUseStyleCheck.class); checkConfig.addAttribute("closingParens", "ignore"); checkConfig.addAttribute("elementStyle", "EXPANDED"); checkConfig.addAttribute("trailingArrayComma", "ignore"); @@ -136,7 +136,7 @@ public class AnnotationUseStyleTest extends BaseCheckTestSupport { @Test public void testStyleCompact() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(AnnotationUseStyleCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(AnnotationUseStyleCheck.class); checkConfig.addAttribute("closingParens", "ignore"); checkConfig.addAttribute("elementStyle", "COMPACT"); checkConfig.addAttribute("trailingArrayComma", "ignore"); @@ -150,7 +150,7 @@ public class AnnotationUseStyleTest extends BaseCheckTestSupport { @Test public void testStyleCompactNoArray() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(AnnotationUseStyleCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(AnnotationUseStyleCheck.class); checkConfig.addAttribute("closingParens", "ignore"); checkConfig.addAttribute("elementStyle", "COMPACT_NO_ARRAY"); checkConfig.addAttribute("trailingArrayComma", "ignore"); @@ -167,7 +167,7 @@ public class AnnotationUseStyleTest extends BaseCheckTestSupport { @Test public void testCommaAlwaysViolations() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(AnnotationUseStyleCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(AnnotationUseStyleCheck.class); checkConfig.addAttribute("closingParens", "ignore"); checkConfig.addAttribute("elementStyle", "ignore"); checkConfig.addAttribute("trailingArrayComma", "ALWAYS"); @@ -192,7 +192,7 @@ public class AnnotationUseStyleTest extends BaseCheckTestSupport { @Test public void testCommaAlwaysNoViolations() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(AnnotationUseStyleCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(AnnotationUseStyleCheck.class); checkConfig.addAttribute("closingParens", "ignore"); checkConfig.addAttribute("elementStyle", "ignore"); checkConfig.addAttribute("trailingArrayComma", "ALWAYS"); @@ -203,7 +203,7 @@ public class AnnotationUseStyleTest extends BaseCheckTestSupport { @Test public void testCommaNeverViolations() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(AnnotationUseStyleCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(AnnotationUseStyleCheck.class); checkConfig.addAttribute("closingParens", "ignore"); checkConfig.addAttribute("elementStyle", "ignore"); checkConfig.addAttribute("trailingArrayComma", "NEVER"); @@ -223,7 +223,7 @@ public class AnnotationUseStyleTest extends BaseCheckTestSupport { @Test public void testCommaNeverNoViolations() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(AnnotationUseStyleCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(AnnotationUseStyleCheck.class); checkConfig.addAttribute("closingParens", "ignore"); checkConfig.addAttribute("elementStyle", "ignore"); checkConfig.addAttribute("trailingArrayComma", "NEVER"); @@ -234,7 +234,7 @@ public class AnnotationUseStyleTest extends BaseCheckTestSupport { @Test public void testEverythingMixed() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(AnnotationUseStyleCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(AnnotationUseStyleCheck.class); checkConfig.addAttribute("closingParens", "ignore"); checkConfig.addAttribute("elementStyle", "ignore"); checkConfig.addAttribute("trailingArrayComma", "ignore"); @@ -245,7 +245,7 @@ public class AnnotationUseStyleTest extends BaseCheckTestSupport { @Test public void testAnnotationsWithoutDefaultValues() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(AnnotationUseStyleCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(AnnotationUseStyleCheck.class); checkConfig.addAttribute("closingParens", "NEVER"); final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; @@ -254,15 +254,15 @@ public class AnnotationUseStyleTest extends BaseCheckTestSupport { @Test public void testGetAcceptableTokens() { - AnnotationUseStyleCheck constantNameCheckObj = new AnnotationUseStyleCheck(); - int[] actual = constantNameCheckObj.getAcceptableTokens(); - int[] expected = {TokenTypes.ANNOTATION }; + final AnnotationUseStyleCheck constantNameCheckObj = new AnnotationUseStyleCheck(); + final int[] actual = constantNameCheckObj.getAcceptableTokens(); + final int[] expected = {TokenTypes.ANNOTATION }; Assert.assertArrayEquals(expected, actual); } @Test public void testGetOption() throws Exception { - AnnotationUseStyleCheck check = new AnnotationUseStyleCheck(); + final AnnotationUseStyleCheck check = new AnnotationUseStyleCheck(); try { check.setElementStyle("SHOULD_PRODUCE_ERROR"); } @@ -276,7 +276,7 @@ public class AnnotationUseStyleTest extends BaseCheckTestSupport { @Test public void testStyleNotInList() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(AnnotationUseStyleCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(AnnotationUseStyleCheck.class); checkConfig.addAttribute("closingParens", "ignore"); checkConfig.addAttribute("elementStyle", "COMPACT_NO_ARRAY"); checkConfig.addAttribute("trailingArrayComma", "ignore"); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingDeprecatedTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingDeprecatedTest.java index 81a973ace..f60d47e84 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingDeprecatedTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingDeprecatedTest.java @@ -43,8 +43,8 @@ public class MissingDeprecatedTest extends BaseCheckTestSupport { @Test public void testGetRequiredTokens() { - MissingDeprecatedCheck checkObj = new MissingDeprecatedCheck(); - int[] expected = { + final MissingDeprecatedCheck checkObj = new MissingDeprecatedCheck(); + final int[] expected = { TokenTypes.INTERFACE_DEF, TokenTypes.CLASS_DEF, TokenTypes.ANNOTATION_DEF, @@ -63,7 +63,7 @@ public class MissingDeprecatedTest extends BaseCheckTestSupport { */ @Test public void testBadDeprecatedAnnotation() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(MissingDeprecatedCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(MissingDeprecatedCheck.class); final String[] expected = { "7: " + getCheckMessage(MSG_KEY_ANNOTATION_MISSING_DEPRECATED), @@ -86,7 +86,7 @@ public class MissingDeprecatedTest extends BaseCheckTestSupport { @Test public void testBadDeprecatedJavadoc() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(MissingDeprecatedCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(MissingDeprecatedCheck.class); final String[] expected = { "5: " + getCheckMessage(MSG_KEY_ANNOTATION_MISSING_DEPRECATED), @@ -109,7 +109,7 @@ public class MissingDeprecatedTest extends BaseCheckTestSupport { @Test public void testSpecialCaseDeprecated() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(MissingDeprecatedCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(MissingDeprecatedCheck.class); final String[] expected = { "5: " + getCheckMessage(MSG_KEY_JAVADOC_DUPLICATE_TAG, "@deprecated"), @@ -136,7 +136,7 @@ public class MissingDeprecatedTest extends BaseCheckTestSupport { @Test public void testGoodDeprecated() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(MissingDeprecatedCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(MissingDeprecatedCheck.class); final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; @@ -146,7 +146,7 @@ public class MissingDeprecatedTest extends BaseCheckTestSupport { @Test public void testTwoInJavadocWithoutAnnotation() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(MissingDeprecatedCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(MissingDeprecatedCheck.class); final String[] expected = { "7: " + getCheckMessage(MSG_KEY_JAVADOC_MISSING), @@ -160,7 +160,7 @@ public class MissingDeprecatedTest extends BaseCheckTestSupport { @Test public void testEmptyJavadocLine() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(MissingDeprecatedCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(MissingDeprecatedCheck.class); final String[] expected = { "7: " + getCheckMessage(MSG_KEY_JAVADOC_MISSING), diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingOverrideCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingOverrideCheckTest.java index 1b4a8a158..47e65e149 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingOverrideCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/MissingOverrideCheckTest.java @@ -47,7 +47,7 @@ public class MissingOverrideCheckTest extends BaseCheckTestSupport { */ @Test public void testBadOverrideFromObject() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(MissingOverrideCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(MissingOverrideCheck.class); checkConfig.addAttribute("javaFiveCompatibility", "false"); final String[] expected = { @@ -66,7 +66,7 @@ public class MissingOverrideCheckTest extends BaseCheckTestSupport { */ @Test public void testBadOverrideFromObjectJ5Compatible() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(MissingOverrideCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(MissingOverrideCheck.class); checkConfig.addAttribute("javaFiveCompatibility", "true"); final String[] expected = { @@ -85,7 +85,7 @@ public class MissingOverrideCheckTest extends BaseCheckTestSupport { */ @Test public void testBadOverrideFromOther() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(MissingOverrideCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(MissingOverrideCheck.class); final String[] expected = { "10: " + getCheckMessage(MSG_KEY_ANNOTATION_MISSING_OVERRIDE), "26: " + getCheckMessage(MSG_KEY_ANNOTATION_MISSING_OVERRIDE), @@ -105,7 +105,7 @@ public class MissingOverrideCheckTest extends BaseCheckTestSupport { */ @Test public void testBadOverrideFromOtherJ5Compatible() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(MissingOverrideCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(MissingOverrideCheck.class); checkConfig.addAttribute("javaFiveCompatibility", "true"); final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; @@ -119,7 +119,7 @@ public class MissingOverrideCheckTest extends BaseCheckTestSupport { */ @Test public void testBadAnnotationOverride() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(MissingOverrideCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(MissingOverrideCheck.class); final String[] expected = { "10: " + getCheckMessage(MSG_KEY_ANNOTATION_MISSING_OVERRIDE), "16: " + getCheckMessage(MSG_KEY_ANNOTATION_MISSING_OVERRIDE), @@ -136,7 +136,7 @@ public class MissingOverrideCheckTest extends BaseCheckTestSupport { */ @Test public void testBadAnnotationOverrideJ5Compatible() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(MissingOverrideCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(MissingOverrideCheck.class); checkConfig.addAttribute("javaFiveCompatibility", "true"); final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; @@ -148,7 +148,7 @@ public class MissingOverrideCheckTest extends BaseCheckTestSupport { */ @Test public void testNotOverride() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(MissingOverrideCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(MissingOverrideCheck.class); final String[] expected = { "8: " + getCheckMessage(MSG_KEY_TAG_NOT_VALID_ON, "{@inheritDoc}"), "15: " + getCheckMessage(MSG_KEY_TAG_NOT_VALID_ON, "{@inheritDoc}"), @@ -163,7 +163,7 @@ public class MissingOverrideCheckTest extends BaseCheckTestSupport { */ @Test public void testGoodOverrideFromObject() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(MissingOverrideCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(MissingOverrideCheck.class); checkConfig.addAttribute("javaFiveCompatibility", "false"); final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; @@ -177,7 +177,7 @@ public class MissingOverrideCheckTest extends BaseCheckTestSupport { */ @Test public void testGoodOverrideFromObjectJ5Compatible() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(MissingOverrideCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(MissingOverrideCheck.class); checkConfig.addAttribute("javaFiveCompatibility", "true"); final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; @@ -191,7 +191,7 @@ public class MissingOverrideCheckTest extends BaseCheckTestSupport { */ @Test public void testGoodOverrideFromOther() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(MissingOverrideCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(MissingOverrideCheck.class); final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; verify(checkConfig, getPath("InputGoodOverrideFromOther.java"), expected); @@ -203,7 +203,7 @@ public class MissingOverrideCheckTest extends BaseCheckTestSupport { */ @Test public void testGoodOverrideFromOtherJ5Compatible() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(MissingOverrideCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(MissingOverrideCheck.class); checkConfig.addAttribute("javaFiveCompatibility", "true"); final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; @@ -217,7 +217,7 @@ public class MissingOverrideCheckTest extends BaseCheckTestSupport { */ @Test public void testGoodAnnotationOverride() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(MissingOverrideCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(MissingOverrideCheck.class); final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; verify(checkConfig, getPath("InputGoodAnnotationOverride.java"), expected); @@ -229,7 +229,7 @@ public class MissingOverrideCheckTest extends BaseCheckTestSupport { */ @Test public void testGoodAnnotationOverrideJ5Compatible() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(MissingOverrideCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(MissingOverrideCheck.class); checkConfig.addAttribute("javaFiveCompatibility", "true"); final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; @@ -238,9 +238,9 @@ public class MissingOverrideCheckTest extends BaseCheckTestSupport { @Test public void testGetAcceptableTokens() throws Exception { - int[] expectedTokens = {TokenTypes.METHOD_DEF }; - MissingOverrideCheck check = new MissingOverrideCheck(); - int[] actual = check.getAcceptableTokens(); + final int[] expectedTokens = {TokenTypes.METHOD_DEF }; + final MissingOverrideCheck check = new MissingOverrideCheck(); + final int[] actual = check.getAcceptableTokens(); assertEquals(1, actual.length); Assert.assertArrayEquals(expectedTokens, actual); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/PackageAnnotationTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/PackageAnnotationTest.java index 6a8c2fc27..cd0074166 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/PackageAnnotationTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/PackageAnnotationTest.java @@ -48,7 +48,7 @@ public class PackageAnnotationTest extends BaseCheckTestSupport { */ @Test public void testGoodPackageAnnotation() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(PackageAnnotationCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(PackageAnnotationCheck.class); final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; @@ -57,15 +57,15 @@ public class PackageAnnotationTest extends BaseCheckTestSupport { @Test public void testGetAcceptableTokens() { - PackageAnnotationCheck constantNameCheckObj = new PackageAnnotationCheck(); - int[] actual = constantNameCheckObj.getAcceptableTokens(); - int[] expected = {TokenTypes.PACKAGE_DEF }; + final PackageAnnotationCheck constantNameCheckObj = new PackageAnnotationCheck(); + final int[] actual = constantNameCheckObj.getAcceptableTokens(); + final int[] expected = {TokenTypes.PACKAGE_DEF }; Assert.assertArrayEquals(expected, actual); } @Test public void testAnnotationNotInPackageInfo() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(PackageAnnotationCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(PackageAnnotationCheck.class); final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; @@ -74,7 +74,7 @@ public class PackageAnnotationTest extends BaseCheckTestSupport { @Test public void testWithoutAnnotation() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(PackageAnnotationCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(PackageAnnotationCheck.class); final String[] expected = { "0: Package annotations must be in the package-info.java info.", diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/SuppressWarningsCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/SuppressWarningsCheckTest.java index 795ec337a..b715fd628 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/SuppressWarningsCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/annotation/SuppressWarningsCheckTest.java @@ -42,7 +42,7 @@ public class SuppressWarningsCheckTest extends BaseCheckTestSupport { */ @Test public void testSingleDefault() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); final String[] expected = { "8:23: " + getCheckMessage(MSG_KEY_SUPPRESSED_WARNING_NOT_ALLOWED, " "), @@ -64,7 +64,7 @@ public class SuppressWarningsCheckTest extends BaseCheckTestSupport { */ @Test public void testSingleAll() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); checkConfig.addAttribute("format", ".*"); final String[] expected = { @@ -106,7 +106,7 @@ public class SuppressWarningsCheckTest extends BaseCheckTestSupport { */ @Test public void testSingleNoUnchecked() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); checkConfig.addAttribute("format", "^unchecked$*"); final String[] expected = { @@ -130,7 +130,7 @@ public class SuppressWarningsCheckTest extends BaseCheckTestSupport { */ @Test public void testSingleNoUncheckedTokens() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); checkConfig.addAttribute("format", "^unchecked$*"); checkConfig.addAttribute("tokens", "CLASS_DEF,METHOD_DEF"); @@ -152,7 +152,7 @@ public class SuppressWarningsCheckTest extends BaseCheckTestSupport { */ @Test public void testSingleNoUnWildcard() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); checkConfig.addAttribute("format", ".*un.*"); final String[] expected = { @@ -185,7 +185,7 @@ public class SuppressWarningsCheckTest extends BaseCheckTestSupport { */ @Test public void testSingleNoUncheckedUnused() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); checkConfig.addAttribute("format", "^unchecked$*|^unused$"); final String[] expected = { @@ -215,7 +215,7 @@ public class SuppressWarningsCheckTest extends BaseCheckTestSupport { */ @Test public void testSingleNoUncheckedUnusedAll() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); checkConfig.addAttribute("format", "^unchecked$*|^unused$*|.*"); final String[] expected = { @@ -257,7 +257,7 @@ public class SuppressWarningsCheckTest extends BaseCheckTestSupport { */ @Test public void testCompactDefault() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); final String[] expected = { "8:24: " + getCheckMessage(MSG_KEY_SUPPRESSED_WARNING_NOT_ALLOWED, " "), @@ -286,7 +286,7 @@ public class SuppressWarningsCheckTest extends BaseCheckTestSupport { */ @Test public void testCompactAll() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); checkConfig.addAttribute("format", ".*"); final String[] expected = { @@ -347,7 +347,7 @@ public class SuppressWarningsCheckTest extends BaseCheckTestSupport { */ @Test public void testCompactNoUnchecked() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); checkConfig.addAttribute("format", "^unchecked$*"); final String[] expected = { @@ -375,7 +375,7 @@ public class SuppressWarningsCheckTest extends BaseCheckTestSupport { */ @Test public void testCompactNoUncheckedTokens() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); checkConfig.addAttribute("format", "^unchecked$*"); checkConfig.addAttribute("tokens", "CLASS_DEF"); @@ -394,7 +394,7 @@ public class SuppressWarningsCheckTest extends BaseCheckTestSupport { */ @Test public void testCompactNoUnWildcard() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); checkConfig.addAttribute("format", "un.*"); final String[] expected = { @@ -436,7 +436,7 @@ public class SuppressWarningsCheckTest extends BaseCheckTestSupport { */ @Test public void testCompactNoUncheckedUnused() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); checkConfig.addAttribute("format", "^unchecked$*|^unused$"); final String[] expected = { @@ -472,7 +472,7 @@ public class SuppressWarningsCheckTest extends BaseCheckTestSupport { */ @Test public void testCompactNoUncheckedUnusedAll() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); checkConfig.addAttribute("format", "^unchecked$*|^unused$*|.*"); final String[] expected = { @@ -533,7 +533,7 @@ public class SuppressWarningsCheckTest extends BaseCheckTestSupport { */ @Test public void testExpandedDefault() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); final String[] expected = { "8:30: " + getCheckMessage(MSG_KEY_SUPPRESSED_WARNING_NOT_ALLOWED, " "), @@ -560,7 +560,7 @@ public class SuppressWarningsCheckTest extends BaseCheckTestSupport { */ @Test public void testExpandedAll() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); checkConfig.addAttribute("format", ".*"); final String[] expected = { @@ -618,7 +618,7 @@ public class SuppressWarningsCheckTest extends BaseCheckTestSupport { */ @Test public void testExpandedNoUnchecked() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); checkConfig.addAttribute("format", "^unchecked$*"); final String[] expected = { @@ -646,7 +646,7 @@ public class SuppressWarningsCheckTest extends BaseCheckTestSupport { */ @Test public void testExpandedNoUncheckedTokens() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); checkConfig.addAttribute("format", "^unchecked$*"); checkConfig.addAttribute("tokens", "CLASS_DEF"); @@ -665,7 +665,7 @@ public class SuppressWarningsCheckTest extends BaseCheckTestSupport { */ @Test public void testExpandedNoUnWildcard() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); checkConfig.addAttribute("format", "un.*"); final String[] expected = { @@ -703,7 +703,7 @@ public class SuppressWarningsCheckTest extends BaseCheckTestSupport { */ @Test public void testExpandedNoUncheckedUnused() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); checkConfig.addAttribute("format", "^unchecked$*|^unused$"); final String[] expected = { @@ -740,7 +740,7 @@ public class SuppressWarningsCheckTest extends BaseCheckTestSupport { */ @Test public void testExpandedNoUncheckedUnusedAll() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); checkConfig.addAttribute("format", "^unchecked$*|^unused$*|.*"); final String[] expected = { @@ -794,27 +794,27 @@ public class SuppressWarningsCheckTest extends BaseCheckTestSupport { @Test public void testUncheckedInConstant() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); - String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; + final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; verify(checkConfig, getPath("InputSuppressWarningsConstants.java"), expected); } @Test public void testValuePairAnnotation() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); - String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; + final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; verify(checkConfig, getPath("InputSuppressWarningsValuePair.java"), expected); } @Test public void testWorkingProperlyOnComplexAnnotations() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(SuppressWarningsCheck.class); - String[] expected = { + final String[] expected = { "18:34: " + getCheckMessage(MSG_KEY_SUPPRESSED_WARNING_NOT_ALLOWED, ""), "24:23: " + getCheckMessage(MSG_KEY_SUPPRESSED_WARNING_NOT_ALLOWED, ""), "28:52: " + getCheckMessage(MSG_KEY_SUPPRESSED_WARNING_NOT_ALLOWED, ""), diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/blocks/AvoidNestedBlocksCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/blocks/AvoidNestedBlocksCheckTest.java index 5e7ca24c4..4a5a49a3f 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/blocks/AvoidNestedBlocksCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/blocks/AvoidNestedBlocksCheckTest.java @@ -41,8 +41,8 @@ public class AvoidNestedBlocksCheckTest @Test public void testGetRequiredTokens() { - AvoidNestedBlocksCheck checkObj = new AvoidNestedBlocksCheck(); - int[] expected = {TokenTypes.SLIST}; + final AvoidNestedBlocksCheck checkObj = new AvoidNestedBlocksCheck(); + final int[] expected = {TokenTypes.SLIST}; assertArrayEquals(expected, checkObj.getRequiredTokens()); } @@ -77,9 +77,9 @@ public class AvoidNestedBlocksCheckTest @Test public void testGetAcceptableTokens() { - AvoidNestedBlocksCheck constantNameCheckObj = new AvoidNestedBlocksCheck(); - int[] actual = constantNameCheckObj.getAcceptableTokens(); - int[] expected = {TokenTypes.SLIST }; + final AvoidNestedBlocksCheck constantNameCheckObj = new AvoidNestedBlocksCheck(); + final int[] actual = constantNameCheckObj.getAcceptableTokens(); + final int[] expected = {TokenTypes.SLIST }; assertArrayEquals(expected, actual); } } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/blocks/EmptyBlockCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/blocks/EmptyBlockCheckTest.java index 06c2bdbea..b9bc9790d 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/blocks/EmptyBlockCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/blocks/EmptyBlockCheckTest.java @@ -45,7 +45,7 @@ public class EmptyBlockCheckTest */ @Test public void testBlockOptionValueOf() { - BlockOption option = BlockOption.valueOf("TEXT"); + final BlockOption option = BlockOption.valueOf("TEXT"); assertEquals(BlockOption.TEXT, option); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/blocks/EmptyCatchBlockCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/blocks/EmptyCatchBlockCheckTest.java index 412218751..332553423 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/blocks/EmptyCatchBlockCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/blocks/EmptyCatchBlockCheckTest.java @@ -44,8 +44,8 @@ public class EmptyCatchBlockCheckTest extends BaseCheckTestSupport { @Test public void testGetRequiredTokens() { - EmptyCatchBlockCheck checkObj = new EmptyCatchBlockCheck(); - int[] expected = {TokenTypes.LITERAL_CATCH}; + final EmptyCatchBlockCheck checkObj = new EmptyCatchBlockCheck(); + final int[] expected = {TokenTypes.LITERAL_CATCH}; assertArrayEquals(expected, checkObj.getRequiredTokens()); } @@ -81,9 +81,9 @@ public class EmptyCatchBlockCheckTest extends BaseCheckTestSupport { @Test public void testGetAcceptableTokens() { - EmptyCatchBlockCheck constantNameCheckObj = new EmptyCatchBlockCheck(); - int[] actual = constantNameCheckObj.getAcceptableTokens(); - int[] expected = {TokenTypes.LITERAL_CATCH }; + final EmptyCatchBlockCheck constantNameCheckObj = new EmptyCatchBlockCheck(); + final int[] actual = constantNameCheckObj.getAcceptableTokens(); + final int[] expected = {TokenTypes.LITERAL_CATCH }; assertArrayEquals(expected, actual); } } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/blocks/LeftCurlyCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/blocks/LeftCurlyCheckTest.java index 63792ee65..ad33cba00 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/blocks/LeftCurlyCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/blocks/LeftCurlyCheckTest.java @@ -56,13 +56,13 @@ public class LeftCurlyCheckTest extends BaseCheckTestSupport { */ @Test public void testLeftCurlyOptionValueOf() { - LeftCurlyOption option = LeftCurlyOption.valueOf("NL"); + final LeftCurlyOption option = LeftCurlyOption.valueOf("NL"); assertEquals(LeftCurlyOption.NL, option); } @Test public void testGetRequiredTokens() { - LeftCurlyCheck checkObj = new LeftCurlyCheck(); + final LeftCurlyCheck checkObj = new LeftCurlyCheck(); assertArrayEquals(ArrayUtils.EMPTY_INT_ARRAY, checkObj.getRequiredTokens()); } @@ -281,9 +281,9 @@ public class LeftCurlyCheckTest extends BaseCheckTestSupport { @Test public void testGetAcceptableTokens() { - LeftCurlyCheck check = new LeftCurlyCheck(); - int[] actual = check.getAcceptableTokens(); - int[] expected = { + final LeftCurlyCheck check = new LeftCurlyCheck(); + final int[] actual = check.getAcceptableTokens(); + final int[] expected = { TokenTypes.INTERFACE_DEF, TokenTypes.CLASS_DEF, TokenTypes.ANNOTATION_DEF, diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/blocks/RightCurlyCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/blocks/RightCurlyCheckTest.java index 3fedd564b..a8d4bb698 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/blocks/RightCurlyCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/blocks/RightCurlyCheckTest.java @@ -55,7 +55,7 @@ public class RightCurlyCheckTest extends BaseCheckTestSupport { */ @Test public void testRightCurlyOptionValueOf() { - RightCurlyOption option = RightCurlyOption.valueOf("ALONE"); + final RightCurlyOption option = RightCurlyOption.valueOf("ALONE"); assertEquals(RightCurlyOption.ALONE, option); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/ArrayTrailingCommaCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/ArrayTrailingCommaCheckTest.java index 8d2134738..6043f3b36 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/ArrayTrailingCommaCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/ArrayTrailingCommaCheckTest.java @@ -53,7 +53,7 @@ public class ArrayTrailingCommaCheckTest @Test public void testTokensNotNull() { - ArrayTrailingCommaCheck check = new ArrayTrailingCommaCheck(); + final ArrayTrailingCommaCheck check = new ArrayTrailingCommaCheck(); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/AvoidInlineConditionalsCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/AvoidInlineConditionalsCheckTest.java index ed34c92b8..ef0bea865 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/AvoidInlineConditionalsCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/AvoidInlineConditionalsCheckTest.java @@ -53,7 +53,7 @@ public class AvoidInlineConditionalsCheckTest @Test public void testTokensNotNull() { - AvoidInlineConditionalsCheck check = new AvoidInlineConditionalsCheck(); + final AvoidInlineConditionalsCheck check = new AvoidInlineConditionalsCheck(); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/CovariantEqualsCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/CovariantEqualsCheckTest.java index 3914925fd..442d82e0b 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/CovariantEqualsCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/CovariantEqualsCheckTest.java @@ -56,7 +56,7 @@ public class CovariantEqualsCheckTest @Test public void testTokensNotNull() { - CovariantEqualsCheck check = new CovariantEqualsCheck(); + final CovariantEqualsCheck check = new CovariantEqualsCheck(); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/DeclarationOrderCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/DeclarationOrderCheckTest.java index 75232abaa..958dd9a91 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/DeclarationOrderCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/DeclarationOrderCheckTest.java @@ -138,7 +138,7 @@ public class DeclarationOrderCheckTest @Test public void testTokensNotNull() { - DeclarationOrderCheck check = new DeclarationOrderCheck(); + final DeclarationOrderCheck check = new DeclarationOrderCheck(); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); @@ -146,29 +146,29 @@ public class DeclarationOrderCheckTest @Test public void testParents() { - DetailAST parent = new DetailAST(); + final DetailAST parent = new DetailAST(); parent.setType(TokenTypes.STATIC_INIT); - DetailAST method = new DetailAST(); + final DetailAST method = new DetailAST(); method.setType(TokenTypes.METHOD_DEF); parent.setFirstChild(method); - DetailAST ctor = new DetailAST(); + final DetailAST ctor = new DetailAST(); ctor.setType(TokenTypes.CTOR_DEF); method.setNextSibling(ctor); - DeclarationOrderCheck check = new DeclarationOrderCheck(); + final DeclarationOrderCheck check = new DeclarationOrderCheck(); check.visitToken(method); check.visitToken(ctor); } @Test public void testImproperToken() { - DetailAST parent = new DetailAST(); + final DetailAST parent = new DetailAST(); parent.setType(TokenTypes.STATIC_INIT); - DetailAST array = new DetailAST(); + final DetailAST array = new DetailAST(); array.setType(TokenTypes.ARRAY_INIT); parent.setFirstChild(array); - DeclarationOrderCheck check = new DeclarationOrderCheck(); + final DeclarationOrderCheck check = new DeclarationOrderCheck(); check.visitToken(array); } } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/DefaultComesLastCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/DefaultComesLastCheckTest.java index 0cb3a6c81..92cdc1277 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/DefaultComesLastCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/DefaultComesLastCheckTest.java @@ -70,7 +70,7 @@ public class DefaultComesLastCheckTest extends BaseCheckTestSupport { @Test public void testTokensNotNull() { - DefaultComesLastCheck check = new DefaultComesLastCheck(); + final DefaultComesLastCheck check = new DefaultComesLastCheck(); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/EmptyStatementCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/EmptyStatementCheckTest.java index 2c55ba1ef..c7ce1549b 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/EmptyStatementCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/EmptyStatementCheckTest.java @@ -67,7 +67,8 @@ public class EmptyStatementCheckTest @Test public void testTokensNotNull() { - EmptyStatementCheck check = new EmptyStatementCheck(); + + final EmptyStatementCheck check = new EmptyStatementCheck(); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/EqualsAvoidNullCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/EqualsAvoidNullCheckTest.java index ce2747afa..960cdd9fe 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/EqualsAvoidNullCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/EqualsAvoidNullCheckTest.java @@ -151,7 +151,7 @@ public class EqualsAvoidNullCheckTest extends BaseCheckTestSupport { @Test public void testTokensNotNull() { - EqualsAvoidNullCheck check = new EqualsAvoidNullCheck(); + final EqualsAvoidNullCheck check = new EqualsAvoidNullCheck(); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/EqualsHashCodeCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/EqualsHashCodeCheckTest.java index a4d70dbc6..a224e6b00 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/EqualsHashCodeCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/EqualsHashCodeCheckTest.java @@ -61,7 +61,7 @@ public class EqualsHashCodeCheckTest @Test public void testTokensNotNull() { - EqualsHashCodeCheck check = new EqualsHashCodeCheck(); + final EqualsHashCodeCheck check = new EqualsHashCodeCheck(); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/ExplicitInitializationCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/ExplicitInitializationCheckTest.java index 7411b518a..c98a77bfd 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/ExplicitInitializationCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/ExplicitInitializationCheckTest.java @@ -69,7 +69,7 @@ public class ExplicitInitializationCheckTest extends BaseCheckTestSupport { @Test public void testTokensNotNull() { - ExplicitInitializationCheck check = new ExplicitInitializationCheck(); + final ExplicitInitializationCheck check = new ExplicitInitializationCheck(); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/FallThroughCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/FallThroughCheckTest.java index e02af8829..7efc782bc 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/FallThroughCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/FallThroughCheckTest.java @@ -40,7 +40,7 @@ public class FallThroughCheckTest extends BaseCheckTestSupport { @Test public void testDefault() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(FallThroughCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(FallThroughCheck.class); final String[] expected = { "14:13: " + getCheckMessage(MSG_FALL_THROUGH), "38:13: " + getCheckMessage(MSG_FALL_THROUGH), @@ -67,7 +67,7 @@ public class FallThroughCheckTest extends BaseCheckTestSupport { @Test public void testLastCaseGroup() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(FallThroughCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(FallThroughCheck.class); checkConfig.addAttribute("checkLastCaseGroup", "true"); final String[] expected = { "14:13: " + getCheckMessage(MSG_FALL_THROUGH), @@ -145,7 +145,7 @@ public class FallThroughCheckTest extends BaseCheckTestSupport { @Test public void testTokensNotNull() { - FallThroughCheck check = new FallThroughCheck(); + final FallThroughCheck check = new FallThroughCheck(); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); @@ -153,7 +153,7 @@ public class FallThroughCheckTest extends BaseCheckTestSupport { @Test public void testFallThroughNoElse() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(FallThroughCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(FallThroughCheck.class); final String[] expected = { "20:13: " + getCheckMessage(MSG_FALL_THROUGH), "35:13: " + getCheckMessage(MSG_FALL_THROUGH), diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/FinalLocalVariableCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/FinalLocalVariableCheckTest.java index fb61bdb4d..0c12b0795 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/FinalLocalVariableCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/FinalLocalVariableCheckTest.java @@ -162,9 +162,9 @@ public class FinalLocalVariableCheckTest @Test public void testImproperToken() throws Exception { - FinalLocalVariableCheck check = new FinalLocalVariableCheck(); + final FinalLocalVariableCheck check = new FinalLocalVariableCheck(); - DetailAST lambdaAst = new DetailAST(); + final DetailAST lambdaAst = new DetailAST(); lambdaAst.setType(TokenTypes.LAMBDA); try { diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalCatchCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalCatchCheckTest.java index 60a14ff7a..30213b2b0 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalCatchCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalCatchCheckTest.java @@ -39,9 +39,9 @@ public class IllegalCatchCheckTest extends BaseCheckTestSupport { @Test public void testDefault() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(IllegalCatchCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(IllegalCatchCheck.class); - String[] expected = { + final String[] expected = { "6:11: " + getCheckMessage(MSG_KEY, "RuntimeException"), "7:11: " + getCheckMessage(MSG_KEY, "Exception"), "8:11: " + getCheckMessage(MSG_KEY, "Throwable"), @@ -55,11 +55,11 @@ public class IllegalCatchCheckTest extends BaseCheckTestSupport { @Test public void testIllegalClassNames() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(IllegalCatchCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(IllegalCatchCheck.class); checkConfig.addAttribute("illegalClassNames", "java.lang.Error, java.lang.Exception, java.lang.Throwable"); - String[] expected = { + final String[] expected = { "7:11: " + getCheckMessage(MSG_KEY, "Exception"), "8:11: " + getCheckMessage(MSG_KEY, "Throwable"), "15:11: " + getCheckMessage(MSG_KEY, "java.lang.Exception"), @@ -71,9 +71,9 @@ public class IllegalCatchCheckTest extends BaseCheckTestSupport { @Test public void testMultipleTypes() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(IllegalCatchCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(IllegalCatchCheck.class); - String[] expected = { + final String[] expected = { "7:11: " + getCheckMessage(MSG_KEY, "RuntimeException"), "10:11: " + getCheckMessage(MSG_KEY, "RuntimeException"), "13:11: " + getCheckMessage(MSG_KEY, "RuntimeException"), @@ -85,7 +85,7 @@ public class IllegalCatchCheckTest extends BaseCheckTestSupport { @Test public void testTokensNotNull() { - IllegalCatchCheck check = new IllegalCatchCheck(); + final IllegalCatchCheck check = new IllegalCatchCheck(); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalInstantiationCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalInstantiationCheckTest.java index 056eb6517..5ff235f3e 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalInstantiationCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalInstantiationCheckTest.java @@ -128,25 +128,25 @@ public class IllegalInstantiationCheckTest @Test public void testNullClassLoader() throws Exception { - DetailAST exprAst = new DetailAST(); + final DetailAST exprAst = new DetailAST(); exprAst.setType(TokenTypes.EXPR); - DetailAST newAst = new DetailAST(); + final DetailAST newAst = new DetailAST(); newAst.setType(TokenTypes.LITERAL_NEW); newAst.setLineNo(1); newAst.setColumnNo(1); - DetailAST identAst = new DetailAST(); + final DetailAST identAst = new DetailAST(); identAst.setType(TokenTypes.IDENT); identAst.setText("Boolean"); - DetailAST lparenAst = new DetailAST(); + final DetailAST lparenAst = new DetailAST(); lparenAst.setType(TokenTypes.LPAREN); - DetailAST elistAst = new DetailAST(); + final DetailAST elistAst = new DetailAST(); elistAst.setType(TokenTypes.ELIST); - DetailAST rparenAst = new DetailAST(); + final DetailAST rparenAst = new DetailAST(); rparenAst.setType(TokenTypes.RPAREN); exprAst.addChild(newAst); @@ -155,8 +155,8 @@ public class IllegalInstantiationCheckTest lparenAst.setNextSibling(elistAst); elistAst.setNextSibling(rparenAst); - IllegalInstantiationCheck check = new IllegalInstantiationCheck(); - File inputFile = new File(getNonCompilablePath("InputIllegalInstantiationLang.java")); + final IllegalInstantiationCheck check = new IllegalInstantiationCheck(); + final File inputFile = new File(getNonCompilablePath("InputIllegalInstantiationLang.java")); check.setFileContents(new FileContents(new FileText(inputFile, "UTF-8"))); check.configure(createCheckConfig(IllegalInstantiationCheck.class)); check.setMessages(new LocalizedMessages()); @@ -168,7 +168,7 @@ public class IllegalInstantiationCheckTest @Test public void testTokensNotNull() { - IllegalInstantiationCheck check = new IllegalInstantiationCheck(); + final IllegalInstantiationCheck check = new IllegalInstantiationCheck(); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); @@ -176,9 +176,9 @@ public class IllegalInstantiationCheckTest @Test public void testImproperToken() throws Exception { - IllegalInstantiationCheck check = new IllegalInstantiationCheck(); + final IllegalInstantiationCheck check = new IllegalInstantiationCheck(); - DetailAST lambdaAst = new DetailAST(); + final DetailAST lambdaAst = new DetailAST(); lambdaAst.setType(TokenTypes.LAMBDA); try { diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalThrowsCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalThrowsCheckTest.java index 4860d23bf..52d947b95 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalThrowsCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalThrowsCheckTest.java @@ -40,9 +40,9 @@ public class IllegalThrowsCheckTest extends BaseCheckTestSupport { @Test public void testDefault() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(IllegalThrowsCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(IllegalThrowsCheck.class); - String[] expected = { + final String[] expected = { "9:51: " + getCheckMessage(MSG_KEY, "RuntimeException"), "14:45: " + getCheckMessage(MSG_KEY, "java.lang.RuntimeException"), "14:73: " + getCheckMessage(MSG_KEY, "java.lang.Error"), @@ -53,7 +53,7 @@ public class IllegalThrowsCheckTest extends BaseCheckTestSupport { @Test public void testIllegalClassNames() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(IllegalThrowsCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(IllegalThrowsCheck.class); checkConfig.addAttribute("illegalClassNames", "java.lang.Error, java.lang.Exception, NullPointerException"); @@ -61,7 +61,7 @@ public class IllegalThrowsCheckTest extends BaseCheckTestSupport { checkConfig.addAttribute("illegalClassNames", "java.lang.IOException."); - String[] expected = { + final String[] expected = { "5:33: " + getCheckMessage(MSG_KEY, "NullPointerException"), "14:73: " + getCheckMessage(MSG_KEY, "java.lang.Error"), }; @@ -74,10 +74,10 @@ public class IllegalThrowsCheckTest extends BaseCheckTestSupport { */ @Test public void testIgnoreMethodNames() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(IllegalThrowsCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(IllegalThrowsCheck.class); checkConfig.addAttribute("ignoredMethodNames", "methodTwo"); - String[] expected = { + final String[] expected = { "9:51: " + getCheckMessage(MSG_KEY, "RuntimeException"), "18:35: " + getCheckMessage(MSG_KEY, "Throwable"), }; @@ -90,12 +90,12 @@ public class IllegalThrowsCheckTest extends BaseCheckTestSupport { */ @Test public void testIllegalClassNamesWithIgnoreMethodNames() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(IllegalThrowsCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(IllegalThrowsCheck.class); checkConfig.addAttribute("illegalClassNames", "java.lang.Error, java.lang.Exception, NullPointerException, Throwable"); checkConfig.addAttribute("ignoredMethodNames", "methodTwo"); - String[] expected = { + final String[] expected = { "5:33: " + getCheckMessage(MSG_KEY, "NullPointerException"), "18:35: " + getCheckMessage(MSG_KEY, "Throwable"), }; @@ -109,10 +109,10 @@ public class IllegalThrowsCheckTest extends BaseCheckTestSupport { */ @Test public void testIgnoreOverriddenMethods() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(IllegalThrowsCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(IllegalThrowsCheck.class); checkConfig.addAttribute("ignoreOverriddenMethods", "true"); - String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; + final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; verify(checkConfig, getPath("InputIllegalThrowsIgnoreOverriddenMethods.java"), expected); } @@ -123,10 +123,10 @@ public class IllegalThrowsCheckTest extends BaseCheckTestSupport { */ @Test public void testNotIgnoreOverriddenMethods() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(IllegalThrowsCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(IllegalThrowsCheck.class); checkConfig.addAttribute("ignoreOverriddenMethods", "false"); - String[] expected = { + final String[] expected = { "7:36: " + getCheckMessage(MSG_KEY, "RuntimeException"), "12:51: " + getCheckMessage(MSG_KEY, "RuntimeException"), }; @@ -136,7 +136,7 @@ public class IllegalThrowsCheckTest extends BaseCheckTestSupport { @Test public void testTokensNotNull() { - IllegalThrowsCheck check = new IllegalThrowsCheck(); + final IllegalThrowsCheck check = new IllegalThrowsCheck(); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalTokenTextCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalTokenTextCheckTest.java index 9db5816c2..e4d87ca0a 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalTokenTextCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalTokenTextCheckTest.java @@ -75,7 +75,7 @@ public class IllegalTokenTextCheckTest checkConfig.addAttribute("tokens", "STRING_LITERAL"); checkConfig.addAttribute("format", "a href"); - String customMessage = "My custom message"; + final String customMessage = "My custom message"; checkConfig.addAttribute("message", customMessage); final String[] expected = { "24:28: " + customMessage, @@ -100,7 +100,7 @@ public class IllegalTokenTextCheckTest @Test public void testTokensNotNull() { - IllegalTokenTextCheck check = new IllegalTokenTextCheck(); + final IllegalTokenTextCheck check = new IllegalTokenTextCheck(); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalTypeCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalTypeCheckTest.java index 5ffc637c3..76a3859b1 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalTypeCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalTypeCheckTest.java @@ -51,7 +51,7 @@ public class IllegalTypeCheckTest extends BaseCheckTestSupport { @Test public void testValidateAbstractClassNamesSetToTrue() throws Exception { checkConfig.addAttribute("validateAbstractClassNames", "true"); - String[] expected = { + final String[] expected = { "27:5: " + getCheckMessage(MSG_KEY, "AbstractClass"), "29:37: " + getCheckMessage(MSG_KEY, "AbstractClass"), "33:12: " + getCheckMessage(MSG_KEY, "AbstractClass"), @@ -63,14 +63,14 @@ public class IllegalTypeCheckTest extends BaseCheckTestSupport { @Test public void testValidateAbstractClassNamesSetToFalse() throws Exception { checkConfig.addAttribute("validateAbstractClassNames", "false"); - String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; + final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; verify(checkConfig, getPath("InputIllegalTypeAbstractClassNames.java"), expected); } @Test public void testDefaults() throws Exception { - String[] expected = { + final String[] expected = { "16:13: " + getCheckMessage(MSG_KEY, "java.util.TreeSet"), "17:13: " + getCheckMessage(MSG_KEY, "TreeSet"), }; @@ -82,7 +82,7 @@ public class IllegalTypeCheckTest extends BaseCheckTestSupport { public void testIgnoreMethodNames() throws Exception { checkConfig.addAttribute("ignoredMethodNames", "table2"); checkConfig.addAttribute("validateAbstractClassNames", "true"); - String[] expected = { + final String[] expected = { "6:13: " + getCheckMessage(MSG_KEY, "AbstractClass"), "9:13: " + getCheckMessage(MSG_KEY, "com.puppycrawl.tools.checkstyle.checks.coding.InputIllegalType.AbstractClass"), @@ -96,7 +96,7 @@ public class IllegalTypeCheckTest extends BaseCheckTestSupport { public void testFormat() throws Exception { checkConfig.addAttribute("format", "^$"); - String[] expected = { + final String[] expected = { "16:13: " + getCheckMessage(MSG_KEY, "java.util.TreeSet"), "17:13: " + getCheckMessage(MSG_KEY, "TreeSet"), }; @@ -109,7 +109,7 @@ public class IllegalTypeCheckTest extends BaseCheckTestSupport { checkConfig.addAttribute("validateAbstractClassNames", "true"); checkConfig.addAttribute("legalAbstractClassNames", "AbstractClass"); - String[] expected = { + final String[] expected = { "9:13: " + getCheckMessage(MSG_KEY, "com.puppycrawl.tools.checkstyle.checks.coding.InputIllegalType.AbstractClass"), "16:13: " + getCheckMessage(MSG_KEY, "java.util.TreeSet"), @@ -124,7 +124,7 @@ public class IllegalTypeCheckTest extends BaseCheckTestSupport { checkConfig.addAttribute("illegalClassNames", "java.util.GregorianCalendar, SubCalendar, " + "java.util.List"); - String[] expected = { + final String[] expected = { "12:5: " + getCheckMessage(MSG_KEY, "SubCalendar"), "27:5: " + getCheckMessage(MSG_KEY, "java.util.List"), }; @@ -136,7 +136,7 @@ public class IllegalTypeCheckTest extends BaseCheckTestSupport { public void testSameFileNameGeneral() throws Exception { checkConfig.addAttribute("illegalClassNames", "List, InputGregorianCalendar, java.io.File, ArrayList"); - String[] expected = { + final String[] expected = { "10:5: " + getCheckMessage(MSG_KEY, "InputGregorianCalendar"), "16:23: " + getCheckMessage(MSG_KEY, "InputGregorianCalendar"), "24:9: " + getCheckMessage(MSG_KEY, "List"), @@ -151,7 +151,7 @@ public class IllegalTypeCheckTest extends BaseCheckTestSupport { public void testStarImports() throws Exception { checkConfig.addAttribute("illegalClassNames", "List"); - String[] expected = { + final String[] expected = { "10:5: " + getCheckMessage(MSG_KEY, "List"), }; @@ -163,7 +163,7 @@ public class IllegalTypeCheckTest extends BaseCheckTestSupport { checkConfig.addAttribute("illegalClassNames", "SomeStaticClass"); checkConfig.addAttribute("ignoredMethodNames", "foo1"); - String[] expected = { + final String[] expected = { "13:6: " + getCheckMessage(MSG_KEY, "SomeStaticClass"), "15:31: " + getCheckMessage(MSG_KEY, "SomeStaticClass"), }; @@ -176,7 +176,7 @@ public class IllegalTypeCheckTest extends BaseCheckTestSupport { checkConfig.addAttribute("validateAbstractClassNames", "true"); checkConfig.addAttribute("memberModifiers", "LITERAL_PRIVATE, LITERAL_PROTECTED," + " LITERAL_STATIC"); - String[] expected = { + final String[] expected = { "6:13: " + getCheckMessage(MSG_KEY, "AbstractClass"), "9:13: " + getCheckMessage(MSG_KEY, "com.puppycrawl.tools.checkstyle.checks.coding." @@ -195,7 +195,7 @@ public class IllegalTypeCheckTest extends BaseCheckTestSupport { @Test public void testTokensNotNull() { - IllegalTypeCheck check = new IllegalTypeCheck(); + final IllegalTypeCheck check = new IllegalTypeCheck(); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); @@ -203,9 +203,9 @@ public class IllegalTypeCheckTest extends BaseCheckTestSupport { @Test public void testImproperToken() throws Exception { - IllegalTypeCheck check = new IllegalTypeCheck(); + final IllegalTypeCheck check = new IllegalTypeCheck(); - DetailAST classDefAst = new DetailAST(); + final DetailAST classDefAst = new DetailAST(); classDefAst.setType(TokenTypes.CLASS_DEF); try { diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/InnerAssignmentCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/InnerAssignmentCheckTest.java index 13372de62..a1f444c98 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/InnerAssignmentCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/InnerAssignmentCheckTest.java @@ -82,7 +82,7 @@ public class InnerAssignmentCheckTest @Test public void testTokensNotNull() { - InnerAssignmentCheck check = new InnerAssignmentCheck(); + final InnerAssignmentCheck check = new InnerAssignmentCheck(); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/MissingCtorCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/MissingCtorCheckTest.java index 8da283ef5..21ae13c8a 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/MissingCtorCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/MissingCtorCheckTest.java @@ -39,7 +39,7 @@ public class MissingCtorCheckTest extends BaseCheckTestSupport { @Test public void testMissingSwitchDefault() throws Exception { - DefaultConfiguration checkConfig = + final DefaultConfiguration checkConfig = createCheckConfig(MissingCtorCheck.class); final String[] expected = { @@ -53,7 +53,7 @@ public class MissingCtorCheckTest extends BaseCheckTestSupport { @Test public void testTokensNotNull() { - MissingCtorCheck check = new MissingCtorCheck(); + final MissingCtorCheck check = new MissingCtorCheck(); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/MissingSwitchDefaultCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/MissingSwitchDefaultCheckTest.java index 08d274ab6..4c48e01fc 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/MissingSwitchDefaultCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/MissingSwitchDefaultCheckTest.java @@ -59,7 +59,7 @@ public class MissingSwitchDefaultCheckTest @Test public void testTokensNotNull() { - MissingSwitchDefaultCheck check = new MissingSwitchDefaultCheck(); + final MissingSwitchDefaultCheck check = new MissingSwitchDefaultCheck(); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/ModifiedControlVariableCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/ModifiedControlVariableCheckTest.java index 98c2048f1..7e81de72e 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/ModifiedControlVariableCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/ModifiedControlVariableCheckTest.java @@ -83,7 +83,7 @@ public class ModifiedControlVariableCheckTest @Test public void testTokensNotNull() { - ModifiedControlVariableCheck check = new ModifiedControlVariableCheck(); + final ModifiedControlVariableCheck check = new ModifiedControlVariableCheck(); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); @@ -91,9 +91,9 @@ public class ModifiedControlVariableCheckTest @Test public void testImproperToken() throws Exception { - ModifiedControlVariableCheck check = new ModifiedControlVariableCheck(); + final ModifiedControlVariableCheck check = new ModifiedControlVariableCheck(); - DetailAST classDefAst = new DetailAST(); + final DetailAST classDefAst = new DetailAST(); classDefAst.setType(TokenTypes.CLASS_DEF); try { diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/MultipleStringLiteralsCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/MultipleStringLiteralsCheckTest.java index edbc2a43d..b26cd4b48 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/MultipleStringLiteralsCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/MultipleStringLiteralsCheckTest.java @@ -39,7 +39,7 @@ public class MultipleStringLiteralsCheckTest extends BaseCheckTestSupport { @Test public void testIt() throws Exception { - DefaultConfiguration checkConfig = + final DefaultConfiguration checkConfig = createCheckConfig(MultipleStringLiteralsCheck.class); checkConfig.addAttribute("allowedDuplicates", "2"); checkConfig.addAttribute("ignoreStringsRegexp", ""); @@ -57,7 +57,7 @@ public class MultipleStringLiteralsCheckTest extends BaseCheckTestSupport { @Test public void testItIgnoreEmpty() throws Exception { - DefaultConfiguration checkConfig = + final DefaultConfiguration checkConfig = createCheckConfig(MultipleStringLiteralsCheck.class); checkConfig.addAttribute("allowedDuplicates", "2"); @@ -73,7 +73,7 @@ public class MultipleStringLiteralsCheckTest extends BaseCheckTestSupport { @Test public void testItIgnoreEmptyAndComspace() throws Exception { - DefaultConfiguration checkConfig = + final DefaultConfiguration checkConfig = createCheckConfig(MultipleStringLiteralsCheck.class); checkConfig.addAttribute("allowedDuplicates", "2"); checkConfig.addAttribute("ignoreStringsRegexp", "^((\"\")|(\", \"))$"); @@ -89,7 +89,7 @@ public class MultipleStringLiteralsCheckTest extends BaseCheckTestSupport { @Test public void testItWithoutIgnoringAnnotations() throws Exception { - DefaultConfiguration checkConfig = + final DefaultConfiguration checkConfig = createCheckConfig(MultipleStringLiteralsCheck.class); checkConfig.addAttribute("allowedDuplicates", "3"); checkConfig.addAttribute("ignoreOccurrenceContext", ""); @@ -105,7 +105,7 @@ public class MultipleStringLiteralsCheckTest extends BaseCheckTestSupport { @Test public void testTokensNotNull() { - MultipleStringLiteralsCheck check = new MultipleStringLiteralsCheck(); + final MultipleStringLiteralsCheck check = new MultipleStringLiteralsCheck(); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); @@ -113,7 +113,7 @@ public class MultipleStringLiteralsCheckTest extends BaseCheckTestSupport { @Test public void testDefaultConfiguration() throws Exception { - DefaultConfiguration checkConfig = + final DefaultConfiguration checkConfig = createCheckConfig(MultipleStringLiteralsCheck.class); final String[] expected = { "5:16: " + getCheckMessage(MSG_KEY, "\"StringContents\"", 3), @@ -129,7 +129,7 @@ public class MultipleStringLiteralsCheckTest extends BaseCheckTestSupport { @Test public void testIgnores() throws Exception { - DefaultConfiguration checkConfig = + final DefaultConfiguration checkConfig = createCheckConfig(MultipleStringLiteralsCheck.class); checkConfig.addAttribute("ignoreStringsRegexp", null); checkConfig.addAttribute("ignoreOccurrenceContext", "VARIABLE_DEF"); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/MultipleVariableDeclarationsCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/MultipleVariableDeclarationsCheckTest.java index 0f2183e93..e71b170e1 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/MultipleVariableDeclarationsCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/MultipleVariableDeclarationsCheckTest.java @@ -40,7 +40,7 @@ public class MultipleVariableDeclarationsCheckTest extends BaseCheckTestSupport @Test public void testIt() throws Exception { - DefaultConfiguration checkConfig = + final DefaultConfiguration checkConfig = createCheckConfig(MultipleVariableDeclarationsCheck.class); final String[] expected = { @@ -59,7 +59,7 @@ public class MultipleVariableDeclarationsCheckTest extends BaseCheckTestSupport @Test public void testTokensNotNull() { - MultipleVariableDeclarationsCheck check = new MultipleVariableDeclarationsCheck(); + final MultipleVariableDeclarationsCheck check = new MultipleVariableDeclarationsCheck(); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/NestedForDepthCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/NestedForDepthCheckTest.java index 2889a7dab..9c9436460 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/NestedForDepthCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/NestedForDepthCheckTest.java @@ -90,7 +90,7 @@ public class NestedForDepthCheckTest extends BaseCheckTestSupport { @Test public void testTokensNotNull() { - NestedForDepthCheck check = new NestedForDepthCheck(); + final NestedForDepthCheck check = new NestedForDepthCheck(); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/NestedIfDepthCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/NestedIfDepthCheckTest.java index b62d54d39..022c36d79 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/NestedIfDepthCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/NestedIfDepthCheckTest.java @@ -65,7 +65,7 @@ public class NestedIfDepthCheckTest extends BaseCheckTestSupport { @Test public void testTokensNotNull() { - NestedIfDepthCheck check = new NestedIfDepthCheck(); + final NestedIfDepthCheck check = new NestedIfDepthCheck(); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/NestedTryDepthCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/NestedTryDepthCheckTest.java index d7941f308..1bd743d47 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/NestedTryDepthCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/NestedTryDepthCheckTest.java @@ -66,7 +66,7 @@ public class NestedTryDepthCheckTest extends BaseCheckTestSupport { @Test public void testTokensNotNull() { - NestedTryDepthCheck check = new NestedTryDepthCheck(); + final NestedTryDepthCheck check = new NestedTryDepthCheck(); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/NoCloneCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/NoCloneCheckTest.java index 3b8c435c9..2b40d7c1f 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/NoCloneCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/NoCloneCheckTest.java @@ -60,7 +60,7 @@ public class NoCloneCheckTest @Test public void testTokensNotNull() { - NoCloneCheck check = new NoCloneCheck(); + final NoCloneCheck check = new NoCloneCheck(); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/OneStatementPerLineCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/OneStatementPerLineCheckTest.java index d8a323a6b..36919eaa2 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/OneStatementPerLineCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/OneStatementPerLineCheckTest.java @@ -45,7 +45,7 @@ public class OneStatementPerLineCheckTest extends BaseCheckTestSupport { @Test public void testMultiCaseClass() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(OneStatementPerLineCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(OneStatementPerLineCheck.class); final String[] expected = { "24:59: " + getCheckMessage(MSG_KEY), "104:21: " + getCheckMessage(MSG_KEY), @@ -63,7 +63,7 @@ public class OneStatementPerLineCheckTest extends BaseCheckTestSupport { @Test public void testTokensNotNull() { - OneStatementPerLineCheck check = new OneStatementPerLineCheck(); + final OneStatementPerLineCheck check = new OneStatementPerLineCheck(); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); @@ -71,7 +71,7 @@ public class OneStatementPerLineCheckTest extends BaseCheckTestSupport { @Test public void testWithMultilineStatements() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(OneStatementPerLineCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(OneStatementPerLineCheck.class); final String[] expected = { "44:21: " + getCheckMessage(MSG_KEY), "61:17: " + getCheckMessage(MSG_KEY), @@ -88,7 +88,7 @@ public class OneStatementPerLineCheckTest extends BaseCheckTestSupport { @Test public void oneStatementNonCompilableInputTest() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(OneStatementPerLineCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(OneStatementPerLineCheck.class); final String[] expected = { "24:6: " + getCheckMessage(MSG_KEY), }; diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/OverloadMethodsDeclarationOrderCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/OverloadMethodsDeclarationOrderCheckTest.java index 7a68de52c..3f2150291 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/OverloadMethodsDeclarationOrderCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/OverloadMethodsDeclarationOrderCheckTest.java @@ -54,7 +54,8 @@ public class OverloadMethodsDeclarationOrderCheckTest @Test public void testTokensNotNull() { - OverloadMethodsDeclarationOrderCheck check = new OverloadMethodsDeclarationOrderCheck(); + final OverloadMethodsDeclarationOrderCheck check = + new OverloadMethodsDeclarationOrderCheck(); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/PackageDeclarationCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/PackageDeclarationCheckTest.java index e99a1ab5e..a924aea75 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/PackageDeclarationCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/PackageDeclarationCheckTest.java @@ -46,9 +46,9 @@ public class PackageDeclarationCheckTest extends BaseCheckTestSupport { @Test public void testDefault() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(PackageDeclarationCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(PackageDeclarationCheck.class); - String[] expected = { + final String[] expected = { "4: " + getCheckMessage(MSG_KEY), }; @@ -57,9 +57,9 @@ public class PackageDeclarationCheckTest extends BaseCheckTestSupport { @Test public void testOnFileWithCommentOnly() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(PackageDeclarationCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(PackageDeclarationCheck.class); - String[] expected = { + final String[] expected = { "1: " + getCheckMessage(MSG_KEY), }; @@ -68,16 +68,16 @@ public class PackageDeclarationCheckTest extends BaseCheckTestSupport { @Test public void testCorrectFile() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(PackageDeclarationCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(PackageDeclarationCheck.class); - String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; + final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; verify(checkConfig, getPath("InputPackageDeclaration.java"), expected); } @Test public void testTokensNotNull() { - PackageDeclarationCheck check = new PackageDeclarationCheck(); + final PackageDeclarationCheck check = new PackageDeclarationCheck(); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/ParameterAssignmentCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/ParameterAssignmentCheckTest.java index 5765b6f8f..4ecae943a 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/ParameterAssignmentCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/ParameterAssignmentCheckTest.java @@ -56,7 +56,7 @@ public class ParameterAssignmentCheckTest extends BaseCheckTestSupport { @Test public void testTokensNotNull() { - ParameterAssignmentCheck check = new ParameterAssignmentCheck(); + final ParameterAssignmentCheck check = new ParameterAssignmentCheck(); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); @@ -64,9 +64,9 @@ public class ParameterAssignmentCheckTest extends BaseCheckTestSupport { @Test public void testImproperToken() throws Exception { - ParameterAssignmentCheck check = new ParameterAssignmentCheck(); + final ParameterAssignmentCheck check = new ParameterAssignmentCheck(); - DetailAST classDefAst = new DetailAST(); + final DetailAST classDefAst = new DetailAST(); classDefAst.setType(TokenTypes.CLASS_DEF); try { diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/RequireThisCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/RequireThisCheckTest.java index da5b2f035..c846bfd41 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/RequireThisCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/RequireThisCheckTest.java @@ -107,7 +107,7 @@ public class RequireThisCheckTest extends BaseCheckTestSupport { @Test public void testTokensNotNull() { - RequireThisCheck check = new RequireThisCheck(); + final RequireThisCheck check = new RequireThisCheck(); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/ReturnCountCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/ReturnCountCheckTest.java index 6beb4a55a..3ed91e2fe 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/ReturnCountCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/ReturnCountCheckTest.java @@ -117,9 +117,9 @@ public class ReturnCountCheckTest extends BaseCheckTestSupport { @Test public void testImproperToken() throws Exception { - ReturnCountCheck check = new ReturnCountCheck(); + final ReturnCountCheck check = new ReturnCountCheck(); - DetailAST classDefAst = new DetailAST(); + final DetailAST classDefAst = new DetailAST(); classDefAst.setType(TokenTypes.CLASS_DEF); try { diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/SimplifyBooleanExpressionCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/SimplifyBooleanExpressionCheckTest.java index 047a3a6f0..b5fbcd430 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/SimplifyBooleanExpressionCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/SimplifyBooleanExpressionCheckTest.java @@ -54,7 +54,7 @@ public class SimplifyBooleanExpressionCheckTest @Test public void testTokensNotNull() { - SimplifyBooleanExpressionCheck check = new SimplifyBooleanExpressionCheck(); + final SimplifyBooleanExpressionCheck check = new SimplifyBooleanExpressionCheck(); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/SimplifyBooleanReturnCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/SimplifyBooleanReturnCheckTest.java index d9cc17456..53ad06c0a 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/SimplifyBooleanReturnCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/SimplifyBooleanReturnCheckTest.java @@ -51,7 +51,7 @@ public class SimplifyBooleanReturnCheckTest @Test public void testTokensNotNull() { - SimplifyBooleanReturnCheck check = new SimplifyBooleanReturnCheck(); + final SimplifyBooleanReturnCheck check = new SimplifyBooleanReturnCheck(); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/StringLiteralEqualityCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/StringLiteralEqualityCheckTest.java index 586136bb9..fa1ff0576 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/StringLiteralEqualityCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/StringLiteralEqualityCheckTest.java @@ -52,7 +52,7 @@ public class StringLiteralEqualityCheckTest @Test public void testTokensNotNull() { - StringLiteralEqualityCheck check = new StringLiteralEqualityCheck(); + final StringLiteralEqualityCheck check = new StringLiteralEqualityCheck(); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/SuperCloneCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/SuperCloneCheckTest.java index b7ece4834..8011bafaa 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/SuperCloneCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/SuperCloneCheckTest.java @@ -69,7 +69,7 @@ public class SuperCloneCheckTest @Test public void testTokensNotNull() { - SuperCloneCheck check = new SuperCloneCheck(); + final SuperCloneCheck check = new SuperCloneCheck(); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/UnnecessaryParenthesesCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/UnnecessaryParenthesesCheckTest.java index 65c4b2160..3f83ab570 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/UnnecessaryParenthesesCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/UnnecessaryParenthesesCheckTest.java @@ -113,7 +113,7 @@ public class UnnecessaryParenthesesCheckTest extends BaseCheckTestSupport { @Test public void testTokensNotNull() { - UnnecessaryParenthesesCheck check = new UnnecessaryParenthesesCheck(); + final UnnecessaryParenthesesCheck check = new UnnecessaryParenthesesCheck(); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getRequiredTokens()); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/VariableDeclarationUsageDistanceCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/VariableDeclarationUsageDistanceCheckTest.java index e03aeb5d1..2a80c5826 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/VariableDeclarationUsageDistanceCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/VariableDeclarationUsageDistanceCheckTest.java @@ -228,7 +228,8 @@ public class VariableDeclarationUsageDistanceCheckTest extends @Test public void testTokensNotNull() { - VariableDeclarationUsageDistanceCheck check = new VariableDeclarationUsageDistanceCheck(); + final VariableDeclarationUsageDistanceCheck check = + new VariableDeclarationUsageDistanceCheck(); Assert.assertNotNull(check.getAcceptableTokens()); Assert.assertNotNull(check.getDefaultTokens()); Assert.assertNotNull(check.getRequiredTokens()); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/DesignForExtensionCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/DesignForExtensionCheckTest.java index 9d1ddb197..f9163b2bd 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/DesignForExtensionCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/DesignForExtensionCheckTest.java @@ -41,8 +41,8 @@ public class DesignForExtensionCheckTest @Test public void testGetRequiredTokens() { - DesignForExtensionCheck checkObj = new DesignForExtensionCheck(); - int[] expected = {TokenTypes.METHOD_DEF}; + final DesignForExtensionCheck checkObj = new DesignForExtensionCheck(); + final int[] expected = {TokenTypes.METHOD_DEF}; assertArrayEquals(expected, checkObj.getRequiredTokens()); } @@ -61,8 +61,8 @@ public class DesignForExtensionCheckTest @Test public void testGetAcceptableTokens() { - DesignForExtensionCheck obj = new DesignForExtensionCheck(); - int[] expected = {TokenTypes.METHOD_DEF}; + final DesignForExtensionCheck obj = new DesignForExtensionCheck(); + final int[] expected = {TokenTypes.METHOD_DEF}; assertArrayEquals(expected, obj.getAcceptableTokens()); } } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/FinalClassCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/FinalClassCheckTest.java index 4de4169da..259b22e9f 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/FinalClassCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/FinalClassCheckTest.java @@ -41,8 +41,8 @@ public class FinalClassCheckTest @Test public void testGetRequiredTokens() { - FinalClassCheck checkObj = new FinalClassCheck(); - int[] expected = {TokenTypes.CLASS_DEF, TokenTypes.CTOR_DEF}; + final FinalClassCheck checkObj = new FinalClassCheck(); + final int[] expected = {TokenTypes.CLASS_DEF, TokenTypes.CTOR_DEF}; assertArrayEquals(expected, checkObj.getRequiredTokens()); } @@ -60,8 +60,8 @@ public class FinalClassCheckTest @Test public void testGetAcceptableTokens() { - FinalClassCheck obj = new FinalClassCheck(); - int[] expected = {TokenTypes.CLASS_DEF, TokenTypes.CTOR_DEF}; + final FinalClassCheck obj = new FinalClassCheck(); + final int[] expected = {TokenTypes.CLASS_DEF, TokenTypes.CTOR_DEF}; assertArrayEquals(expected, obj.getAcceptableTokens()); } } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/HideUtilityClassConstructorCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/HideUtilityClassConstructorCheckTest.java index 2df816316..85f5c0330 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/HideUtilityClassConstructorCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/HideUtilityClassConstructorCheckTest.java @@ -42,9 +42,9 @@ public class HideUtilityClassConstructorCheckTest @Test public void testGetRequiredTokens() { - HideUtilityClassConstructorCheck checkObj = + final HideUtilityClassConstructorCheck checkObj = new HideUtilityClassConstructorCheck(); - int[] expected = {TokenTypes.CLASS_DEF}; + final int[] expected = {TokenTypes.CLASS_DEF}; assertArrayEquals(expected, checkObj.getRequiredTokens()); } @@ -135,8 +135,8 @@ public class HideUtilityClassConstructorCheckTest @Test public void testGetAcceptableTokens() { - HideUtilityClassConstructorCheck obj = new HideUtilityClassConstructorCheck(); - int[] expected = {TokenTypes.CLASS_DEF}; + final HideUtilityClassConstructorCheck obj = new HideUtilityClassConstructorCheck(); + final int[] expected = {TokenTypes.CLASS_DEF}; assertArrayEquals(expected, obj.getAcceptableTokens()); } } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/InnerTypeLastCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/InnerTypeLastCheckTest.java index d3f891704..3c90577ac 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/InnerTypeLastCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/InnerTypeLastCheckTest.java @@ -40,8 +40,8 @@ public class InnerTypeLastCheckTest extends BaseCheckTestSupport { @Test public void testGetRequiredTokens() { - InnerTypeLastCheck checkObj = new InnerTypeLastCheck(); - int[] expected = {TokenTypes.CLASS_DEF, TokenTypes.INTERFACE_DEF}; + final InnerTypeLastCheck checkObj = new InnerTypeLastCheck(); + final int[] expected = {TokenTypes.CLASS_DEF, TokenTypes.INTERFACE_DEF}; assertArrayEquals(expected, checkObj.getRequiredTokens()); } @@ -61,8 +61,8 @@ public class InnerTypeLastCheckTest extends BaseCheckTestSupport { @Test public void testGetAcceptableTokens() { - InnerTypeLastCheck obj = new InnerTypeLastCheck(); - int[] expected = {TokenTypes.CLASS_DEF, TokenTypes.INTERFACE_DEF}; + final InnerTypeLastCheck obj = new InnerTypeLastCheck(); + final int[] expected = {TokenTypes.CLASS_DEF, TokenTypes.INTERFACE_DEF}; assertArrayEquals(expected, obj.getAcceptableTokens()); } } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/InterfaceIsTypeCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/InterfaceIsTypeCheckTest.java index 26bce395e..378ccdf83 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/InterfaceIsTypeCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/InterfaceIsTypeCheckTest.java @@ -65,15 +65,15 @@ public class InterfaceIsTypeCheckTest @Test public void testGetAcceptableTokens() { - InterfaceIsTypeCheck obj = new InterfaceIsTypeCheck(); - int[] expected = {TokenTypes.INTERFACE_DEF}; + final InterfaceIsTypeCheck obj = new InterfaceIsTypeCheck(); + final int[] expected = {TokenTypes.INTERFACE_DEF}; assertArrayEquals(expected, obj.getAcceptableTokens()); } @Test public void testGetRequiredTokens() { - InterfaceIsTypeCheck obj = new InterfaceIsTypeCheck(); - int[] expected = {TokenTypes.INTERFACE_DEF}; + final InterfaceIsTypeCheck obj = new InterfaceIsTypeCheck(); + final int[] expected = {TokenTypes.INTERFACE_DEF}; assertArrayEquals(expected, obj.getRequiredTokens()); } } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/MutableExceptionCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/MutableExceptionCheckTest.java index 32f6d7c0b..30f758129 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/MutableExceptionCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/MutableExceptionCheckTest.java @@ -45,9 +45,9 @@ public class MutableExceptionCheckTest extends BaseCheckTestSupport { @Test public void testClassExtendsGenericClass() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(MutableExceptionCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(MutableExceptionCheck.class); - String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; + final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; verify(checkConfig, getPath("InputMutableExceptionClassExtendsGenericClass.java"), expected); @@ -55,9 +55,9 @@ public class MutableExceptionCheckTest extends BaseCheckTestSupport { @Test public void testDefault() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(MutableExceptionCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(MutableExceptionCheck.class); - String[] expected = { + final String[] expected = { "6:9: " + getCheckMessage(MSG_KEY, "errorCode"), "23:9: " + getCheckMessage(MSG_KEY, "errorCode"), "46:9: " + getCheckMessage(MSG_KEY, "errorCode"), @@ -68,10 +68,10 @@ public class MutableExceptionCheckTest extends BaseCheckTestSupport { @Test public void testFormat() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(MutableExceptionCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(MutableExceptionCheck.class); checkConfig.addAttribute("format", "^.*Failure$"); checkConfig.addAttribute("extendedClassNameFormat", "^.*ThreadDeath$"); - String[] expected = { + final String[] expected = { "34:13: " + getCheckMessage(MSG_KEY, "errorCode"), }; @@ -80,22 +80,22 @@ public class MutableExceptionCheckTest extends BaseCheckTestSupport { @Test public void testGetAcceptableTokens() { - MutableExceptionCheck obj = new MutableExceptionCheck(); - int[] expected = {TokenTypes.CLASS_DEF, TokenTypes.VARIABLE_DEF}; + final MutableExceptionCheck obj = new MutableExceptionCheck(); + final int[] expected = {TokenTypes.CLASS_DEF, TokenTypes.VARIABLE_DEF}; assertArrayEquals(expected, obj.getAcceptableTokens()); } @Test public void testGetRequiredTokens() { - MutableExceptionCheck obj = new MutableExceptionCheck(); - int[] expected = {TokenTypes.CLASS_DEF, TokenTypes.VARIABLE_DEF}; + final MutableExceptionCheck obj = new MutableExceptionCheck(); + final int[] expected = {TokenTypes.CLASS_DEF, TokenTypes.VARIABLE_DEF}; assertArrayEquals(expected, obj.getRequiredTokens()); } @Test public void testWrongTokenType() { - MutableExceptionCheck obj = new MutableExceptionCheck(); - DetailAST ast = new DetailAST(); + final MutableExceptionCheck obj = new MutableExceptionCheck(); + final DetailAST ast = new DetailAST(); ast.initialize(new CommonHiddenStreamToken(TokenTypes.INTERFACE_DEF, "interface")); try { obj.visitToken(ast); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/OneTopLevelClassCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/OneTopLevelClassCheckTest.java index 60fb9a376..db713430f 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/OneTopLevelClassCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/OneTopLevelClassCheckTest.java @@ -47,7 +47,7 @@ public class OneTopLevelClassCheckTest extends BaseCheckTestSupport { @Test public void testGetRequiredTokens() { - OneTopLevelClassCheck checkObj = new OneTopLevelClassCheck(); + final OneTopLevelClassCheck checkObj = new OneTopLevelClassCheck(); assertArrayEquals(ArrayUtils.EMPTY_INT_ARRAY, checkObj.getRequiredTokens()); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/ThrowsCountCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/ThrowsCountCheckTest.java index 796e80cd8..d0b7381e1 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/ThrowsCountCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/ThrowsCountCheckTest.java @@ -45,9 +45,9 @@ public class ThrowsCountCheckTest extends BaseCheckTestSupport { @Test public void testDefault() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(ThrowsCountCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(ThrowsCountCheck.class); - String[] expected = { + final String[] expected = { "17:20: " + getCheckMessage(MSG_KEY, 5, 4), "22:20: " + getCheckMessage(MSG_KEY, 5, 4), "27:20: " + getCheckMessage(MSG_KEY, 6, 4), @@ -59,10 +59,10 @@ public class ThrowsCountCheckTest extends BaseCheckTestSupport { @Test public void testMax() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(ThrowsCountCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(ThrowsCountCheck.class); checkConfig.addAttribute("max", "5"); - String[] expected = { + final String[] expected = { "27:20: " + getCheckMessage(MSG_KEY, 6, 5), }; @@ -71,22 +71,22 @@ public class ThrowsCountCheckTest extends BaseCheckTestSupport { @Test public void testGetAcceptableTokens() { - ThrowsCountCheck obj = new ThrowsCountCheck(); - int[] expected = {TokenTypes.LITERAL_THROWS}; + final ThrowsCountCheck obj = new ThrowsCountCheck(); + final int[] expected = {TokenTypes.LITERAL_THROWS}; assertArrayEquals(expected, obj.getAcceptableTokens()); } @Test public void testGetRequiredTokens() { - ThrowsCountCheck obj = new ThrowsCountCheck(); - int[] expected = {TokenTypes.LITERAL_THROWS}; + final ThrowsCountCheck obj = new ThrowsCountCheck(); + final int[] expected = {TokenTypes.LITERAL_THROWS}; assertArrayEquals(expected, obj.getRequiredTokens()); } @Test public void testWrongTokenType() { - ThrowsCountCheck obj = new ThrowsCountCheck(); - DetailAST ast = new DetailAST(); + final ThrowsCountCheck obj = new ThrowsCountCheck(); + final DetailAST ast = new DetailAST(); ast.initialize(new CommonHiddenStreamToken(TokenTypes.CLASS_DEF, "class")); try { obj.visitToken(ast); @@ -99,9 +99,9 @@ public class ThrowsCountCheckTest extends BaseCheckTestSupport { @Test public void testNotIgnorePrivateMethod() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(ThrowsCountCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(ThrowsCountCheck.class); checkConfig.addAttribute("ignorePrivateMethods", "false"); - String[] expected = { + final String[] expected = { "17:20: " + getCheckMessage(MSG_KEY, 5, 4), "22:20: " + getCheckMessage(MSG_KEY, 5, 4), "27:20: " + getCheckMessage(MSG_KEY, 6, 4), diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/VisibilityModifierCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/VisibilityModifierCheckTest.java index 4d0525518..0609e09ff 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/VisibilityModifierCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/VisibilityModifierCheckTest.java @@ -53,8 +53,8 @@ public class VisibilityModifierCheckTest @Test public void testGetRequiredTokens() { - VisibilityModifierCheck checkObj = new VisibilityModifierCheck(); - int[] expected = { + final VisibilityModifierCheck checkObj = new VisibilityModifierCheck(); + final int[] expected = { TokenTypes.VARIABLE_DEF, TokenTypes.IMPORT, }; @@ -267,8 +267,8 @@ public class VisibilityModifierCheckTest @Test public void testGetAcceptableTokens() { - VisibilityModifierCheck obj = new VisibilityModifierCheck(); - int[] expected = { + final VisibilityModifierCheck obj = new VisibilityModifierCheck(); + final int[] expected = { TokenTypes.VARIABLE_DEF, TokenTypes.IMPORT, }; @@ -292,8 +292,8 @@ public class VisibilityModifierCheckTest @Test(expected = IllegalArgumentException.class) public void testWrongTokenType() { - VisibilityModifierCheck obj = new VisibilityModifierCheck(); - DetailAST ast = new DetailAST(); + final VisibilityModifierCheck obj = new VisibilityModifierCheck(); + final DetailAST ast = new DetailAST(); ast.initialize(new CommonHiddenStreamToken(TokenTypes.CLASS_DEF, "class")); obj.visitToken(ast); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/header/HeaderCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/header/HeaderCheckTest.java index 1254ac5da..d00ad048a 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/header/HeaderCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/header/HeaderCheckTest.java @@ -156,7 +156,7 @@ public class HeaderCheckTest extends BaseFileSetCheckTestSupport { @Test public void testSetHeaderTwice() { - HeaderCheck check = new HeaderCheck(); + final HeaderCheck check = new HeaderCheck(); check.setHeader("Header"); try { check.setHeader("Header2"); @@ -170,7 +170,7 @@ public class HeaderCheckTest extends BaseFileSetCheckTestSupport { @Test public void testIoExceptionWhenLoadingHeader() throws Exception { - HeaderCheck check = PowerMockito.spy(new HeaderCheck()); + final HeaderCheck check = PowerMockito.spy(new HeaderCheck()); PowerMockito.doThrow(new IOException("expected exception")).when(check, "loadHeader", anyObject()); @@ -186,13 +186,13 @@ public class HeaderCheckTest extends BaseFileSetCheckTestSupport { @Test public void testIoExceptionWhenLoadingHeaderFile() throws Exception { - HeaderCheck check = PowerMockito.spy(new HeaderCheck()); + final HeaderCheck check = PowerMockito.spy(new HeaderCheck()); PowerMockito.doThrow(new IOException("expected exception")).when(check, "loadHeader", anyObject()); check.setHeaderFile(getPath("InputRegexpHeader1.java")); - Method loadHeaderFile = AbstractHeaderCheck.class.getDeclaredMethod("loadHeaderFile"); + final Method loadHeaderFile = AbstractHeaderCheck.class.getDeclaredMethod("loadHeaderFile"); loadHeaderFile.setAccessible(true); try { loadHeaderFile.invoke(check); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/header/RegexpHeaderCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/header/RegexpHeaderCheckTest.java index c14a3fda0..824f7127d 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/header/RegexpHeaderCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/header/RegexpHeaderCheckTest.java @@ -54,9 +54,9 @@ public class RegexpHeaderCheckTest extends BaseFileSetCheckTestSupport { @Test public void testSetHeaderNull() { // check null passes - RegexpHeaderCheck instance = new RegexpHeaderCheck(); + final RegexpHeaderCheck instance = new RegexpHeaderCheck(); // recreate for each test because multiple invocations fail - String header = null; + final String header = null; instance.setHeader(header); } @@ -66,9 +66,9 @@ public class RegexpHeaderCheckTest extends BaseFileSetCheckTestSupport { @Test public void testSetHeaderEmpty() { // check null passes - RegexpHeaderCheck instance = new RegexpHeaderCheck(); + final RegexpHeaderCheck instance = new RegexpHeaderCheck(); // check empty string passes - String header = ""; + final String header = ""; instance.setHeader(header); } @@ -77,9 +77,9 @@ public class RegexpHeaderCheckTest extends BaseFileSetCheckTestSupport { */ @Test public void testSetHeaderSimple() { - RegexpHeaderCheck instance = new RegexpHeaderCheck(); + final RegexpHeaderCheck instance = new RegexpHeaderCheck(); // check valid header passes - String header = "abc.*"; + final String header = "abc.*"; instance.setHeader(header); } @@ -89,9 +89,9 @@ public class RegexpHeaderCheckTest extends BaseFileSetCheckTestSupport { @Test public void testSetHeader() { // check invalid header passes - RegexpHeaderCheck instance = new RegexpHeaderCheck(); + final RegexpHeaderCheck instance = new RegexpHeaderCheck(); try { - String header = "^/**\\n * Licensed to the Apache Software Foundation (ASF)"; + final String header = "^/**\\n * Licensed to the Apache Software Foundation (ASF)"; instance.setHeader(header); fail(String.format(Locale.ROOT, "%s should have been thrown", ConversionException.class)); @@ -143,7 +143,7 @@ public class RegexpHeaderCheckTest extends BaseFileSetCheckTestSupport { public void testRegexpHeaderURL() throws Exception { final DefaultConfiguration checkConfig = createCheckConfig(RegexpHeaderCheck.class); - URI uri = new File(getPath("regexp.header")).toURI(); + final URI uri = new File(getPath("regexp.header")).toURI(); checkConfig.addAttribute("headerFile", uri.toString()); final String[] expected = { "3: " + getCheckMessage(MSG_MISMATCH, "// Created: 2002"), diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/AvoidStarImportTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/AvoidStarImportTest.java index 7d6babbe9..409078b28 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/AvoidStarImportTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/AvoidStarImportTest.java @@ -100,19 +100,19 @@ public class AvoidStarImportTest @Test public void testGetAcceptableTokens() { - AvoidStarImportCheck testCheckObject = + final AvoidStarImportCheck testCheckObject = new AvoidStarImportCheck(); - int[] actual = testCheckObject.getAcceptableTokens(); - int[] expected = {TokenTypes.IMPORT, TokenTypes.STATIC_IMPORT}; + final int[] actual = testCheckObject.getAcceptableTokens(); + final int[] expected = {TokenTypes.IMPORT, TokenTypes.STATIC_IMPORT}; assertArrayEquals(expected, actual); } @Test public void testGetRequiredTokens() { - AvoidStarImportCheck testCheckObject = + final AvoidStarImportCheck testCheckObject = new AvoidStarImportCheck(); - int[] actual = testCheckObject.getRequiredTokens(); - int[] expected = {TokenTypes.IMPORT, TokenTypes.STATIC_IMPORT}; + final int[] actual = testCheckObject.getRequiredTokens(); + final int[] expected = {TokenTypes.IMPORT, TokenTypes.STATIC_IMPORT}; assertArrayEquals(expected, actual); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/AvoidStaticImportTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/AvoidStaticImportTest.java index bc6d45fe6..d6a043fec 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/AvoidStaticImportTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/AvoidStaticImportTest.java @@ -41,8 +41,8 @@ public class AvoidStaticImportTest @Test public void testGetRequiredTokens() { - AvoidStaticImportCheck checkObj = new AvoidStaticImportCheck(); - int[] expected = {TokenTypes.STATIC_IMPORT}; + final AvoidStaticImportCheck checkObj = new AvoidStaticImportCheck(); + final int[] expected = {TokenTypes.STATIC_IMPORT}; assertArrayEquals(expected, checkObj.getRequiredTokens()); } @@ -165,10 +165,10 @@ public class AvoidStaticImportTest @Test public void testGetAcceptableTokens() { - AvoidStaticImportCheck testCheckObject = + final AvoidStaticImportCheck testCheckObject = new AvoidStaticImportCheck(); - int[] actual = testCheckObject.getAcceptableTokens(); - int[] expected = {TokenTypes.STATIC_IMPORT}; + final int[] actual = testCheckObject.getAcceptableTokens(); + final int[] expected = {TokenTypes.STATIC_IMPORT}; assertArrayEquals(expected, actual); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/CustomImportOrderCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/CustomImportOrderCheckTest.java index dd7b2c9c6..bfae0ece0 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/CustomImportOrderCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/CustomImportOrderCheckTest.java @@ -63,8 +63,8 @@ public class CustomImportOrderCheckTest extends BaseCheckTestSupport { @Test public void testGetRequiredTokens() { - CustomImportOrderCheck checkObj = new CustomImportOrderCheck(); - int[] expected = { + final CustomImportOrderCheck checkObj = new CustomImportOrderCheck(); + final int[] expected = { TokenTypes.IMPORT, TokenTypes.STATIC_IMPORT, TokenTypes.PACKAGE_DEF, @@ -353,10 +353,10 @@ public class CustomImportOrderCheckTest extends BaseCheckTestSupport { @Test public void testGetAcceptableTokens() { - CustomImportOrderCheck testCheckObject = + final CustomImportOrderCheck testCheckObject = new CustomImportOrderCheck(); - int[] actual = testCheckObject.getAcceptableTokens(); - int[] expected = { + final int[] actual = testCheckObject.getAcceptableTokens(); + final int[] expected = { TokenTypes.IMPORT, TokenTypes.STATIC_IMPORT, TokenTypes.PACKAGE_DEF, @@ -371,9 +371,9 @@ public class CustomImportOrderCheckTest extends BaseCheckTestSupport { public void testGetFullImportIdent() { Object actual; try { - Class<?> clazz = CustomImportOrderCheck.class; - Object t = clazz.getConstructor().newInstance(); - Method method = clazz.getDeclaredMethod("getFullImportIdent", DetailAST.class); + final Class<?> clazz = CustomImportOrderCheck.class; + final Object t = clazz.getConstructor().newInstance(); + final Method method = clazz.getDeclaredMethod("getFullImportIdent", DetailAST.class); method.setAccessible(true); actual = method.invoke(t, (DetailAST) null); } @@ -382,7 +382,7 @@ public class CustomImportOrderCheckTest extends BaseCheckTestSupport { actual = null; } - String expected = ""; + final String expected = ""; assertEquals(expected, actual); } @@ -525,7 +525,7 @@ public class CustomImportOrderCheckTest extends BaseCheckTestSupport { public void testDefaultConfiguration() throws Exception { final DefaultConfiguration checkConfig = createCheckConfig(CustomImportOrderCheck.class); - String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; + final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; createChecker(checkConfig); verify(checkConfig, getPath("InputCustomImportOrder.java"), expected); @@ -566,7 +566,7 @@ public class CustomImportOrderCheckTest extends BaseCheckTestSupport { "SPECIAL_IMPORTS###STANDARD_JAVA_PACKAGE"); checkConfig.addAttribute("specialImportsRegExp", "org"); checkConfig.addAttribute("standardPackageRegExp", "junit"); - String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; + final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; createChecker(checkConfig); verify(checkConfig, getPath("InputCustomImportOrder_MultiplePatternMatches.java"), @@ -581,7 +581,7 @@ public class CustomImportOrderCheckTest extends BaseCheckTestSupport { "SPECIAL_IMPORTS###STANDARD_JAVA_PACKAGE"); checkConfig.addAttribute("specialImportsRegExp", "Test"); checkConfig.addAttribute("standardPackageRegExp", "unit"); - String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; + final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; createChecker(checkConfig); verify(checkConfig, getPath("InputCustomImportOrder_MultiplePatternMatches.java"), @@ -596,7 +596,7 @@ public class CustomImportOrderCheckTest extends BaseCheckTestSupport { "SPECIAL_IMPORTS###STANDARD_JAVA_PACKAGE"); checkConfig.addAttribute("specialImportsRegExp", "unit"); checkConfig.addAttribute("standardPackageRegExp", "Test"); - String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; + final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; createChecker(checkConfig); verify(checkConfig, getPath("InputCustomImportOrder_MultiplePatternMatches.java"), diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/GuardTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/GuardTest.java index 35362fd1f..c56170573 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/GuardTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/GuardTest.java @@ -33,7 +33,7 @@ public class GuardTest { */ @Test public void testAccessResultValueOf() { - AccessResult result = AccessResult.valueOf("ALLOWED"); + final AccessResult result = AccessResult.valueOf("ALLOWED"); assertEquals(AccessResult.ALLOWED, result); } @@ -43,8 +43,8 @@ public class GuardTest { */ @Test public void testAccessResultValues() { - AccessResult[] actual = AccessResult.values(); - AccessResult[] expected = { + final AccessResult[] actual = AccessResult.values(); + final AccessResult[] expected = { AccessResult.ALLOWED, AccessResult.DISALLOWED, AccessResult.UNKNOWN, diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/IllegalImportCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/IllegalImportCheckTest.java index c5faa9b65..9094a670f 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/IllegalImportCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/IllegalImportCheckTest.java @@ -40,8 +40,8 @@ public class IllegalImportCheckTest extends BaseCheckTestSupport { @Test public void testGetRequiredTokens() { - IllegalImportCheck checkObj = new IllegalImportCheck(); - int[] expected = {TokenTypes.IMPORT, TokenTypes.STATIC_IMPORT}; + final IllegalImportCheck checkObj = new IllegalImportCheck(); + final int[] expected = {TokenTypes.IMPORT, TokenTypes.STATIC_IMPORT}; assertArrayEquals(expected, checkObj.getRequiredTokens()); } @@ -73,10 +73,10 @@ public class IllegalImportCheckTest extends BaseCheckTestSupport { @Test public void testGetAcceptableTokens() { - IllegalImportCheck testCheckObject = + final IllegalImportCheck testCheckObject = new IllegalImportCheck(); - int[] actual = testCheckObject.getAcceptableTokens(); - int[] expected = {TokenTypes.IMPORT, TokenTypes.STATIC_IMPORT}; + final int[] actual = testCheckObject.getAcceptableTokens(); + final int[] expected = {TokenTypes.IMPORT, TokenTypes.STATIC_IMPORT}; assertArrayEquals(expected, actual); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/ImportControlCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/ImportControlCheckTest.java index e1582bb58..15361f111 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/ImportControlCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/ImportControlCheckTest.java @@ -53,8 +53,8 @@ public class ImportControlCheckTest extends BaseCheckTestSupport { @Test public void testGetRequiredTokens() { - ImportControlCheck checkObj = new ImportControlCheck(); - int[] expected = { + final ImportControlCheck checkObj = new ImportControlCheck(); + final int[] expected = { TokenTypes.PACKAGE_DEF, TokenTypes.IMPORT, TokenTypes.STATIC_IMPORT, @@ -162,10 +162,10 @@ public class ImportControlCheckTest extends BaseCheckTestSupport { @Test public void testGetAcceptableTokens() { - ImportControlCheck testCheckObject = + final ImportControlCheck testCheckObject = new ImportControlCheck(); - int[] actual = testCheckObject.getAcceptableTokens(); - int[] expected = { + final int[] actual = testCheckObject.getAcceptableTokens(); + final int[] expected = { TokenTypes.PACKAGE_DEF, TokenTypes.IMPORT, TokenTypes.STATIC_IMPORT, diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/ImportControlLoaderTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/ImportControlLoaderTest.java index dfc6371ff..1f1b89377 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/ImportControlLoaderTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/ImportControlLoaderTest.java @@ -64,15 +64,15 @@ public class ImportControlLoaderTest { @Test(expected = InvocationTargetException.class) // UT uses Reflection to avoid removing null-validation from static method public void testSafeGetThrowsException() throws InvocationTargetException { - AttributesImpl attr = new AttributesImpl() { + final AttributesImpl attr = new AttributesImpl() { @Override public String getValue(int index) { return null; } }; try { - Class<?> clazz = ImportControlLoader.class; - Method privateMethod = clazz.getDeclaredMethod("safeGet", + final Class<?> clazz = ImportControlLoader.class; + final Method privateMethod = clazz.getDeclaredMethod("safeGet", Attributes.class, String.class); privateMethod.setAccessible(true); privateMethod.invoke(null, attr, "you_cannot_find_me"); @@ -88,10 +88,11 @@ public class ImportControlLoaderTest { // because this is possible situation (though highly unlikely), which depends on hardware // and is difficult to emulate public void testLoadThrowsException() throws InvocationTargetException { - InputSource source = new InputSource(); + final InputSource source = new InputSource(); try { - Class<?> clazz = ImportControlLoader.class; - Method privateMethod = clazz.getDeclaredMethod("load", InputSource.class, URI.class); + final Class<?> clazz = ImportControlLoader.class; + final Method privateMethod = clazz.getDeclaredMethod("load", InputSource.class, + URI.class); privateMethod.setAccessible(true); privateMethod.invoke(null, source, new File(getPath("import-control_complete.xml")).toURI()); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/ImportOrderCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/ImportOrderCheckTest.java index 623479ad4..25b179d6c 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/ImportOrderCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/ImportOrderCheckTest.java @@ -63,7 +63,7 @@ public class ImportOrderCheckTest extends BaseCheckTestSupport { */ @Test public void testImportOrderOptionValueOf() { - ImportOrderOption option = ImportOrderOption.valueOf("TOP"); + final ImportOrderOption option = ImportOrderOption.valueOf("TOP"); assertEquals(ImportOrderOption.TOP, option); } @@ -420,20 +420,21 @@ public class ImportOrderCheckTest extends BaseCheckTestSupport { @Test(expected = IllegalStateException.class) public void testVisitTokenSwitchReflection() throws Exception { - ImportOrderOption importOrderOptionMock = PowerMockito.mock(ImportOrderOption.class); + final ImportOrderOption importOrderOptionMock = PowerMockito.mock(ImportOrderOption.class); Whitebox.setInternalState(importOrderOptionMock, "name", "NEW_OPTION_FOR_UT"); Whitebox.setInternalState(importOrderOptionMock, "ordinal", 5); - DetailAST astImport = mockAST(TokenTypes.IMPORT, "import", "mockfile", 0, 0); - DetailAST astIdent = mockAST(TokenTypes.IDENT, "myTestImport", "mockfile", 0, 0); + final DetailAST astImport = mockAST(TokenTypes.IMPORT, "import", "mockfile", 0, 0); + final DetailAST astIdent = mockAST(TokenTypes.IDENT, "myTestImport", "mockfile", 0, 0); astImport.addChild(astIdent); - DetailAST astSemi = mockAST(TokenTypes.SEMI, ";", "mockfile", 0, 0); + final DetailAST astSemi = mockAST(TokenTypes.SEMI, ";", "mockfile", 0, 0); astIdent.addNextSibling(astSemi); - ImportOrderCheck check = new ImportOrderCheck() { + final ImportOrderCheck check = new ImportOrderCheck() { @Override public ImportOrderOption getAbstractOption() { - ImportOrderOption importOrderOption = PowerMockito.mock(ImportOrderOption.class); + final ImportOrderOption importOrderOption = PowerMockito + .mock(ImportOrderOption.class); Whitebox.setInternalState(importOrderOption, "name", "NEW_OPTION_FOR_UT"); Whitebox.setInternalState(importOrderOption, "ordinal", 5); return importOrderOption; @@ -454,13 +455,13 @@ public class ImportOrderCheckTest extends BaseCheckTestSupport { */ private static DetailAST mockAST(final int tokenType, final String tokenText, final String tokenFileName, final int tokenRow, final int tokenColumn) { - CommonHiddenStreamToken tokenImportSemi = new CommonHiddenStreamToken(); + final CommonHiddenStreamToken tokenImportSemi = new CommonHiddenStreamToken(); tokenImportSemi.setType(tokenType); tokenImportSemi.setText(tokenText); tokenImportSemi.setLine(tokenRow); tokenImportSemi.setColumn(tokenColumn); tokenImportSemi.setFilename(tokenFileName); - DetailAST astSemi = new DetailAST(); + final DetailAST astSemi = new DetailAST(); astSemi.initialize(tokenImportSemi); return astSemi; } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/RedundantImportCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/RedundantImportCheckTest.java index 2040b97cb..3d8ea841c 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/RedundantImportCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/RedundantImportCheckTest.java @@ -49,8 +49,8 @@ public class RedundantImportCheckTest @Test public void testGetRequiredTokens() { - RedundantImportCheck checkObj = new RedundantImportCheck(); - int[] expected = { + final RedundantImportCheck checkObj = new RedundantImportCheck(); + final int[] expected = { TokenTypes.IMPORT, TokenTypes.STATIC_IMPORT, TokenTypes.PACKAGE_DEF, @@ -90,10 +90,10 @@ public class RedundantImportCheckTest @Test public void testGetAcceptableTokens() { - RedundantImportCheck testCheckObject = + final RedundantImportCheck testCheckObject = new RedundantImportCheck(); - int[] actual = testCheckObject.getAcceptableTokens(); - int[] expected = { + final int[] actual = testCheckObject.getAcceptableTokens(); + final int[] expected = { TokenTypes.IMPORT, TokenTypes.STATIC_IMPORT, TokenTypes.PACKAGE_DEF, diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/UnusedImportsCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/UnusedImportsCheckTest.java index d5eb96219..e042c4f4f 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/UnusedImportsCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/UnusedImportsCheckTest.java @@ -120,10 +120,10 @@ public class UnusedImportsCheckTest extends BaseCheckTestSupport { @Test public void testGetRequiredTokens() { - UnusedImportsCheck testCheckObject = + final UnusedImportsCheck testCheckObject = new UnusedImportsCheck(); - int[] actual = testCheckObject.getRequiredTokens(); - int[] expected = { + final int[] actual = testCheckObject.getRequiredTokens(); + final int[] expected = { TokenTypes.IDENT, TokenTypes.IMPORT, TokenTypes.STATIC_IMPORT, @@ -145,10 +145,10 @@ public class UnusedImportsCheckTest extends BaseCheckTestSupport { @Test public void testGetAcceptableTokens() { - UnusedImportsCheck testCheckObject = + final UnusedImportsCheck testCheckObject = new UnusedImportsCheck(); - int[] actual = testCheckObject.getAcceptableTokens(); - int[] expected = { + final int[] actual = testCheckObject.getAcceptableTokens(); + final int[] expected = { TokenTypes.IDENT, TokenTypes.IMPORT, TokenTypes.STATIC_IMPORT, diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/indentation/CommentsIndentationCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/indentation/CommentsIndentationCheckTest.java index 89bc8677b..0ba54adb9 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/indentation/CommentsIndentationCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/indentation/CommentsIndentationCheckTest.java @@ -86,7 +86,7 @@ public class CommentsIndentationCheckTest extends BaseCheckTestSupport { @Test public void testVisitToken() throws Exception { final CommentsIndentationCheck check = new CommentsIndentationCheck(); - DetailAST methodDef = new DetailAST(); + final DetailAST methodDef = new DetailAST(); methodDef.setType(TokenTypes.METHOD_DEF); methodDef.setText("methodStub"); try { diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/indentation/IndentationCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/indentation/IndentationCheckTest.java index 36ae295b2..688485940 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/indentation/IndentationCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/indentation/IndentationCheckTest.java @@ -76,12 +76,12 @@ public class IndentationCheckTest extends BaseCheckTestSupport { private static Integer[] getLinesWithWarnAndCheckComments(String aFileName, final int tabWidth) throws IOException { - List<Integer> result = new ArrayList<>(); + final List<Integer> result = new ArrayList<>(); try (BufferedReader br = new BufferedReader(new InputStreamReader( new FileInputStream(aFileName), StandardCharsets.UTF_8))) { int lineNumber = 1; for (String line = br.readLine(); line != null; line = br.readLine()) { - Matcher match = LINE_WITH_COMMENT_REGEX.matcher(line); + final Matcher match = LINE_WITH_COMMENT_REGEX.matcher(line); if (match.matches()) { final String comment = match.group(1); final int indentInComment = getIndentFromComment(comment); @@ -135,7 +135,7 @@ public class IndentationCheckTest extends BaseCheckTestSupport { final int indentInComment = getIndentFromComment(comment); final boolean isWarnComment = isWarnComment(comment); - Matcher multilevelMatch = MULTILEVEL_COMMENT_REGEX.matcher(comment); + final Matcher multilevelMatch = MULTILEVEL_COMMENT_REGEX.matcher(comment); if (multilevelMatch.matches()) { final String[] levels = multilevelMatch.group(1).split(","); final String indentInCommentStr = String.valueOf(indentInComment); @@ -146,13 +146,13 @@ public class IndentationCheckTest extends BaseCheckTestSupport { || !containsActualLevel && isWarnComment; } - Matcher singleLevelMatch = SINGLE_LEVEL_COMMENT_REGEX.matcher(comment); + final Matcher singleLevelMatch = SINGLE_LEVEL_COMMENT_REGEX.matcher(comment); if (singleLevelMatch.matches()) { final int expectedLevel = Integer.parseInt(singleLevelMatch.group(1)); return isSingleLevelCommentConsistent(indentInComment, isWarnComment, expectedLevel); } - Matcher nonStrictLevelMatch = NON_STRICT_LEVEL_COMMENT_REGEX.matcher(comment); + final Matcher nonStrictLevelMatch = NON_STRICT_LEVEL_COMMENT_REGEX.matcher(comment); if (nonStrictLevelMatch.matches()) { final int expectedMinimalIndent = Integer.parseInt(nonStrictLevelMatch.group(1)); @@ -182,7 +182,7 @@ public class IndentationCheckTest extends BaseCheckTestSupport { String[] expected, int warnCountCorrection) throws Exception { final int tabWidth = Integer.parseInt(config.getAttribute("tabWidth")); - Integer[] linesWithWarn = + final Integer[] linesWithWarn = getLinesWithWarnAndCheckComments(filePath, tabWidth); assertEquals("Expected warning count in UT does not match warn" + " comment count in input file", linesWithWarn.length @@ -211,23 +211,23 @@ public class IndentationCheckTest extends BaseCheckTestSupport { @Test public void testGetRequiredTokens() { - IndentationCheck checkObj = new IndentationCheck(); + final IndentationCheck checkObj = new IndentationCheck(); final HandlerFactory handlerFactory = new HandlerFactory(); - int[] expected = handlerFactory.getHandledTypes(); + final int[] expected = handlerFactory.getHandledTypes(); assertArrayEquals(expected, checkObj.getRequiredTokens()); } @Test public void testGetAcceptableTokens() { - IndentationCheck checkObj = new IndentationCheck(); + final IndentationCheck checkObj = new IndentationCheck(); final HandlerFactory handlerFactory = new HandlerFactory(); - int[] expected = handlerFactory.getHandledTypes(); + final int[] expected = handlerFactory.getHandledTypes(); assertArrayEquals(expected, checkObj.getAcceptableTokens()); } @Test public void testThrowsIndentProperty() { - IndentationCheck indentationCheck = new IndentationCheck(); + final IndentationCheck indentationCheck = new IndentationCheck(); indentationCheck.setThrowsIndent(1); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/indentation/LineSetTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/indentation/LineSetTest.java index 456d71dfa..aee00d2c0 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/indentation/LineSetTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/indentation/LineSetTest.java @@ -27,11 +27,11 @@ public class LineSetTest { @Test public void testToStringShowingFirstAndLastLine() { - LineSet lineSet = new LineSet(); + final LineSet lineSet = new LineSet(); lineSet.addLineAndCol(0, 1); lineSet.addLineAndCol(2, 3); - String result = lineSet.toString(); + final String result = lineSet.toString(); assertEquals("LineSet[firstLine=0, lastLine=2]", result); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AbstractJavadocCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AbstractJavadocCheckTest.java index 22f3f4a60..4167e7cf6 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AbstractJavadocCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AbstractJavadocCheckTest.java @@ -104,7 +104,7 @@ public class AbstractJavadocCheckTest extends BaseCheckTestSupport { @Test public void testCheckReuseAfterParseErrorWithFollowingAntlrErrorInTwoFiles() throws Exception { final DefaultConfiguration checkConfig = createCheckConfig(TempCheck.class); - Map<String, List<String>> expectedMessages = new LinkedHashMap<>(2); + final Map<String, List<String>> expectedMessages = new LinkedHashMap<>(2); expectedMessages.put(getPath("InputParsingErrors.java"), asList( "4: " + getCheckMessage(JAVADOC_MISSED_HTML_CLOSE, 4, "unclosedTag"), "8: " + getCheckMessage(JAVADOC_WRONG_SINGLETON_TAG, 35, "img") diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AbstractTypeAwareCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AbstractTypeAwareCheckTest.java index c75a52f75..8ddb07cae 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AbstractTypeAwareCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AbstractTypeAwareCheckTest.java @@ -56,8 +56,8 @@ public class AbstractTypeAwareCheckTest extends BaseCheckTestSupport { @Test public void testIsSubclassWithNulls() throws Exception { - JavadocMethodCheck check = new JavadocMethodCheck(); - Method isSubclass = check.getClass().getSuperclass() + final JavadocMethodCheck check = new JavadocMethodCheck(); + final Method isSubclass = check.getClass().getSuperclass() .getDeclaredMethod("isSubclass", Class.class, Class.class); isSubclass.setAccessible(true); assertFalse((boolean) isSubclass.invoke(check, null, null)); @@ -65,26 +65,26 @@ public class AbstractTypeAwareCheckTest extends BaseCheckTestSupport { @Test public void testTokenToString() throws Exception { - Class<?> tokenType = Class + final Class<?> tokenType = Class .forName("com.puppycrawl.tools.checkstyle.checks.AbstractTypeAwareCheck$Token"); - Constructor<?> tokenConstructor = tokenType.getDeclaredConstructor(String.class, int.class, - int.class); - Object token = tokenConstructor.newInstance("blablabla", 1, 1); - Method toString = token.getClass().getDeclaredMethod("toString"); - String result = (String) toString.invoke(token); + final Constructor<?> tokenConstructor = tokenType.getDeclaredConstructor(String.class, + int.class, int.class); + final Object token = tokenConstructor.newInstance("blablabla", 1, 1); + final Method toString = token.getClass().getDeclaredMethod("toString"); + final String result = (String) toString.invoke(token); assertEquals("Token[blablabla(1x1)]", result); } @Test public void testClassRegularClass() throws Exception { - Class<?> tokenType = Class + final Class<?> tokenType = Class .forName("com.puppycrawl.tools.checkstyle.checks.AbstractTypeAwareCheck$Token"); - Class<?> regularClassType = Class + final Class<?> regularClassType = Class .forName( "com.puppycrawl.tools.checkstyle.checks.AbstractTypeAwareCheck$RegularClass"); - Constructor<?> regularClassConstructor = regularClassType.getDeclaredConstructor(tokenType, - String.class, AbstractTypeAwareCheck.class); + final Constructor<?> regularClassConstructor = regularClassType.getDeclaredConstructor( + tokenType, String.class, AbstractTypeAwareCheck.class); regularClassConstructor.setAccessible(true); try { @@ -95,67 +95,67 @@ public class AbstractTypeAwareCheckTest extends BaseCheckTestSupport { assertEquals("ClassInfo's name should be non-null", ex.getCause().getMessage()); } - Constructor<?> tokenConstructor = tokenType.getDeclaredConstructor(String.class, int.class, - int.class); - Object token = tokenConstructor.newInstance("blablabla", 1, 1); + final Constructor<?> tokenConstructor = tokenType.getDeclaredConstructor(String.class, + int.class, int.class); + final Object token = tokenConstructor.newInstance("blablabla", 1, 1); - Object regularClass = regularClassConstructor.newInstance(token, "sur", + final Object regularClass = regularClassConstructor.newInstance(token, "sur", new JavadocMethodCheck()); - Method toString = regularClass.getClass().getDeclaredMethod("toString"); + final Method toString = regularClass.getClass().getDeclaredMethod("toString"); toString.setAccessible(true); - String result = (String) toString.invoke(regularClass); + final String result = (String) toString.invoke(regularClass); assertEquals("RegularClass[name=Token[blablabla(1x1)], in class=sur, loadable=true," + " class=null]", result); - Method setClazz = regularClass.getClass().getDeclaredMethod("setClazz", Class.class); + final Method setClazz = regularClass.getClass().getDeclaredMethod("setClazz", Class.class); setClazz.setAccessible(true); - Class<?> arg = null; + final Class<?> arg = null; setClazz.invoke(regularClass, arg); - Method getClazz = regularClass.getClass().getDeclaredMethod("getClazz"); + final Method getClazz = regularClass.getClass().getDeclaredMethod("getClazz"); getClazz.setAccessible(true); assertNull(getClazz.invoke(regularClass)); } @Test public void testClassAliasToString() throws Exception { - Class<?> tokenType = Class + final Class<?> tokenType = Class .forName("com.puppycrawl.tools.checkstyle.checks.AbstractTypeAwareCheck$Token"); - Class<?> regularClassType = Class + final Class<?> regularClassType = Class .forName( "com.puppycrawl.tools.checkstyle.checks.AbstractTypeAwareCheck$RegularClass"); - Constructor<?> regularClassConstructor = regularClassType.getDeclaredConstructor(tokenType, - String.class, AbstractTypeAwareCheck.class); + final Constructor<?> regularClassConstructor = regularClassType.getDeclaredConstructor( + tokenType, String.class, AbstractTypeAwareCheck.class); regularClassConstructor.setAccessible(true); - Constructor<?> tokenConstructor = tokenType.getDeclaredConstructor(String.class, int.class, - int.class); - Object token = tokenConstructor.newInstance("blablabla", 1, 1); + final Constructor<?> tokenConstructor = tokenType.getDeclaredConstructor(String.class, + int.class, int.class); + final Object token = tokenConstructor.newInstance("blablabla", 1, 1); - Object regularClass = regularClassConstructor.newInstance(token, "sur", + final Object regularClass = regularClassConstructor.newInstance(token, "sur", new JavadocMethodCheck()); - Class<?> classAliasType = Class.forName( + final Class<?> classAliasType = Class.forName( "com.puppycrawl.tools.checkstyle.checks.AbstractTypeAwareCheck$ClassAlias"); - Class<?> abstractTypeInfoType = Class.forName( + final Class<?> abstractTypeInfoType = Class.forName( "com.puppycrawl.tools.checkstyle.checks.AbstractTypeAwareCheck$AbstractClassInfo"); - Constructor<?> classAliasConstructor = classAliasType + final Constructor<?> classAliasConstructor = classAliasType .getDeclaredConstructor(tokenType, abstractTypeInfoType); classAliasConstructor.setAccessible(true); - Object classAlias = classAliasConstructor.newInstance(token, regularClass); - Method toString = classAlias.getClass().getDeclaredMethod("toString"); + final Object classAlias = classAliasConstructor.newInstance(token, regularClass); + final Method toString = classAlias.getClass().getDeclaredMethod("toString"); toString.setAccessible(true); - String result = (String) toString.invoke(classAlias); + final String result = (String) toString.invoke(classAlias); assertEquals("ClassAlias[alias Token[blablabla(1x1)] for Token[blablabla(1x1)]]", result); } @Test public void testWithoutLogErrors() throws Exception { - DefaultConfiguration config = createCheckConfig(JavadocMethodCheck.class); + final DefaultConfiguration config = createCheckConfig(JavadocMethodCheck.class); config.addAttribute("logLoadErrors", "false"); config.addAttribute("allowUndeclaredRTE", "true"); final String[] expected = { diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AtclauseOrderCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AtclauseOrderCheckTest.java index ba806df19..aed9cd616 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AtclauseOrderCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AtclauseOrderCheckTest.java @@ -41,21 +41,21 @@ public class AtclauseOrderCheckTest extends BaseCheckTestSupport { @Test public void testGetAcceptableTokens() { - AtclauseOrderCheck checkObj = new AtclauseOrderCheck(); - int[] expected = {TokenTypes.BLOCK_COMMENT_BEGIN}; + final AtclauseOrderCheck checkObj = new AtclauseOrderCheck(); + final int[] expected = {TokenTypes.BLOCK_COMMENT_BEGIN}; assertArrayEquals(expected, checkObj.getAcceptableTokens()); } @Test public void testGetRequiredTokens() { - AtclauseOrderCheck checkObj = new AtclauseOrderCheck(); - int[] expected = {TokenTypes.BLOCK_COMMENT_BEGIN}; + final AtclauseOrderCheck checkObj = new AtclauseOrderCheck(); + final int[] expected = {TokenTypes.BLOCK_COMMENT_BEGIN}; assertArrayEquals(expected, checkObj.getRequiredTokens()); } @Test public void testCorrect() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(AtclauseOrderCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(AtclauseOrderCheck.class); final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; verify(checkConfig, getPath("InputCorrectAtClauseOrder.java"), expected); @@ -65,7 +65,7 @@ public class AtclauseOrderCheckTest extends BaseCheckTestSupport { public void testIncorrect() throws Exception { final String tagOrder = "[@author, @version, @param, @return, @throws, @exception, @see," + " @since, @serial, @serialField, @serialData, @deprecated]"; - DefaultConfiguration checkConfig = createCheckConfig(AtclauseOrderCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(AtclauseOrderCheck.class); final String[] expected = { "9: " + getCheckMessage(MSG_KEY, tagOrder), "11: " + getCheckMessage(MSG_KEY, tagOrder), @@ -114,7 +114,7 @@ public class AtclauseOrderCheckTest extends BaseCheckTestSupport { @Test public void testIncorrectCustom() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(AtclauseOrderCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(AtclauseOrderCheck.class); checkConfig.addAttribute("target", "CLASS_DEF"); final String customOrder = " @since, @version, @param,@return,@throws, @exception," + "@deprecated, @see,@serial, @serialField, @serialData,@author"; diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocMethodCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocMethodCheckTest.java index 6ca395e51..b255ad86b 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocMethodCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocMethodCheckTest.java @@ -57,10 +57,10 @@ public class JavadocMethodCheckTest extends BaseCheckTestSupport { @Test public void testGetAcceptableTokens() { - JavadocMethodCheck javadocMethodCheck = new JavadocMethodCheck(); + final JavadocMethodCheck javadocMethodCheck = new JavadocMethodCheck(); - int[] actual = javadocMethodCheck.getAcceptableTokens(); - int[] expected = { + final int[] actual = javadocMethodCheck.getAcceptableTokens(); + final int[] expected = { TokenTypes.PACKAGE_DEF, TokenTypes.IMPORT, TokenTypes.CLASS_DEF, @@ -76,7 +76,7 @@ public class JavadocMethodCheckTest extends BaseCheckTestSupport { @Test public void testLogLoadErrors() throws Exception { - DefaultConfiguration config = createCheckConfig(JavadocMethodCheck.class); + final DefaultConfiguration config = createCheckConfig(JavadocMethodCheck.class); config.addAttribute("logLoadErrors", "true"); config.addAttribute("allowUndeclaredRTE", "true"); final String[] expected = { @@ -87,7 +87,7 @@ public class JavadocMethodCheckTest extends BaseCheckTestSupport { @Test public void extendAnnotationTest() throws Exception { - DefaultConfiguration config = createCheckConfig(JavadocMethodCheck.class); + final DefaultConfiguration config = createCheckConfig(JavadocMethodCheck.class); config.addAttribute("allowedAnnotations", "MyAnnotation, Override"); config.addAttribute("minLineCount", "2"); final String[] expected = { @@ -98,7 +98,7 @@ public class JavadocMethodCheckTest extends BaseCheckTestSupport { @Test public void newTest() throws Exception { - DefaultConfiguration config = createCheckConfig(JavadocMethodCheck.class); + final DefaultConfiguration config = createCheckConfig(JavadocMethodCheck.class); config.addAttribute("allowedAnnotations", "MyAnnotation, Override"); config.addAttribute("minLineCount", "2"); final String[] expected = { @@ -110,7 +110,7 @@ public class JavadocMethodCheckTest extends BaseCheckTestSupport { @Test public void allowedAnnotationsTest() throws Exception { - DefaultConfiguration config = createCheckConfig(JavadocMethodCheck.class); + final DefaultConfiguration config = createCheckConfig(JavadocMethodCheck.class); config.addAttribute("allowedAnnotations", "Override,ThisIsOk, \t\n\t ThisIsOkToo"); final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; verify(config, getPath("InputAllowedAnnotations.java"), expected); @@ -553,14 +553,14 @@ public class JavadocMethodCheckTest extends BaseCheckTestSupport { @Test public void testSkipCertainMethods() throws Exception { checkConfig.addAttribute("ignoreMethodNamesRegex", "^foo.*$"); - String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; + final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; verify(checkConfig, getPath("InputJavadocMethodIgnoreNameRegex.java"), expected); } @Test public void testNotSkipAnythingWhenSkipRegexDoesNotMatch() throws Exception { checkConfig.addAttribute("ignoreMethodNamesRegex", "regexThatDoesNotMatch"); - String[] expected = { + final String[] expected = { "5:5: " + getCheckMessage(MSG_JAVADOC_MISSING), "9:5: " + getCheckMessage(MSG_JAVADOC_MISSING), "13:5: " + getCheckMessage(MSG_JAVADOC_MISSING), diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocNodeImplTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocNodeImplTest.java index b060f160a..bd5d0b9fa 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocNodeImplTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocNodeImplTest.java @@ -29,22 +29,22 @@ public class JavadocNodeImplTest { @Test public void testToString() { - JavadocNodeImpl javadocNode = new JavadocNodeImpl(); + final JavadocNodeImpl javadocNode = new JavadocNodeImpl(); javadocNode.setType(JavadocTokenTypes.CODE_LITERAL); javadocNode.setLineNumber(1); javadocNode.setColumnNumber(2); - String result = javadocNode.toString(); + final String result = javadocNode.toString(); assertEquals("CODE_LITERAL[1x2]", result); } @Test public void testGetColumnNumber() { - JavadocNodeImpl javadocNode = new JavadocNodeImpl(); + final JavadocNodeImpl javadocNode = new JavadocNodeImpl(); javadocNode.setColumnNumber(1); - int result = javadocNode.getColumnNumber(); + final int result = javadocNode.getColumnNumber(); assertEquals(1, result); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocParagraphCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocParagraphCheckTest.java index 0f49cfb51..38d5de3a3 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocParagraphCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocParagraphCheckTest.java @@ -52,8 +52,8 @@ public class JavadocParagraphCheckTest extends BaseCheckTestSupport { @Test public void testGetRequiredTokens() { - JavadocParagraphCheck checkObj = new JavadocParagraphCheck(); - int[] expected = {TokenTypes.BLOCK_COMMENT_BEGIN}; + final JavadocParagraphCheck checkObj = new JavadocParagraphCheck(); + final int[] expected = {TokenTypes.BLOCK_COMMENT_BEGIN}; assertArrayEquals(expected, checkObj.getRequiredTokens()); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocStyleCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocStyleCheckTest.java index e669a02ae..58a4c4254 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocStyleCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocStyleCheckTest.java @@ -47,9 +47,9 @@ public class JavadocStyleCheckTest @Test public void testGetRequiredTokens() { - JavadocStyleCheck javadocStyleCheck = new JavadocStyleCheck(); - int[] actual = javadocStyleCheck.getRequiredTokens(); - int[] expected = { + final JavadocStyleCheck javadocStyleCheck = new JavadocStyleCheck(); + final int[] actual = javadocStyleCheck.getRequiredTokens(); + final int[] expected = { TokenTypes.INTERFACE_DEF, TokenTypes.CLASS_DEF, TokenTypes.ANNOTATION_DEF, @@ -66,10 +66,10 @@ public class JavadocStyleCheckTest @Test public void testGetAcceptableTokens() { - JavadocStyleCheck javadocStyleCheck = new JavadocStyleCheck(); + final JavadocStyleCheck javadocStyleCheck = new JavadocStyleCheck(); - int[] actual = javadocStyleCheck.getAcceptableTokens(); - int[] expected = { + final int[] actual = javadocStyleCheck.getAcceptableTokens(); + final int[] expected = { TokenTypes.INTERFACE_DEF, TokenTypes.CLASS_DEF, TokenTypes.ANNOTATION_DEF, diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocTagContinuationIndentationCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocTagContinuationIndentationCheckTest.java index 413ea5c41..15c7044cd 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocTagContinuationIndentationCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocTagContinuationIndentationCheckTest.java @@ -42,9 +42,9 @@ public class JavadocTagContinuationIndentationCheckTest @Test public void testGetRequiredTokens() { - JavadocTagContinuationIndentationCheck checkObj = + final JavadocTagContinuationIndentationCheck checkObj = new JavadocTagContinuationIndentationCheck(); - int[] expected = {TokenTypes.BLOCK_COMMENT_BEGIN }; + final int[] expected = {TokenTypes.BLOCK_COMMENT_BEGIN }; assertArrayEquals(expected, checkObj.getRequiredTokens()); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocTagInfoTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocTagInfoTest.java index f05062c20..b7950ede0 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocTagInfoTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocTagInfoTest.java @@ -40,7 +40,7 @@ public class JavadocTagInfoTest { */ @Test public void testJavadocTagInfoValueOf() { - JavadocTagInfo tag = JavadocTagInfo.valueOf("AUTHOR"); + final JavadocTagInfo tag = JavadocTagInfo.valueOf("AUTHOR"); assertEquals(JavadocTagInfo.AUTHOR, tag); } @@ -50,7 +50,7 @@ public class JavadocTagInfoTest { */ @Test public void testTypeValueOf() { - JavadocTagInfo.Type type = JavadocTagInfo.Type.valueOf("BLOCK"); + final JavadocTagInfo.Type type = JavadocTagInfo.Type.valueOf("BLOCK"); assertEquals(JavadocTagInfo.Type.BLOCK, type); } @@ -60,11 +60,11 @@ public class JavadocTagInfoTest { */ @Test public void testTypeValues() { - JavadocTagInfo.Type[] expected = { + final JavadocTagInfo.Type[] expected = { JavadocTagInfo.Type.BLOCK, JavadocTagInfo.Type.INLINE, }; - JavadocTagInfo.Type[] actual = JavadocTagInfo.Type.values(); + final JavadocTagInfo.Type[] actual = JavadocTagInfo.Type.values(); assertArrayEquals(expected, actual); } @@ -72,7 +72,7 @@ public class JavadocTagInfoTest { public void testAuthor() { final DetailAST ast = new DetailAST(); - int[] validTypes = { + final int[] validTypes = { TokenTypes.PACKAGE_DEF, TokenTypes.CLASS_DEF, TokenTypes.INTERFACE_DEF, @@ -90,7 +90,7 @@ public class JavadocTagInfoTest { @Test public void testOthers() throws ReflectiveOperationException { - JavadocTagInfo[] tags = { + final JavadocTagInfo[] tags = { JavadocTagInfo.CODE, JavadocTagInfo.DOC_ROOT, JavadocTagInfo.LINK, @@ -101,15 +101,15 @@ public class JavadocTagInfoTest { JavadocTagInfo.VALUE, }; for (JavadocTagInfo tagInfo : tags) { - DetailAST astParent = new DetailAST(); + final DetailAST astParent = new DetailAST(); astParent.setType(TokenTypes.LITERAL_CATCH); final DetailAST ast = new DetailAST(); - Method setParent = ast.getClass().getDeclaredMethod("setParent", DetailAST.class); + final Method setParent = ast.getClass().getDeclaredMethod("setParent", DetailAST.class); setParent.setAccessible(true); setParent.invoke(ast, astParent); - int[] validTypes = { + final int[] validTypes = { TokenTypes.PACKAGE_DEF, TokenTypes.CLASS_DEF, TokenTypes.INTERFACE_DEF, @@ -136,13 +136,13 @@ public class JavadocTagInfoTest { @Test public void testDeprecated() throws ReflectiveOperationException { final DetailAST ast = new DetailAST(); - DetailAST astParent = new DetailAST(); + final DetailAST astParent = new DetailAST(); astParent.setType(TokenTypes.LITERAL_CATCH); - Method setParent = ast.getClass().getDeclaredMethod("setParent", DetailAST.class); + final Method setParent = ast.getClass().getDeclaredMethod("setParent", DetailAST.class); setParent.setAccessible(true); setParent.invoke(ast, astParent); - int[] validTypes = { + final int[] validTypes = { TokenTypes.CLASS_DEF, TokenTypes.INTERFACE_DEF, TokenTypes.ENUM_DEF, @@ -169,13 +169,13 @@ public class JavadocTagInfoTest { @Test public void testSerial() throws ReflectiveOperationException { final DetailAST ast = new DetailAST(); - DetailAST astParent = new DetailAST(); + final DetailAST astParent = new DetailAST(); astParent.setType(TokenTypes.LITERAL_CATCH); - Method setParent = ast.getClass().getDeclaredMethod("setParent", DetailAST.class); + final Method setParent = ast.getClass().getDeclaredMethod("setParent", DetailAST.class); setParent.setAccessible(true); setParent.invoke(ast, astParent); - int[] validTypes = { + final int[] validTypes = { TokenTypes.VARIABLE_DEF, }; for (int type: validTypes) { @@ -195,7 +195,7 @@ public class JavadocTagInfoTest { public void testException() { final DetailAST ast = new DetailAST(); - int[] validTypes = { + final int[] validTypes = { TokenTypes.METHOD_DEF, TokenTypes.CTOR_DEF, }; @@ -212,7 +212,7 @@ public class JavadocTagInfoTest { public void testThrows() { final DetailAST ast = new DetailAST(); - int[] validTypes = { + final int[] validTypes = { TokenTypes.METHOD_DEF, TokenTypes.CTOR_DEF, }; @@ -229,7 +229,7 @@ public class JavadocTagInfoTest { public void testVersions() { final DetailAST ast = new DetailAST(); - int[] validTypes = { + final int[] validTypes = { TokenTypes.PACKAGE_DEF, TokenTypes.CLASS_DEF, TokenTypes.INTERFACE_DEF, @@ -249,7 +249,7 @@ public class JavadocTagInfoTest { public void testParam() { final DetailAST ast = new DetailAST(); - int[] validTypes = { + final int[] validTypes = { TokenTypes.CLASS_DEF, TokenTypes.INTERFACE_DEF, TokenTypes.METHOD_DEF, @@ -274,7 +274,7 @@ public class JavadocTagInfoTest { astChild2.setType(TokenTypes.LITERAL_INT); astChild.setFirstChild(astChild2); - int[] validTypes = { + final int[] validTypes = { TokenTypes.METHOD_DEF, }; for (int type: validTypes) { @@ -300,7 +300,7 @@ public class JavadocTagInfoTest { astChild2.setText("ObjectStreafield"); astChild.setFirstChild(astChild2); - int[] validTypes = { + final int[] validTypes = { TokenTypes.VARIABLE_DEF, }; for (int type: validTypes) { @@ -327,7 +327,7 @@ public class JavadocTagInfoTest { astChild.setText("writeObject"); ast.setFirstChild(astChild); - String[] validNames = { + final String[] validNames = { "writeObject", "readObject", "writeExternal", diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocTagTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocTagTest.java index 11c8ca9d9..6c956f62d 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocTagTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocTagTest.java @@ -34,7 +34,7 @@ public class JavadocTagTest { */ @Test public void testJavadocTagTypeValueOf() { - JavadocUtils.JavadocTagType enumConst = + final JavadocUtils.JavadocTagType enumConst = JavadocUtils.JavadocTagType.valueOf("ALL"); assertEquals(JavadocUtils.JavadocTagType.ALL, enumConst); } @@ -45,9 +45,9 @@ public class JavadocTagTest { */ @Test public void testJavadocTagTypeValues() { - JavadocUtils.JavadocTagType[] enumConstants = + final JavadocUtils.JavadocTagType[] enumConstants = JavadocUtils.JavadocTagType.values(); - JavadocUtils.JavadocTagType[] expected = { + final JavadocUtils.JavadocTagType[] expected = { JavadocUtils.JavadocTagType.BLOCK, JavadocUtils.JavadocTagType.INLINE, JavadocUtils.JavadocTagType.ALL, @@ -57,9 +57,9 @@ public class JavadocTagTest { @Test public void testToString() { - JavadocTag javadocTag = new JavadocTag(0, 1, "author", "firstArg"); + final JavadocTag javadocTag = new JavadocTag(0, 1, "author", "firstArg"); - String result = javadocTag.toString(); + final String result = javadocTag.toString(); assertEquals("JavadocTag{tag='author' lineNo=0, columnNo=1, firstArg='firstArg'}", result); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocTypeCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocTypeCheckTest.java index 548f9efa2..0a692c335 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocTypeCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocTypeCheckTest.java @@ -49,8 +49,8 @@ public class JavadocTypeCheckTest extends BaseCheckTestSupport { @Test public void testGetRequiredTokens() { - JavadocTypeCheck javadocTypeCheck = new JavadocTypeCheck(); - int[] expected = { + final JavadocTypeCheck javadocTypeCheck = new JavadocTypeCheck(); + final int[] expected = { TokenTypes.INTERFACE_DEF, TokenTypes.CLASS_DEF, TokenTypes.ENUM_DEF, @@ -61,10 +61,10 @@ public class JavadocTypeCheckTest extends BaseCheckTestSupport { @Test public void testGetAcceptableTokens() { - JavadocTypeCheck javadocTypeCheck = new JavadocTypeCheck(); + final JavadocTypeCheck javadocTypeCheck = new JavadocTypeCheck(); - int[] actual = javadocTypeCheck.getAcceptableTokens(); - int[] expected = { + final int[] actual = javadocTypeCheck.getAcceptableTokens(); + final int[] expected = { TokenTypes.INTERFACE_DEF, TokenTypes.CLASS_DEF, TokenTypes.ENUM_DEF, diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocVariableCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocVariableCheckTest.java index 9527f62b6..1d06898b9 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocVariableCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocVariableCheckTest.java @@ -43,9 +43,9 @@ public class JavadocVariableCheckTest @Test public void testGetRequiredTokens() { - JavadocVariableCheck javadocVariableCheck = new JavadocVariableCheck(); - int[] actual = javadocVariableCheck.getRequiredTokens(); - int[] expected = { + final JavadocVariableCheck javadocVariableCheck = new JavadocVariableCheck(); + final int[] actual = javadocVariableCheck.getRequiredTokens(); + final int[] expected = { TokenTypes.VARIABLE_DEF, }; assertArrayEquals(expected, actual); @@ -53,10 +53,10 @@ public class JavadocVariableCheckTest @Test public void testGetAcceptableTokens() { - JavadocVariableCheck javadocVariableCheck = new JavadocVariableCheck(); + final JavadocVariableCheck javadocVariableCheck = new JavadocVariableCheck(); - int[] actual = javadocVariableCheck.getAcceptableTokens(); - int[] expected = { + final int[] actual = javadocVariableCheck.getAcceptableTokens(); + final int[] expected = { TokenTypes.VARIABLE_DEF, TokenTypes.ENUM_CONSTANT_DEF, }; diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/NonEmptyAtclauseDescriptionCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/NonEmptyAtclauseDescriptionCheckTest.java index c968d314f..40fd39a92 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/NonEmptyAtclauseDescriptionCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/NonEmptyAtclauseDescriptionCheckTest.java @@ -41,17 +41,17 @@ public class NonEmptyAtclauseDescriptionCheckTest @Test public void testGetAcceptableTokens() { - NonEmptyAtclauseDescriptionCheck checkObj = + final NonEmptyAtclauseDescriptionCheck checkObj = new NonEmptyAtclauseDescriptionCheck(); - int[] expected = {TokenTypes.BLOCK_COMMENT_BEGIN}; + final int[] expected = {TokenTypes.BLOCK_COMMENT_BEGIN}; assertArrayEquals(expected, checkObj.getAcceptableTokens()); } @Test public void testGetRequiredTokens() { - NonEmptyAtclauseDescriptionCheck checkObj = + final NonEmptyAtclauseDescriptionCheck checkObj = new NonEmptyAtclauseDescriptionCheck(); - int[] expected = {TokenTypes.BLOCK_COMMENT_BEGIN}; + final int[] expected = {TokenTypes.BLOCK_COMMENT_BEGIN}; assertArrayEquals(expected, checkObj.getRequiredTokens()); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/SingleLineJavadocCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/SingleLineJavadocCheckTest.java index 33c9eb56b..3853003b9 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/SingleLineJavadocCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/SingleLineJavadocCheckTest.java @@ -40,15 +40,15 @@ public class SingleLineJavadocCheckTest extends BaseCheckTestSupport { @Test public void testAcceptableTokens() { - SingleLineJavadocCheck checkObj = new SingleLineJavadocCheck(); - int[] expected = {TokenTypes.BLOCK_COMMENT_BEGIN }; + final SingleLineJavadocCheck checkObj = new SingleLineJavadocCheck(); + final int[] expected = {TokenTypes.BLOCK_COMMENT_BEGIN }; assertArrayEquals(expected, checkObj.getAcceptableTokens()); } @Test public void testGetRequiredTokens() { - SingleLineJavadocCheck checkObj = new SingleLineJavadocCheck(); - int[] expected = {TokenTypes.BLOCK_COMMENT_BEGIN }; + final SingleLineJavadocCheck checkObj = new SingleLineJavadocCheck(); + final int[] expected = {TokenTypes.BLOCK_COMMENT_BEGIN }; assertArrayEquals(expected, checkObj.getRequiredTokens()); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/SummaryJavadocCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/SummaryJavadocCheckTest.java index 600056629..dd7ef3eeb 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/SummaryJavadocCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/javadoc/SummaryJavadocCheckTest.java @@ -50,8 +50,8 @@ public class SummaryJavadocCheckTest extends BaseCheckTestSupport { @Test public void testGetRequiredTokens() { - SummaryJavadocCheck checkObj = new SummaryJavadocCheck(); - int[] expected = {TokenTypes.BLOCK_COMMENT_BEGIN }; + final SummaryJavadocCheck checkObj = new SummaryJavadocCheck(); + final int[] expected = {TokenTypes.BLOCK_COMMENT_BEGIN }; assertArrayEquals(expected, checkObj.getRequiredTokens()); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/metrics/BooleanExpressionComplexityCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/metrics/BooleanExpressionComplexityCheckTest.java index f969705ea..10cb79d0a 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/metrics/BooleanExpressionComplexityCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/metrics/BooleanExpressionComplexityCheckTest.java @@ -43,10 +43,10 @@ public class BooleanExpressionComplexityCheckTest extends BaseCheckTestSupport { @Test public void test() throws Exception { - DefaultConfiguration checkConfig = + final DefaultConfiguration checkConfig = createCheckConfig(BooleanExpressionComplexityCheck.class); - String[] expected = { + final String[] expected = { "13:9: " + getCheckMessage(MSG_KEY, 4, 3), "32:9: " + getCheckMessage(MSG_KEY, 6, 3), "38:34: " + getCheckMessage(MSG_KEY, 4, 3), @@ -58,31 +58,31 @@ public class BooleanExpressionComplexityCheckTest extends BaseCheckTestSupport { @Test public void testNoBitwise() throws Exception { - DefaultConfiguration checkConfig = + final DefaultConfiguration checkConfig = createCheckConfig(BooleanExpressionComplexityCheck.class); checkConfig.addAttribute("max", "5"); checkConfig.addAttribute("tokens", "BXOR,LAND,LOR"); - String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; + final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; verify(checkConfig, getPath("InputBooleanExpressionComplexity.java"), expected); } @Test public void testNPE() throws Exception { - DefaultConfiguration checkConfig = + final DefaultConfiguration checkConfig = createCheckConfig(BooleanExpressionComplexityCheck.class); - String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; + final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; verify(checkConfig, getPath("InputBooleanExpressionComplexityNPE.java"), expected); } @Test(expected = IllegalArgumentException.class) public void testWrongToken() { - BooleanExpressionComplexityCheck booleanExpressionComplexityCheckObj = + final BooleanExpressionComplexityCheck booleanExpressionComplexityCheckObj = new BooleanExpressionComplexityCheck(); - DetailAST ast = new DetailAST(); + final DetailAST ast = new DetailAST(); ast.initialize(new CommonHiddenStreamToken(TokenTypes.INTERFACE_DEF, "interface")); booleanExpressionComplexityCheckObj.visitToken(ast); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/metrics/ClassDataAbstractionCouplingCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/metrics/ClassDataAbstractionCouplingCheckTest.java index 95e7ed69b..2ae560d62 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/metrics/ClassDataAbstractionCouplingCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/metrics/ClassDataAbstractionCouplingCheckTest.java @@ -43,13 +43,13 @@ public class ClassDataAbstractionCouplingCheckTest extends BaseCheckTestSupport @Test public void test() throws Exception { - DefaultConfiguration checkConfig = + final DefaultConfiguration checkConfig = createCheckConfig(ClassDataAbstractionCouplingCheck.class); checkConfig.addAttribute("max", "0"); checkConfig.addAttribute("excludedClasses", "InnerClass"); - String[] expected = { + final String[] expected = { "6:1: " + getCheckMessage(MSG_KEY, 4, 0, "[AnotherInnerClass, HashMap, HashSet, int]"), "7:5: " + getCheckMessage(MSG_KEY, 1, 0, "[ArrayList]"), "27:1: " + getCheckMessage(MSG_KEY, 2, 0, "[HashMap, HashSet]"), @@ -60,9 +60,9 @@ public class ClassDataAbstractionCouplingCheckTest extends BaseCheckTestSupport @Test public void testDefaultConfiguration() throws Exception { - DefaultConfiguration checkConfig = + final DefaultConfiguration checkConfig = createCheckConfig(ClassDataAbstractionCouplingCheck.class); - String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; + final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; createChecker(checkConfig); verify(checkConfig, getPath("InputClassCoupling.java"), expected); @@ -70,9 +70,9 @@ public class ClassDataAbstractionCouplingCheckTest extends BaseCheckTestSupport @Test(expected = IllegalArgumentException.class) public void testWrongToken() { - ClassDataAbstractionCouplingCheck classDataAbstractionCouplingCheckObj = + final ClassDataAbstractionCouplingCheck classDataAbstractionCouplingCheckObj = new ClassDataAbstractionCouplingCheck(); - DetailAST ast = new DetailAST(); + final DetailAST ast = new DetailAST(); ast.initialize(new CommonHiddenStreamToken(TokenTypes.CTOR_DEF, "ctor")); classDataAbstractionCouplingCheckObj.visitToken(ast); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/metrics/ClassFanOutComplexityCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/metrics/ClassFanOutComplexityCheckTest.java index d4a96e31c..9da3096ca 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/metrics/ClassFanOutComplexityCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/metrics/ClassFanOutComplexityCheckTest.java @@ -41,11 +41,12 @@ public class ClassFanOutComplexityCheckTest extends BaseCheckTestSupport { @Test public void test() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(ClassFanOutComplexityCheck.class); + final DefaultConfiguration checkConfig = + createCheckConfig(ClassFanOutComplexityCheck.class); checkConfig.addAttribute("max", "0"); - String[] expected = { + final String[] expected = { "6:1: " + getCheckMessage(MSG_KEY, 3, 0), "38:1: " + getCheckMessage(MSG_KEY, 1, 0), }; @@ -55,20 +56,21 @@ public class ClassFanOutComplexityCheckTest extends BaseCheckTestSupport { @Test public void test15() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(ClassFanOutComplexityCheck.class); + final DefaultConfiguration checkConfig = + createCheckConfig(ClassFanOutComplexityCheck.class); checkConfig.addAttribute("max", "0"); - String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; + final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; verify(checkConfig, getPath("Input15Extensions.java"), expected); } @Test public void testDefaultConfiguration() throws Exception { - DefaultConfiguration checkConfig = + final DefaultConfiguration checkConfig = createCheckConfig(ClassFanOutComplexityCheck.class); - String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; + final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; createChecker(checkConfig); verify(checkConfig, getPath("InputClassCoupling.java"), expected); @@ -76,9 +78,10 @@ public class ClassFanOutComplexityCheckTest extends BaseCheckTestSupport { @Test public void testGetAcceptableTokens() { - ClassFanOutComplexityCheck classFanOutComplexityCheckObj = new ClassFanOutComplexityCheck(); - int[] actual = classFanOutComplexityCheckObj.getAcceptableTokens(); - int[] expected = { + final ClassFanOutComplexityCheck classFanOutComplexityCheckObj = + new ClassFanOutComplexityCheck(); + final int[] actual = classFanOutComplexityCheckObj.getAcceptableTokens(); + final int[] expected = { TokenTypes.PACKAGE_DEF, TokenTypes.CLASS_DEF, TokenTypes.INTERFACE_DEF, diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/metrics/CyclomaticComplexityCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/metrics/CyclomaticComplexityCheckTest.java index 04c589919..05daac583 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/metrics/CyclomaticComplexityCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/metrics/CyclomaticComplexityCheckTest.java @@ -92,9 +92,10 @@ public class CyclomaticComplexityCheckTest @Test public void testGetAcceptableTokens() { - CyclomaticComplexityCheck cyclomaticComplexityCheckObj = new CyclomaticComplexityCheck(); - int[] actual = cyclomaticComplexityCheckObj.getAcceptableTokens(); - int[] expected = { + final CyclomaticComplexityCheck cyclomaticComplexityCheckObj = + new CyclomaticComplexityCheck(); + final int[] actual = cyclomaticComplexityCheckObj.getAcceptableTokens(); + final int[] expected = { TokenTypes.CTOR_DEF, TokenTypes.METHOD_DEF, TokenTypes.INSTANCE_INIT, diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/metrics/JavaNCSSCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/metrics/JavaNCSSCheckTest.java index f491be692..8037525ea 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/metrics/JavaNCSSCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/metrics/JavaNCSSCheckTest.java @@ -48,13 +48,13 @@ public class JavaNCSSCheckTest extends BaseCheckTestSupport { @Test public void test() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(JavaNCSSCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(JavaNCSSCheck.class); checkConfig.addAttribute("methodMaximum", "0"); checkConfig.addAttribute("classMaximum", "1"); checkConfig.addAttribute("fileMaximum", "2"); - String[] expected = { + final String[] expected = { "2:1: " + getCheckMessage(MSG_FILE, 39, 2), "9:1: " + getCheckMessage(MSG_CLASS, 22, 1), "14:5: " + getCheckMessage(MSG_METHOD, 2, 0), @@ -75,8 +75,8 @@ public class JavaNCSSCheckTest extends BaseCheckTestSupport { @Test public void testDefaultConfiguration() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(JavaNCSSCheck.class); - String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; + final DefaultConfiguration checkConfig = createCheckConfig(JavaNCSSCheck.class); + final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; createChecker(checkConfig); verify(checkConfig, getPath("InputJavaNCSS.java"), expected); @@ -84,9 +84,9 @@ public class JavaNCSSCheckTest extends BaseCheckTestSupport { @Test public void testGetAcceptableTokens() { - JavaNCSSCheck javaNcssCheckObj = new JavaNCSSCheck(); - int[] actual = javaNcssCheckObj.getAcceptableTokens(); - int[] expected = { + final JavaNCSSCheck javaNcssCheckObj = new JavaNCSSCheck(); + final int[] actual = javaNcssCheckObj.getAcceptableTokens(); + final int[] expected = { TokenTypes.CLASS_DEF, TokenTypes.INTERFACE_DEF, TokenTypes.METHOD_DEF, @@ -122,9 +122,9 @@ public class JavaNCSSCheckTest extends BaseCheckTestSupport { @Test public void testGetRequiredTokens() { - JavaNCSSCheck javaNcssCheckObj = new JavaNCSSCheck(); - int[] actual = javaNcssCheckObj.getRequiredTokens(); - int[] expected = { + final JavaNCSSCheck javaNcssCheckObj = new JavaNCSSCheck(); + final int[] actual = javaNcssCheckObj.getRequiredTokens(); + final int[] expected = { TokenTypes.CLASS_DEF, TokenTypes.INTERFACE_DEF, TokenTypes.METHOD_DEF, diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/metrics/NPathComplexityCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/metrics/NPathComplexityCheckTest.java index f7b8d3f2d..105781899 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/metrics/NPathComplexityCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/metrics/NPathComplexityCheckTest.java @@ -44,11 +44,11 @@ public class NPathComplexityCheckTest extends BaseCheckTestSupport { @Test public void testCalculation() throws Exception { - DefaultConfiguration checkConfig = + final DefaultConfiguration checkConfig = createCheckConfig(NPathComplexityCheck.class); checkConfig.addAttribute("max", "0"); - String[] expected = { + final String[] expected = { "4:5: " + getCheckMessage(MSG_KEY, 2, 0), "7:17: " + getCheckMessage(MSG_KEY, 2, 0), "17:5: " + getCheckMessage(MSG_KEY, 5, 0), @@ -66,14 +66,14 @@ public class NPathComplexityCheckTest extends BaseCheckTestSupport { @Test public void testIntegerOverflow() throws Exception { - DefaultConfiguration checkConfig = + final DefaultConfiguration checkConfig = createCheckConfig(NPathComplexityCheck.class); checkConfig.addAttribute("max", "0"); final long largerThanMaxInt = 3486784401L; - String[] expected = { + final String[] expected = { "9:5: " + getCheckMessage(MSG_KEY, largerThanMaxInt, 0), }; @@ -82,9 +82,9 @@ public class NPathComplexityCheckTest extends BaseCheckTestSupport { @Test public void testDefaultConfiguration() throws Exception { - DefaultConfiguration checkConfig = + final DefaultConfiguration checkConfig = createCheckConfig(NPathComplexityCheck.class); - String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; + final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; createChecker(checkConfig); verify(checkConfig, getPath("InputComplexity.java"), expected); @@ -92,9 +92,9 @@ public class NPathComplexityCheckTest extends BaseCheckTestSupport { @Test public void testGetAcceptableTokens() { - NPathComplexityCheck npathComplexityCheckObj = new NPathComplexityCheck(); - int[] actual = npathComplexityCheckObj.getAcceptableTokens(); - int[] expected = { + final NPathComplexityCheck npathComplexityCheckObj = new NPathComplexityCheck(); + final int[] actual = npathComplexityCheckObj.getAcceptableTokens(); + final int[] expected = { TokenTypes.CTOR_DEF, TokenTypes.METHOD_DEF, TokenTypes.STATIC_INIT, @@ -116,9 +116,9 @@ public class NPathComplexityCheckTest extends BaseCheckTestSupport { @Test public void testGetRequiredTokens() { - NPathComplexityCheck npathComplexityCheckObj = new NPathComplexityCheck(); - int[] actual = npathComplexityCheckObj.getRequiredTokens(); - int[] expected = { + final NPathComplexityCheck npathComplexityCheckObj = new NPathComplexityCheck(); + final int[] actual = npathComplexityCheckObj.getRequiredTokens(); + final int[] expected = { TokenTypes.CTOR_DEF, TokenTypes.METHOD_DEF, TokenTypes.INSTANCE_INIT, @@ -130,8 +130,8 @@ public class NPathComplexityCheckTest extends BaseCheckTestSupport { @Test public void testDefaultHooks() { - NPathComplexityCheck npathComplexityCheckObj = new NPathComplexityCheck(); - DetailAST ast = new DetailAST(); + final NPathComplexityCheck npathComplexityCheckObj = new NPathComplexityCheck(); + final DetailAST ast = new DetailAST(); ast.initialize(new CommonHiddenStreamToken(TokenTypes.INTERFACE_DEF, "interface")); npathComplexityCheckObj.visitToken(ast); npathComplexityCheckObj.leaveToken(ast); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/modifier/ModifierOrderCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/modifier/ModifierOrderCheckTest.java index b26cb1903..ee3fb59f1 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/modifier/ModifierOrderCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/modifier/ModifierOrderCheckTest.java @@ -50,8 +50,8 @@ public class ModifierOrderCheckTest @Test public void testGetRequiredTokens() { - ModifierOrderCheck checkObj = new ModifierOrderCheck(); - int[] expected = {TokenTypes.MODIFIERS}; + final ModifierOrderCheck checkObj = new ModifierOrderCheck(); + final int[] expected = {TokenTypes.MODIFIERS}; assertArrayEquals(expected, checkObj.getRequiredTokens()); } @@ -81,11 +81,11 @@ public class ModifierOrderCheckTest @Test public void testGetDefaultTokens() { - ModifierOrderCheck modifierOrderCheckObj = new ModifierOrderCheck(); - int[] actual = modifierOrderCheckObj.getDefaultTokens(); - int[] expected = {TokenTypes.MODIFIERS}; - int[] unexpectedEmptyArray = ArrayUtils.EMPTY_INT_ARRAY; - int[] unexpectedArray = { + final ModifierOrderCheck modifierOrderCheckObj = new ModifierOrderCheck(); + final int[] actual = modifierOrderCheckObj.getDefaultTokens(); + final int[] expected = {TokenTypes.MODIFIERS}; + final int[] unexpectedEmptyArray = ArrayUtils.EMPTY_INT_ARRAY; + final int[] unexpectedArray = { TokenTypes.MODIFIERS, TokenTypes.OBJBLOCK, }; @@ -97,11 +97,11 @@ public class ModifierOrderCheckTest @Test public void testGetAcceptableTokens() { - ModifierOrderCheck modifierOrderCheckObj = new ModifierOrderCheck(); - int[] actual = modifierOrderCheckObj.getAcceptableTokens(); - int[] expected = {TokenTypes.MODIFIERS}; - int[] unexpectedEmptyArray = ArrayUtils.EMPTY_INT_ARRAY; - int[] unexpectedArray = { + final ModifierOrderCheck modifierOrderCheckObj = new ModifierOrderCheck(); + final int[] actual = modifierOrderCheckObj.getAcceptableTokens(); + final int[] expected = {TokenTypes.MODIFIERS}; + final int[] unexpectedEmptyArray = ArrayUtils.EMPTY_INT_ARRAY; + final int[] unexpectedArray = { TokenTypes.MODIFIERS, TokenTypes.OBJBLOCK, }; diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/modifier/RedundantModifierTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/modifier/RedundantModifierTest.java index b46937427..217899ceb 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/modifier/RedundantModifierTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/modifier/RedundantModifierTest.java @@ -154,9 +154,9 @@ public class RedundantModifierTest @Test public void testGetAcceptableTokens() { - RedundantModifierCheck redundantModifierCheckObj = new RedundantModifierCheck(); - int[] actual = redundantModifierCheckObj.getAcceptableTokens(); - int[] expected = { + final RedundantModifierCheck redundantModifierCheckObj = new RedundantModifierCheck(); + final int[] actual = redundantModifierCheckObj.getAcceptableTokens(); + final int[] expected = { TokenTypes.METHOD_DEF, TokenTypes.VARIABLE_DEF, TokenTypes.ANNOTATION_FIELD_DEF, @@ -170,9 +170,9 @@ public class RedundantModifierTest @Test public void testGetRequiredTokens() { - RedundantModifierCheck redundantModifierCheckObj = new RedundantModifierCheck(); - int[] actual = redundantModifierCheckObj.getRequiredTokens(); - int[] expected = ArrayUtils.EMPTY_INT_ARRAY; + final RedundantModifierCheck redundantModifierCheckObj = new RedundantModifierCheck(); + final int[] actual = redundantModifierCheckObj.getRequiredTokens(); + final int[] expected = ArrayUtils.EMPTY_INT_ARRAY; Assert.assertArrayEquals(expected, actual); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/AbstractClassNameCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/AbstractClassNameCheckTest.java index 8e1d3bed8..549d4659f 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/AbstractClassNameCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/AbstractClassNameCheckTest.java @@ -107,9 +107,9 @@ public class AbstractClassNameCheckTest extends BaseCheckTestSupport { @Test public void testGetAcceptableTokens() { - AbstractClassNameCheck classNameCheckObj = new AbstractClassNameCheck(); - int[] actual = classNameCheckObj.getAcceptableTokens(); - int[] expected = { + final AbstractClassNameCheck classNameCheckObj = new AbstractClassNameCheck(); + final int[] actual = classNameCheckObj.getAcceptableTokens(); + final int[] expected = { TokenTypes.CLASS_DEF, }; Assert.assertArrayEquals(expected, actual); @@ -117,9 +117,9 @@ public class AbstractClassNameCheckTest extends BaseCheckTestSupport { @Test public void testGetRequiredTokens() { - AbstractClassNameCheck classNameCheckObj = new AbstractClassNameCheck(); - int[] actual = classNameCheckObj.getRequiredTokens(); - int[] expected = { + final AbstractClassNameCheck classNameCheckObj = new AbstractClassNameCheck(); + final int[] actual = classNameCheckObj.getRequiredTokens(); + final int[] expected = { TokenTypes.CLASS_DEF, }; Assert.assertArrayEquals(expected, actual); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/ConstantNameCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/ConstantNameCheckTest.java index 1da9576aa..ea111de47 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/ConstantNameCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/ConstantNameCheckTest.java @@ -52,8 +52,8 @@ public class ConstantNameCheckTest @Test public void testGetRequiredTokens() { - ConstantNameCheck checkObj = new ConstantNameCheck(); - int[] expected = {TokenTypes.VARIABLE_DEF}; + final ConstantNameCheck checkObj = new ConstantNameCheck(); + final int[] expected = {TokenTypes.VARIABLE_DEF}; assertArrayEquals(expected, checkObj.getRequiredTokens()); } @@ -163,9 +163,9 @@ public class ConstantNameCheckTest @Test public void testGetAcceptableTokens() { - ConstantNameCheck constantNameCheckObj = new ConstantNameCheck(); - int[] actual = constantNameCheckObj.getAcceptableTokens(); - int[] expected = { + final ConstantNameCheck constantNameCheckObj = new ConstantNameCheck(); + final int[] actual = constantNameCheckObj.getAcceptableTokens(); + final int[] expected = { TokenTypes.VARIABLE_DEF, }; Assert.assertNotNull(actual); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/LocalFinalVariableNameCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/LocalFinalVariableNameCheckTest.java index 0cdd41564..e2c3da567 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/LocalFinalVariableNameCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/LocalFinalVariableNameCheckTest.java @@ -42,7 +42,7 @@ public class LocalFinalVariableNameCheckTest @Test public void testGetRequiredTokens() { - LocalFinalVariableNameCheck checkObj = + final LocalFinalVariableNameCheck checkObj = new LocalFinalVariableNameCheck(); assertArrayEquals(ArrayUtils.EMPTY_INT_ARRAY, checkObj.getRequiredTokens()); } @@ -87,10 +87,10 @@ public class LocalFinalVariableNameCheckTest @Test public void testGetAcceptableTokens() { - LocalFinalVariableNameCheck localFinalVariableNameCheckObj = + final LocalFinalVariableNameCheck localFinalVariableNameCheckObj = new LocalFinalVariableNameCheck(); - int[] actual = localFinalVariableNameCheckObj.getAcceptableTokens(); - int[] expected = { + final int[] actual = localFinalVariableNameCheckObj.getAcceptableTokens(); + final int[] expected = { TokenTypes.VARIABLE_DEF, TokenTypes.PARAMETER_DEF, }; diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/MemberNameCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/MemberNameCheckTest.java index e3858a035..3d282ef59 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/MemberNameCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/MemberNameCheckTest.java @@ -41,8 +41,8 @@ public class MemberNameCheckTest @Test public void testGetRequiredTokens() { - MemberNameCheck checkObj = new MemberNameCheck(); - int[] expected = {TokenTypes.VARIABLE_DEF}; + final MemberNameCheck checkObj = new MemberNameCheck(); + final int[] expected = {TokenTypes.VARIABLE_DEF}; assertArrayEquals(expected, checkObj.getRequiredTokens()); } @@ -240,9 +240,9 @@ public class MemberNameCheckTest @Test public void testGetAcceptableTokens() { - MemberNameCheck memberNameCheckObj = new MemberNameCheck(); - int[] actual = memberNameCheckObj.getAcceptableTokens(); - int[] expected = { + final MemberNameCheck memberNameCheckObj = new MemberNameCheck(); + final int[] actual = memberNameCheckObj.getAcceptableTokens(); + final int[] expected = { TokenTypes.VARIABLE_DEF, }; assertArrayEquals(expected, actual); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/MethodNameCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/MethodNameCheckTest.java index 490de90c9..2440f8850 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/MethodNameCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/MethodNameCheckTest.java @@ -43,8 +43,8 @@ public class MethodNameCheckTest @Test public void testGetRequiredTokens() { - MethodNameCheck checkObj = new MethodNameCheck(); - int[] expected = {TokenTypes.METHOD_DEF}; + final MethodNameCheck checkObj = new MethodNameCheck(); + final int[] expected = {TokenTypes.METHOD_DEF}; assertArrayEquals(expected, checkObj.getRequiredTokens()); } @@ -164,9 +164,9 @@ public class MethodNameCheckTest @Test public void testGetAcceptableTokens() { - MethodNameCheck methodNameCheckObj = new MethodNameCheck(); - int[] actual = methodNameCheckObj.getAcceptableTokens(); - int[] expected = { + final MethodNameCheck methodNameCheckObj = new MethodNameCheck(); + final int[] actual = methodNameCheckObj.getAcceptableTokens(); + final int[] expected = { TokenTypes.METHOD_DEF, }; assertArrayEquals(expected, actual); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/PackageNameCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/PackageNameCheckTest.java index 88171e4e1..1a76279c0 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/PackageNameCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/PackageNameCheckTest.java @@ -42,8 +42,8 @@ public class PackageNameCheckTest @Test public void testGetRequiredTokens() { - PackageNameCheck checkObj = new PackageNameCheck(); - int[] expected = {TokenTypes.PACKAGE_DEF}; + final PackageNameCheck checkObj = new PackageNameCheck(); + final int[] expected = {TokenTypes.PACKAGE_DEF}; assertArrayEquals(expected, checkObj.getRequiredTokens()); } @@ -74,9 +74,9 @@ public class PackageNameCheckTest @Test public void testGetAcceptableTokens() { - PackageNameCheck packageNameCheckObj = new PackageNameCheck(); - int[] actual = packageNameCheckObj.getAcceptableTokens(); - int[] expected = { + final PackageNameCheck packageNameCheckObj = new PackageNameCheck(); + final int[] actual = packageNameCheckObj.getAcceptableTokens(); + final int[] expected = { TokenTypes.PACKAGE_DEF, }; assertArrayEquals(expected, actual); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/ParameterNameCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/ParameterNameCheckTest.java index 65c623aa2..c0bbc3860 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/ParameterNameCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/ParameterNameCheckTest.java @@ -42,8 +42,8 @@ public class ParameterNameCheckTest @Test public void testGetRequiredTokens() { - ParameterNameCheck checkObj = new ParameterNameCheck(); - int[] expected = {TokenTypes.PARAMETER_DEF}; + final ParameterNameCheck checkObj = new ParameterNameCheck(); + final int[] expected = {TokenTypes.PARAMETER_DEF}; assertArrayEquals(expected, checkObj.getRequiredTokens()); } @@ -85,9 +85,9 @@ public class ParameterNameCheckTest @Test public void testGetAcceptableTokens() { - ParameterNameCheck parameterNameCheckObj = new ParameterNameCheck(); - int[] actual = parameterNameCheckObj.getAcceptableTokens(); - int[] expected = { + final ParameterNameCheck parameterNameCheckObj = new ParameterNameCheck(); + final int[] actual = parameterNameCheckObj.getAcceptableTokens(); + final int[] expected = { TokenTypes.PARAMETER_DEF, }; assertArrayEquals(expected, actual); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/StaticVariableNameCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/StaticVariableNameCheckTest.java index fa33f5edf..f029830f2 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/StaticVariableNameCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/StaticVariableNameCheckTest.java @@ -42,8 +42,8 @@ public class StaticVariableNameCheckTest @Test public void testGetRequiredTokens() { - StaticVariableNameCheck checkObj = new StaticVariableNameCheck(); - int[] expected = {TokenTypes.VARIABLE_DEF}; + final StaticVariableNameCheck checkObj = new StaticVariableNameCheck(); + final int[] expected = {TokenTypes.VARIABLE_DEF}; assertArrayEquals(expected, checkObj.getRequiredTokens()); } @@ -87,9 +87,9 @@ public class StaticVariableNameCheckTest @Test public void testGetAcceptableTokens() { - StaticVariableNameCheck staticVariableNameCheckObj = new StaticVariableNameCheck(); - int[] actual = staticVariableNameCheckObj.getAcceptableTokens(); - int[] expected = { + final StaticVariableNameCheck staticVariableNameCheckObj = new StaticVariableNameCheck(); + final int[] actual = staticVariableNameCheckObj.getAcceptableTokens(); + final int[] expected = { TokenTypes.VARIABLE_DEF, }; assertArrayEquals(expected, actual); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/TypeParameterNameTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/TypeParameterNameTest.java index ec758496b..2aa2133a9 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/TypeParameterNameTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/TypeParameterNameTest.java @@ -41,25 +41,25 @@ public class TypeParameterNameTest @Test public void testGetInterfaceRequiredTokens() { - InterfaceTypeParameterNameCheck checkObj = + final InterfaceTypeParameterNameCheck checkObj = new InterfaceTypeParameterNameCheck(); - int[] expected = {TokenTypes.TYPE_PARAMETER}; + final int[] expected = {TokenTypes.TYPE_PARAMETER}; assertArrayEquals(expected, checkObj.getRequiredTokens()); } @Test public void testGetMethodRequiredTokens() { - MethodTypeParameterNameCheck checkObj = + final MethodTypeParameterNameCheck checkObj = new MethodTypeParameterNameCheck(); - int[] expected = {TokenTypes.TYPE_PARAMETER}; + final int[] expected = {TokenTypes.TYPE_PARAMETER}; assertArrayEquals(expected, checkObj.getRequiredTokens()); } @Test public void testGetClassRequiredTokens() { - ClassTypeParameterNameCheck checkObj = + final ClassTypeParameterNameCheck checkObj = new ClassTypeParameterNameCheck(); - int[] expected = {TokenTypes.TYPE_PARAMETER}; + final int[] expected = {TokenTypes.TYPE_PARAMETER}; assertArrayEquals(expected, checkObj.getRequiredTokens()); } @@ -166,10 +166,10 @@ public class TypeParameterNameTest @Test public void testGetAcceptableTokens() { - AbstractTypeParameterNameCheck typeParameterNameCheckObj = + final AbstractTypeParameterNameCheck typeParameterNameCheckObj = new ClassTypeParameterNameCheck(); - int[] actual = typeParameterNameCheckObj.getAcceptableTokens(); - int[] expected = { + final int[] actual = typeParameterNameCheckObj.getAcceptableTokens(); + final int[] expected = { TokenTypes.TYPE_PARAMETER, }; assertArrayEquals(expected, actual); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/regexp/RegexpCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/regexp/RegexpCheckTest.java index 7f40212cf..25c83bd52 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/regexp/RegexpCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/regexp/RegexpCheckTest.java @@ -42,7 +42,7 @@ public class RegexpCheckTest extends BaseCheckTestSupport { @Test public void testGetRequiredTokens() { - RegexpCheck checkObj = new RegexpCheck(); + final RegexpCheck checkObj = new RegexpCheck(); assertArrayEquals(ArrayUtils.EMPTY_INT_ARRAY, checkObj.getRequiredTokens()); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/regexp/RegexpMultilineCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/regexp/RegexpMultilineCheckTest.java index 7413351a9..21cc8661f 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/regexp/RegexpMultilineCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/regexp/RegexpMultilineCheckTest.java @@ -174,7 +174,7 @@ public class RegexpMultilineCheckTest extends BaseFileSetCheckTestSupport { // now needs 10'000 or 100'000, as just 1000 is no longer enough today to provoke the // StackOverflowError final int size = 100000; - StringBuffer largeString = new StringBuffer(size); + final StringBuffer largeString = new StringBuffer(size); for (int i = 0; i < size / 2; i++) { largeString.append("xy"); } @@ -188,7 +188,7 @@ public class RegexpMultilineCheckTest extends BaseFileSetCheckTestSupport { checkConfig.addAttribute("minimum", "500"); checkConfig.addAttribute("message", "someMessage"); - String[] expected = new String[223]; + final String[] expected = new String[223]; for (int i = 0; i < 223; i++) { expected[i] = i + ": someMessage"; } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/regexp/RegexpSinglelineJavaCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/regexp/RegexpSinglelineJavaCheckTest.java index e9a6facf0..68f48a3b4 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/regexp/RegexpSinglelineJavaCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/regexp/RegexpSinglelineJavaCheckTest.java @@ -49,7 +49,7 @@ public class RegexpSinglelineJavaCheckTest extends BaseCheckTestSupport { @Test public void testGetRequiredTokens() { - RegexpSinglelineJavaCheck checkObj = new RegexpSinglelineJavaCheck(); + final RegexpSinglelineJavaCheck checkObj = new RegexpSinglelineJavaCheck(); assertArrayEquals(ArrayUtils.EMPTY_INT_ARRAY, checkObj.getRequiredTokens()); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/AnonInnerLengthCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/AnonInnerLengthCheckTest.java index b79ab58bb..60cc7c2cc 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/AnonInnerLengthCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/AnonInnerLengthCheckTest.java @@ -45,17 +45,17 @@ public class AnonInnerLengthCheckTest extends BaseCheckTestSupport { @Test public void testGetRequiredTokens() { - AnonInnerLengthCheck checkObj = new AnonInnerLengthCheck(); - int[] expected = {TokenTypes.LITERAL_NEW}; + final AnonInnerLengthCheck checkObj = new AnonInnerLengthCheck(); + final int[] expected = {TokenTypes.LITERAL_NEW}; assertArrayEquals(expected, checkObj.getRequiredTokens()); } @Test public void testGetAcceptableTokens() { - AnonInnerLengthCheck anonInnerLengthCheckObj = + final AnonInnerLengthCheck anonInnerLengthCheckObj = new AnonInnerLengthCheck(); - int[] actual = anonInnerLengthCheckObj.getAcceptableTokens(); - int[] expected = {TokenTypes.LITERAL_NEW}; + final int[] actual = anonInnerLengthCheckObj.getAcceptableTokens(); + final int[] expected = {TokenTypes.LITERAL_NEW}; assertArrayEquals(expected, actual); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/ExecutableStatementCountCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/ExecutableStatementCountCheckTest.java index 06baf2202..36a80429b 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/ExecutableStatementCountCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/ExecutableStatementCountCheckTest.java @@ -133,9 +133,9 @@ public class ExecutableStatementCountCheckTest @Test(expected = IllegalStateException.class) public void testVisitTokenWithWrongTokenType() { - ExecutableStatementCountCheck checkObj = + final ExecutableStatementCountCheck checkObj = new ExecutableStatementCountCheck(); - DetailAST ast = new DetailAST(); + final DetailAST ast = new DetailAST(); ast.initialize( new CommonHiddenStreamToken(TokenTypes.ENUM, "ENUM")); checkObj.visitToken(ast); @@ -143,9 +143,9 @@ public class ExecutableStatementCountCheckTest @Test(expected = IllegalStateException.class) public void testLeaveTokenWithWrongTokenType() { - ExecutableStatementCountCheck checkObj = + final ExecutableStatementCountCheck checkObj = new ExecutableStatementCountCheck(); - DetailAST ast = new DetailAST(); + final DetailAST ast = new DetailAST(); ast.initialize( new CommonHiddenStreamToken(TokenTypes.ENUM, "ENUM")); checkObj.leaveToken(ast); @@ -153,9 +153,9 @@ public class ExecutableStatementCountCheckTest @Test public void testDefaultConfiguration() throws Exception { - DefaultConfiguration checkConfig = + final DefaultConfiguration checkConfig = createCheckConfig(ExecutableStatementCountCheck.class); - String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; + final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; createChecker(checkConfig); verify(checkConfig, getPath("InputExecutableStatementCount.java"), expected); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/FileLengthCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/FileLengthCheckTest.java index dcdb05950..5ac015b51 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/FileLengthCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/FileLengthCheckTest.java @@ -45,14 +45,14 @@ public class FileLengthCheckTest @Override protected DefaultConfiguration createCheckerConfig( Configuration config) { - DefaultConfiguration dc = new DefaultConfiguration("root"); + final DefaultConfiguration dc = new DefaultConfiguration("root"); dc.addChild(config); return dc; } @Test public void testAlarm() throws Exception { - DefaultConfiguration checkConfig = + final DefaultConfiguration checkConfig = createCheckConfig(FileLengthCheck.class); checkConfig.addAttribute("max", "20"); final String[] expected = { @@ -65,7 +65,7 @@ public class FileLengthCheckTest @Test public void testOK() throws Exception { - DefaultConfiguration checkConfig = + final DefaultConfiguration checkConfig = createCheckConfig(FileLengthCheck.class); checkConfig.addAttribute("max", "2000"); final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; @@ -95,7 +95,7 @@ public class FileLengthCheckTest @Test public void testNoAlarmByExtension() throws Exception { - DefaultConfiguration checkConfig = + final DefaultConfiguration checkConfig = createCheckConfig(FileLengthCheck.class); checkConfig.addAttribute("fileExtensions", "txt"); final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; @@ -107,7 +107,7 @@ public class FileLengthCheckTest @Test public void testExtensions() throws Exception { - FileLengthCheck check = new FileLengthCheck(); + final FileLengthCheck check = new FileLengthCheck(); check.setFileExtensions("java"); assertEquals("extension should be the same", ".java", check.getFileExtensions()[0]); check.setFileExtensions(".java"); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/LineLengthCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/LineLengthCheckTest.java index 022e8fbd6..e238856a7 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/LineLengthCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/LineLengthCheckTest.java @@ -40,13 +40,13 @@ public class LineLengthCheckTest extends BaseCheckTestSupport { @Test public void testGetRequiredTokens() { - LineLengthCheck checkObj = new LineLengthCheck(); + final LineLengthCheck checkObj = new LineLengthCheck(); assertArrayEquals(ArrayUtils.EMPTY_INT_ARRAY, checkObj.getRequiredTokens()); } @Test public void testGetAcceptableTokens() { - LineLengthCheck checkObj = new LineLengthCheck(); + final LineLengthCheck checkObj = new LineLengthCheck(); assertArrayEquals(ArrayUtils.EMPTY_INT_ARRAY, checkObj.getAcceptableTokens()); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/MethodCountCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/MethodCountCheckTest.java index 5df38b035..a677f40c8 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/MethodCountCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/MethodCountCheckTest.java @@ -45,17 +45,17 @@ public class MethodCountCheckTest extends BaseCheckTestSupport { @Test public void testGetRequiredTokens() { - MethodCountCheck checkObj = new MethodCountCheck(); - int[] expected = {TokenTypes.METHOD_DEF}; + final MethodCountCheck checkObj = new MethodCountCheck(); + final int[] expected = {TokenTypes.METHOD_DEF}; assertArrayEquals(expected, checkObj.getRequiredTokens()); } @Test public void testGetAcceptableTokens() { - MethodCountCheck methodCountCheckObj = + final MethodCountCheck methodCountCheckObj = new MethodCountCheck(); - int[] actual = methodCountCheckObj.getAcceptableTokens(); - int[] expected = { + final int[] actual = methodCountCheckObj.getAcceptableTokens(); + final int[] expected = { TokenTypes.CLASS_DEF, TokenTypes.ENUM_CONSTANT_DEF, TokenTypes.ENUM_DEF, diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/MethodLengthCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/MethodLengthCheckTest.java index 3cf05f615..8711773ed 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/MethodLengthCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/MethodLengthCheckTest.java @@ -41,16 +41,16 @@ public class MethodLengthCheckTest extends BaseCheckTestSupport { @Test public void testGetRequiredTokens() { - MethodLengthCheck checkObj = new MethodLengthCheck(); + final MethodLengthCheck checkObj = new MethodLengthCheck(); assertArrayEquals(ArrayUtils.EMPTY_INT_ARRAY, checkObj.getRequiredTokens()); } @Test public void testGetAcceptableTokens() { - MethodLengthCheck methodLengthCheckObj = + final MethodLengthCheck methodLengthCheckObj = new MethodLengthCheck(); - int[] actual = methodLengthCheckObj.getAcceptableTokens(); - int[] expected = { + final int[] actual = methodLengthCheckObj.getAcceptableTokens(); + final int[] expected = { TokenTypes.METHOD_DEF, TokenTypes.CTOR_DEF, }; diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/OuterTypeNumberCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/OuterTypeNumberCheckTest.java index 5901edf1b..a1d656429 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/OuterTypeNumberCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/OuterTypeNumberCheckTest.java @@ -41,8 +41,8 @@ public class OuterTypeNumberCheckTest extends BaseCheckTestSupport { @Test public void testGetRequiredTokens() { - OuterTypeNumberCheck checkObj = new OuterTypeNumberCheck(); - int[] expected = { + final OuterTypeNumberCheck checkObj = new OuterTypeNumberCheck(); + final int[] expected = { TokenTypes.CLASS_DEF, TokenTypes.INTERFACE_DEF, TokenTypes.ENUM_DEF, @@ -53,10 +53,10 @@ public class OuterTypeNumberCheckTest extends BaseCheckTestSupport { @Test public void testGetAcceptableTokens() { - OuterTypeNumberCheck outerTypeNumberObj = + final OuterTypeNumberCheck outerTypeNumberObj = new OuterTypeNumberCheck(); - int[] actual = outerTypeNumberObj.getAcceptableTokens(); - int[] expected = { + final int[] actual = outerTypeNumberObj.getAcceptableTokens(); + final int[] expected = { TokenTypes.CLASS_DEF, TokenTypes.INTERFACE_DEF, TokenTypes.ENUM_DEF, TokenTypes.ANNOTATION_DEF, diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/ParameterNumberCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/ParameterNumberCheckTest.java index 84744986f..098b62b30 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/ParameterNumberCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/ParameterNumberCheckTest.java @@ -42,16 +42,16 @@ public class ParameterNumberCheckTest @Test public void testGetRequiredTokens() { - ParameterNumberCheck checkObj = new ParameterNumberCheck(); + final ParameterNumberCheck checkObj = new ParameterNumberCheck(); assertArrayEquals(ArrayUtils.EMPTY_INT_ARRAY, checkObj.getRequiredTokens()); } @Test public void testGetAcceptableTokens() { - ParameterNumberCheck paramNumberCheckObj = + final ParameterNumberCheck paramNumberCheckObj = new ParameterNumberCheck(); - int[] actual = paramNumberCheckObj.getAcceptableTokens(); - int[] expected = { + final int[] actual = paramNumberCheckObj.getAcceptableTokens(); + final int[] expected = { TokenTypes.METHOD_DEF, TokenTypes.CTOR_DEF, }; diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/EmptyForInitializerPadCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/EmptyForInitializerPadCheckTest.java index ca5bd861e..324dc1420 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/EmptyForInitializerPadCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/EmptyForInitializerPadCheckTest.java @@ -51,8 +51,8 @@ public class EmptyForInitializerPadCheckTest @Test public void testGetRequiredTokens() { - EmptyForInitializerPadCheck checkObj = new EmptyForInitializerPadCheck(); - int[] expected = {TokenTypes.FOR_INIT}; + final EmptyForInitializerPadCheck checkObj = new EmptyForInitializerPadCheck(); + final int[] expected = {TokenTypes.FOR_INIT}; assertArrayEquals(expected, checkObj.getRequiredTokens()); } @@ -75,10 +75,10 @@ public class EmptyForInitializerPadCheckTest @Test public void testGetAcceptableTokens() { - EmptyForInitializerPadCheck emptyForInitializerPadCheckObj = + final EmptyForInitializerPadCheck emptyForInitializerPadCheckObj = new EmptyForInitializerPadCheck(); - int[] actual = emptyForInitializerPadCheckObj.getAcceptableTokens(); - int[] expected = { + final int[] actual = emptyForInitializerPadCheckObj.getAcceptableTokens(); + final int[] expected = { TokenTypes.FOR_INIT, }; assertArrayEquals(expected, actual); @@ -90,7 +90,7 @@ public class EmptyForInitializerPadCheckTest */ @Test public void testPadOptionValueOf() { - PadOption option = PadOption.valueOf("NOSPACE"); + final PadOption option = PadOption.valueOf("NOSPACE"); assertEquals(PadOption.NOSPACE, option); } @@ -100,7 +100,7 @@ public class EmptyForInitializerPadCheckTest */ @Test public void testWrapOptionValueOf() { - WrapOption option = WrapOption.valueOf("EOL"); + final WrapOption option = WrapOption.valueOf("EOL"); assertEquals(WrapOption.EOL, option); } } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/EmptyForIteratorPadCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/EmptyForIteratorPadCheckTest.java index 23cfa8b28..4a39ffe52 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/EmptyForIteratorPadCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/EmptyForIteratorPadCheckTest.java @@ -50,8 +50,8 @@ public class EmptyForIteratorPadCheckTest @Test public void testGetRequiredTokens() { - EmptyForIteratorPadCheck checkObj = new EmptyForIteratorPadCheck(); - int[] expected = {TokenTypes.FOR_ITERATOR}; + final EmptyForIteratorPadCheck checkObj = new EmptyForIteratorPadCheck(); + final int[] expected = {TokenTypes.FOR_ITERATOR}; assertArrayEquals(expected, checkObj.getRequiredTokens()); } @@ -76,9 +76,9 @@ public class EmptyForIteratorPadCheckTest @Test public void testGetAcceptableTokens() { - EmptyForIteratorPadCheck emptyForIteratorPadCheckObj = new EmptyForIteratorPadCheck(); - int[] actual = emptyForIteratorPadCheckObj.getAcceptableTokens(); - int[] expected = { + final EmptyForIteratorPadCheck emptyForIteratorPadCheckObj = new EmptyForIteratorPadCheck(); + final int[] actual = emptyForIteratorPadCheckObj.getAcceptableTokens(); + final int[] expected = { TokenTypes.FOR_ITERATOR, }; assertArrayEquals(expected, actual); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/EmptyLineSeparatorCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/EmptyLineSeparatorCheckTest.java index 8d0c2bba9..76a4375bf 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/EmptyLineSeparatorCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/EmptyLineSeparatorCheckTest.java @@ -43,13 +43,13 @@ public class EmptyLineSeparatorCheckTest @Test public void testGetRequiredTokens() { - EmptyLineSeparatorCheck checkObj = new EmptyLineSeparatorCheck(); + final EmptyLineSeparatorCheck checkObj = new EmptyLineSeparatorCheck(); assertArrayEquals(ArrayUtils.EMPTY_INT_ARRAY, checkObj.getRequiredTokens()); } @Test public void testDefault() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(EmptyLineSeparatorCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(EmptyLineSeparatorCheck.class); final String[] expected = { "21: " + getCheckMessage(MSG_SHOULD_BE_SEPARATED, "import"), @@ -68,7 +68,7 @@ public class EmptyLineSeparatorCheckTest @Test public void testAllowNoEmptyLineBetweenFields() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(EmptyLineSeparatorCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(EmptyLineSeparatorCheck.class); checkConfig.addAttribute("allowNoEmptyLineBetweenFields", "true"); final String[] expected = { @@ -86,7 +86,7 @@ public class EmptyLineSeparatorCheckTest @Test public void testHeader() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(EmptyLineSeparatorCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(EmptyLineSeparatorCheck.class); final String[] expected = { "19: " + getCheckMessage(MSG_SHOULD_BE_SEPARATED, "package"), }; @@ -95,7 +95,7 @@ public class EmptyLineSeparatorCheckTest @Test public void testMultipleEmptyLinesBetweenClassMembers() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(EmptyLineSeparatorCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(EmptyLineSeparatorCheck.class); checkConfig.addAttribute("allowMultipleEmptyLines", "false"); final String[] expected = { "21: " + getCheckMessage(MSG_MULTIPLE_LINES, "package"), @@ -109,7 +109,7 @@ public class EmptyLineSeparatorCheckTest @Test public void testFormerArrayIndexOutOfBounds() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(EmptyLineSeparatorCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(EmptyLineSeparatorCheck.class); checkConfig.addAttribute("allowMultipleEmptyLines", "false"); final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; verify(checkConfig, getPath("InputEmptyLineSeparatorFormerException.java"), expected); @@ -117,7 +117,7 @@ public class EmptyLineSeparatorCheckTest @Test public void testAllowMultipleFieldInClass() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(EmptyLineSeparatorCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(EmptyLineSeparatorCheck.class); checkConfig.addAttribute("allowMultipleEmptyLines", "false"); checkConfig.addAttribute("allowNoEmptyLineBetweenFields", "true"); final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; @@ -126,7 +126,7 @@ public class EmptyLineSeparatorCheckTest @Test public void testAllowMultipleImportSeparatedFromPackage() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(EmptyLineSeparatorCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(EmptyLineSeparatorCheck.class); checkConfig.addAttribute("allowMultipleEmptyLines", "false"); final String[] expected = { "1: " + getCheckMessage(MSG_SHOULD_BE_SEPARATED, "import"), @@ -137,9 +137,9 @@ public class EmptyLineSeparatorCheckTest @Test public void testGetAcceptableTokens() { - EmptyLineSeparatorCheck emptyLineSeparatorCheckObj = new EmptyLineSeparatorCheck(); - int[] actual = emptyLineSeparatorCheckObj.getAcceptableTokens(); - int[] expected = { + final EmptyLineSeparatorCheck emptyLineSeparatorCheckObj = new EmptyLineSeparatorCheck(); + final int[] actual = emptyLineSeparatorCheckObj.getAcceptableTokens(); + final int[] expected = { TokenTypes.PACKAGE_DEF, TokenTypes.IMPORT, TokenTypes.CLASS_DEF, @@ -156,7 +156,7 @@ public class EmptyLineSeparatorCheckTest @Test public void testPrePreviousLineEmptiness() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(EmptyLineSeparatorCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(EmptyLineSeparatorCheck.class); checkConfig.addAttribute("allowMultipleEmptyLines", "false"); final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; verify(checkConfig, getPath("InputPrePreviousLineEmptiness.java"), expected); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/GenericWhitespaceCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/GenericWhitespaceCheckTest.java index 178a8039a..929f9f51d 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/GenericWhitespaceCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/GenericWhitespaceCheckTest.java @@ -48,7 +48,7 @@ public class GenericWhitespaceCheckTest @Before public void setUp() { checkConfig = createCheckConfig(GenericWhitespaceCheck.class); - Map<Class<?>, Integer> x = Maps.newHashMap(); + final Map<Class<?>, Integer> x = Maps.newHashMap(); for (final Map.Entry<Class<?>, Integer> entry : x.entrySet()) { entry.getValue(); } @@ -69,8 +69,8 @@ public class GenericWhitespaceCheckTest @Test public void testGetRequiredTokens() { - GenericWhitespaceCheck checkObj = new GenericWhitespaceCheck(); - int[] expected = { + final GenericWhitespaceCheck checkObj = new GenericWhitespaceCheck(); + final int[] expected = { TokenTypes.GENERIC_START, TokenTypes.GENERIC_END, }; @@ -138,9 +138,9 @@ public class GenericWhitespaceCheckTest @Test public void testGetAcceptableTokens() { - GenericWhitespaceCheck genericWhitespaceCheckObj = new GenericWhitespaceCheck(); - int[] actual = genericWhitespaceCheckObj.getAcceptableTokens(); - int[] expected = { + final GenericWhitespaceCheck genericWhitespaceCheckObj = new GenericWhitespaceCheck(); + final int[] actual = genericWhitespaceCheckObj.getAcceptableTokens(); + final int[] expected = { TokenTypes.GENERIC_START, TokenTypes.GENERIC_END, }; @@ -149,8 +149,8 @@ public class GenericWhitespaceCheckTest @Test(expected = IllegalArgumentException.class) public void testWrongTokenType() { - GenericWhitespaceCheck genericWhitespaceCheckObj = new GenericWhitespaceCheck(); - DetailAST ast = new DetailAST(); + final GenericWhitespaceCheck genericWhitespaceCheckObj = new GenericWhitespaceCheck(); + final DetailAST ast = new DetailAST(); ast.initialize(new CommonHiddenStreamToken(TokenTypes.INTERFACE_DEF, "interface")); genericWhitespaceCheckObj.visitToken(ast); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/MethodParamPadCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/MethodParamPadCheckTest.java index 112dd8179..df1a54821 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/MethodParamPadCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/MethodParamPadCheckTest.java @@ -52,7 +52,7 @@ public class MethodParamPadCheckTest @Test public void testGetRequiredTokens() { - MethodParamPadCheck checkObj = new MethodParamPadCheck(); + final MethodParamPadCheck checkObj = new MethodParamPadCheck(); assertArrayEquals(ArrayUtils.EMPTY_INT_ARRAY, checkObj.getRequiredTokens()); } @@ -134,9 +134,9 @@ public class MethodParamPadCheckTest @Test public void testGetAcceptableTokens() { - MethodParamPadCheck methodParamPadCheckObj = new MethodParamPadCheck(); - int[] actual = methodParamPadCheckObj.getAcceptableTokens(); - int[] expected = { + final MethodParamPadCheck methodParamPadCheckObj = new MethodParamPadCheck(); + final int[] actual = methodParamPadCheckObj.getAcceptableTokens(); + final int[] expected = { TokenTypes.CTOR_DEF, TokenTypes.LITERAL_NEW, TokenTypes.METHOD_CALL, diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/SeparatorWrapCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/SeparatorWrapCheckTest.java index 49da264e3..1a1e55c24 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/SeparatorWrapCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/SeparatorWrapCheckTest.java @@ -71,9 +71,9 @@ public class SeparatorWrapCheckTest @Test public void testGetDefaultTokens() { - SeparatorWrapCheck separatorWrapCheckObj = new SeparatorWrapCheck(); - int[] actual = separatorWrapCheckObj.getDefaultTokens(); - int[] expected = { + final SeparatorWrapCheck separatorWrapCheckObj = new SeparatorWrapCheck(); + final int[] actual = separatorWrapCheckObj.getDefaultTokens(); + final int[] expected = { TokenTypes.DOT, TokenTypes.COMMA, }; diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/TypecastParenPadCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/TypecastParenPadCheckTest.java index e7bc1e436..a5500a760 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/TypecastParenPadCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/TypecastParenPadCheckTest.java @@ -86,9 +86,9 @@ public class TypecastParenPadCheckTest @Test public void testGetAcceptableTokens() { - TypecastParenPadCheck typecastParenPadCheckObj = new TypecastParenPadCheck(); - int[] actual = typecastParenPadCheckObj.getAcceptableTokens(); - int[] expected = { + final TypecastParenPadCheck typecastParenPadCheckObj = new TypecastParenPadCheck(); + final int[] actual = typecastParenPadCheckObj.getAcceptableTokens(); + final int[] expected = { TokenTypes.RPAREN, TokenTypes.TYPECAST, }; diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/WhitespaceAfterCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/WhitespaceAfterCheckTest.java index 004157df7..d0c3a82c5 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/WhitespaceAfterCheckTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/WhitespaceAfterCheckTest.java @@ -50,7 +50,7 @@ public class WhitespaceAfterCheckTest @Test public void testGetRequiredTokens() { - WhitespaceAfterCheck checkObj = new WhitespaceAfterCheck(); + final WhitespaceAfterCheck checkObj = new WhitespaceAfterCheck(); assertArrayEquals(ArrayUtils.EMPTY_INT_ARRAY, checkObj.getRequiredTokens()); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/WhitespaceAroundTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/WhitespaceAroundTest.java index dd35d6a46..836d2681f 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/WhitespaceAroundTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/whitespace/WhitespaceAroundTest.java @@ -51,7 +51,7 @@ public class WhitespaceAroundTest @Test public void testGetRequiredTokens() { - WhitespaceAroundCheck checkObj = new WhitespaceAroundCheck(); + final WhitespaceAroundCheck checkObj = new WhitespaceAroundCheck(); assertArrayEquals(ArrayUtils.EMPTY_INT_ARRAY, checkObj.getRequiredTokens()); } @@ -227,9 +227,9 @@ public class WhitespaceAroundTest @Test public void testGetAcceptableTokens() { - WhitespaceAroundCheck whitespaceAroundCheckObj = new WhitespaceAroundCheck(); - int[] actual = whitespaceAroundCheckObj.getAcceptableTokens(); - int[] expected = { + final WhitespaceAroundCheck whitespaceAroundCheckObj = new WhitespaceAroundCheck(); + final int[] actual = whitespaceAroundCheckObj.getAcceptableTokens(); + final int[] expected = { TokenTypes.ASSIGN, TokenTypes.BAND, TokenTypes.BAND_ASSIGN, diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/doclets/TokenTypesDocletTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/doclets/TokenTypesDocletTest.java index 3e17d6bd6..441b2477c 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/doclets/TokenTypesDocletTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/doclets/TokenTypesDocletTest.java @@ -62,11 +62,11 @@ public class TokenTypesDocletTest { @Test public void testCheckOptions() { - Context context = new Context(); - TestMessager testMessager = new TestMessager(context); + final Context context = new Context(); + final TestMessager testMessager = new TestMessager(context); //pass invalid options - empty array - String[][] options = new String[3][1]; + final String[][] options = new String[3][1]; assertFalse(TokenTypesDoclet.checkOptions(options, testMessager)); //pass valid options - array with one "-destfile" option @@ -77,7 +77,7 @@ public class TokenTypesDocletTest { options[1][0] = "-destfile"; assertFalse(TokenTypesDoclet.checkOptions(options, testMessager)); - String[] expected = { + final String[] expected = { "Usage: javadoc -destfile file -doclet TokenTypesDoclet ...", "Only one -destfile option allowed.", }; @@ -91,33 +91,33 @@ public class TokenTypesDocletTest { // modifiers public, static, final and type int, because they are referenced statically in // a lot of different places, must not be changed and an int value is used to encrypt // a token type. - ListBuffer<String[]> options = new ListBuffer<>(); + final ListBuffer<String[]> options = new ListBuffer<>(); options.add(new String[]{"-doclet", "TokenTypesDoclet"}); options.add(new String[]{"-destfile", "target/tokentypes.properties"}); - ListBuffer<String> names = new ListBuffer<>(); + final ListBuffer<String> names = new ListBuffer<>(); names.add(getPath("InputTokenTypesDocletNotConstants.java")); - Context context = new Context(); + final Context context = new Context(); new TestMessager(context); - JavadocTool javadocTool = JavadocTool.make0(context); - RootDoc rootDoc = getRootDoc(javadocTool, options, names); + final JavadocTool javadocTool = JavadocTool.make0(context); + final RootDoc rootDoc = getRootDoc(javadocTool, options, names); assertTrue(TokenTypesDoclet.start(rootDoc)); } @Test public void testEmptyJavadoc() throws Exception { - ListBuffer<String[]> options = new ListBuffer<>(); + final ListBuffer<String[]> options = new ListBuffer<>(); options.add(new String[]{"-destfile", "target/tokentypes.properties"}); - ListBuffer<String> names = new ListBuffer<>(); + final ListBuffer<String> names = new ListBuffer<>(); names.add(getPath("InputTokenTypesDocletEmptyJavadoc.java")); - Context context = new Context(); + final Context context = new Context(); new TestMessager(context); - JavadocTool javadocTool = JavadocTool.make0(context); - RootDoc rootDoc = getRootDoc(javadocTool, options, names); + final JavadocTool javadocTool = JavadocTool.make0(context); + final RootDoc rootDoc = getRootDoc(javadocTool, options, names); try { TokenTypesDoclet.start(rootDoc); @@ -132,23 +132,23 @@ public class TokenTypesDocletTest { @Test public void testCorrect() throws Exception { - ListBuffer<String[]> options = new ListBuffer<>(); + final ListBuffer<String[]> options = new ListBuffer<>(); options.add(new String[]{"-destfile", "target/tokentypes.properties"}); - ListBuffer<String> names = new ListBuffer<>(); + final ListBuffer<String> names = new ListBuffer<>(); names.add(getPath("InputTokenTypesDocletCorrect.java")); - Context context = new Context(); + final Context context = new Context(); new TestMessager(context); - JavadocTool javadocTool = JavadocTool.make0(context); - RootDoc rootDoc = getRootDoc(javadocTool, options, names); + final JavadocTool javadocTool = JavadocTool.make0(context); + final RootDoc rootDoc = getRootDoc(javadocTool, options, names); assertTrue(TokenTypesDoclet.start(rootDoc)); } private static RootDoc getRootDoc(JavadocTool javadocTool, ListBuffer<String[]> options, ListBuffer<String> names) throws Exception { - Method getRootDocImpl = getMethodGetRootDocImplByReflection(); + final Method getRootDocImpl = getMethodGetRootDocImplByReflection(); RootDoc rootDoc; if (System.getProperty("java.version").startsWith("1.7.")) { rootDoc = (RootDoc) getRootDocImpl.invoke(javadocTool, "", "UTF-8", @@ -176,8 +176,8 @@ public class TokenTypesDocletTest { private static Method getMethodGetRootDocImplByReflection() throws ClassNotFoundException { Method result = null; - Class<?> javadocToolClass = Class.forName("com.sun.tools.javadoc.JavadocTool"); - Method[] methods = javadocToolClass.getMethods(); + final Class<?> javadocToolClass = Class.forName("com.sun.tools.javadoc.JavadocTool"); + final Method[] methods = javadocToolClass.getMethods(); for (Method method: methods) { if ("getRootDocImpl".equals(method.getName())) { result = method; diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/filters/FilterSetTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/filters/FilterSetTest.java index 581660985..07c40e6aa 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/filters/FilterSetTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/filters/FilterSetTest.java @@ -74,14 +74,14 @@ public class FilterSetTest { @Test public void testGetFilters2() { - FilterSet filterSet = new FilterSet(); + final FilterSet filterSet = new FilterSet(); filterSet.addFilter(new SeverityMatchFilter()); assertEquals("size is the same", 1, filterSet.getFilters().size()); } @Test public void testToString2() { - FilterSet filterSet = new FilterSet(); + final FilterSet filterSet = new FilterSet(); filterSet.addFilter(new SeverityMatchFilter()); assertNotNull("size is the same", filterSet.toString()); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/filters/SeverityMatchFilterTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/filters/SeverityMatchFilterTest.java index f0137bad8..c0953e7ce 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/filters/SeverityMatchFilterTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/filters/SeverityMatchFilterTest.java @@ -36,14 +36,14 @@ public class SeverityMatchFilterTest { public void testDefault() { final AuditEvent ev = new AuditEvent(this, "Test.java"); assertFalse("no message", filter.accept(ev)); - SeverityLevel errorLevel = SeverityLevel.ERROR; - LocalizedMessage errorMessage = + final SeverityLevel errorLevel = SeverityLevel.ERROR; + final LocalizedMessage errorMessage = new LocalizedMessage(0, 0, "", "", null, errorLevel, null, getClass(), null); final AuditEvent ev2 = new AuditEvent(this, "ATest.java", errorMessage); assertTrue("level:" + errorLevel, filter.accept(ev2)); - SeverityLevel infoLevel = SeverityLevel.INFO; - LocalizedMessage infoMessage = + final SeverityLevel infoLevel = SeverityLevel.INFO; + final LocalizedMessage infoMessage = new LocalizedMessage(0, 0, "", "", null, infoLevel, null, getClass(), null); final AuditEvent ev3 = new AuditEvent(this, "ATest.java", infoMessage); assertFalse("level:" + infoLevel, filter.accept(ev3)); @@ -55,14 +55,14 @@ public class SeverityMatchFilterTest { final AuditEvent ev = new AuditEvent(this, "Test.java"); // event with no message has severity level INFO assertTrue("no message", filter.accept(ev)); - SeverityLevel errorLevel = SeverityLevel.ERROR; - LocalizedMessage errorMessage = + final SeverityLevel errorLevel = SeverityLevel.ERROR; + final LocalizedMessage errorMessage = new LocalizedMessage(0, 0, "", "", null, errorLevel, null, getClass(), null); final AuditEvent ev2 = new AuditEvent(this, "ATest.java", errorMessage); assertFalse("level:" + errorLevel, filter.accept(ev2)); - SeverityLevel infoLevel = SeverityLevel.INFO; - LocalizedMessage infoMessage = + final SeverityLevel infoLevel = SeverityLevel.INFO; + final LocalizedMessage infoMessage = new LocalizedMessage(0, 0, "", "", null, infoLevel, null, getClass(), null); final AuditEvent ev3 = new AuditEvent(this, "ATest.java", infoMessage); assertTrue("level:" + infoLevel, filter.accept(ev3)); @@ -75,15 +75,15 @@ public class SeverityMatchFilterTest { final AuditEvent ev = new AuditEvent(this, "Test.java"); // event with no message has severity level INFO assertFalse("no message", filter.accept(ev)); - SeverityLevel errorLevel = SeverityLevel.ERROR; - LocalizedMessage errorMessage = + final SeverityLevel errorLevel = SeverityLevel.ERROR; + final LocalizedMessage errorMessage = new LocalizedMessage(0, 0, "", "", null, errorLevel, null, getClass(), null); final AuditEvent ev2 = new AuditEvent(this, "ATest.java", errorMessage); assertTrue("level:" + errorLevel, filter.accept(ev2)); - SeverityLevel infoLevel = SeverityLevel.INFO; - LocalizedMessage infoMessage = new LocalizedMessage(0, 0, "", "", null, infoLevel, null, - getClass(), null); + final SeverityLevel infoLevel = SeverityLevel.INFO; + final LocalizedMessage infoMessage = new LocalizedMessage(0, 0, "", "", null, infoLevel, + null, getClass(), null); final AuditEvent ev3 = new AuditEvent(this, "ATest.java", infoMessage); assertFalse("level:" + infoLevel, filter.accept(ev3)); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressElementTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressElementTest.java index 61d3c5c74..b4594a332 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressElementTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressElementTest.java @@ -49,7 +49,7 @@ public class SuppressElementTest { @Test public void testDecideLocalizedMessage() { - LocalizedMessage message = + final LocalizedMessage message = new LocalizedMessage(0, 0, "", "", null, null, getClass(), null); final AuditEvent ev = new AuditEvent(this, "ATest.java", message); //deny because there are matches on file and check names @@ -58,7 +58,7 @@ public class SuppressElementTest { @Test public void testDecideByLine() { - LocalizedMessage message = + final LocalizedMessage message = new LocalizedMessage(10, 10, "", "", null, null, getClass(), null); final AuditEvent ev = new AuditEvent(this, "ATest.java", message); //deny because there are matches on file name, check name, and line @@ -72,7 +72,7 @@ public class SuppressElementTest { @Test public void testDecideByColumn() { - LocalizedMessage message = + final LocalizedMessage message = new LocalizedMessage(10, 10, "", "", null, null, getClass(), null); final AuditEvent ev = new AuditEvent(this, "ATest.java", message); //deny because there are matches on file name, check name, and column @@ -84,7 +84,7 @@ public class SuppressElementTest { @Test public void testDecideByFileNameAndModuleMatchingFileNameNull() { - LocalizedMessage message = + final LocalizedMessage message = new LocalizedMessage(10, 10, "", "", null, null, getClass(), null); final AuditEvent ev = new AuditEvent(this, null, message); assertTrue(filter.accept(ev)); @@ -98,7 +98,7 @@ public class SuppressElementTest { @Test public void testDecideByFileNameAndModuleMatchingModuleNull() { - LocalizedMessage message = + final LocalizedMessage message = new LocalizedMessage(10, 10, "", "", null, "MyModule", getClass(), null); final AuditEvent ev = new AuditEvent(this, "ATest.java", message); filter.setModuleId(null); @@ -107,7 +107,7 @@ public class SuppressElementTest { @Test public void testDecideByFileNameAndModuleMatchingModuleEqual() { - LocalizedMessage message = + final LocalizedMessage message = new LocalizedMessage(10, 10, "", "", null, "MyModule", getClass(), null); final AuditEvent ev = new AuditEvent(this, "ATest.java", message); filter.setModuleId("MyModule"); @@ -116,7 +116,7 @@ public class SuppressElementTest { @Test public void testDecideByFileNameAndModuleMatchingModuleNotEqual() { - LocalizedMessage message = + final LocalizedMessage message = new LocalizedMessage(10, 10, "", "", null, "TheirModule", getClass(), null); final AuditEvent ev = new AuditEvent(this, "ATest.java", message); filter.setModuleId("MyModule"); @@ -125,7 +125,7 @@ public class SuppressElementTest { @Test public void testDecideByFileNameAndModuleMatchingRegExpNotMatch() { - LocalizedMessage message = + final LocalizedMessage message = new LocalizedMessage(10, 10, "", "", null, null, getClass(), null); final AuditEvent ev = new AuditEvent(this, "T1est", message); assertTrue(filter.accept(ev)); @@ -133,16 +133,16 @@ public class SuppressElementTest { @Test public void testDecideByFileNameAndModuleMatchingRegExpMatch() { - LocalizedMessage message = + final LocalizedMessage message = new LocalizedMessage(10, 10, "", "", null, null, getClass(), null); final AuditEvent ev = new AuditEvent(this, "TestSUFFIX", message); - SuppressElement filterWithoutChecks = new SuppressElement("Test"); + final SuppressElement filterWithoutChecks = new SuppressElement("Test"); assertFalse(filterWithoutChecks.accept(ev)); } @Test public void testDecideByFileNameAndModuleMatchingCheckRegExpNotMatch() { - LocalizedMessage message = + final LocalizedMessage message = new LocalizedMessage(10, 10, "", "", null, null, getClass(), null); final AuditEvent ev = new AuditEvent(this, "ATest.java", message); filter.setChecks("NON_EXISTING_CHECK"); @@ -151,7 +151,7 @@ public class SuppressElementTest { @Test public void testDecideByFileNameAndModuleMatchingCheckRegExpMatch() { - LocalizedMessage message = + final LocalizedMessage message = new LocalizedMessage(10, 10, "", "", null, null, getClass(), null); final AuditEvent ev = new AuditEvent(this, "ATest.java", message); filter.setChecks(getClass().getCanonicalName()); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressWithNearbyCommentFilterTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressWithNearbyCommentFilterTest.java index 22532ff37..3cbbb50e4 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressWithNearbyCommentFilterTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressWithNearbyCommentFilterTest.java @@ -271,13 +271,13 @@ public class SuppressWithNearbyCommentFilterTest new LocalizedMessage(1, 1, "messages.properties", "key", null, SeverityLevel.ERROR, null, getClass(), null); final AuditEvent auditEvent = new AuditEvent(this, "Test.java", message); - SuppressWithNearbyCommentFilter filter = new SuppressWithNearbyCommentFilter(); + final SuppressWithNearbyCommentFilter filter = new SuppressWithNearbyCommentFilter(); Assert.assertTrue(filter.accept(auditEvent)); } @Test public void testToStringOfTagClass() { - SuppressWithNearbyCommentFilter.Tag tag = new SuppressWithNearbyCommentFilter.Tag( + final SuppressWithNearbyCommentFilter.Tag tag = new SuppressWithNearbyCommentFilter.Tag( "text", 7, new SuppressWithNearbyCommentFilter() ); assertEquals("Tag[lines=[7 to 7]; text='text']", tag.toString()); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressionCommentFilterTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressionCommentFilterTest.java index ab1d10033..8cd16887e 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressionCommentFilterTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressionCommentFilterTest.java @@ -247,7 +247,7 @@ public class SuppressionCommentFilterTest @Test public void testToStringOfTagClass() { - SuppressionCommentFilter.Tag tag = new SuppressionCommentFilter.Tag( + final SuppressionCommentFilter.Tag tag = new SuppressionCommentFilter.Tag( 0, 1, "text", false, new SuppressionCommentFilter() ); @@ -286,7 +286,7 @@ public class SuppressionCommentFilterTest "messages.properties", "key", null, SeverityLevel.ERROR, null, getClass(), null); final AuditEvent auditEvent = new AuditEvent(this, "Test.java", message); - SuppressionCommentFilter filter = new SuppressionCommentFilter(); + final SuppressionCommentFilter filter = new SuppressionCommentFilter(); Assert.assertTrue(filter.accept(auditEvent)); } } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressionFilterTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressionFilterTest.java index e141697d4..f7a740815 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressionFilterTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressionFilterTest.java @@ -39,7 +39,7 @@ public class SuppressionFilterTest { @Test public void testAccept() throws CheckstyleException { - SuppressionFilter filter = new SuppressionFilter(); + final SuppressionFilter filter = new SuppressionFilter(); filter.setFile("src/test/resources/com/puppycrawl/tools/checkstyle/filters/" + "suppressions_none.xml"); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressionsLoaderTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressionsLoaderTest.java index 355bc05a7..2baf37009 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressionsLoaderTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressionsLoaderTest.java @@ -104,18 +104,18 @@ public class SuppressionsLoaderTest extends BaseCheckTestSupport { final FilterSet fc = SuppressionsLoader.loadSuppressions(getPath("suppressions_multiple.xml")); final FilterSet fc2 = new FilterSet(); - SuppressElement se0 = new SuppressElement("file0"); + final SuppressElement se0 = new SuppressElement("file0"); se0.setChecks("check0"); fc2.addFilter(se0); - SuppressElement se1 = new SuppressElement("file1"); + final SuppressElement se1 = new SuppressElement("file1"); se1.setChecks("check1"); se1.setLines("1,2-3"); fc2.addFilter(se1); - SuppressElement se2 = new SuppressElement("file2"); + final SuppressElement se2 = new SuppressElement("file2"); se2.setChecks("check2"); se2.setColumns("1,2-3"); fc2.addFilter(se2); - SuppressElement se3 = new SuppressElement("file3"); + final SuppressElement se3 = new SuppressElement("file3"); se3.setChecks("check3"); se3.setLines("1,2-3"); se3.setColumns("1,2-3"); @@ -194,8 +194,8 @@ public class SuppressionsLoaderTest extends BaseCheckTestSupport { private static boolean isUrlReachable(String url) { try { - URL verifiableUrl = new URL(url); - HttpURLConnection urlConnect = (HttpURLConnection) verifiableUrl.openConnection(); + final URL verifiableUrl = new URL(url); + final HttpURLConnection urlConnect = (HttpURLConnection) verifiableUrl.openConnection(); urlConnect.getContent(); } catch (IOException e) { @@ -206,13 +206,13 @@ public class SuppressionsLoaderTest extends BaseCheckTestSupport { @Test public void testUnableToFindSuppressions() throws Exception { - Class<SuppressionsLoader> loaderClass = SuppressionsLoader.class; - Method loadSuppressions = + final Class<SuppressionsLoader> loaderClass = SuppressionsLoader.class; + final Method loadSuppressions = loaderClass.getDeclaredMethod("loadSuppressions", InputSource.class, String.class); loadSuppressions.setAccessible(true); - String sourceName = "suppressions_none.xml"; - InputSource inputSource = new InputSource(sourceName); + final String sourceName = "suppressions_none.xml"; + final InputSource inputSource = new InputSource(sourceName); thrown.expect(CheckstyleException.class); thrown.expectMessage("Unable to find: " + sourceName); @@ -222,15 +222,15 @@ public class SuppressionsLoaderTest extends BaseCheckTestSupport { @Test public void testUnableToReadSuppressions() throws Exception { - Class<SuppressionsLoader> loaderClass = SuppressionsLoader.class; - Method loadSuppressions = + final Class<SuppressionsLoader> loaderClass = SuppressionsLoader.class; + final Method loadSuppressions = loaderClass.getDeclaredMethod("loadSuppressions", InputSource.class, String.class); loadSuppressions.setAccessible(true); - InputSource inputSource = new InputSource(); + final InputSource inputSource = new InputSource(); thrown.expect(CheckstyleException.class); - String sourceName = "suppressions_none.xml"; + final String sourceName = "suppressions_none.xml"; thrown.expectMessage("Unable to read " + sourceName); loadSuppressions.invoke(loaderClass, inputSource, sourceName); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/grammars/comments/AllBlockCommentsTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/grammars/comments/AllBlockCommentsTest.java index fe5fca5d8..68860c892 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/grammars/comments/AllBlockCommentsTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/grammars/comments/AllBlockCommentsTest.java @@ -48,7 +48,7 @@ public class AllBlockCommentsTest extends BaseCheckTestSupport { @Test public void testAllBlockComments() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(BlockCommentListenerCheck.class); + final DefaultConfiguration checkConfig = createCheckConfig(BlockCommentListenerCheck.class); final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; verify(checkConfig, getPath("InputFullOfBlockComments.java"), expected); Assert.assertTrue(ALL_COMMENTS.isEmpty()); @@ -90,7 +90,7 @@ public class AllBlockCommentsTest extends BaseCheckTestSupport { @Override public void visitToken(DetailAST ast) { - String commentContent = ast.getFirstChild().getText(); + final String commentContent = ast.getFirstChild().getText(); if (!ALL_COMMENTS.remove(commentContent)) { Assert.fail("Unexpected comment: " + commentContent); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/grammars/comments/AllSinglelineCommentsTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/grammars/comments/AllSinglelineCommentsTest.java index 6f4b062a6..9b3c161ba 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/grammars/comments/AllSinglelineCommentsTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/grammars/comments/AllSinglelineCommentsTest.java @@ -47,7 +47,8 @@ public class AllSinglelineCommentsTest extends BaseCheckTestSupport { @Test public void testAllBlockComments() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(SinglelineCommentListenerCheck.class); + final DefaultConfiguration checkConfig = + createCheckConfig(SinglelineCommentListenerCheck.class); final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; verify(checkConfig, getPath("InputFullOfSinglelineComments.java"), expected); Assert.assertTrue(ALL_COMMENTS.isEmpty()); @@ -76,7 +77,7 @@ public class AllSinglelineCommentsTest extends BaseCheckTestSupport { @Override public void init() { - int lines = 63; + final int lines = 63; for (int i = 0; i < lines; i++) { ALL_COMMENTS.add(i + LINE_SEPARATOR); } @@ -85,7 +86,7 @@ public class AllSinglelineCommentsTest extends BaseCheckTestSupport { @Override public void visitToken(DetailAST ast) { - String commentContent = ast.getFirstChild().getText(); + final String commentContent = ast.getFirstChild().getText(); if (!ALL_COMMENTS.remove(commentContent)) { Assert.fail("Unexpected comment: " + commentContent); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/grammars/comments/CommentsTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/grammars/comments/CommentsTest.java index 883b952b2..3f9caa560 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/grammars/comments/CommentsTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/grammars/comments/CommentsTest.java @@ -83,163 +83,163 @@ public class CommentsTest extends BaseCheckTestSupport { * +--RCURLY [6,0] */ private static DetailAST buildInput1() { - DetailAST packageDef = new DetailAST(); + final DetailAST packageDef = new DetailAST(); packageDef.setType(PACKAGE_DEF); packageDef.setText("package"); packageDef.setLineNo(1); packageDef.setColumnNo(0); - DetailAST annotationsDef = new DetailAST(); + final DetailAST annotationsDef = new DetailAST(); annotationsDef.setType(ANNOTATIONS); annotationsDef.setText("ANNOTATIONS"); annotationsDef.setLineNo(1); annotationsDef.setColumnNo(48); - DetailAST dotDef = new DetailAST(); + final DetailAST dotDef = new DetailAST(); dotDef.setType(DOT); dotDef.setText("."); dotDef.setLineNo(1); dotDef.setColumnNo(48); - DetailAST subDotDef = new DetailAST(); + final DetailAST subDotDef = new DetailAST(); subDotDef.setType(DOT); subDotDef.setText("."); subDotDef.setLineNo(1); subDotDef.setColumnNo(39); - DetailAST subDotDef1 = new DetailAST(); + final DetailAST subDotDef1 = new DetailAST(); subDotDef1.setType(DOT); subDotDef1.setText("."); subDotDef1.setLineNo(1); subDotDef1.setColumnNo(28); - DetailAST subDotDef2 = new DetailAST(); + final DetailAST subDotDef2 = new DetailAST(); subDotDef2.setType(DOT); subDotDef2.setText("."); subDotDef2.setLineNo(1); subDotDef2.setColumnNo(22); - DetailAST subDotDef3 = new DetailAST(); + final DetailAST subDotDef3 = new DetailAST(); subDotDef3.setType(DOT); subDotDef3.setText("."); subDotDef3.setLineNo(1); subDotDef3.setColumnNo(11); - DetailAST identDef = new DetailAST(); + final DetailAST identDef = new DetailAST(); identDef.setType(IDENT); identDef.setText("com"); identDef.setLineNo(1); identDef.setColumnNo(8); - DetailAST identDef2 = new DetailAST(); + final DetailAST identDef2 = new DetailAST(); identDef2.setType(IDENT); identDef2.setText("puppycrawl"); identDef2.setLineNo(1); identDef2.setColumnNo(12); - DetailAST identDef3 = new DetailAST(); + final DetailAST identDef3 = new DetailAST(); identDef3.setType(IDENT); identDef3.setText("tools"); identDef3.setLineNo(1); identDef3.setColumnNo(23); - DetailAST semiDef = new DetailAST(); + final DetailAST semiDef = new DetailAST(); semiDef.setType(SEMI); semiDef.setText(";"); semiDef.setLineNo(1); semiDef.setColumnNo(57); - DetailAST identDef4 = new DetailAST(); + final DetailAST identDef4 = new DetailAST(); identDef4.setType(IDENT); identDef4.setText("checkstyle"); identDef4.setLineNo(1); identDef4.setColumnNo(29); - DetailAST identDef5 = new DetailAST(); + final DetailAST identDef5 = new DetailAST(); identDef5.setType(IDENT); identDef5.setText("grammars"); identDef5.setLineNo(1); identDef5.setColumnNo(40); - DetailAST identDef6 = new DetailAST(); + final DetailAST identDef6 = new DetailAST(); identDef6.setType(IDENT); identDef6.setText("comments"); identDef6.setLineNo(1); identDef6.setColumnNo(49); - DetailAST classDef = new DetailAST(); + final DetailAST classDef = new DetailAST(); classDef.setType(CLASS_DEF); classDef.setText("CLASS_DEF"); classDef.setLineNo(2); classDef.setColumnNo(0); - DetailAST modifiers = new DetailAST(); + final DetailAST modifiers = new DetailAST(); modifiers.setType(MODIFIERS); modifiers.setText("MODIFIERS"); modifiers.setLineNo(2); modifiers.setColumnNo(0); - DetailAST literalPublic = new DetailAST(); + final DetailAST literalPublic = new DetailAST(); literalPublic.setType(LITERAL_PUBLIC); literalPublic.setText("public"); literalPublic.setLineNo(2); literalPublic.setColumnNo(0); - DetailAST literalClass = new DetailAST(); + final DetailAST literalClass = new DetailAST(); literalClass.setType(LITERAL_CLASS); literalClass.setText("class"); literalClass.setLineNo(2); literalClass.setColumnNo(7); - DetailAST blockCommentStart = new DetailAST(); + final DetailAST blockCommentStart = new DetailAST(); blockCommentStart.setType(BLOCK_COMMENT_BEGIN); blockCommentStart.setText("/*"); blockCommentStart.setLineNo(2); blockCommentStart.setColumnNo(13); - DetailAST blockCommentContent = new DetailAST(); + final DetailAST blockCommentContent = new DetailAST(); blockCommentContent.setType(COMMENT_CONTENT); blockCommentContent.setText(LINE_SEPARATOR + " i'mcomment567" + LINE_SEPARATOR + " "); blockCommentContent.setLineNo(2); blockCommentContent.setColumnNo(15); - DetailAST blockCommentEnd = new DetailAST(); + final DetailAST blockCommentEnd = new DetailAST(); blockCommentEnd.setType(BLOCK_COMMENT_END); blockCommentEnd.setText("*/"); blockCommentEnd.setLineNo(4); blockCommentEnd.setColumnNo(4); - DetailAST ident = new DetailAST(); + final DetailAST ident = new DetailAST(); ident.setType(IDENT); ident.setText("InputComments1"); ident.setLineNo(5); ident.setColumnNo(0); - DetailAST objBlock = new DetailAST(); + final DetailAST objBlock = new DetailAST(); objBlock.setType(OBJBLOCK); objBlock.setText("OBJBLOCK"); objBlock.setLineNo(6); objBlock.setColumnNo(0); - DetailAST lcurly = new DetailAST(); + final DetailAST lcurly = new DetailAST(); lcurly.setType(LCURLY); lcurly.setText("{"); lcurly.setLineNo(6); lcurly.setColumnNo(0); - DetailAST slComment = new DetailAST(); + final DetailAST slComment = new DetailAST(); slComment.setType(SINGLE_LINE_COMMENT); slComment.setText("//"); slComment.setLineNo(6); slComment.setColumnNo(2); - DetailAST slCommentContent = new DetailAST(); + final DetailAST slCommentContent = new DetailAST(); slCommentContent.setType(COMMENT_CONTENT); slCommentContent.setText(" comment to left curly brace" + LINE_SEPARATOR); slCommentContent.setLineNo(6); slCommentContent.setColumnNo(4); - DetailAST rcurly = new DetailAST(); + final DetailAST rcurly = new DetailAST(); rcurly.setType(RCURLY); rcurly.setText("}"); rcurly.setLineNo(7); @@ -313,97 +313,97 @@ public class CommentsTest extends BaseCheckTestSupport { * +--RCURLY [12,0] */ private static DetailAST buildInput2() { - DetailAST packageDef = new DetailAST(); + final DetailAST packageDef = new DetailAST(); packageDef.setType(PACKAGE_DEF); packageDef.setText("package"); packageDef.setLineNo(1); packageDef.setColumnNo(0); - DetailAST annotationsDef = new DetailAST(); + final DetailAST annotationsDef = new DetailAST(); annotationsDef.setType(ANNOTATIONS); annotationsDef.setText("ANNOTATIONS"); annotationsDef.setLineNo(1); annotationsDef.setColumnNo(48); - DetailAST dotDef = new DetailAST(); + final DetailAST dotDef = new DetailAST(); dotDef.setType(DOT); dotDef.setText("."); dotDef.setLineNo(1); dotDef.setColumnNo(48); - DetailAST subDotDef = new DetailAST(); + final DetailAST subDotDef = new DetailAST(); subDotDef.setType(DOT); subDotDef.setText("."); subDotDef.setLineNo(1); subDotDef.setColumnNo(39); - DetailAST subDotDef1 = new DetailAST(); + final DetailAST subDotDef1 = new DetailAST(); subDotDef1.setType(DOT); subDotDef1.setText("."); subDotDef1.setLineNo(1); subDotDef1.setColumnNo(28); - DetailAST subDotDef2 = new DetailAST(); + final DetailAST subDotDef2 = new DetailAST(); subDotDef2.setType(DOT); subDotDef2.setText("."); subDotDef2.setLineNo(1); subDotDef2.setColumnNo(22); - DetailAST subDotDef3 = new DetailAST(); + final DetailAST subDotDef3 = new DetailAST(); subDotDef3.setType(DOT); subDotDef3.setText("."); subDotDef3.setLineNo(1); subDotDef3.setColumnNo(11); - DetailAST identDef = new DetailAST(); + final DetailAST identDef = new DetailAST(); identDef.setType(IDENT); identDef.setText("com"); identDef.setLineNo(1); identDef.setColumnNo(8); - DetailAST identDef2 = new DetailAST(); + final DetailAST identDef2 = new DetailAST(); identDef2.setType(IDENT); identDef2.setText("puppycrawl"); identDef2.setLineNo(1); identDef2.setColumnNo(12); - DetailAST identDef3 = new DetailAST(); + final DetailAST identDef3 = new DetailAST(); identDef3.setType(IDENT); identDef3.setText("tools"); identDef3.setLineNo(1); identDef3.setColumnNo(23); - DetailAST semiDef = new DetailAST(); + final DetailAST semiDef = new DetailAST(); semiDef.setType(SEMI); semiDef.setText(";"); semiDef.setLineNo(1); semiDef.setColumnNo(57); - DetailAST identDef4 = new DetailAST(); + final DetailAST identDef4 = new DetailAST(); identDef4.setType(IDENT); identDef4.setText("checkstyle"); identDef4.setLineNo(1); identDef4.setColumnNo(29); - DetailAST identDef5 = new DetailAST(); + final DetailAST identDef5 = new DetailAST(); identDef5.setType(IDENT); identDef5.setText("grammars"); identDef5.setLineNo(1); identDef5.setColumnNo(40); - DetailAST identDef6 = new DetailAST(); + final DetailAST identDef6 = new DetailAST(); identDef6.setType(IDENT); identDef6.setText("comments"); identDef6.setLineNo(1); identDef6.setColumnNo(49); - DetailAST classDef = new DetailAST(); + final DetailAST classDef = new DetailAST(); classDef.setType(CLASS_DEF); classDef.setText("CLASS_DEF"); classDef.setLineNo(3); classDef.setColumnNo(0); - DetailAST modifiers = new DetailAST(); + final DetailAST modifiers = new DetailAST(); modifiers.setType(MODIFIERS); modifiers.setText("MODIFIERS"); modifiers.setLineNo(3); @@ -411,13 +411,13 @@ public class CommentsTest extends BaseCheckTestSupport { classDef.setFirstChild(modifiers); - DetailAST slComment = new DetailAST(); + final DetailAST slComment = new DetailAST(); slComment.setType(SINGLE_LINE_COMMENT); slComment.setText("//"); slComment.setLineNo(2); slComment.setColumnNo(0); - DetailAST slCommentContent = new DetailAST(); + final DetailAST slCommentContent = new DetailAST(); slCommentContent.setType(COMMENT_CONTENT); slCommentContent.setText(" my class" + LINE_SEPARATOR); slCommentContent.setLineNo(2); @@ -426,7 +426,7 @@ public class CommentsTest extends BaseCheckTestSupport { slComment.setFirstChild(slCommentContent); modifiers.setNextSibling(slComment); - DetailAST literalClass = new DetailAST(); + final DetailAST literalClass = new DetailAST(); literalClass.setType(LITERAL_CLASS); literalClass.setText("class"); literalClass.setLineNo(3); @@ -434,7 +434,7 @@ public class CommentsTest extends BaseCheckTestSupport { slComment.setNextSibling(literalClass); - DetailAST identClassName = new DetailAST(); + final DetailAST identClassName = new DetailAST(); identClassName.setType(IDENT); identClassName.setText("InputComments2"); identClassName.setLineNo(3); @@ -442,7 +442,7 @@ public class CommentsTest extends BaseCheckTestSupport { literalClass.setNextSibling(identClassName); - DetailAST objBlock = new DetailAST(); + final DetailAST objBlock = new DetailAST(); objBlock.setType(OBJBLOCK); objBlock.setText("OBJBLOCK"); objBlock.setLineNo(4); @@ -450,7 +450,7 @@ public class CommentsTest extends BaseCheckTestSupport { identClassName.setNextSibling(objBlock); - DetailAST lcurly = new DetailAST(); + final DetailAST lcurly = new DetailAST(); lcurly.setType(LCURLY); lcurly.setText("{"); lcurly.setLineNo(4); @@ -458,7 +458,7 @@ public class CommentsTest extends BaseCheckTestSupport { objBlock.setFirstChild(lcurly); - DetailAST methodDef = new DetailAST(); + final DetailAST methodDef = new DetailAST(); methodDef.setType(METHOD_DEF); methodDef.setText("METHOD_DEF"); methodDef.setLineNo(10); @@ -466,7 +466,7 @@ public class CommentsTest extends BaseCheckTestSupport { lcurly.setNextSibling(methodDef); - DetailAST rcurly = new DetailAST(); + final DetailAST rcurly = new DetailAST(); rcurly.setType(RCURLY); rcurly.setText("}"); rcurly.setLineNo(14); @@ -474,7 +474,7 @@ public class CommentsTest extends BaseCheckTestSupport { methodDef.setNextSibling(rcurly); - DetailAST methodModifiers = new DetailAST(); + final DetailAST methodModifiers = new DetailAST(); methodModifiers.setType(MODIFIERS); methodModifiers.setText("MODIFIERS"); methodModifiers.setLineNo(10); @@ -482,7 +482,7 @@ public class CommentsTest extends BaseCheckTestSupport { methodDef.setFirstChild(methodModifiers); - DetailAST methodType = new DetailAST(); + final DetailAST methodType = new DetailAST(); methodType.setType(TYPE); methodType.setText("TYPE"); methodType.setLineNo(10); @@ -490,7 +490,7 @@ public class CommentsTest extends BaseCheckTestSupport { methodModifiers.setNextSibling(methodType); - DetailAST identMethodType = new DetailAST(); + final DetailAST identMethodType = new DetailAST(); identMethodType.setType(IDENT); identMethodType.setText("String"); identMethodType.setLineNo(10); @@ -498,7 +498,7 @@ public class CommentsTest extends BaseCheckTestSupport { methodType.setFirstChild(identMethodType); - DetailAST identMethodName = new DetailAST(); + final DetailAST identMethodName = new DetailAST(); identMethodName.setType(IDENT); identMethodName.setText("line"); identMethodName.setLineNo(10); @@ -506,7 +506,7 @@ public class CommentsTest extends BaseCheckTestSupport { methodType.setNextSibling(identMethodName); - DetailAST lparen = new DetailAST(); + final DetailAST lparen = new DetailAST(); lparen.setType(LPAREN); lparen.setText("("); lparen.setLineNo(10); @@ -514,7 +514,7 @@ public class CommentsTest extends BaseCheckTestSupport { identMethodName.setNextSibling(lparen); - DetailAST parameters = new DetailAST(); + final DetailAST parameters = new DetailAST(); parameters.setType(PARAMETERS); parameters.setText("PARAMETERS"); parameters.setLineNo(10); @@ -522,25 +522,25 @@ public class CommentsTest extends BaseCheckTestSupport { lparen.setNextSibling(parameters); - DetailAST returnDef = new DetailAST(); + final DetailAST returnDef = new DetailAST(); returnDef.setType(LITERAL_RETURN); returnDef.setText("return"); returnDef.setLineNo(12); returnDef.setColumnNo(2); - DetailAST exprDef = new DetailAST(); + final DetailAST exprDef = new DetailAST(); exprDef.setType(EXPR); exprDef.setText("EXPR"); exprDef.setLineNo(12); exprDef.setColumnNo(9); - DetailAST nullDef = new DetailAST(); + final DetailAST nullDef = new DetailAST(); nullDef.setType(LITERAL_NULL); nullDef.setText("null"); nullDef.setLineNo(12); nullDef.setColumnNo(9); - DetailAST rparen = new DetailAST(); + final DetailAST rparen = new DetailAST(); rparen.setType(RPAREN); rparen.setText(")"); rparen.setLineNo(10); @@ -548,13 +548,13 @@ public class CommentsTest extends BaseCheckTestSupport { parameters.setNextSibling(rparen); - DetailAST slist = new DetailAST(); + final DetailAST slist = new DetailAST(); slist.setType(SLIST); slist.setText("{"); slist.setLineNo(11); slist.setColumnNo(4); - DetailAST semiDef1 = new DetailAST(); + final DetailAST semiDef1 = new DetailAST(); semiDef1.setType(SEMI); semiDef1.setText(";"); semiDef1.setLineNo(12); @@ -562,7 +562,7 @@ public class CommentsTest extends BaseCheckTestSupport { rparen.setNextSibling(slist); - DetailAST methodRcurly = new DetailAST(); + final DetailAST methodRcurly = new DetailAST(); methodRcurly.setType(RCURLY); methodRcurly.setText("}"); methodRcurly.setLineNo(13); @@ -574,13 +574,13 @@ public class CommentsTest extends BaseCheckTestSupport { exprDef.setFirstChild(nullDef); exprDef.setNextSibling(semiDef1); - DetailAST blockCommentStart = new DetailAST(); + final DetailAST blockCommentStart = new DetailAST(); blockCommentStart.setType(BLOCK_COMMENT_BEGIN); blockCommentStart.setText("/*"); blockCommentStart.setLineNo(5); blockCommentStart.setColumnNo(4); - DetailAST blockCommentContent = new DetailAST(); + final DetailAST blockCommentContent = new DetailAST(); blockCommentContent.setType(COMMENT_CONTENT); blockCommentContent.setText("*" + LINE_SEPARATOR + " * Lines <b>method</b>." + LINE_SEPARATOR @@ -592,7 +592,7 @@ public class CommentsTest extends BaseCheckTestSupport { blockCommentStart.setFirstChild(blockCommentContent); - DetailAST blockCommentEnd = new DetailAST(); + final DetailAST blockCommentEnd = new DetailAST(); blockCommentEnd.setType(BLOCK_COMMENT_END); blockCommentEnd.setText("*/"); blockCommentEnd.setLineNo(9); @@ -601,7 +601,7 @@ public class CommentsTest extends BaseCheckTestSupport { blockCommentContent.setNextSibling(blockCommentEnd); methodModifiers.setFirstChild(blockCommentStart); - DetailAST literalProtected = new DetailAST(); + final DetailAST literalProtected = new DetailAST(); literalProtected.setType(LITERAL_PROTECTED); literalProtected.setText("protected"); literalProtected.setLineNo(10); @@ -633,7 +633,7 @@ public class CommentsTest extends BaseCheckTestSupport { @Test public void testCompareExpectedTreeWithInput1() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(CompareTreesWithComments.class); + final DefaultConfiguration checkConfig = createCheckConfig(CompareTreesWithComments.class); CompareTreesWithComments.setExpectedTree(buildInput1()); final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; verify(checkConfig, getPath("InputComments1.java"), expected); @@ -641,7 +641,7 @@ public class CommentsTest extends BaseCheckTestSupport { @Test public void testCompareExpectedTreeWithInput2() throws Exception { - DefaultConfiguration checkConfig = createCheckConfig(CompareTreesWithComments.class); + final DefaultConfiguration checkConfig = createCheckConfig(CompareTreesWithComments.class); CompareTreesWithComments.setExpectedTree(buildInput2()); final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY; verify(checkConfig, getPath("InputComments2.java"), expected); @@ -649,7 +649,7 @@ public class CommentsTest extends BaseCheckTestSupport { @Test public void testToString() throws Exception { - Comment comment = new Comment(new String[]{"value"}, 1, 2, 3); + final Comment comment = new Comment(new String[]{"value"}, 1, 2, 3); Assert.assertEquals("Comment[2:1-2:3]", comment.toString()); } } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/grammars/comments/CompareTreesWithComments.java b/src/test/java/com/puppycrawl/tools/checkstyle/grammars/comments/CompareTreesWithComments.java index 97af7ffb3..e5065ec6a 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/grammars/comments/CompareTreesWithComments.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/grammars/comments/CompareTreesWithComments.java @@ -85,12 +85,12 @@ class CompareTreesWithComments extends Check { } if (result) { - DetailAST childExpected = expected.getFirstChild(); - DetailAST childActual = actual.getFirstChild(); + final DetailAST childExpected = expected.getFirstChild(); + final DetailAST childActual = actual.getFirstChild(); result = isAstEquals(childExpected, childActual); if (result) { - DetailAST nextSiblingExpected = expected.getNextSibling(); - DetailAST nextSiblingActual = actual.getNextSibling(); + final DetailAST nextSiblingExpected = expected.getNextSibling(); + final DetailAST nextSiblingActual = actual.getNextSibling(); result = isAstEquals(nextSiblingExpected, nextSiblingActual); } } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/grammars/javadoc/JavadocParseTreeTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/grammars/javadoc/JavadocParseTreeTest.java index 7890c676e..d95519938 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/grammars/javadoc/JavadocParseTreeTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/grammars/javadoc/JavadocParseTreeTest.java @@ -82,198 +82,199 @@ public class JavadocParseTreeTest { @Test public void oneSimpleHtmlTag() throws IOException { - String filename = getHtmlPath("InputOneSimpleHtmlTag.txt"); - ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); - ParseTree expectedTree = ParseTreeBuilder.treeOneSimpleHtmlTag(); + final String filename = getHtmlPath("InputOneSimpleHtmlTag.txt"); + final ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); + final ParseTree expectedTree = ParseTreeBuilder.treeOneSimpleHtmlTag(); compareTrees(expectedTree, generatedTree); } @Test public void textBeforeJavadocTags() throws IOException { - String filename = getDocPath("InputTextBeforeJavadocTags.txt"); - ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); - ParseTree expectedTree = ParseTreeBuilder.treeTextBeforeJavadocTags(); + final String filename = getDocPath("InputTextBeforeJavadocTags.txt"); + final ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); + final ParseTree expectedTree = ParseTreeBuilder.treeTextBeforeJavadocTags(); compareTrees(expectedTree, generatedTree); } @Test public void customJavadocTags() throws IOException { - String filename = getDocPath("InputCustomJavadocTags.txt"); - ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); - ParseTree expectedTree = ParseTreeBuilder.treeCustomJavadocTags(); + final String filename = getDocPath("InputCustomJavadocTags.txt"); + final ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); + final ParseTree expectedTree = ParseTreeBuilder.treeCustomJavadocTags(); compareTrees(expectedTree, generatedTree); } @Test public void javadocTagDescriptionWithInlineTags() throws IOException { - String filename = getDocPath("InputJavadocTagDescriptionWithInlineTags.txt"); - ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); - ParseTree expectedTree = ParseTreeBuilder.treeJavadocTagDescriptionWithInlineTags(); + final String filename = getDocPath("InputJavadocTagDescriptionWithInlineTags.txt"); + final ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); + final ParseTree expectedTree = ParseTreeBuilder.treeJavadocTagDescriptionWithInlineTags(); compareTrees(expectedTree, generatedTree); } @Test public void leadingAsterisks() throws IOException { - String filename = getPath("InputLeadingAsterisks.txt"); - ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); - ParseTree expectedTree = ParseTreeBuilder.treeLeadingAsterisks(); + final String filename = getPath("InputLeadingAsterisks.txt"); + final ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); + final ParseTree expectedTree = ParseTreeBuilder.treeLeadingAsterisks(); compareTrees(expectedTree, generatedTree); } @Test public void authorWithMailto() throws IOException { - String filename = getDocPath("InputAuthorWithMailto.txt"); - ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); - ParseTree expectedTree = ParseTreeBuilder.treeAuthorWithMailto(); + final String filename = getDocPath("InputAuthorWithMailto.txt"); + final ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); + final ParseTree expectedTree = ParseTreeBuilder.treeAuthorWithMailto(); compareTrees(expectedTree, generatedTree); } @Test public void htmlTagsInParagraph() throws IOException { - String filename = getHtmlPath("InputHtmlTagsInParagraph.txt"); - ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); - ParseTree expectedTree = ParseTreeBuilder.treeHtmlTagsInParagraph(); + final String filename = getHtmlPath("InputHtmlTagsInParagraph.txt"); + final ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); + final ParseTree expectedTree = ParseTreeBuilder.treeHtmlTagsInParagraph(); compareTrees(expectedTree, generatedTree); } @Test public void linkInlineTags() throws IOException { - String filename = getDocPath("InputLinkInlineTags.txt"); - ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); - ParseTree expectedTree = ParseTreeBuilder.treeLinkInlineTags(); + final String filename = getDocPath("InputLinkInlineTags.txt"); + final ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); + final ParseTree expectedTree = ParseTreeBuilder.treeLinkInlineTags(); compareTrees(expectedTree, generatedTree); } @Test public void seeReferenceWithFewNestedClasses() throws IOException { - String filename = getDocPath("InputSeeReferenceWithFewNestedClasses.txt"); - ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); - ParseTree expectedTree = ParseTreeBuilder.treeSeeReferenceWithFewNestedClasses(); + final String filename = getDocPath("InputSeeReferenceWithFewNestedClasses.txt"); + final ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); + final ParseTree expectedTree = ParseTreeBuilder.treeSeeReferenceWithFewNestedClasses(); compareTrees(expectedTree, generatedTree); } @Test public void paramWithGeneric() throws IOException { - String filename = getDocPath("InputParamWithGeneric.txt"); - ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); - ParseTree expectedTree = ParseTreeBuilder.treeParamWithGeneric(); + final String filename = getDocPath("InputParamWithGeneric.txt"); + final ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); + final ParseTree expectedTree = ParseTreeBuilder.treeParamWithGeneric(); compareTrees(expectedTree, generatedTree); } @Test public void serial() throws IOException { - String filename = getDocPath("InputSerial.txt"); - ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); - ParseTree expectedTree = ParseTreeBuilder.treeSerial(); + final String filename = getDocPath("InputSerial.txt"); + final ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); + final ParseTree expectedTree = ParseTreeBuilder.treeSerial(); compareTrees(expectedTree, generatedTree); } @Test public void since() throws IOException { - String filename = getDocPath("InputSince.txt"); - ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); - ParseTree expectedTree = ParseTreeBuilder.treeSince(); + final String filename = getDocPath("InputSince.txt"); + final ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); + final ParseTree expectedTree = ParseTreeBuilder.treeSince(); compareTrees(expectedTree, generatedTree); } @Test public void unclosedAndClosedParagraphs() throws IOException { - String filename = getHtmlPath("InputUnclosedAndClosedParagraphs.txt"); - ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); - ParseTree expectedTree = ParseTreeBuilder.treeUnclosedAndClosedParagraphs(); + final String filename = getHtmlPath("InputUnclosedAndClosedParagraphs.txt"); + final ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); + final ParseTree expectedTree = ParseTreeBuilder.treeUnclosedAndClosedParagraphs(); compareTrees(expectedTree, generatedTree); } @Test public void listWithUnclosedItemInUnclosedParagraph() throws IOException { - String filename = getHtmlPath("InputListWithUnclosedItemInUnclosedParagraph.txt"); - ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); - ParseTree expectedTree = ParseTreeBuilder.treeListWithUnclosedItemInUnclosedParagraph(); + final String filename = getHtmlPath("InputListWithUnclosedItemInUnclosedParagraph.txt"); + final ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); + final ParseTree expectedTree = ParseTreeBuilder + .treeListWithUnclosedItemInUnclosedParagraph(); compareTrees(expectedTree, generatedTree); } @Test public void unclosedParagraphFollowedByJavadocTag() throws IOException { - String filename = getHtmlPath("InputUnclosedParagraphFollowedByJavadocTag.txt"); - ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); - ParseTree expectedTree = ParseTreeBuilder.treeUnclosedParagraphFollowedByJavadocTag(); + final String filename = getHtmlPath("InputUnclosedParagraphFollowedByJavadocTag.txt"); + final ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); + final ParseTree expectedTree = ParseTreeBuilder.treeUnclosedParagraphFollowedByJavadocTag(); compareTrees(expectedTree, generatedTree); } @Test public void allJavadocInlineTags() throws IOException { - String filename = getDocPath("InputAllJavadocInlineTags.txt"); - ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); - ParseTree expectedTree = ParseTreeBuilder.treeAllJavadocInlineTags(); + final String filename = getDocPath("InputAllJavadocInlineTags.txt"); + final ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); + final ParseTree expectedTree = ParseTreeBuilder.treeAllJavadocInlineTags(); compareTrees(expectedTree, generatedTree); } @Test public void docRootInheritDoc() throws IOException { - String filename = getDocPath("InputDocRootInheritDoc.txt"); - ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); - ParseTree expectedTree = ParseTreeBuilder.treeDocRootInheritDoc(); + final String filename = getDocPath("InputDocRootInheritDoc.txt"); + final ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); + final ParseTree expectedTree = ParseTreeBuilder.treeDocRootInheritDoc(); compareTrees(expectedTree, generatedTree); } @Test public void fewWhiteSpacesAsSeparator() throws IOException { - String filename = getDocPath("InputFewWhiteSpacesAsSeparator.txt"); - ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); - ParseTree expectedTree = ParseTreeBuilder.treeFewWhiteSpacesAsSeparator(); + final String filename = getDocPath("InputFewWhiteSpacesAsSeparator.txt"); + final ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); + final ParseTree expectedTree = ParseTreeBuilder.treeFewWhiteSpacesAsSeparator(); compareTrees(expectedTree, generatedTree); } @Test public void mixedCaseOfHtmlTags() throws IOException { - String filename = getHtmlPath("InputMixedCaseOfHtmlTags.txt"); - ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); - ParseTree expectedTree = ParseTreeBuilder.treeMixedCaseOfHtmlTags(); + final String filename = getHtmlPath("InputMixedCaseOfHtmlTags.txt"); + final ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); + final ParseTree expectedTree = ParseTreeBuilder.treeMixedCaseOfHtmlTags(); compareTrees(expectedTree, generatedTree); } @Test public void htmlComments() throws IOException { - String filename = getHtmlPath("InputComments.txt"); - ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); - ParseTree expectedTree = ParseTreeBuilder.treeComments(); + final String filename = getHtmlPath("InputComments.txt"); + final ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); + final ParseTree expectedTree = ParseTreeBuilder.treeComments(); compareTrees(expectedTree, generatedTree); } @Test public void negativeNumberInAttribute() throws IOException { - String filename = getHtmlPath("InputNegativeNumberInAttribute.txt"); - ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); - ParseTree expectedTree = ParseTreeBuilder.treeNegativeNumberInAttribute(); + final String filename = getHtmlPath("InputNegativeNumberInAttribute.txt"); + final ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); + final ParseTree expectedTree = ParseTreeBuilder.treeNegativeNumberInAttribute(); compareTrees(expectedTree, generatedTree); } @Test public void dollarInLink() throws IOException { - String filename = getDocPath("InputDollarInLink.txt"); - ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); - ParseTree expectedTree = ParseTreeBuilder.treeDollarInLink(); + final String filename = getDocPath("InputDollarInLink.txt"); + final ParseTree generatedTree = parseJavadoc(getFileContent(new File(filename))); + final ParseTree expectedTree = ParseTreeBuilder.treeDollarInLink(); compareTrees(expectedTree, generatedTree); } diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/utils/AnnotationUtilityTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/utils/AnnotationUtilityTest.java index b55669284..5ce697d1e 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/utils/AnnotationUtilityTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/utils/AnnotationUtilityTest.java @@ -66,16 +66,16 @@ public class AnnotationUtilityTest { @Test public void testContainsAnnotationFalse() throws ReflectiveOperationException { - DetailAST ast = new DetailAST(); + final DetailAST ast = new DetailAST(); ast.setType(1); Assert.assertFalse(AnnotationUtility.containsAnnotation(ast)); } @Test public void testContainsAnnotationFalse2() throws ReflectiveOperationException { - DetailAST ast = new DetailAST(); + final DetailAST ast = new DetailAST(); ast.setType(1); - DetailAST ast2 = new DetailAST(); + final DetailAST ast2 = new DetailAST(); ast2.setType(TokenTypes.MODIFIERS); ast.addChild(ast2); Assert.assertFalse(AnnotationUtility.containsAnnotation(ast)); @@ -83,12 +83,12 @@ public class AnnotationUtilityTest { @Test public void testContainsAnnotationTrue() throws ReflectiveOperationException { - DetailAST ast = new DetailAST(); + final DetailAST ast = new DetailAST(); ast.setType(1); - DetailAST ast2 = new DetailAST(); + final DetailAST ast2 = new DetailAST(); ast2.setType(TokenTypes.MODIFIERS); ast.addChild(ast2); - DetailAST ast3 = new DetailAST(); + final DetailAST ast3 = new DetailAST(); ast3.setType(TokenTypes.ANNOTATION); ast2.addChild(ast3); Assert.assertTrue(AnnotationUtility.containsAnnotation(ast)); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/utils/CheckUtilsTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/utils/CheckUtilsTest.java index ee0655f75..17d47adf6 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/utils/CheckUtilsTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/utils/CheckUtilsTest.java @@ -37,29 +37,29 @@ public class CheckUtilsTest { @Test public void testParseDoubleWithIncorrectToken() throws Exception { - double parsedDouble = CheckUtils.parseDouble("1_02", TokenTypes.ASSIGN); + final double parsedDouble = CheckUtils.parseDouble("1_02", TokenTypes.ASSIGN); assertEquals(0.0, parsedDouble, 0.0); } @Test public void testElseWithCurly() throws Exception { - DetailAST ast = new DetailAST(); + final DetailAST ast = new DetailAST(); ast.setType(TokenTypes.ASSIGN); ast.setText("ASSIGN"); Assert.assertFalse(CheckUtils.isElseIf(ast)); - DetailAST parentAst = new DetailAST(); + final DetailAST parentAst = new DetailAST(); parentAst.setType(TokenTypes.LCURLY); parentAst.setText("LCURLY"); - DetailAST ifAst = new DetailAST(); + final DetailAST ifAst = new DetailAST(); ifAst.setType(TokenTypes.LITERAL_IF); ifAst.setText("IF"); parentAst.addChild(ifAst); Assert.assertFalse(CheckUtils.isElseIf(ifAst)); - DetailAST parentAst2 = new DetailAST(); + final DetailAST parentAst2 = new DetailAST(); parentAst2.setType(TokenTypes.SLIST); parentAst2.setText("SLIST"); @@ -67,7 +67,7 @@ public class CheckUtilsTest { Assert.assertFalse(CheckUtils.isElseIf(ifAst)); - DetailAST elseAst = new DetailAST(); + final DetailAST elseAst = new DetailAST(); elseAst.setType(TokenTypes.LITERAL_ELSE); elseAst.setFirstChild(ifAst); @@ -76,14 +76,14 @@ public class CheckUtilsTest { @Test public void testEquals() throws Exception { - DetailAST litStatic = new DetailAST(); + final DetailAST litStatic = new DetailAST(); litStatic.setType(TokenTypes.LITERAL_STATIC); - DetailAST modifiers = new DetailAST(); + final DetailAST modifiers = new DetailAST(); modifiers.setType(TokenTypes.MODIFIERS); modifiers.addChild(litStatic); - DetailAST metDef = new DetailAST(); + final DetailAST metDef = new DetailAST(); metDef.setType(TokenTypes.METHOD_DEF); metDef.addChild(modifiers); @@ -91,19 +91,19 @@ public class CheckUtilsTest { metDef.removeChildren(); - DetailAST metName = new DetailAST(); + final DetailAST metName = new DetailAST(); metName.setType(TokenTypes.IDENT); metName.setText("equals"); metDef.addChild(metName); - DetailAST modifiers2 = new DetailAST(); + final DetailAST modifiers2 = new DetailAST(); modifiers2.setType(TokenTypes.MODIFIERS); metDef.addChild(modifiers2); - DetailAST parameter1 = new DetailAST(); - DetailAST parameter2 = new DetailAST(); + final DetailAST parameter1 = new DetailAST(); + final DetailAST parameter2 = new DetailAST(); - DetailAST parameters = new DetailAST(); + final DetailAST parameters = new DetailAST(); parameters.setType(TokenTypes.PARAMETERS); parameters.addChild(parameter2); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/utils/CommonUtilsTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/utils/CommonUtilsTest.java index c6e8cb260..da7418f48 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/utils/CommonUtilsTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/utils/CommonUtilsTest.java @@ -89,12 +89,12 @@ public class CommonUtilsTest { @Test public void testFileExtensions() { final String[] fileExtensions = {"java"}; - File pdfFile = new File("file.pdf"); + final File pdfFile = new File("file.pdf"); assertFalse(CommonUtils.matchesFileExtension(pdfFile, fileExtensions)); assertTrue(CommonUtils.matchesFileExtension(pdfFile, (String[]) null)); - File javaFile = new File("file.java"); + final File javaFile = new File("file.java"); assertTrue(CommonUtils.matchesFileExtension(javaFile, fileExtensions)); - File emptyExtensionFile = new File("file."); + final File emptyExtensionFile = new File("file."); assertTrue(CommonUtils.matchesFileExtension(emptyExtensionFile, "")); } @@ -136,13 +136,13 @@ public class CommonUtilsTest { @Test public void testInvalidPattern() { - boolean result = CommonUtils.isPatternValid("some[invalidPattern"); + final boolean result = CommonUtils.isPatternValid("some[invalidPattern"); assertFalse(result); } @Test public void testGetExistingConstructor() throws NoSuchMethodException { - Constructor<?> constructor = CommonUtils.getConstructor(String.class, String.class); + final Constructor<?> constructor = CommonUtils.getConstructor(String.class, String.class); assertEquals(String.class.getConstructor(String.class), constructor); } @@ -160,9 +160,9 @@ public class CommonUtilsTest { @Test public void testInvokeConstructor() throws NoSuchMethodException { - Constructor<String> constructor = String.class.getConstructor(String.class); + final Constructor<String> constructor = String.class.getConstructor(String.class); - String constructedString = CommonUtils.invokeConstructor(constructor, "string"); + final String constructedString = CommonUtils.invokeConstructor(constructor, "string"); assertEquals("string", constructedString); } @@ -170,7 +170,7 @@ public class CommonUtilsTest { @SuppressWarnings("rawtypes") @Test public void testInvokeConstructorThatFails() throws NoSuchMethodException { - Constructor<Dictionary> constructor = Dictionary.class.getConstructor(); + final Constructor<Dictionary> constructor = Dictionary.class.getConstructor(); try { CommonUtils.invokeConstructor(constructor); @@ -183,7 +183,7 @@ public class CommonUtilsTest { @Test public void testClose() { - TestCloseable closeable = new TestCloseable(); + final TestCloseable closeable = new TestCloseable(); CommonUtils.close(null); CommonUtils.close(closeable); @@ -206,11 +206,11 @@ public class CommonUtilsTest { @PrepareForTest({ CommonUtils.class, CommonUtilsTest.class }) @SuppressWarnings("unchecked") public void testLoadSuppressionsURISyntaxException() throws Exception { - URL configUrl = mock(URL.class); + final URL configUrl = mock(URL.class); when(configUrl.toURI()).thenThrow(URISyntaxException.class); mockStatic(CommonUtils.class, Mockito.CALLS_REAL_METHODS); - String fileName = "suppressions_none.xml"; + final String fileName = "suppressions_none.xml"; when(CommonUtils.class.getResource(fileName)).thenReturn(configUrl); try { diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/utils/JavadocUtilsTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/utils/JavadocUtilsTest.java index da28f5d60..ae85727b7 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/utils/JavadocUtilsTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/utils/JavadocUtilsTest.java @@ -140,15 +140,15 @@ public class JavadocUtilsTest { @Test public void testEmptyBlockCommentAst() { - DetailAST commentBegin = new DetailAST(); + final DetailAST commentBegin = new DetailAST(); commentBegin.setType(TokenTypes.BLOCK_COMMENT_BEGIN); commentBegin.setText("/*"); - DetailAST commentContent = new DetailAST(); + final DetailAST commentContent = new DetailAST(); commentContent.setType(TokenTypes.COMMENT_CONTENT); commentContent.setText(""); - DetailAST commentEnd = new DetailAST(); + final DetailAST commentEnd = new DetailAST(); commentEnd.setType(TokenTypes.BLOCK_COMMENT_END); commentEnd.setText("*/"); @@ -166,15 +166,15 @@ public class JavadocUtilsTest { @Test public void testEmptyJavadocCommentAst() { - DetailAST commentBegin = new DetailAST(); + final DetailAST commentBegin = new DetailAST(); commentBegin.setType(TokenTypes.BLOCK_COMMENT_BEGIN); commentBegin.setText("/*"); - DetailAST javadocCommentContent = new DetailAST(); + final DetailAST javadocCommentContent = new DetailAST(); javadocCommentContent.setType(TokenTypes.COMMENT_CONTENT); javadocCommentContent.setText("*"); - DetailAST commentEnd = new DetailAST(); + final DetailAST commentEnd = new DetailAST(); commentEnd.setType(TokenTypes.BLOCK_COMMENT_END); commentEnd.setText("*/"); @@ -191,9 +191,9 @@ public class JavadocUtilsTest { @Test public void testBranchContains() { - JavadocNodeImpl node = new JavadocNodeImpl(); - JavadocNodeImpl firstChild = new JavadocNodeImpl(); - JavadocNodeImpl secondChild = new JavadocNodeImpl(); + final JavadocNodeImpl node = new JavadocNodeImpl(); + final JavadocNodeImpl firstChild = new JavadocNodeImpl(); + final JavadocNodeImpl secondChild = new JavadocNodeImpl(); node.setType(JavadocTokenTypes.JAVADOC); firstChild.setType(JavadocTokenTypes.BODY_TAG_OPEN); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/utils/ScopeUtilsTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/utils/ScopeUtilsTest.java index 03f1d6db6..91bf13453 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/utils/ScopeUtilsTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/utils/ScopeUtilsTest.java @@ -36,15 +36,15 @@ public class ScopeUtilsTest { @Test public void testInEnumOnRoot() throws ReflectiveOperationException { - DetailAST ast = new DetailAST(); + final DetailAST ast = new DetailAST(); Assert.assertFalse(ScopeUtils.isInEnumBlock(ast)); } @Test public void testInEnumBlockInNew() throws ReflectiveOperationException { - DetailAST ast = new DetailAST(); + final DetailAST ast = new DetailAST(); ast.setType(TokenTypes.LITERAL_NEW); - DetailAST ast2 = new DetailAST(); + final DetailAST ast2 = new DetailAST(); ast2.setType(TokenTypes.MODIFIERS); ast.addChild(ast2); @@ -53,12 +53,12 @@ public class ScopeUtilsTest { @Test public void testInEnumBlockWithEnum() throws ReflectiveOperationException { - DetailAST ast0 = new DetailAST(); + final DetailAST ast0 = new DetailAST(); ast0.setType(TokenTypes.OBJBLOCK); - DetailAST ast1 = new DetailAST(); + final DetailAST ast1 = new DetailAST(); ast1.setType(TokenTypes.ENUM_DEF); ast0.addChild(ast1); - DetailAST ast2 = new DetailAST(); + final DetailAST ast2 = new DetailAST(); ast2.setType(TokenTypes.MODIFIERS); ast1.addChild(ast2); @@ -67,9 +67,9 @@ public class ScopeUtilsTest { @Test public void testInEnumBlockInInterface() throws ReflectiveOperationException { - DetailAST ast = new DetailAST(); + final DetailAST ast = new DetailAST(); ast.setType(TokenTypes.INTERFACE_DEF); - DetailAST ast2 = new DetailAST(); + final DetailAST ast2 = new DetailAST(); ast2.setType(TokenTypes.MODIFIERS); ast.addChild(ast2); @@ -78,9 +78,9 @@ public class ScopeUtilsTest { @Test public void testInEnumBlockInAnnotation() throws ReflectiveOperationException { - DetailAST ast = new DetailAST(); + final DetailAST ast = new DetailAST(); ast.setType(TokenTypes.ANNOTATION_DEF); - DetailAST ast2 = new DetailAST(); + final DetailAST ast2 = new DetailAST(); ast2.setType(TokenTypes.MODIFIERS); ast.addChild(ast2); @@ -89,9 +89,9 @@ public class ScopeUtilsTest { @Test public void testInEnumBlockInClass() throws ReflectiveOperationException { - DetailAST ast = new DetailAST(); + final DetailAST ast = new DetailAST(); ast.setType(TokenTypes.CLASS_DEF); - DetailAST ast2 = new DetailAST(); + final DetailAST ast2 = new DetailAST(); ast2.setType(TokenTypes.MODIFIERS); ast.addChild(ast2); @@ -100,9 +100,9 @@ public class ScopeUtilsTest { @Test public void testIsOuterMostTypeInterface() throws ReflectiveOperationException { - DetailAST ast = new DetailAST(); + final DetailAST ast = new DetailAST(); ast.setType(TokenTypes.INTERFACE_DEF); - DetailAST ast2 = new DetailAST(); + final DetailAST ast2 = new DetailAST(); ast2.setType(TokenTypes.MODIFIERS); ast.addChild(ast2); @@ -111,9 +111,9 @@ public class ScopeUtilsTest { @Test public void testIsOuterMostTypeAnnotation() throws ReflectiveOperationException { - DetailAST ast = new DetailAST(); + final DetailAST ast = new DetailAST(); ast.setType(TokenTypes.ANNOTATION_DEF); - DetailAST ast2 = new DetailAST(); + final DetailAST ast2 = new DetailAST(); ast2.setType(TokenTypes.MODIFIERS); ast.addChild(ast2); @@ -122,9 +122,9 @@ public class ScopeUtilsTest { @Test public void testIsOuterMostTypeEnum() throws ReflectiveOperationException { - DetailAST ast = new DetailAST(); + final DetailAST ast = new DetailAST(); ast.setType(TokenTypes.ENUM_DEF); - DetailAST ast2 = new DetailAST(); + final DetailAST ast2 = new DetailAST(); ast2.setType(TokenTypes.MODIFIERS); ast.addChild(ast2); @@ -133,9 +133,9 @@ public class ScopeUtilsTest { @Test public void testIsLocalVariableDefCatch() throws ReflectiveOperationException { - DetailAST ast = new DetailAST(); + final DetailAST ast = new DetailAST(); ast.setType(TokenTypes.LITERAL_CATCH); - DetailAST ast2 = new DetailAST(); + final DetailAST ast2 = new DetailAST(); ast2.setType(TokenTypes.PARAMETER_DEF); ast.addChild(ast2); @@ -144,7 +144,7 @@ public class ScopeUtilsTest { @Test public void testIsLocalVariableDefUnexpected() throws ReflectiveOperationException { - DetailAST ast = new DetailAST(); + final DetailAST ast = new DetailAST(); ast.setType(TokenTypes.LITERAL_CATCH); Assert.assertFalse(ScopeUtils.isLocalVariableDef(ast)); diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/utils/TokenUtilsTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/utils/TokenUtilsTest.java index c1e3fbeeb..9cd7744be 100644 --- a/src/test/java/com/puppycrawl/tools/checkstyle/utils/TokenUtilsTest.java +++ b/src/test/java/com/puppycrawl/tools/checkstyle/utils/TokenUtilsTest.java @@ -40,14 +40,14 @@ public class TokenUtilsTest { @Test public void testGetIntFromAccessibleField() throws NoSuchFieldException { - Field field = Integer.class.getField("MAX_VALUE"); + final Field field = Integer.class.getField("MAX_VALUE"); assertEquals(Integer.MAX_VALUE, TokenUtils.getIntFromField(field, 0)); } @Test public void testGetIntFromInaccessibleField() throws NoSuchFieldException { - Field field = Integer.class.getDeclaredField("value"); + final Field field = Integer.class.getDeclaredField("value"); try { TokenUtils.getIntFromField(field, 0); @@ -63,7 +63,7 @@ public class TokenUtilsTest { @Test public void testTokenValueIncorrect() { - Integer id = Integer.MAX_VALUE - 1; + final Integer id = Integer.MAX_VALUE - 1; try { TokenUtils.getTokenName(id); fail(); @@ -75,17 +75,17 @@ public class TokenUtilsTest { @Test public void testTokenValueIncorrect2() throws Exception { - Integer id = 0; + final Integer id = 0; String[] originalValue = null; Field fieldToken = null; try { // overwrite static field with new value - Field[] fields = TokenUtils.class.getDeclaredFields(); + final Field[] fields = TokenUtils.class.getDeclaredFields(); for (Field field : fields) { field.setAccessible(true); if ("TOKEN_VALUE_TO_NAME".equals(field.getName())) { fieldToken = field; - Field modifiersField = Field.class.getDeclaredField("modifiers"); + final Field modifiersField = Field.class.getDeclaredField("modifiers"); modifiersField.setAccessible(true); modifiersField.setInt(field, field.getModifiers() & ~Modifier.FINAL); originalValue = (String[]) field.get(null); @@ -110,7 +110,7 @@ public class TokenUtilsTest { @Test public void testTokenIdIncorrect() { - String id = "NON_EXISTING_VALUE"; + final String id = "NON_EXISTING_VALUE"; try { TokenUtils.getTokenId(id); fail(); @@ -122,7 +122,7 @@ public class TokenUtilsTest { @Test public void testShortDescriptionIncorrect() { - String id = "NON_EXISTING_VALUE"; + final String id = "NON_EXISTING_VALUE"; try { TokenUtils.getShortDescription(id); fail(); |