Issue #1273: CustomImportOrderCheck rule priorities

3 files changed, 59 insertions, 8 deletions

diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/imports/InputCustomImportOrder2.java b/src/test/resources/com/puppycrawl/tools/checkstyle/imports/InputCustomImportOrder2.java
index 3cb591d76..a87c97e9e 100644
--- a/src/test/resources/com/puppycrawl/tools/checkstyle/imports/InputCustomImportOrder2.java
+++ b/src/test/resources/com/puppycrawl/tools/checkstyle/imports/InputCustomImportOrder2.java
@@ -1,20 +1,28 @@
 package com.puppycrawl.tools.checkstyle.imports;
 
 import static java.io.File.createTempFile;
-import static java.awt.Button.ABORT;
+import static java.awt.Button.ABORT; //warn, LEXIC, should be before java.io.File.createTempFile
 import static javax.swing.WindowConstants.*;
 
-import java.util.List;
-import java.util.StringTokenizer;
-import java.util.*;
-import java.util.concurrent.AbstractExecutorService;
-import java.util.concurrent.*;
+import java.util.List; //warn, LEXIC, should be before javax.swing.WindowConstants.*
+import java.util.StringTokenizer; //warn, LEXIC, should be before javax.swing.WindowConstants.*
+import java.util.*; //warn, LEXIC, should be before javax.swing.WindowConstants.*
+import java.util.concurrent.AbstractExecutorService; //warn, LEXIC, should be before javax.swing.WindowConstants.*
+import java.util.concurrent.*; //warn, LEXIC, should be before javax.swing.WindowConstants.*
 
 import com.puppycrawl.tools.*;
-import com.*;
+import com.*; //warn, LEXIC, should be before com.puppycrawl.tools.*
 
-import com.google.common.base.*;
+import com.google.common.base.*; //warn, LEXIC, should be before com.puppycrawl.tools.*
 import org.junit.*;
 
 public class InputCustomImportOrder2 {
 }
+/*
+test: testOrderRuleWithOneGroup()
+configuration:
+        checkConfig.addAttribute("thirdPartyPackageRegExp", "org.");
+        checkConfig.addAttribute("customImportOrderRules",
+                "STANDARD_JAVA_PACKAGE");
+        checkConfig.addAttribute("sortImportsInGroupAlphabetically", "true");
+*/
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/imports/InputCustomImportOrder_MultiplePatternMatches.java b/src/test/resources/com/puppycrawl/tools/checkstyle/imports/InputCustomImportOrder_MultiplePatternMatches.java
new file mode 100644
index 000000000..1002ecece
--- /dev/null
+++ b/src/test/resources/com/puppycrawl/tools/checkstyle/imports/InputCustomImportOrder_MultiplePatternMatches.java
@@ -0,0 +1,6 @@
+package com.puppycrawl.tools.checkstyle.imports;
+
+import org.junit.Test;
+
+public class InputCustomImportOrder_MultiplePatternMatches {
+}
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/imports/InputCustomImportOrder_OverlappingPatterns.java b/src/test/resources/com/puppycrawl/tools/checkstyle/imports/InputCustomImportOrder_OverlappingPatterns.java
new file mode 100644
index 000000000..10b839922
--- /dev/null
+++ b/src/test/resources/com/puppycrawl/tools/checkstyle/imports/InputCustomImportOrder_OverlappingPatterns.java
@@ -0,0 +1,37 @@
+package com.puppycrawl.tools.checkstyle.checks.imports;
+
+import com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck;
+import com.puppycrawl.tools.checkstyle.checks.imports.ImportOrderCheck;
+import com.puppycrawl.tools.checkstyle.checks.imports.ImportOrderOption;
+
+// every import from javadoc package has comment in brackets indicating presence of keywords
+// Javadoc, Check, Tag. For example J_T = Javadoc, no Check, Tag
+import com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocNodeImpl; //warn, should be on THIRD-PARTY (J__)
+
+// STANDARD - keyword Check
+
+import com.puppycrawl.tools.checkstyle.checks.javadoc.AbstractJavadocCheck; // (JC_)
+import com.puppycrawl.tools.checkstyle.checks.javadoc.AtclauseOrderCheck; // (_C_)
+import com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocTagContinuationIndentationCheck; // (JCT)
+
+// SPECIAL_IMPORTS - keyword Tag
+
+import com.puppycrawl.tools.checkstyle.checks.javadoc.InvalidJavadocTag; // (J_T)
+//import com.puppycrawl.tools.checkstyle.checks.javadoc.TagParser; // (__T)
+import com.puppycrawl.tools.checkstyle.checks.javadoc.WriteTagCheck; //warn, should be on STANDARD (_CT)
+
+import com.puppycrawl.tools.*;
+//import com.puppycrawl.tools.checkstyle.checks.javadoc.HtmlTag; //warn, should be on SPECIAL (__T)
+import com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocTag; //warn, should be on SPECIAL (J_T)
+import com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck; //warn, should be on STANDARD  (JC_)
+import com.puppycrawl.tools.checkstyle.checks.javadoc.NonEmptyAtclauseDescriptionCheck; //warn, should be on STANDARD (_C_)
+
+public class InputCustomImportOrder_OverlappingPatterns {
+}
+/*
+test: testRulesOrder_ThirdBeforeSame()
+configuration:
+        checkConfig.addAttribute("customImportOrderRules",
+                "THIRD_PARTY_PACKAGE###SAME_PACKAGE(3)###SPECIAL_IMPORTS");
+        checkConfig.addAttribute("sortImportsInGroupAlphabetically", "true");
+*/