aboutsummaryrefslogtreecommitdiff
path: root/src/test
diff options
context:
space:
mode:
authorAndrei Selkin <andreyselkin@gmail.com>2015-12-09 22:54:41 +0300
committerAndrei Selkin <andreyselkin@gmail.com>2015-12-09 22:59:54 +0300
commit75bbb441800de900e268cfa5ee82a64966b405b2 (patch)
treed697871302b2065249acb8cec88688c7869ada01 /src/test
parent5d7226fac58883bc41058b28b8fcdb6f159cf1e2 (diff)
downloadcheckstyle-75bbb441800de900e268cfa5ee82a64966b405b2.tar.gz
Issue #2678: Fix NPE in ParameterNameCheck
Diffstat (limited to 'src/test')
-rw-r--r--src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/ParameterNameCheckTest.java10
-rw-r--r--src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/InputOverrideAnnotationNoNPE.java27
2 files changed, 37 insertions, 0 deletions
diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/ParameterNameCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/ParameterNameCheckTest.java
index 1c35fd32e..28b363d87 100644
--- a/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/ParameterNameCheckTest.java
+++ b/src/test/java/com/puppycrawl/tools/checkstyle/checks/naming/ParameterNameCheckTest.java
@@ -137,4 +137,14 @@ public class ParameterNameCheckTest
};
verify(checkConfig, getPath("InputOverrideAnnotation.java"), expected);
}
+
+ @Test
+ public void testIsOverriddenNoNullPointerException()
+ throws Exception {
+ final DefaultConfiguration checkConfig = createCheckConfig(ParameterNameCheck.class);
+ checkConfig.addAttribute("format", "^[a-z][a-zA-Z0-9]*$");
+ checkConfig.addAttribute("ignoreOverridden", "true");
+ final String[] expected = ArrayUtils.EMPTY_STRING_ARRAY;
+ verify(checkConfig, getPath("InputOverrideAnnotationNoNPE.java"), expected);
+ }
}
diff --git a/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/InputOverrideAnnotationNoNPE.java b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/InputOverrideAnnotationNoNPE.java
new file mode 100644
index 000000000..8295a120e
--- /dev/null
+++ b/src/test/resources/com/puppycrawl/tools/checkstyle/checks/naming/InputOverrideAnnotationNoNPE.java
@@ -0,0 +1,27 @@
+package com.puppycrawl.tools.checkstyle.checks.naming;
+
+class InputOverrideAnnotationNoNPE
+{
+ // method with many parameters
+ void myMethod(int a, int b) {
+
+ }
+
+ // method with many parameters
+ void myMethod2(int a, int b) {
+
+ }
+}
+
+class Test extends InputOverrideAnnotationNoNPE
+{
+ @Override
+ void myMethod(int a, int b) {
+
+ }
+
+ @java.lang.Override
+ void myMethod2(int a, int b) {
+
+ }
+}