1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
|
////////////////////////////////////////////////////////////////////////////////
// checkstyle: Checks Java source code for adherence to a set of rules.
// Copyright (C) 2001-2016 the original author or authors.
//
// This library is free software; you can redistribute it and/or
// modify it under the terms of the GNU Lesser General Public
// License as published by the Free Software Foundation; either
// version 2.1 of the License, or (at your option) any later version.
//
// This library is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
// Lesser General Public License for more details.
//
// You should have received a copy of the GNU Lesser General Public
// License along with this library; if not, write to the Free Software
// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
////////////////////////////////////////////////////////////////////////////////
package com.puppycrawl.tools.checkstyle.checks;
import static com.puppycrawl.tools.checkstyle.checks.FinalParametersCheck.MSG_KEY;
import java.io.File;
import java.io.IOException;
import org.junit.Test;
import com.puppycrawl.tools.checkstyle.BaseCheckTestSupport;
import com.puppycrawl.tools.checkstyle.DefaultConfiguration;
import com.puppycrawl.tools.checkstyle.utils.CommonUtils;
public class FinalParametersCheckTest extends BaseCheckTestSupport {
@Override
protected String getPath(String filename) throws IOException {
return super.getPath("checks" + File.separator + filename);
}
@Test
public void testDefaultTokens() throws Exception {
final DefaultConfiguration checkConfig =
createCheckConfig(FinalParametersCheck.class);
final String[] expected = {
"23:26: " + getCheckMessage(MSG_KEY, "s"),
"38:26: " + getCheckMessage(MSG_KEY, "i"),
"43:26: " + getCheckMessage(MSG_KEY, "s"),
"53:17: " + getCheckMessage(MSG_KEY, "s"),
"69:17: " + getCheckMessage(MSG_KEY, "s"),
"75:17: " + getCheckMessage(MSG_KEY, "s"),
"90:45: " + getCheckMessage(MSG_KEY, "e"),
"93:36: " + getCheckMessage(MSG_KEY, "e"),
"110:18: " + getCheckMessage(MSG_KEY, "aParam"),
"113:18: " + getCheckMessage(MSG_KEY, "args"),
"116:18: " + getCheckMessage(MSG_KEY, "args"),
};
verify(checkConfig, getPath("InputFinalParameters.java"), expected);
}
@Test
public void testCtorToken() throws Exception {
final DefaultConfiguration checkConfig =
createCheckConfig(FinalParametersCheck.class);
checkConfig.addAttribute("tokens", "CTOR_DEF");
final String[] expected = {
"23:26: " + getCheckMessage(MSG_KEY, "s"),
"38:26: " + getCheckMessage(MSG_KEY, "i"),
"43:26: " + getCheckMessage(MSG_KEY, "s"),
};
verify(checkConfig, getPath("InputFinalParameters.java"), expected);
}
@Test
public void testMethodToken() throws Exception {
final DefaultConfiguration checkConfig =
createCheckConfig(FinalParametersCheck.class);
checkConfig.addAttribute("tokens", "METHOD_DEF");
final String[] expected = {
"53:17: " + getCheckMessage(MSG_KEY, "s"),
"69:17: " + getCheckMessage(MSG_KEY, "s"),
"75:17: " + getCheckMessage(MSG_KEY, "s"),
"90:45: " + getCheckMessage(MSG_KEY, "e"),
"93:36: " + getCheckMessage(MSG_KEY, "e"),
"110:18: " + getCheckMessage(MSG_KEY, "aParam"),
"113:18: " + getCheckMessage(MSG_KEY, "args"),
"116:18: " + getCheckMessage(MSG_KEY, "args"),
};
verify(checkConfig, getPath("InputFinalParameters.java"), expected);
}
@Test
public void testCatchToken() throws Exception {
final DefaultConfiguration checkConfig =
createCheckConfig(FinalParametersCheck.class);
checkConfig.addAttribute("tokens", "LITERAL_CATCH");
final String[] expected = {
"125:16: " + getCheckMessage(MSG_KEY, "npe"),
"131:16: " + getCheckMessage(MSG_KEY, "e"),
"134:16: " + getCheckMessage(MSG_KEY, "e"),
};
verify(checkConfig, getPath("InputFinalParameters.java"), expected);
}
@Test
public void testForEachClauseToken() throws Exception {
final DefaultConfiguration checkConfig =
createCheckConfig(FinalParametersCheck.class);
checkConfig.addAttribute("tokens", "FOR_EACH_CLAUSE");
final String[] expected = {
"152:13: " + getCheckMessage(MSG_KEY, "s"),
"160:13: " + getCheckMessage(MSG_KEY, "s"),
};
verify(checkConfig, getPath("InputFinalParameters.java"), expected);
}
@Test
public void testIgnorePrimitiveTypesParameters() throws Exception {
final DefaultConfiguration checkConfig =
createCheckConfig(FinalParametersCheck.class);
checkConfig.addAttribute("ignorePrimitiveTypes", "true");
final String[] expected = {
"6:22: " + getCheckMessage(MSG_KEY, "k"),
"7:15: " + getCheckMessage(MSG_KEY, "s"),
"7:25: " + getCheckMessage(MSG_KEY, "o"),
"8:15: " + getCheckMessage(MSG_KEY, "array"),
"9:31: " + getCheckMessage(MSG_KEY, "s"),
"10:22: " + getCheckMessage(MSG_KEY, "l"),
"10:32: " + getCheckMessage(MSG_KEY, "s"),
};
verify(checkConfig, getPath("InputFinalParametersPrimitiveTypes.java"), expected);
}
@Test
public void testRecieverParameters() throws Exception {
final DefaultConfiguration checkConfig =
createCheckConfig(FinalParametersCheck.class);
final String[] expected = CommonUtils.EMPTY_STRING_ARRAY;
verify(checkConfig, getPath("InputFinalParametersReceiver.java"), expected);
}
}
|
