1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
|
/*
* Copyright (C) 2021 The Dagger Authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package dagger.internal.codegen;
import static com.google.common.truth.Truth.assertThat;
import androidx.room.compiler.processing.XProcessingEnv;
import androidx.room.compiler.processing.util.Source;
import com.google.common.collect.ImmutableMap;
import dagger.testing.compile.CompilerTests;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
@RunWith(JUnit4.class)
public final class UnresolvableDependencyTest {
@Test
public void referencesUnresolvableDependency() {
Source fooComponent =
CompilerTests.javaSource(
"test.FooComponent",
"package test;",
"",
"import dagger.Component;",
"",
"@Component",
"interface FooComponent {",
" Foo foo();",
"}");
Source foo =
CompilerTests.javaSource(
"test.Foo",
"package test;",
"",
"import javax.inject.Inject;",
"",
"class Foo {",
" @Inject",
" Foo(Bar bar) {}",
"}");
Source bar =
CompilerTests.javaSource(
"test.Bar",
"package test;",
"",
"import javax.inject.Inject;",
"",
"class Bar {",
" @Inject",
" Bar(UnresolvableDependency dep) {}",
"}");
// Only include a minimal portion of the stacktrace to minimize breaking tests due to refactors.
String stacktraceErrorMessage =
"dagger.internal.codegen.base"
+ ".DaggerSuperficialValidation$ValidationException$KnownErrorType";
CompilerTests.daggerCompiler(fooComponent, foo, bar)
.compile(
subject -> {
switch (CompilerTests.backend(subject)) {
case JAVAC:
subject.hasErrorCount(3);
subject.hasErrorContaining(
"cannot find symbol"
+ "\n symbol: class UnresolvableDependency"
+ "\n location: class test.Bar");
break;
case KSP:
subject.hasErrorCount(2);
break;
}
// TODO(b/248552462): Javac and KSP should match once this bug is fixed.
boolean isJavac = CompilerTests.backend(subject) == XProcessingEnv.Backend.JAVAC;
String trace = "\n "
+ "\n Dependency trace:"
+ "\n => element (CLASS): test.Bar"
+ "\n => element (CONSTRUCTOR): Bar(%1$s)"
+ "\n => type (EXECUTABLE constructor): (%1$s)void"
+ "\n => type (ERROR parameter type): %1$s";
subject.hasErrorContaining(
String.format(
"InjectProcessingStep was unable to process 'Bar(%1$s)' because '%1$s' could "
+ "not be resolved." + trace,
isJavac ? "UnresolvableDependency" : "error.NonExistentClass"));
subject.hasErrorContaining(
String.format(
"ComponentProcessingStep was unable to process 'test.FooComponent' because "
+ "'%1$s' could not be resolved." + trace,
isJavac ? "UnresolvableDependency" : "error.NonExistentClass"));
// Check that the stacktrace is not included in the error message by default.
assertThat(subject.getCompilationResult().rawOutput())
.doesNotContain(stacktraceErrorMessage);
});
CompilerTests.daggerCompiler(fooComponent, foo, bar)
.withProcessingOptions(
ImmutableMap.of("dagger.includeStacktraceWithDeferredErrorMessages", "ENABLED"))
.compile(
subject -> {
switch (CompilerTests.backend(subject)) {
case JAVAC:
subject.hasErrorCount(3);
break;
case KSP:
subject.hasErrorCount(2);
break;
}
subject.hasErrorContaining(stacktraceErrorMessage);
});
}
@Test
public void referencesUnresolvableAnnotationOnType() {
Source fooComponent =
CompilerTests.javaSource(
"test.FooComponent",
"package test;",
"",
"import dagger.Component;",
"",
"@Component",
"interface FooComponent {",
" Foo foo();",
"}");
Source foo =
CompilerTests.javaSource(
"test.Foo",
"package test;",
"",
"import javax.inject.Inject;",
"",
"class Foo {",
" @Inject",
" Foo(Bar bar) {}",
"}");
Source bar =
CompilerTests.javaSource(
"test.Bar",
"package test;",
"",
"import javax.inject.Inject;",
"",
"@UnresolvableAnnotation",
"class Bar {",
" @Inject",
" Bar(String dep) {}",
"}");
CompilerTests.daggerCompiler(fooComponent, foo, bar)
.compile(
subject -> {
switch (CompilerTests.backend(subject)) {
case JAVAC:
subject.hasErrorCount(3);
subject.hasErrorContaining(
"cannot find symbol"
+ "\n symbol: class UnresolvableAnnotation");
break;
case KSP:
subject.hasErrorCount(2);
break;
}
// TODO(b/248552462): Javac and KSP should match once this bug is fixed.
boolean isJavac = CompilerTests.backend(subject) == XProcessingEnv.Backend.JAVAC;
String trace = "\n "
+ "\n Dependency trace:"
+ "\n => element (CLASS): test.Bar"
+ "\n => annotation: @UnresolvableAnnotation"
+ "\n => type (ERROR annotation type): %1$s";
subject.hasErrorContaining(
String.format(
"InjectProcessingStep was unable to process 'Bar(java.lang.String)' because "
+ "'%1$s' could not be resolved." + trace,
isJavac ? "UnresolvableAnnotation" : "error.NonExistentClass"));
subject.hasErrorContaining(
String.format(
"ComponentProcessingStep was unable to process 'test.FooComponent' because "
+ "'%1$s' could not be resolved." + trace,
isJavac ? "UnresolvableAnnotation" : "error.NonExistentClass"));
});
}
@Test
public void referencesUnresolvableAnnotationOnTypeOnParameter() {
Source fooComponent =
CompilerTests.javaSource(
"test.FooComponent",
"package test;",
"",
"import dagger.Component;",
"",
"@Component",
"interface FooComponent {",
" Foo foo();",
"}");
Source foo =
CompilerTests.javaSource(
"test.Foo",
"package test;",
"",
"import javax.inject.Inject;",
"",
"class Foo {",
" @Inject",
" Foo(Bar bar) {}",
"}");
Source bar =
CompilerTests.javaSource(
"test.Bar",
"package test;",
"",
"import javax.inject.Inject;",
"",
"class Bar {",
" @Inject",
" Bar(@UnresolvableAnnotation String dep) {}",
"}");
CompilerTests.daggerCompiler(fooComponent, foo, bar)
.compile(
subject -> {
switch (CompilerTests.backend(subject)) {
case JAVAC:
subject.hasErrorCount(3);
subject.hasErrorContaining(
"cannot find symbol"
+ "\n symbol: class UnresolvableAnnotation"
+ "\n location: class test.Bar");
break;
case KSP:
subject.hasErrorCount(2);
break;
}
// TODO(b/248552462): Javac and KSP should match once this bug is fixed.
boolean isJavac = CompilerTests.backend(subject) == XProcessingEnv.Backend.JAVAC;
String trace = "\n "
+ "\n Dependency trace:"
+ "\n => element (CLASS): test.Bar"
+ "\n => element (CONSTRUCTOR): Bar(java.lang.String)"
+ "\n => element (PARAMETER): dep"
+ "\n => annotation: @UnresolvableAnnotation"
+ "\n => type (ERROR annotation type): %1$s";
subject.hasErrorContaining(
String.format(
"InjectProcessingStep was unable to process 'Bar(java.lang.String)' because "
+ "'%1$s' could not be resolved." + trace,
isJavac ? "UnresolvableAnnotation" : "error.NonExistentClass"));
subject.hasErrorContaining(
String.format(
"ComponentProcessingStep was unable to process 'test.FooComponent' because "
+ "'%1$s' could not be resolved." + trace,
isJavac ? "UnresolvableAnnotation" : "error.NonExistentClass"));
});
}
}
|
