diff options
author | Roman Stratiienko <r.stratiienko@gmail.com> | 2022-10-20 13:18:57 +0300 |
---|---|---|
committer | Roman Stratiienko <r.stratiienko@gmail.com> | 2022-10-20 14:14:33 +0300 |
commit | a7913de518c8bdc1998deef38438f1354fa00c92 (patch) | |
tree | c9db85e8c02098e1d248ac12d2dc3f6f084f8ad2 /backend | |
parent | ce2ce75a366db0dc60e0a521aaa66daa06701417 (diff) | |
download | drm_hwcomposer-a7913de518c8bdc1998deef38438f1354fa00c92.tar.gz |
drm_hwcomposer: CI: Bump-up clang toolchain to v15
Address new clang-tidy findings, in most cases 'misc-const-correctness'
check was addressed by adding 'const' modifier, or in some cases changed
to 'auto' (where it's better for formatting).
Signed-off-by: Roman Stratiienko <r.stratiienko@gmail.com>
Diffstat (limited to 'backend')
-rw-r--r-- | backend/Backend.cpp | 16 | ||||
-rw-r--r-- | backend/BackendManager.cpp | 2 |
2 files changed, 9 insertions, 9 deletions
diff --git a/backend/Backend.cpp b/backend/Backend.cpp index ba0518a..679f083 100644 --- a/backend/Backend.cpp +++ b/backend/Backend.cpp @@ -43,7 +43,7 @@ HWC2::Error Backend::ValidateDisplay(HwcDisplay *display, uint32_t *num_types, MarkValidated(layers, client_start, client_size); - bool testing_needed = !(client_start == 0 && client_size == layers.size()); + auto testing_needed = client_start != 0 || client_size != layers.size(); AtomicCommitArgs a_args = {.test_only = true}; @@ -99,7 +99,7 @@ uint32_t Backend::CalcPixOps(const std::vector<HwcLayer *> &layers, uint32_t pixops = 0; for (size_t z_order = 0; z_order < layers.size(); ++z_order) { if (z_order >= first_z && z_order < first_z + size) { - hwc_rect_t &df = layers[z_order]->GetLayerData().pi.display_frame; + auto &df = layers[z_order]->GetLayerData().pi.display_frame; pixops += (df.right - df.left) * (df.bottom - df.top); } } @@ -129,16 +129,16 @@ std::tuple<int, int> Backend::GetExtraClientRange( if (avail_planes < display->layers().size()) avail_planes--; - int extra_client = int(layers.size() - client_size) - int(avail_planes); + const int extra_client = int(layers.size() - client_size) - int(avail_planes); if (extra_client > 0) { int start = 0; size_t steps = 0; if (client_size != 0) { - int prepend = std::min(client_start, extra_client); - int append = std::min(int(layers.size()) - - int(client_start + client_size), - extra_client); + const int prepend = std::min(client_start, extra_client); + const int append = std::min(int(layers.size()) - + int(client_start + client_size), + extra_client); start = client_start - (int)prepend; client_size += extra_client; steps = 1 + std::min(std::min(append, prepend), @@ -150,7 +150,7 @@ std::tuple<int, int> Backend::GetExtraClientRange( uint32_t gpu_pixops = UINT32_MAX; for (size_t i = 0; i < steps; i++) { - uint32_t po = CalcPixOps(layers, start + i, client_size); + const uint32_t po = CalcPixOps(layers, start + i, client_size); if (po < gpu_pixops) { gpu_pixops = po; client_start = start + int(i); diff --git a/backend/BackendManager.cpp b/backend/BackendManager.cpp index 9bf6324..c1bc0f6 100644 --- a/backend/BackendManager.cpp +++ b/backend/BackendManager.cpp @@ -42,7 +42,7 @@ int BackendManager::RegisterBackend(const std::string &name, } int BackendManager::SetBackendForDisplay(HwcDisplay *display) { - std::string driver_name(display->GetPipe().device->GetName()); + auto driver_name(display->GetPipe().device->GetName()); char backend_override[PROPERTY_VALUE_MAX]; property_get("vendor.hwc.backend_override", backend_override, driver_name.c_str()); |