1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
|
BASE_DIR:=../aospless
SYSTEM_INCLUDE_DIRS := /usr/include/libdrm
CLANG := clang++-15
CLANG_TIDY := clang-tidy-15
OUT_DIR := /tmp/drm_hwcomposer/build
SRC_DIR := .
CXXFLAGS := -Wall -Wextra -Werror
CXXFLAGS += -D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS
CXXFLAGS += -fvisibility-inlines-hidden -std=gnu++17 -DHWC2_USE_CPP11 -DHWC2_INCLUDE_STRINGIFICATION -fno-rtti
CXXARGS := $(shell cat $(BASE_DIR)/build_flags/sharedlib.cppflags)
CXXARGS := $(subst [BASE_DIR],$(BASE_DIR),$(CXXARGS))
# clang-tidy doesn't like -mcpu=xxx flag
CXXARGS := $(patsubst -mcpu=%,,$(CXXARGS))
# TODO: build aospless with gtest enabled and remove line below
CXXARGS := $(subst -nostdlibinc,,$(CXXARGS))
CXXARGS += -I. -I./tests/test_include $(CXXFLAGS)
TIDY_FILES_OVERRIDE := \
bufferinfo/legacy/BufferInfoImagination.cpp:COARSE \
bufferinfo/legacy/BufferInfoLibdrm.cpp:COARSE \
bufferinfo/legacy/BufferInfoMaliHisi.cpp:COARSE \
bufferinfo/legacy/BufferInfoMaliMediatek.cpp:COARSE \
bufferinfo/legacy/BufferInfoMaliMeson.cpp:COARSE \
bufferinfo/legacy/BufferInfoMinigbm.cpp:COARSE \
drm/DrmFbImporter.h:FINE \
drm/DrmUnique.h:FINE \
hwc2_device/DrmHwcTwo.cpp:COARSE \
hwc2_device/DrmHwcTwo.h:COARSE \
hwc2_device/HwcDisplay.cpp:COARSE \
hwc2_device/HwcDisplay.h:COARSE \
utils/log.h:FINE \
utils/properties.h:FINE \
TIDY_CHECKS_FINE := * \
-llvmlibc* -fuchsia-* -altera-* \
-llvm-header-guard \
-cppcoreguidelines-pro-type-vararg \
-hicpp-vararg \
-hicpp-signed-bitwise \
-readability-identifier-length \
TIDY_CHECKS_NORMAL := \
$(TIDY_CHECKS_FINE) \
-hicpp* \
-bugprone-easily-swappable-parameters \
-cppcoreguidelines-special-member-functions \
-cppcoreguidelines-avoid-c-arrays \
-cppcoreguidelines-pro-bounds-array-to-pointer-decay \
-cppcoreguidelines-pro-bounds-constant-array-index \
-cppcoreguidelines-avoid-magic-numbers \
-google-readability-braces-around-statements \
-google-readability-casting \
-misc-non-private-member-variables-in-classes \
-modernize-avoid-c-arrays \
-modernize-use-nodiscard \
-modernize-use-trailing-return-type \
-readability-braces-around-statements \
TIDY_CHECKS_COARSE := \
$(TIDY_CHECKS_NORMAL) \
-cppcoreguidelines-non-private-member-variables-in-classes \
-cppcoreguidelines-pro-bounds-pointer-arithmetic \
-cppcoreguidelines-pro-type-cstyle-cast \
-cppcoreguidelines-pro-type-reinterpret-cast \
-cppcoreguidelines-pro-type-static-cast-downcast \
-cppcoreguidelines-pro-type-union-access \
-cppcoreguidelines-macro-usage \
-readability-convert-member-functions-to-static \
-readability-implicit-bool-conversion \
-readability-identifier-naming \
-readability-magic-numbers \
.PHONY: all build tidy clean
all: build tidy
clean:
rm -rf $(OUT_DIR)/
# Build
BUILD_FILES_AUTO := $(shell find -L $(SRC_DIR) -not -path '*/\.*' -not -path '*/tests/test_include/*' -path '*.cpp')
SKIP_FILES_path := $(foreach file,$(SKIP_FILES),$(SRC_DIR)/$(file))
BUILD_FILES := $(subst ./,,$(filter-out $(SKIP_FILES_path),$(BUILD_FILES_AUTO)))
_OBJ := $(BUILD_FILES:.cpp=.o)
OBJ := $(patsubst %,$(OUT_DIR)/%,$(_OBJ))
DEPS := $(patsubst %.cpp,$(OUT_DIR)/%.d,$(BUILD_FILES))
build: $(OBJ)
$(OUT_DIR)/%.o: $(SRC_DIR)/%.cpp
@mkdir -p $(dir $@)
@echo "CC $<"
@$(CLANG) $< $(CXXARGS) -c -o $@
$(OUT_DIR)/%.d: $(SRC_DIR)/%.cpp
@mkdir -p $(dir $@)
@$(CLANG) $(CXXARGS) $< -MM -MT $(OUT_DIR)/$(patsubst %.cpp,%.o,$<) -o $@
# TIDY
TIDY_FILES_AUTO := $(shell find -L $(SRC_DIR) -not -path '*/\.*' -not -path '*/tests/test_include/*' \( -path '*.cpp' -o -path '*.h' \))
TIDY_FILES_AUTO_filtered := $(filter-out $(SKIP_FILES_path),$(TIDY_FILES_AUTO))
TIDY_FILES_OVERRIDE_path := $(foreach pair,$(TIDY_FILES_OVERRIDE),$(SRC_DIR)/$(pair))
TIDY_FILES_OVERRIDE_name_only := $(foreach pair,$(TIDY_FILES_OVERRIDE_path),$(word 1, $(subst :, ,$(pair))))
TIDY_FILES := $(sort $(TIDY_FILES_AUTO_filtered) $(TIDY_FILES_OVERRIDE_name_only))
space := $(subst ,, )
comma := ,
TIDY_ARGS_NONE := --checks="-*,llvm-include-order"
TIDY_ARGS_ := --checks="-*,llvm-include-order"
TIDY_ARGS_FINE := --checks="$(subst $(space),$(comma),$(strip $(TIDY_CHECKS_FINE)))"
TIDY_ARGS_NORMAL := --checks="$(subst $(space),$(comma),$(strip $(TIDY_CHECKS_NORMAL)))"
TIDY_ARGS_COARSE := --checks="$(subst $(space),$(comma),$(strip $(TIDY_CHECKS_COARSE)))"
define process-tidy
_TARG := $(OUT_DIR)/$1.tidy.ts
_DEP := $1
TIDY_DEPS += $(_TARG)
TIDY_LEVEL_1 := $$(strip $$(foreach pair,$$(TIDY_FILES_OVERRIDE_path),$$(if $$(filter $$(word 1, $$(subst :, ,$$(pair))),$1),$$(word 2, $$(subst :, ,$$(pair))),)))
TIDY_LEVEL_2 := $$(if $$(TIDY_LEVEL_1),$$(TIDY_LEVEL_1),NORMAL)
TIDY_ARGS := $$(TIDY_ARGS_$$(TIDY_LEVEL_2))
$$(_TARG): _DEP := $$(_DEP)
$$(_TARG): _TARG := $$(_TARG)
$$(_TARG): TIDY_ARGS := $$(TIDY_ARGS)
$$(_TARG): $$(_DEP)
@mkdir -p $$(dir $$(_TARG))
@echo "TIDY $$<"
@$$(CLANG_TIDY) $$(_DEP) $$(TIDY_ARGS) --quiet -- -x c++ $$(CXXARGS) -Wno-pragma-once-outside-header
@touch $$(_TARG)
endef
$(foreach file,$(TIDY_FILES),$(eval $(call process-tidy,$(file))))
tidy: $(TIDY_DEPS)
ifneq ($(MAKECMDGOALS), clean)
-include $(DEPS)
endif
|
