summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTor Norbye <tnorbye@google.com>2012-06-06 14:18:11 -0700
committerandroid code review <noreply-gerritcodereview@google.com>2012-06-06 14:18:11 -0700
commitaeaf3d42f74a302bafedf68ce4f687d5b6171c25 (patch)
tree17cd2abeb9614f485fe5854d6cc749684ac13252
parentbc38c8ea6aff3059860f68fb8a7053c9fdcf707e (diff)
parent767eb85ab3a32c1a9621eca167863e625b0927cc (diff)
downloadeclipse-windowbuilder-aeaf3d42f74a302bafedf68ce4f687d5b6171c25.tar.gz
Merge "Prevent beeps in property editor"android-sdk-adt_r20tools_r20ics-plus-aosp
-rw-r--r--propertysheet/src/org/eclipse/wb/internal/core/model/property/editor/AbstractTextPropertyEditor.java8
1 files changed, 8 insertions, 0 deletions
diff --git a/propertysheet/src/org/eclipse/wb/internal/core/model/property/editor/AbstractTextPropertyEditor.java b/propertysheet/src/org/eclipse/wb/internal/core/model/property/editor/AbstractTextPropertyEditor.java
index 1ee9237..dd651af 100644
--- a/propertysheet/src/org/eclipse/wb/internal/core/model/property/editor/AbstractTextPropertyEditor.java
+++ b/propertysheet/src/org/eclipse/wb/internal/core/model/property/editor/AbstractTextPropertyEditor.java
@@ -57,6 +57,7 @@ public abstract class AbstractTextPropertyEditor extends TextDisplayPropertyEdit
private class ImmediateProposalAdapter extends ContentProposalAdapter
implements FocusListener, IContentProposalListener, IContentProposalListener2 {
private final PropertyTable m_propertyTable;
+ private final IContentProposalProvider m_proposalProvider;
public ImmediateProposalAdapter(
Text control,
IControlContentAdapter controlContentAdapter,
@@ -67,6 +68,7 @@ public abstract class AbstractTextPropertyEditor extends TextDisplayPropertyEdit
super(control, controlContentAdapter, proposalProvider, keyStroke,
autoActivationCharacters);
m_propertyTable = propertyTable;
+ m_proposalProvider = proposalProvider;
// On focus gain, start completing
control.addFocusListener(this);
@@ -103,6 +105,12 @@ public abstract class AbstractTextPropertyEditor extends TextDisplayPropertyEdit
}
private void openIfNecessary() {
+ if (m_textControl == null || m_textControl.isDisposed() ||
+ m_proposalProvider.getProposals(m_textControl.getText(),
+ m_textControl.getCaretPosition()).length == 0) {
+ return;
+ }
+
getControl().getDisplay().asyncExec(new Runnable() {
@Override
public void run() {