diff options
| author | Rob Findley <rfindley@google.com> | 2021-07-09 10:43:12 -0400 |
|---|---|---|
| committer | Robert Findley <rfindley@google.com> | 2021-07-09 15:03:35 +0000 |
| commit | 2583041a9ded1b6efc6612d7d0743a42a00dde99 (patch) | |
| tree | baf16fef790b8aef34167c5dcdb12df6798f4bab /go/packages/packages_test.go | |
| parent | 69948257bde7456e6cfd0e7bd2b0415a71370ce1 (diff) | |
| download | golang-x-tools-2583041a9ded1b6efc6612d7d0743a42a00dde99.tar.gz | |
go/packages: fix data race in TestCgoNoSyntax
CL 332350 introduced a race to exported.Config.Mode when it parallelized
this test. Revert the call to t.Parallel.
Change-Id: Ifd4b6c4037ee30e8b3f55dc69d4f9f3f09a89185
Reviewed-on: https://go-review.googlesource.com/c/tools/+/333509
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Diffstat (limited to 'go/packages/packages_test.go')
| -rw-r--r-- | go/packages/packages_test.go | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/go/packages/packages_test.go b/go/packages/packages_test.go index afc0a80b5..61cd38471 100644 --- a/go/packages/packages_test.go +++ b/go/packages/packages_test.go @@ -1905,8 +1905,6 @@ func testCgoNoSyntax(t *testing.T, exporter packagestest.Exporter) { for _, mode := range modes { mode := mode t.Run(fmt.Sprint(mode), func(t *testing.T) { - t.Parallel() - exported.Config.Mode = mode pkgs, err := packages.Load(exported.Config, "golang.org/fake/c") if err != nil { |