diff options
| author | Rebecca Stambler <rstambler@golang.org> | 2020-02-03 18:07:33 -0500 |
|---|---|---|
| committer | Rebecca Stambler <rstambler@golang.org> | 2020-02-04 00:54:49 +0000 |
| commit | 35ac94b00d9e8c6a60f7918389f0c289c680c098 (patch) | |
| tree | fc5ecc562bb39d8fd4cec9ae998cb5b2957eb661 /internal/span/uri_windows_test.go | |
| parent | 174f5c63c9f5907791855012c7d0a5b2d03879f5 (diff) | |
| download | golang-x-tools-35ac94b00d9e8c6a60f7918389f0c289c680c098.tar.gz | |
internal/span, internal/lsp: fix URI escaping
We had previously worked around a VS Code URI bug by unescaping URIs.
This is incorrect, so stop doing it and then add a specific workaround
just for that one bug.
Fixes golang/go#36999
Change-Id: I92f1a5f71749af7a6b1020eee1272586515f7084
Reviewed-on: https://go-review.googlesource.com/c/tools/+/217599
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Diffstat (limited to 'internal/span/uri_windows_test.go')
| -rw-r--r-- | internal/span/uri_windows_test.go | 16 |
1 files changed, 13 insertions, 3 deletions
diff --git a/internal/span/uri_windows_test.go b/internal/span/uri_windows_test.go index 2eb07e7c9..1370b19c8 100644 --- a/internal/span/uri_windows_test.go +++ b/internal/span/uri_windows_test.go @@ -54,12 +54,22 @@ func TestURI(t *testing.T) { { path: `c:\Go\src\bob george\george\george.go`, wantFile: `C:\Go\src\bob george\george\george.go`, - wantURI: span.URI("file:///C:/Go/src/bob george/george/george.go"), + wantURI: span.URI("file:///C:/Go/src/bob%20george/george/george.go"), }, { - path: `file:///c:/Go/src/bob george/george/george.go`, + path: `file:///c:/Go/src/bob%20george/george/george.go`, wantFile: `C:\Go\src\bob george\george\george.go`, - wantURI: span.URI("file:///C:/Go/src/bob george/george/george.go"), + wantURI: span.URI("file:///C:/Go/src/bob%20george/george/george.go"), + }, + { + path: `file:///C%3A/Go/src/bob%20george/george/george.go`, + wantFile: `C:\Go\src\bob george\george\george.go`, + wantURI: span.URI("file:///C:/Go/src/bob%20george/george/george.go"), + }, + { + path: `file:///c:/path/to/%25p%25ercent%25/per%25cent.go`, + wantFile: `C:\path\to\%p%ercent%\per%cent.go`, + wantURI: span.URI(`file:///C:/path/to/%25p%25ercent%25/per%25cent.go`), }, } { got := span.NewURI(test.path) |