Updated annotations!: Changing method signatures and 'REQUIRED' annotations to reflect the need to always include 'partial_failure' parameter in calls to certain conversion-related services.

BREAKING CHANGE: Updated method signature and 'REQUIRED' annotations.

PiperOrigin-RevId: 312675261

4 files changed, 64 insertions, 66 deletions

diff --git a/google/ads/googleads/v1/resources/ad.proto b/google/ads/googleads/v1/resources/ad.proto
index 8a54706d7..d1934414c 100644
--- a/google/ads/googleads/v1/resources/ad.proto
+++ b/google/ads/googleads/v1/resources/ad.proto
@@ -60,6 +60,7 @@ message Ad {
 
   // The list of mappings that can be used to substitute custom parameter tags
   // in a `tracking_url_template`, `final_urls`, or `mobile_final_urls`.
+  // For mutates, please use url custom parameter operations.
   repeated google.ads.googleads.v1.common.CustomParameter url_custom_parameters = 10;
 
   // The URL that appears in the ad description for some ad formats.
diff --git a/google/ads/googleads/v1/resources/campaign.proto b/google/ads/googleads/v1/resources/campaign.proto
index 0f3ba2ada..8ceafcdc5 100644
--- a/google/ads/googleads/v1/resources/campaign.proto
+++ b/google/ads/googleads/v1/resources/campaign.proto
@@ -83,19 +83,6 @@ message Campaign {
     google.protobuf.Int64Value hotel_center_id = 1 [(google.api.field_behavior) = IMMUTABLE];
   }
 
-  // Campaign-level settings for App Campaigns.
-  message AppCampaignSetting {
-    // Represents the goal which the bidding strategy of this app campaign
-    // should optimize towards.
-    google.ads.googleads.v1.enums.AppCampaignBiddingStrategyGoalTypeEnum.AppCampaignBiddingStrategyGoalType bidding_strategy_goal_type = 1;
-
-    // Immutable. A string that uniquely identifies a mobile application.
-    google.protobuf.StringValue app_id = 2 [(google.api.field_behavior) = IMMUTABLE];
-
-    // Immutable. The application store that distributes this specific app.
-    google.ads.googleads.v1.enums.AppCampaignAppStoreEnum.AppCampaignAppStore app_store = 3 [(google.api.field_behavior) = IMMUTABLE];
-  }
-
   // The setting for controlling Dynamic Search Ads (DSA).
   message DynamicSearchAdsSetting {
     // The Internet domain name that this setting represents, e.g., "google.com"
@@ -117,16 +104,6 @@ message Campaign {
     ];
   }
 
-  // Describes how unbranded pharma ads will be displayed.
-  message VanityPharma {
-    // The display mode for vanity pharma URLs.
-    google.ads.googleads.v1.enums.VanityPharmaDisplayUrlModeEnum.VanityPharmaDisplayUrlMode vanity_pharma_display_url_mode = 1;
-
-    // The text that will be displayed in display URL of the text ad when
-    // website description is the selected display mode for vanity pharma URLs.
-    google.ads.googleads.v1.enums.VanityPharmaTextEnum.VanityPharmaText vanity_pharma_text = 2;
-  }
-
   // The setting for Shopping campaigns. Defines the universe of products that
   // can be advertised by the campaign, and how this campaign interacts with
   // other Shopping campaigns.
@@ -160,6 +137,15 @@ message Campaign {
     google.protobuf.StringValue tracking_url = 1 [(google.api.field_behavior) = OUTPUT_ONLY];
   }
 
+  // Selective optimization setting for this campaign, which includes a set of
+  // conversion actions to optimize this campaign towards.
+  message SelectiveOptimization {
+    // The selected set of conversion actions for optimizing this campaign.
+    repeated google.protobuf.StringValue conversion_actions = 1 [(google.api.resource_reference) = {
+                                                                   type: "googleads.googleapis.com/ConversionAction"
+                                                                 }];
+  }
+
   // Represents a collection of settings related to ads geotargeting.
   message GeoTargetTypeSetting {
     // The setting used for positive geotargeting in this particular campaign.
@@ -169,13 +155,27 @@ message Campaign {
     google.ads.googleads.v1.enums.NegativeGeoTargetTypeEnum.NegativeGeoTargetType negative_geo_target_type = 2;
   }
 
-  // Selective optimization setting for this campaign, which includes a set of
-  // conversion actions to optimize this campaign towards.
-  message SelectiveOptimization {
-    // The selected set of conversion actions for optimizing this campaign.
-    repeated google.protobuf.StringValue conversion_actions = 1 [(google.api.resource_reference) = {
-                                                                   type: "googleads.googleapis.com/ConversionAction"
-                                                                 }];
+  // Campaign-level settings for App Campaigns.
+  message AppCampaignSetting {
+    // Represents the goal which the bidding strategy of this app campaign
+    // should optimize towards.
+    google.ads.googleads.v1.enums.AppCampaignBiddingStrategyGoalTypeEnum.AppCampaignBiddingStrategyGoalType bidding_strategy_goal_type = 1;
+
+    // Immutable. A string that uniquely identifies a mobile application.
+    google.protobuf.StringValue app_id = 2 [(google.api.field_behavior) = IMMUTABLE];
+
+    // Immutable. The application store that distributes this specific app.
+    google.ads.googleads.v1.enums.AppCampaignAppStoreEnum.AppCampaignAppStore app_store = 3 [(google.api.field_behavior) = IMMUTABLE];
+  }
+
+  // Describes how unbranded pharma ads will be displayed.
+  message VanityPharma {
+    // The display mode for vanity pharma URLs.
+    google.ads.googleads.v1.enums.VanityPharmaDisplayUrlModeEnum.VanityPharmaDisplayUrlMode vanity_pharma_display_url_mode = 1;
+
+    // The text that will be displayed in display URL of the text ad when
+    // website description is the selected display mode for vanity pharma URLs.
+    google.ads.googleads.v1.enums.VanityPharmaTextEnum.VanityPharmaText vanity_pharma_text = 2;
   }
 
   // Immutable. The resource name of the campaign.
@@ -298,12 +298,10 @@ message Campaign {
   google.ads.googleads.v1.enums.BiddingStrategyTypeEnum.BiddingStrategyType bidding_strategy_type = 22 [(google.api.field_behavior) = OUTPUT_ONLY];
 
   // The date when campaign started.
-  //
   // This field must not be used in WHERE clauses.
   google.protobuf.StringValue start_date = 19;
 
   // The date when campaign ended.
-  //
   // This field must not be used in WHERE clauses.
   google.protobuf.StringValue end_date = 20;
 
diff --git a/google/ads/googleads/v1/resources/keyword_plan_campaign.proto b/google/ads/googleads/v1/resources/keyword_plan_campaign.proto
index 2f6bb8a5f..ac614467b 100644
--- a/google/ads/googleads/v1/resources/keyword_plan_campaign.proto
+++ b/google/ads/googleads/v1/resources/keyword_plan_campaign.proto
@@ -91,7 +91,6 @@ message KeywordPlanCampaign {
 }
 
 // A geo target.
-// Next ID: 3
 message KeywordPlanGeoTarget {
   // Required. The resource name of the geo target.
   google.protobuf.StringValue geo_target_constant = 1 [(google.api.resource_reference) = {
diff --git a/google/ads/googleads/v1/resources/recommendation.proto b/google/ads/googleads/v1/resources/recommendation.proto
index ce7a08c7a..f0e2f6611 100644
--- a/google/ads/googleads/v1/resources/recommendation.proto
+++ b/google/ads/googleads/v1/resources/recommendation.proto
@@ -106,10 +106,15 @@ message Recommendation {
     google.protobuf.Int64Value recommended_cpc_bid_micros = 2 [(google.api.field_behavior) = OUTPUT_ONLY];
   }
 
-  // The Call extension recommendation.
-  message CallExtensionRecommendation {
-    // Output only. Call extensions recommended to be added.
-    repeated google.ads.googleads.v1.common.CallFeedItem recommended_extensions = 1 [(google.api.field_behavior) = OUTPUT_ONLY];
+  // The Optimize Ad Rotation recommendation.
+  message OptimizeAdRotationRecommendation {
+
+  }
+
+  // The Callout extension recommendation.
+  message CalloutExtensionRecommendation {
+    // Output only. Callout extensions recommended to be added.
+    repeated google.ads.googleads.v1.common.CalloutFeedItem recommended_extensions = 1 [(google.api.field_behavior) = OUTPUT_ONLY];
   }
 
   // The text ad recommendation.
@@ -155,17 +160,10 @@ message Recommendation {
     google.protobuf.Int64Value recommended_target_cpa_micros = 2 [(google.api.field_behavior) = OUTPUT_ONLY];
   }
 
-  // The Maximize Clicks opt-in recommendation.
-  message MaximizeClicksOptInRecommendation {
-    // Output only. The recommended new budget amount.
-    // Only set if the current budget is too high.
-    google.protobuf.Int64Value recommended_budget_amount_micros = 1 [(google.api.field_behavior) = OUTPUT_ONLY];
-  }
-
-  // The Maximize Conversions Opt-In recommendation.
-  message MaximizeConversionsOptInRecommendation {
-    // Output only. The recommended new budget amount.
-    google.protobuf.Int64Value recommended_budget_amount_micros = 1 [(google.api.field_behavior) = OUTPUT_ONLY];
+  // The Sitelink extension recommendation.
+  message SitelinkExtensionRecommendation {
+    // Output only. Sitelink extensions recommended to be added.
+    repeated google.ads.googleads.v1.common.SitelinkFeedItem recommended_extensions = 1 [(google.api.field_behavior) = OUTPUT_ONLY];
   }
 
   // The move unused budget recommendation.
@@ -177,25 +175,15 @@ message Recommendation {
     CampaignBudgetRecommendation budget_recommendation = 2 [(google.api.field_behavior) = OUTPUT_ONLY];
   }
 
-  // The Enhanced Cost-Per-Click Opt-In recommendation.
-  message EnhancedCpcOptInRecommendation {
-
-  }
-
   // The Search Partners Opt-In recommendation.
   message SearchPartnersOptInRecommendation {
 
   }
 
-  // The Optimize Ad Rotation recommendation.
-  message OptimizeAdRotationRecommendation {
-
-  }
-
-  // The Callout extension recommendation.
-  message CalloutExtensionRecommendation {
-    // Output only. Callout extensions recommended to be added.
-    repeated google.ads.googleads.v1.common.CalloutFeedItem recommended_extensions = 1 [(google.api.field_behavior) = OUTPUT_ONLY];
+  // The Maximize Conversions Opt-In recommendation.
+  message MaximizeConversionsOptInRecommendation {
+    // Output only. The recommended new budget amount.
+    google.protobuf.Int64Value recommended_budget_amount_micros = 1 [(google.api.field_behavior) = OUTPUT_ONLY];
   }
 
   // The keyword match type recommendation.
@@ -207,10 +195,22 @@ message Recommendation {
     google.ads.googleads.v1.enums.KeywordMatchTypeEnum.KeywordMatchType recommended_match_type = 2 [(google.api.field_behavior) = OUTPUT_ONLY];
   }
 
-  // The Sitelink extension recommendation.
-  message SitelinkExtensionRecommendation {
-    // Output only. Sitelink extensions recommended to be added.
-    repeated google.ads.googleads.v1.common.SitelinkFeedItem recommended_extensions = 1 [(google.api.field_behavior) = OUTPUT_ONLY];
+  // The Enhanced Cost-Per-Click Opt-In recommendation.
+  message EnhancedCpcOptInRecommendation {
+
+  }
+
+  // The Maximize Clicks opt-in recommendation.
+  message MaximizeClicksOptInRecommendation {
+    // Output only. The recommended new budget amount.
+    // Only set if the current budget is too high.
+    google.protobuf.Int64Value recommended_budget_amount_micros = 1 [(google.api.field_behavior) = OUTPUT_ONLY];
+  }
+
+  // The Call extension recommendation.
+  message CallExtensionRecommendation {
+    // Output only. Call extensions recommended to be added.
+    repeated google.ads.googleads.v1.common.CallFeedItem recommended_extensions = 1 [(google.api.field_behavior) = OUTPUT_ONLY];
   }
 
   // Immutable. The resource name of the recommendation.