aboutsummaryrefslogtreecommitdiff
path: root/templates
diff options
context:
space:
mode:
authorYijie Ma <yijiem@google.com>2023-08-21 16:20:55 -0700
committerGitHub <noreply@github.com>2023-08-21 16:20:55 -0700
commitd540b4c088b31e92947914faed88e63520c1eb76 (patch)
treeab33683fd26191f3b5167d977cd875143b0aba6c /templates
parent650c2ea4928dc221747738ecbcf7db7f81dc7496 (diff)
downloadgrpc-grpc-d540b4c088b31e92947914faed88e63520c1eb76.tar.gz
[Windows] Make resolver_component_tests_runner_invoker run with Bazel on Windows (#34107)
Local Bazel invocation succeeds: ``` C:\Users\yijiem\projects\grpc>bazel --output_base=C:\bazel2 test --dynamic_mode=off --verbose_failures //test/cpp/naming:resolver_component_tests_runner_invoker@poller=epoll1 INFO: Analyzed target //test/cpp/naming:resolver_component_tests_runner_invoker@poller=epoll1 (0 packages loaded, 0 targets configured). INFO: Found 1 test target... Target //test/cpp/naming:resolver_component_tests_runner_invoker@poller=epoll1 up-to-date: bazel-bin/test/cpp/naming/resolver_component_tests_runner_invoker@poller=epoll1.exe INFO: Elapsed time: 199.262s, Critical Path: 193.48s INFO: 2 processes: 1 internal, 1 local. INFO: Build completed successfully, 2 total actions //test/cpp/naming:resolver_component_tests_runner_invoker@poller=epoll1 PASSED in 193.4s Executed 1 out of 1 test: 1 test passes. ``` The local invocation of RBE failed with linker error `LINK : error LNK2001: unresolved external symbol mainCRTStartup`, but that does not limited to this target: https://gist.github.com/yijiem/2c6cbd9a31209a6de8fd711afbf2b479. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
Diffstat (limited to 'templates')
-rw-r--r--templates/test/cpp/naming/resolver_component_tests_defs.include2
1 files changed, 1 insertions, 1 deletions
diff --git a/templates/test/cpp/naming/resolver_component_tests_defs.include b/templates/test/cpp/naming/resolver_component_tests_defs.include
index 6877f6a5b0..019686b2b6 100644
--- a/templates/test/cpp/naming/resolver_component_tests_defs.include
+++ b/templates/test/cpp/naming/resolver_component_tests_defs.include
@@ -47,7 +47,7 @@ def test_runner_log(msg):
sys.stderr.write('\n%s: %s\n' % (__file__, msg))
def python_args(arg_list):
- if platform.system() == 'Windows':
+ if platform.system() == 'Windows' and arg_list[0].endswith('.py'):
return [sys.executable] + arg_list
return arg_list