diff options
author | Mykhailo Kovalskyi <mykhailo.kovalskyi@gmail.com> | 2016-10-08 16:51:22 +0200 |
---|---|---|
committer | Mykhailo Kovalskyi <mykhailo.kovalskyi@gmail.com> | 2016-10-08 16:51:22 +0200 |
commit | d1823b6129dc45e4c9a5288cf32de0c865a4cb37 (patch) | |
tree | 283d1d044572407a615c3a52da5f26b9e8478de4 | |
parent | 546fa7d1144287c2f94c6050a2695e3c007fec4c (diff) | |
download | jcommander-d1823b6129dc45e4c9a5288cf32de0c865a4cb37.tar.gz |
Fix code style issues
- Wildcard type argument '?' explicitly extends 'java.lang.Object'.
- Modifier 'public static final' is redundant for interface fields.
- Unnecessary semicolon.
4 files changed, 4 insertions, 4 deletions
diff --git a/src/main/java/com/beust/jcommander/Parameterized.java b/src/main/java/com/beust/jcommander/Parameterized.java index 42b4281..f35c001 100644 --- a/src/main/java/com/beust/jcommander/Parameterized.java +++ b/src/main/java/com/beust/jcommander/Parameterized.java @@ -93,7 +93,7 @@ public class Parameterized { public static List<Parameterized> parseArg(Object arg) { List<Parameterized> result = Lists.newArrayList(); - Class<? extends Object> rootClass = arg.getClass(); + Class<?> rootClass = arg.getClass(); // get the list of types that are extended or implemented by the root class // and all of its parent types diff --git a/src/main/java/com/beust/jcommander/Parameters.java b/src/main/java/com/beust/jcommander/Parameters.java index f2e8c76..d53a014 100644 --- a/src/main/java/com/beust/jcommander/Parameters.java +++ b/src/main/java/com/beust/jcommander/Parameters.java @@ -34,7 +34,7 @@ import static java.lang.annotation.ElementType.TYPE; @Inherited public @interface Parameters { - public static final String DEFAULT_OPTION_PREFIXES = "-"; + String DEFAULT_OPTION_PREFIXES = "-"; /** * The name of the resource bundle to use for this class. diff --git a/src/test/java/com/beust/jcommander/DefaultProviderTest.java b/src/test/java/com/beust/jcommander/DefaultProviderTest.java index 981bd87..ee124ab 100644 --- a/src/test/java/com/beust/jcommander/DefaultProviderTest.java +++ b/src/test/java/com/beust/jcommander/DefaultProviderTest.java @@ -122,7 +122,7 @@ public class DefaultProviderTest { class ArgsRequired { @Parameter(names = "-log", description = "Level of verbosity", required = true) public Integer log; - }; + } IDefaultProvider defaultProvider = new IDefaultProvider() { public String getDefaultValueFor(String optionName) { diff --git a/src/test/java/com/beust/jcommander/args/ArgsEnum.java b/src/test/java/com/beust/jcommander/args/ArgsEnum.java index bef663b..29b43a7 100644 --- a/src/test/java/com/beust/jcommander/args/ArgsEnum.java +++ b/src/test/java/com/beust/jcommander/args/ArgsEnum.java @@ -34,7 +34,7 @@ import com.beust.jcommander.Parameter; */ public class ArgsEnum { - public enum ChoiceType { ONE, Two, THREE }; + public enum ChoiceType { ONE, Two, THREE } @Parameter(names = "-choice") public ChoiceType choice = ChoiceType.ONE; |