Add annotation argument validation to validate API

Fixes: https://github.com/google/ksp/issues/603

1 files changed, 20 insertions, 1 deletions

diff --git a/api/src/main/kotlin/com/google/devtools/ksp/visitor/KSValidateVisitor.kt b/api/src/main/kotlin/com/google/devtools/ksp/visitor/KSValidateVisitor.kt
index 3b1ef354..8e2747df 100644
--- a/api/src/main/kotlin/com/google/devtools/ksp/visitor/KSValidateVisitor.kt
+++ b/api/src/main/kotlin/com/google/devtools/ksp/visitor/KSValidateVisitor.kt
@@ -41,7 +41,16 @@ open class KSValidateVisitor(
     }
 
     override fun visitAnnotation(annotation: KSAnnotation, data: KSNode?): Boolean {
-        return !predicate(data, annotation) || annotation.annotationType.accept(this, annotation)
+        if (!predicate(data, annotation)) {
+            return true
+        }
+        if (!annotation.annotationType.accept(this, annotation)) {
+            return false
+        }
+        if (annotation.arguments.any { !it.accept(this, it) }) {
+            return false
+        }
+        return true
     }
 
     override fun visitTypeReference(typeReference: KSTypeReference, data: KSNode?): Boolean {
@@ -89,6 +98,16 @@ open class KSValidateVisitor(
         return true
     }
 
+    override fun visitValueArgument(valueArgument: KSValueArgument, data: KSNode?): Boolean {
+        fun visitValue(value: Any?): Boolean = when (value) {
+            is KSType -> this.validateType(value)
+            is KSAnnotation -> this.visitAnnotation(value, data)
+            is List<*> -> value.all { visitValue(it) }
+            else -> true
+        }
+        return visitValue(valueArgument.value)
+    }
+
     override fun visitValueParameter(valueParameter: KSValueParameter, data: KSNode?): Boolean {
         return valueParameter.type.accept(this, valueParameter)
     }