diff options
author | Claudio DeSouza <claudiomdsjr@gmail.com> | 2018-02-22 02:27:16 +0900 |
---|---|---|
committer | Qijiang Fan <fqj@google.com> | 2020-06-05 08:35:05 +0900 |
commit | 1181b425059d3e8eca866451bf4c2db705d5c7cc (patch) | |
tree | c075ccab0d089d18caf5c6b1226e8571e8b4c0eb /base/message_loop/message_loop.cc | |
parent | cfe43bf87f314146b04b57524c9273a5d0476a08 (diff) | |
download | libchrome-1181b425059d3e8eca866451bf4c2db705d5c7cc.tar.gz |
Remove some use of base::Passed
As proposed on chromium-dev recently, there seem to be no reason to keep
base::Passed around. In most cases where base::Passed is used, OnceCallback
should be preferred, specially because base::Passed is going to transfer
ownership of whatever was passed on its following run, and mostly behaving as
the intended purpose for OnceCallback.
This CL provides a good number of changes for the most straight forward cases
that do not involve changing any public interface. The code changed is mainly
from //base, //component, //crypto, and //device.
Original forum discussion can be found here: https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/abdff810-4359-41a5-8aa9-cd596c784bf5%40chromium.org?utm_medium=email&utm_source=footer
Bug: 812523
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I7b8c95cee091475602dca240fca9fa843218c563
Reviewed-on: https://chromium-review.googlesource.com/923262
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538143}
CrOS-Libchrome-Original-Commit: 591a997f9b42806d3af3dec8b5fd742dfd1d1386
Diffstat (limited to 'base/message_loop/message_loop.cc')
-rw-r--r-- | base/message_loop/message_loop.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/base/message_loop/message_loop.cc b/base/message_loop/message_loop.cc index 285028ddab..028cf9f8d9 100644 --- a/base/message_loop/message_loop.cc +++ b/base/message_loop/message_loop.cc @@ -85,7 +85,7 @@ MessageLoop::MessageLoop(Type type) } MessageLoop::MessageLoop(std::unique_ptr<MessagePump> pump) - : MessageLoop(TYPE_CUSTOM, BindOnce(&ReturnPump, Passed(&pump))) { + : MessageLoop(TYPE_CUSTOM, BindOnce(&ReturnPump, std::move(pump))) { BindToCurrentThread(); } |