diff options
| author | Alex Vakulenko <avakulenko@google.com> | 2015-09-09 17:59:40 +0000 |
|---|---|---|
| committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2015-09-09 17:59:40 +0000 |
| commit | 1cca93461f2894eb345b97bb9e8ff6724a5057c8 (patch) | |
| tree | 760178e6d2c6ed36f7dd2fe23aca2cf2e8758fea | |
| parent | 37b6fb56a54e36b72fc9a0ea03b7d4a01a086511 (diff) | |
| parent | f4f82e32a39804d6f356aa30310544c8cf53db93 (diff) | |
| download | libchromeos-1cca93461f2894eb345b97bb9e8ff6724a5057c8.tar.gz | |
Merge "Improve default logging when sending asynchronous HTTP requests"
| -rw-r--r-- | chromeos/http/http_transport_curl.cc | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/chromeos/http/http_transport_curl.cc b/chromeos/http/http_transport_curl.cc index 5a3e207..4bc6208 100644 --- a/chromeos/http/http_transport_curl.cc +++ b/chromeos/http/http_transport_curl.cc @@ -246,7 +246,7 @@ RequestID Transport::StartAsyncTransfer(http::Connection* connection, request_id_map_.erase(request_id); return 0; } - VLOG(1) << "Started asynchronous HTTP request with ID " << request_id; + LOG(INFO) << "Started asynchronous HTTP request with ID " << request_id; return request_id; } @@ -258,7 +258,7 @@ bool Transport::CancelRequest(RequestID request_id) { LOG(WARNING) << "HTTP request #" << request_id << " not found"; return false; } - VLOG(1) << "Canceling HTTP request #" << request_id; + LOG(INFO) << "Canceling HTTP request #" << request_id; CleanAsyncConnection(p->second); return true; } @@ -446,8 +446,9 @@ void Transport::OnTransferComplete(Connection* connection, CURLcode code) { auto p = async_requests_.find(connection); CHECK(p != async_requests_.end()) << "Unknown connection"; AsyncRequestData* request_data = p->second.get(); - VLOG(1) << "HTTP request # " << request_data->request_id << " has completed " - << (code == CURLE_OK ? "successfully" : "with an error"); + LOG(INFO) << "HTTP request # " << request_data->request_id + << " has completed " + << (code == CURLE_OK ? "successfully" : "with an error"); if (code != CURLE_OK) { chromeos::ErrorPtr error; AddEasyCurlError(&error, FROM_HERE, code, curl_interface_.get()); @@ -456,6 +457,8 @@ void Transport::OnTransferComplete(Connection* connection, CURLcode code) { p->second->request_id, base::Owned(error.release()))); } else { + LOG(INFO) << "Response: " << connection->GetResponseStatusCode() << " (" + << connection->GetResponseStatusText() << ")"; chromeos::ErrorPtr error; // Rewind the response data stream to the beginning so the clients can // read the data back. |