summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Haller <thaller@redhat.com>2022-03-04 21:37:32 +0100
committerThomas Haller <thaller@redhat.com>2022-03-04 21:48:45 +0100
commit47c04fbfbd0a867773bf2a8f9f81e5338ee31e30 (patch)
tree44ad05e31c87ee8b4d746c60c3d22804f7d1754c
parent79f7c9da87aff6ed4ffa85a24328aba3401e592a (diff)
downloadlibnl-47c04fbfbd0a867773bf2a8f9f81e5338ee31e30.tar.gz
route:act: drop unnecessary implementations for to_clone()
Of the struct has no pointers that require a deep copy, there is no need to implement to_clone().
-rw-r--r--lib/route/act/gact.c10
-rw-r--r--lib/route/act/mirred.c10
-rw-r--r--lib/route/act/skbedit.c10
-rw-r--r--lib/route/act/vlan.c10
4 files changed, 4 insertions, 36 deletions
diff --git a/lib/route/act/gact.c b/lib/route/act/gact.c
index 4557c61f..832d2290 100644
--- a/lib/route/act/gact.c
+++ b/lib/route/act/gact.c
@@ -44,14 +44,6 @@ static void gact_free_data(struct rtnl_tc *tc, void *data)
{
}
-static int gact_clone(void *_dst, void *_src)
-{
- struct rtnl_gact *dst = _dst, *src = _src;
-
- memcpy(&dst->g_parm, &src->g_parm, sizeof(src->g_parm));
- return 0;
-}
-
static void gact_dump_line(struct rtnl_tc *tc, void *data,
struct nl_dump_params *p)
{
@@ -155,7 +147,7 @@ static struct rtnl_tc_ops gact_ops = {
.to_size = sizeof(struct rtnl_gact),
.to_msg_parser = gact_msg_parser,
.to_free_data = gact_free_data,
- .to_clone = gact_clone,
+ .to_clone = NULL,
.to_msg_fill = gact_msg_fill,
.to_dump = {
[NL_DUMP_LINE] = gact_dump_line,
diff --git a/lib/route/act/mirred.c b/lib/route/act/mirred.c
index 9683505a..5d7b089f 100644
--- a/lib/route/act/mirred.c
+++ b/lib/route/act/mirred.c
@@ -43,14 +43,6 @@ static void mirred_free_data(struct rtnl_tc *tc, void *data)
{
}
-static int mirred_clone(void *_dst, void *_src)
-{
- struct rtnl_mirred *dst = _dst, *src = _src;
-
- memcpy(&dst->m_parm, &src->m_parm, sizeof(src->m_parm));
- return 0;
-}
-
static void mirred_dump_line(struct rtnl_tc *tc, void *data,
struct nl_dump_params *p)
{
@@ -214,7 +206,7 @@ static struct rtnl_tc_ops mirred_ops = {
.to_size = sizeof(struct rtnl_mirred),
.to_msg_parser = mirred_msg_parser,
.to_free_data = mirred_free_data,
- .to_clone = mirred_clone,
+ .to_clone = NULL,
.to_msg_fill = mirred_msg_fill,
.to_dump = {
[NL_DUMP_LINE] = mirred_dump_line,
diff --git a/lib/route/act/skbedit.c b/lib/route/act/skbedit.c
index dc82f655..566a1a6f 100644
--- a/lib/route/act/skbedit.c
+++ b/lib/route/act/skbedit.c
@@ -61,14 +61,6 @@ static void skbedit_free_data(struct rtnl_tc *tc, void *data)
{
}
-static int skbedit_clone(void *_dst, void *_src)
-{
- struct rtnl_skbedit *dst = _dst, *src = _src;
-
- memcpy(dst, src, sizeof(*src));
- return 0;
-}
-
static void skbedit_dump_line(struct rtnl_tc *tc, void *data,
struct nl_dump_params *p)
{
@@ -262,7 +254,7 @@ static struct rtnl_tc_ops skbedit_ops = {
.to_size = sizeof(struct rtnl_skbedit),
.to_msg_parser = skbedit_msg_parser,
.to_free_data = skbedit_free_data,
- .to_clone = skbedit_clone,
+ .to_clone = NULL,
.to_msg_fill = skbedit_msg_fill,
.to_dump = {
[NL_DUMP_LINE] = skbedit_dump_line,
diff --git a/lib/route/act/vlan.c b/lib/route/act/vlan.c
index 3ad691e9..3d9fc334 100644
--- a/lib/route/act/vlan.c
+++ b/lib/route/act/vlan.c
@@ -103,14 +103,6 @@ static void vlan_free_data(struct rtnl_tc *tc, void *data)
{
}
-static int vlan_clone(void *_dst, void *_src)
-{
- struct rtnl_vlan *dst = _dst, *src = _src;
-
- memcpy(&dst->v_parm, &src->v_parm, sizeof(src->v_parm));
- return 0;
-}
-
static void vlan_dump_line(struct rtnl_tc *tc, void *data,
struct nl_dump_params *p)
{
@@ -399,7 +391,7 @@ static struct rtnl_tc_ops vlan_ops = {
.to_size = sizeof(struct rtnl_vlan),
.to_msg_parser = vlan_msg_parser,
.to_free_data = vlan_free_data,
- .to_clone = vlan_clone,
+ .to_clone = NULL,
.to_msg_fill = vlan_msg_fill,
.to_dump = {
[NL_DUMP_LINE] = vlan_dump_line,