diff options
| author | John Bowler <jbowler@acm.org> | 2024-01-19 11:07:42 -0800 |
|---|---|---|
| committer | John Bowler <jbowler@acm.org> | 2024-01-19 11:10:00 -0800 |
| commit | 144b348e072a78e8130ed0acc452c9f039a67bf2 (patch) | |
| tree | a0646560fada35374682d6a590616c27d1f6831c | |
| parent | 1a0d7a7481c61a5e92f23d6f1a8066723ecf9790 (diff) | |
| download | libpng-upstream-master.tar.gz | |
Use --xfail for Adler32 check in pngtest-allupstream-master
The test always failed on systems with no support for zlib
inflateValidate and on systems where the png_set_option setting was
disabled, however pngtest-all succeeded because the failure was ignored.
The latter is now fixed so the badadler.png check needs to use --xfail,
not --relaxed.
Signed-off-by: John Bowler <jbowler@acm.org>
| -rwxr-xr-x | tests/pngtest-all | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/tests/pngtest-all b/tests/pngtest-all index ba621f376..6ff351703 100755 --- a/tests/pngtest-all +++ b/tests/pngtest-all @@ -20,7 +20,10 @@ TEST --strict "${srcdir}"/pngtest.png # Various crashers # Use --relaxed because some come from fuzzers that don't maintain CRCs TEST --relaxed "${srcdir}"/contrib/testpngs/crashers/badcrc.png -TEST --relaxed "${srcdir}"/contrib/testpngs/crashers/badadler.png +# Use --xfail because there is no reliable way of disabling these errors +# (Adler32 checking cannot be switched off on all builds and there is no +# provision for turning the other checks into warnings.) +TEST --xfail "${srcdir}"/contrib/testpngs/crashers/badadler.png TEST --xfail "${srcdir}"/contrib/testpngs/crashers/bad_iCCP.png TEST --xfail "${srcdir}"/contrib/testpngs/crashers/empty_ancillary_chunks.png for file in "${srcdir}"/contrib/testpngs/crashers/huge_*_chunk.png |