1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
|
// Copyright 2015 The Weave Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "src/commands/command_queue.h"
#include <set>
#include <string>
#include <vector>
#include <base/bind.h>
#include <base/memory/weak_ptr.h>
#include <gmock/gmock.h>
#include <gtest/gtest.h>
#include <weave/provider/test/fake_task_runner.h>
#include "src/bind_lambda.h"
#include "src/string_utils.h"
namespace weave {
using testing::Return;
using testing::StrictMock;
class CommandQueueTest : public testing::Test {
public:
std::unique_ptr<CommandInstance> CreateDummyCommandInstance(
const std::string& name,
const std::string& id) {
std::unique_ptr<CommandInstance> cmd{
new CommandInstance{name, Command::Origin::kLocal, {}}};
cmd->SetID(id);
return cmd;
}
bool Remove(const std::string& id) { return queue_.Remove(id); }
void Cleanup(const base::TimeDelta& interval) {
return queue_.Cleanup(task_runner_.GetClock()->Now() + interval);
}
std::string GetFirstCommandToBeRemoved() const {
return queue_.remove_queue_.top().second;
}
StrictMock<provider::test::FakeTaskRunner> task_runner_;
CommandQueue queue_{&task_runner_, task_runner_.GetClock()};
};
// Keeps track of commands being added to and removed from the queue_.
// Aborts if duplicate commands are added or non-existent commands are removed.
class FakeDispatcher {
public:
explicit FakeDispatcher(CommandQueue* queue) {
queue->AddCommandAddedCallback(base::Bind(&FakeDispatcher::OnCommandAdded,
weak_ptr_factory_.GetWeakPtr()));
queue->AddCommandRemovedCallback(base::Bind(
&FakeDispatcher::OnCommandRemoved, weak_ptr_factory_.GetWeakPtr()));
}
void OnCommandAdded(Command* command) {
CHECK(ids_.insert(command->GetID()).second) << "Command ID already exists: "
<< command->GetID();
CHECK(commands_.insert(command).second)
<< "Command instance already exists";
}
void OnCommandRemoved(Command* command) {
CHECK_EQ(1u, ids_.erase(command->GetID())) << "Command ID not found: "
<< command->GetID();
CHECK_EQ(1u, commands_.erase(command)) << "Command instance not found";
}
// Get the comma-separated list of command IDs currently accumulated in the
// command queue_.
std::string GetIDs() const {
return Join(",", std::vector<std::string>(ids_.begin(), ids_.end()));
}
private:
std::set<std::string> ids_;
std::set<Command*> commands_;
base::WeakPtrFactory<FakeDispatcher> weak_ptr_factory_{this};
};
TEST_F(CommandQueueTest, Empty) {
EXPECT_TRUE(queue_.IsEmpty());
EXPECT_EQ(0u, queue_.GetCount());
}
TEST_F(CommandQueueTest, Add) {
queue_.Add(CreateDummyCommandInstance("base.reboot", "id1"));
queue_.Add(CreateDummyCommandInstance("base.reboot", "id2"));
queue_.Add(CreateDummyCommandInstance("base.reboot", "id3"));
EXPECT_EQ(3u, queue_.GetCount());
EXPECT_FALSE(queue_.IsEmpty());
}
TEST_F(CommandQueueTest, Remove) {
const std::string id1 = "id1";
const std::string id2 = "id2";
queue_.Add(CreateDummyCommandInstance("base.reboot", id1));
queue_.Add(CreateDummyCommandInstance("base.reboot", id2));
EXPECT_FALSE(queue_.IsEmpty());
EXPECT_FALSE(Remove("dummy"));
EXPECT_EQ(2u, queue_.GetCount());
EXPECT_TRUE(Remove(id1));
EXPECT_EQ(1u, queue_.GetCount());
EXPECT_FALSE(Remove(id1));
EXPECT_EQ(1u, queue_.GetCount());
EXPECT_TRUE(Remove(id2));
EXPECT_EQ(0u, queue_.GetCount());
EXPECT_FALSE(Remove(id2));
EXPECT_EQ(0u, queue_.GetCount());
EXPECT_TRUE(queue_.IsEmpty());
}
TEST_F(CommandQueueTest, RemoveLater) {
const std::string id1 = "id1";
queue_.Add(CreateDummyCommandInstance("base.reboot", id1));
EXPECT_EQ(1u, queue_.GetCount());
queue_.RemoveLater(id1);
EXPECT_EQ(1u, queue_.GetCount());
Cleanup(base::TimeDelta::FromMinutes(1));
EXPECT_EQ(1u, queue_.GetCount());
Cleanup(base::TimeDelta::FromMinutes(15));
EXPECT_EQ(0u, queue_.GetCount());
}
TEST_F(CommandQueueTest, RemoveLaterOnCleanupTask) {
const std::string id1 = "id1";
queue_.Add(CreateDummyCommandInstance("base.reboot", id1));
EXPECT_EQ(1u, queue_.GetCount());
queue_.RemoveLater(id1);
EXPECT_EQ(1u, queue_.GetCount());
ASSERT_EQ(1u, task_runner_.GetTaskQueueSize());
task_runner_.RunOnce();
EXPECT_EQ(0u, queue_.GetCount());
EXPECT_EQ(0u, task_runner_.GetTaskQueueSize());
}
TEST_F(CommandQueueTest, CleanupMultipleCommands) {
const std::string id1 = "id1";
const std::string id2 = "id2";
queue_.Add(CreateDummyCommandInstance("base.reboot", id1));
queue_.Add(CreateDummyCommandInstance("base.reboot", id2));
auto remove_task = [](CommandQueue* queue, const std::string& id) {
queue->RemoveLater(id);
};
remove_task(&queue_, id1);
task_runner_.PostDelayedTask(
FROM_HERE, base::Bind(remove_task, base::Unretained(&queue_), id2),
base::TimeDelta::FromSeconds(10));
EXPECT_EQ(2u, queue_.GetCount());
ASSERT_EQ(2u, task_runner_.GetTaskQueueSize());
task_runner_.RunOnce(); // Executes "remove_task(id2) @ T+10s".
ASSERT_EQ(2u, queue_.GetCount());
ASSERT_EQ(1u, task_runner_.GetTaskQueueSize());
EXPECT_EQ(id1, GetFirstCommandToBeRemoved());
task_runner_.RunOnce(); // Should remove task "id1" from queue.
ASSERT_EQ(1u, queue_.GetCount());
ASSERT_EQ(1u, task_runner_.GetTaskQueueSize());
EXPECT_EQ(id2, GetFirstCommandToBeRemoved());
task_runner_.RunOnce(); // Should remove task "id2" from queue.
EXPECT_EQ(0u, queue_.GetCount());
EXPECT_EQ(0u, task_runner_.GetTaskQueueSize());
}
TEST_F(CommandQueueTest, Dispatch) {
FakeDispatcher dispatch(&queue_);
const std::string id1 = "id1";
const std::string id2 = "id2";
queue_.Add(CreateDummyCommandInstance("base.reboot", id1));
queue_.Add(CreateDummyCommandInstance("base.reboot", id2));
std::set<std::string> ids{id1, id2}; // Make sure they are sorted properly.
std::string expected_set =
Join(",", std::vector<std::string>(ids.begin(), ids.end()));
EXPECT_EQ(expected_set, dispatch.GetIDs());
Remove(id1);
EXPECT_EQ(id2, dispatch.GetIDs());
Remove(id2);
EXPECT_EQ("", dispatch.GetIDs());
}
TEST_F(CommandQueueTest, Find) {
const std::string id1 = "id1";
const std::string id2 = "id2";
queue_.Add(CreateDummyCommandInstance("base.reboot", id1));
queue_.Add(CreateDummyCommandInstance("base.shutdown", id2));
EXPECT_EQ(nullptr, queue_.Find("dummy"));
auto cmd1 = queue_.Find(id1);
EXPECT_NE(nullptr, cmd1);
EXPECT_EQ("base.reboot", cmd1->GetName());
EXPECT_EQ(id1, cmd1->GetID());
auto cmd2 = queue_.Find(id2);
EXPECT_NE(nullptr, cmd2);
EXPECT_EQ("base.shutdown", cmd2->GetName());
EXPECT_EQ(id2, cmd2->GetID());
}
} // namespace weave
|
