diff options
| author | Cole Faust <colefaust@google.com> | 2024-01-08 17:46:07 -0800 |
|---|---|---|
| committer | Cole Faust <colefaust@google.com> | 2024-01-08 17:46:07 -0800 |
| commit | cac8f158d4542f5122e23684598861704ae186a7 (patch) | |
| tree | 003f7313aebeb2d6aa14f51fbccf16853eeebd6e | |
| parent | eb0d26b5d9f59abe522bcd0e4ffe43187fab7ac9 (diff) | |
| download | llvm-cac8f158d4542f5122e23684598861704ae186a7.tar.gz | |
Remove recursive rule variable reference
The command variable was referring to the depfile variable in the same
rule scope. These inter-scope references are only possible in rules,
not builds or the global scope. (though the global scope can reference
earlier variables)
n2 doesn't want to support this because it would slow down evaluating
the build file, so remove the usage.
Bug: 318434287
Test: Presubmits
Change-Id: I3b7f8c02f500d5a6e2eb6a49bc8a1a637ee03813
| -rw-r--r-- | soong/tblgen.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/soong/tblgen.go b/soong/tblgen.go index b0067be36d0a..f1565a406535 100644 --- a/soong/tblgen.go +++ b/soong/tblgen.go @@ -37,10 +37,10 @@ var ( tblgenRule = pctx.StaticRule("tblgenRule", blueprint.RuleParams{ Depfile: "${out}.d", Deps: blueprint.DepsGCC, - Command: "${llvmTblgen} ${includes} ${genopt} -d ${depfile} -o ${out} ${in}", + Command: "${llvmTblgen} ${includes} ${genopt} -d ${out}.d -o ${out} ${in}", CommandDeps: []string{"${llvmTblgen}"}, Description: "LLVM TableGen $in => $out", - }, "includes", "depfile", "genopt") + }, "includes", "genopt") ) type tblgenProperties struct { |