aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZdenek Kabelac <zkabelac@redhat.com>2015-09-10 16:33:11 +0200
committerZdenek Kabelac <zkabelac@redhat.com>2015-09-10 17:28:15 +0200
commita631fa20d0f18d12a8dc564d9b2d53d38e2e4d43 (patch)
treefe4c5a911683b871586418dec14a01c6f9bbb3f8
parent5911fa1d914220a182630a5f353b665478917df1 (diff)
downloadlvm2-a631fa20d0f18d12a8dc564d9b2d53d38e2e4d43.tar.gz
cache: disallow stripes/size for cache pool
ATM allocation can't handle stripping and cache pool allocation. It's not yet even clear what should be actually result. Until resolved, disable this option (it's been coredumping inside allocation anyway).
-rw-r--r--WHATS_NEW1
-rw-r--r--tools/lvcreate.c5
2 files changed, 5 insertions, 1 deletions
diff --git a/WHATS_NEW b/WHATS_NEW
index 3f897ced6..6e23fcbc1 100644
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,5 +1,6 @@
Version 2.02.131 -
=====================================
+ Disallow usage of --stripe and --stripsize when creating cache pool.
Warn user when caching raid or thin pool data LV.
When layering LV, move LV flags with segments.
Ignore persistent cache if configuration changed. (2.02.127)
diff --git a/tools/lvcreate.c b/tools/lvcreate.c
index 364a16ae8..7bba761a4 100644
--- a/tools/lvcreate.c
+++ b/tools/lvcreate.c
@@ -770,7 +770,8 @@ static int _lvcreate_params(struct cmd_context *cmd,
CACHE_POOL_ARGS,
LVCREATE_ARGS,
POOL_ARGS,
- SIZE_ARGS,
+ extents_ARG,
+ size_ARG,
cache_ARG,
chunksize_ARG,
-1))
@@ -1096,6 +1097,8 @@ static int _determine_cache_argument(struct volume_group *vg,
}
/* FIXME How to handle skip flag? */
if (arg_from_list_is_set(cmd, "is unsupported with cache conversion",
+ stripes_ARG,
+ stripesize_ARG,
setactivationskip_ARG,
ignoreactivationskip_ARG,
-1))