aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorShaju Mathew <shaju@google.com>2024-01-02 18:45:43 +0000
committerGerrit Code Review <noreply-gerritcodereview@google.com>2024-01-02 18:45:43 +0000
commit15afa33f8ef88bf5527e70d83bfbdf5119c70509 (patch)
tree50f768bc6f1b7684c5a2476f486d2eff2b121c64
parentab25584713f7d5242cfb1893edf1b3bfc093753f (diff)
parentd9983ee0cb340fac1ed0cec12e28b0ba1bee3745 (diff)
downloadmdnsresponder-15afa33f8ef88bf5527e70d83bfbdf5119c70509.tar.gz
Merge "Fix a mdns coverity issue to avoid RESOURCE_LEAK" into main
-rw-r--r--mDNSShared/PlatformCommon.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/mDNSShared/PlatformCommon.c b/mDNSShared/PlatformCommon.c
index 2fb530e..607a7e7 100644
--- a/mDNSShared/PlatformCommon.c
+++ b/mDNSShared/PlatformCommon.c
@@ -66,7 +66,12 @@ mDNSexport void mDNSPlatformSourceAddrForDest(mDNSAddr *const src, const mDNSAdd
addr.a6.sin6_addr = *(struct in6_addr*)&dst->ip.v6;
addr.a6.sin6_scope_id = 0;
}
- else return;
+ else
+ {
+ // __ANDROID__ : Fix fd leak
+ goto exit;
+ }
+
if ((connect(sock, &addr.s, inner_len)) < 0)
{ LogMsg("mDNSPlatformSourceAddrForDest: connect %#a failed errno %d (%s)", dst, errno, strerror(errno)); goto exit; }