aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKristen Kozak <sebright@google.com>2018-06-18 21:52:17 -0700
committerKristen Kozak <sebright@google.com>2018-06-19 17:19:48 -0700
commitf027bd97f74cde1bc0fbe2dea47945b9a0d96902 (patch)
tree2734084b5eb47c42f89d45176edd84ed7228adaa
parentbe9b78e1c42b6879eea436e3c996ca4c59c810d0 (diff)
downloadopencensus-java-f027bd97f74cde1bc0fbe2dea47945b9a0d96902.tar.gz
Expose an OpenCensusTraceLoggingEnhancer constructor that sets all fields.
This constructor is better than the no-arg constructor for situations where a no-arg constructor is not required, e.g., when reflection is not used.
-rw-r--r--contrib/log_correlation/stackdriver/src/main/java/io/opencensus/contrib/logcorrelation/stackdriver/OpenCensusTraceLoggingEnhancer.java14
1 files changed, 11 insertions, 3 deletions
diff --git a/contrib/log_correlation/stackdriver/src/main/java/io/opencensus/contrib/logcorrelation/stackdriver/OpenCensusTraceLoggingEnhancer.java b/contrib/log_correlation/stackdriver/src/main/java/io/opencensus/contrib/logcorrelation/stackdriver/OpenCensusTraceLoggingEnhancer.java
index 856b51ad..2fc817e2 100644
--- a/contrib/log_correlation/stackdriver/src/main/java/io/opencensus/contrib/logcorrelation/stackdriver/OpenCensusTraceLoggingEnhancer.java
+++ b/contrib/log_correlation/stackdriver/src/main/java/io/opencensus/contrib/logcorrelation/stackdriver/OpenCensusTraceLoggingEnhancer.java
@@ -96,7 +96,8 @@ public final class OpenCensusTraceLoggingEnhancer implements LoggingEnhancer {
}
/**
- * Constructor to be called by Stackdriver logging.
+ * Constructor to be called by reflection, e.g., by a google-cloud-java {@code LoggingHandler} or
+ * google-cloud-logging-logback {@code LoggingAppender}.
*
* <p>This constructor looks up the project ID and {@link SpanSelection SpanSelection} from the
* environment. It uses the default cloud project ID (the value returned by {@code
@@ -112,8 +113,15 @@ public final class OpenCensusTraceLoggingEnhancer implements LoggingEnhancer {
this(lookUpProjectId(), lookUpSpanSelectionProperty());
}
- /** Constructor used for testing. */
- OpenCensusTraceLoggingEnhancer(@Nullable String projectId, SpanSelection spanSelection) {
+ /**
+ * Constructs a {@code OpenCensusTraceLoggingEnhancer} with the given project ID and {@code
+ * SpanSelection}.
+ *
+ * @param projectId the project ID for this instance.
+ * @param spanSelection the {@code SpanSelection} for this instance.
+ * @since 0.15
+ */
+ public OpenCensusTraceLoggingEnhancer(@Nullable String projectId, SpanSelection spanSelection) {
this.projectId = projectId == null ? "" : projectId;
this.spanSelection = spanSelection;
this.tracePrefix = "projects/" + this.projectId + "/traces/";