diff options
| author | Bogdan Drutu <bdrutu@google.com> | 2017-03-21 21:19:55 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-03-21 21:19:55 -0700 |
| commit | 1858c491e3bfae2becb1b99abacf5d9c98222766 (patch) | |
| tree | ed154968e0a9c06092985d8e821201021fa3374f /all | |
| parent | 7c59ee6cd4e261abbeee972aad8297422b4c16ac (diff) | |
| download | opencensus-java-1858c491e3bfae2becb1b99abacf5d9c98222766.tar.gz | |
Change the trace API to directly depend on the Context implementation. (#154)
* Change the trace API to directly depend on the Context implementation.
Other changes in this PR:
Enable maven tests for core (common and trace).
Make trace tests in core to compile with java6.
Reasons to change to directly use the io.grpc.Context API:
We would need to have a different API that allows users to pass the generic context between threads and via Executors (similar with io.grpc.Context).
io.grpc.Context is an API the Storage is decoupled and can be backed by any mechanism not necessary thread-local.
Support for Deadline and Cancellation is a nice to have.
Other products may already support propagation of the io.grpc.Context.
It would have been very hard to make binaries work correctly when they have libraries that are using io.grpc.Context and libraries that are using something different.
Diffstat (limited to 'all')
| -rw-r--r-- | all/build.gradle | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/all/build.gradle b/all/build.gradle index 14cfe888..5e14f9d4 100644 --- a/all/build.gradle +++ b/all/build.gradle @@ -13,7 +13,6 @@ buildscript { def subprojects = [ project(':instrumentation-core'), - project(':instrumentation-core-context-impl'), project(':instrumentation-core-impl'), ] |