Check for null in more public methods in Span and its subclasses.

1 files changed, 3 insertions, 0 deletions

diff --git a/impl_core/src/main/java/io/opencensus/implcore/trace/SpanImpl.java b/impl_core/src/main/java/io/opencensus/implcore/trace/SpanImpl.java
index 81b27e32..59291685 100644
--- a/impl_core/src/main/java/io/opencensus/implcore/trace/SpanImpl.java
+++ b/impl_core/src/main/java/io/opencensus/implcore/trace/SpanImpl.java
@@ -268,6 +268,8 @@ public final class SpanImpl extends Span implements Element<SpanImpl> {
 
   @Override
   public void putAttribute(String key, AttributeValue value) {
+    Preconditions.checkNotNull(key, "key");
+    Preconditions.checkNotNull(value, "value");
     if (!getOptions().contains(Options.RECORD_EVENTS)) {
       return;
     }
@@ -381,6 +383,7 @@ public final class SpanImpl extends Span implements Element<SpanImpl> {
 
   @Override
   public void end(EndSpanOptions options) {
+    Preconditions.checkNotNull(options, "options");
     if (!getOptions().contains(Options.RECORD_EVENTS)) {
       return;
     }