Format TODO URLs as TODO(crbug.com/openscreen/000)

Put crbug URLs in TODOs to make it easier to open the bug pages.

Change-Id: Ibc8fce98a795d7e8c714627bf1ecd970a3865563
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1872176
Reviewed-by: Max Yakimakha <yakimakha@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>

25 files changed, 52 insertions, 46 deletions

diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index c7a54cc1..84d63cfe 100755
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -26,8 +26,8 @@ def _CheckDeps(input_api, output_api):
 
 def _CommonChecks(input_api, output_api):
   results = []
-  # TODO(issues/43): Probably convert this to python so we can give more
-  # detailed errors.
+  # TODO(crbug.com/openscreen/43): Probably convert this to python so we can
+  # give more detailed errors.
   presubmit_sh_result = input_api.subprocess.call(
       input_api.PresubmitLocalPath() + '/PRESUBMIT.sh')
   if presubmit_sh_result != 0:
diff --git a/build/config/BUILD.gn b/build/config/BUILD.gn
index 18667369..b6d48531 100644
--- a/build/config/BUILD.gn
+++ b/build/config/BUILD.gn
@@ -79,7 +79,8 @@ config("openscreen_code") {
     cflags += [ "-Wno-maybe-uninitialized" ]
     cflags_cc += [
       # GCC 7.2 reports noexcept errors that are not found in GCC 8.
-      # TODO(openscreen:40) Remove this when bots are upgraded to >= GCC 8.3.
+      # TODO(crbug.com/openscreen/40): Remove this when bots are upgraded to
+      # >= GCC 8.3.
       "-Wno-noexcept-type",
     ]
   }
diff --git a/osp/impl/discovery/mdns/mdns_demo.cc b/osp/impl/discovery/mdns/mdns_demo.cc
index f8a5466f..92b0fef9 100644
--- a/osp/impl/discovery/mdns/mdns_demo.cc
+++ b/osp/impl/discovery/mdns/mdns_demo.cc
@@ -59,7 +59,7 @@ class DemoSocketClient : public platform::UdpSocket::Client {
   DemoSocketClient(mdns::MdnsResponderAdapterImpl* mdns) : mdns_(mdns) {}
 
   void OnError(platform::UdpSocket* socket, Error error) override {
-    // TODO(issue/66): Change to OSP_LOG_FATAL.
+    // TODO(crbug.com/openscreen/66): Change to OSP_LOG_FATAL.
     OSP_LOG_ERROR << "configuration failed for interface " << error.message();
     OSP_CHECK(false);
   }
diff --git a/osp/impl/discovery/mdns/mdns_responder_adapter_impl.cc b/osp/impl/discovery/mdns/mdns_responder_adapter_impl.cc
index 8b868a58..04485e68 100644
--- a/osp/impl/discovery/mdns/mdns_responder_adapter_impl.cc
+++ b/osp/impl/discovery/mdns/mdns_responder_adapter_impl.cc
@@ -339,13 +339,13 @@ void MdnsResponderAdapterImpl::OnRead(
 
 void MdnsResponderAdapterImpl::OnSendError(platform::UdpSocket* socket,
                                            Error error) {
-  // TODO(issue/67): Implement this method.
+  // TODO(crbug.com/openscreen/67): Implement this method.
   OSP_UNIMPLEMENTED();
 }
 
 void MdnsResponderAdapterImpl::OnError(platform::UdpSocket* socket,
                                        Error error) {
-  // TODO(issue/67): Implement this method.
+  // TODO(crbug.com/openscreen/67): Implement this method.
   OSP_UNIMPLEMENTED();
 }
 
diff --git a/osp/impl/internal_services.cc b/osp/impl/internal_services.cc
index c5a4afe5..8b456d2c 100644
--- a/osp/impl/internal_services.cc
+++ b/osp/impl/internal_services.cc
@@ -216,7 +216,7 @@ void InternalServices::OnError(platform::UdpSocket* socket, Error error) {
 }
 
 void InternalServices::OnSendError(platform::UdpSocket* socket, Error error) {
-  // TODO(issue/67): Implement this method.
+  // TODO(crbug.com/openscreen/67): Implement this method.
   OSP_UNIMPLEMENTED();
 }
 
diff --git a/osp/impl/mdns_responder_service.cc b/osp/impl/mdns_responder_service.cc
index bf290bd5..aac68c4b 100644
--- a/osp/impl/mdns_responder_service.cc
+++ b/osp/impl/mdns_responder_service.cc
@@ -347,7 +347,8 @@ void MdnsResponderService::StopListening() {
 }
 
 void MdnsResponderService::StartService() {
-  // TODO(issue/45): This should really be a library-wide whitelist.
+  // TODO(crbug.com/openscreen/45): This should really be a library-wide
+  // whitelist.
   if (!bound_interfaces_.empty() && !interface_index_whitelist_.empty()) {
     // TODO(btolsch): New interfaces won't be picked up on this path, but this
     // also highlights a larger issue of the interface list being frozen while
diff --git a/osp/impl/presentation/presentation_connection.cc b/osp/impl/presentation/presentation_connection.cc
index cee8a60e..adcfde17 100644
--- a/osp/impl/presentation/presentation_connection.cc
+++ b/osp/impl/presentation/presentation_connection.cc
@@ -18,7 +18,7 @@
 #include "platform/api/logging.h"
 #include "util/std_util.h"
 
-// TODO(issue/27): Address TODOs in this file
+// TODO(crbug.com/openscreen/27): Address TODOs in this file
 namespace openscreen {
 namespace presentation {
 
diff --git a/osp/impl/presentation/presentation_controller.cc b/osp/impl/presentation/presentation_controller.cc
index fa62a3df..b91e1e2f 100644
--- a/osp/impl/presentation/presentation_controller.cc
+++ b/osp/impl/presentation/presentation_controller.cc
@@ -428,9 +428,9 @@ Controller::Controller(platform::ClockNowFunctionPtr now_function) {
   const std::vector<ServiceInfo>& receivers =
       NetworkServiceManager::Get()->GetMdnsServiceListener()->GetReceivers();
   for (const auto& info : receivers) {
-    // TODO(issue/33): Replace service_id with endpoint_id when endpoint_id is
-    // more than just an IPEndpoint counter and actually relates to a device's
-    // identity.
+    // TODO(crbug.com/openscreen/33): Replace service_id with endpoint_id when
+    // endpoint_id is more than just an IPEndpoint counter and actually relates
+    // to a device's identity.
     receiver_endpoints_.emplace(info.service_id, info.v4_endpoint.port
                                                      ? info.v4_endpoint
                                                      : info.v6_endpoint);
diff --git a/osp/impl/presentation/presentation_receiver.cc b/osp/impl/presentation/presentation_receiver.cc
index 5c3cd0d1..5590561e 100644
--- a/osp/impl/presentation/presentation_receiver.cc
+++ b/osp/impl/presentation/presentation_receiver.cc
@@ -321,9 +321,9 @@ ErrorOr<size_t> Receiver::OnStreamMessage(uint64_t endpoint_id,
   }
 }
 
-// TODO(issue/31): Remove singletons in the embedder API and protocol
-// implementation layers and in presentation_connection, as well as unit tests.
-// static
+// TODO(crbug.com/openscreen/31): Remove singletons in the embedder API and
+// protocol implementation layers and in presentation_connection, as well as
+// unit tests. static
 Receiver* Receiver::Get() {
   static Receiver& receiver = *new Receiver();
   return &receiver;
diff --git a/osp/impl/quic/quic_client.cc b/osp/impl/quic/quic_client.cc
index 7c4fcc47..7b3b0bff 100644
--- a/osp/impl/quic/quic_client.cc
+++ b/osp/impl/quic/quic_client.cc
@@ -151,9 +151,9 @@ void QuicClient::OnConnectionClosed(uint64_t endpoint_id,
 
   delete_connections_.emplace_back(connection_entry);
 
-  // TODO(issue/42): If we reset request IDs when a connection is closed, we
-  // might end up re-using request IDs when a new connection is created to the
-  // same endpoint.
+  // TODO(crbug.com/openscreen/42): If we reset request IDs when a connection is
+  // closed, we might end up re-using request IDs when a new connection is
+  // created to the same endpoint.
   endpoint_request_ids_.ResetRequestId(endpoint_id);
 }
 
diff --git a/osp/impl/quic/quic_connection_factory_impl.cc b/osp/impl/quic/quic_connection_factory_impl.cc
index dfa37f00..0b5fbd95 100644
--- a/osp/impl/quic/quic_connection_factory_impl.cc
+++ b/osp/impl/quic/quic_connection_factory_impl.cc
@@ -215,7 +215,7 @@ void QuicConnectionFactoryImpl::OnError(platform::UdpSocket* socket,
 
 void QuicConnectionFactoryImpl::OnSendError(platform::UdpSocket* socket,
                                             Error error) {
-  // TODO(issue/67): Implement this method.
+  // TODO(crbug.com/openscreen/67): Implement this method.
   OSP_UNIMPLEMENTED();
 }
 
diff --git a/osp/impl/quic/quic_connection_impl.cc b/osp/impl/quic/quic_connection_impl.cc
index 26135589..3821ecae 100644
--- a/osp/impl/quic/quic_connection_impl.cc
+++ b/osp/impl/quic/quic_connection_impl.cc
@@ -89,12 +89,12 @@ void QuicConnectionImpl::OnRead(platform::UdpSocket* socket,
 }
 
 void QuicConnectionImpl::OnSendError(platform::UdpSocket* socket, Error error) {
-  // TODO(issue/67): Implement this method.
+  // TODO(crbug.com/openscreen/67): Implement this method.
   OSP_UNIMPLEMENTED();
 }
 
 void QuicConnectionImpl::OnError(platform::UdpSocket* socket, Error error) {
-  // TODO(issue/67): Implement this method.
+  // TODO(crbug.com/openscreen/67): Implement this method.
   OSP_UNIMPLEMENTED();
 }
 
diff --git a/osp/impl/quic/quic_server.cc b/osp/impl/quic/quic_server.cc
index 7aa00a9d..c1ec14e7 100644
--- a/osp/impl/quic/quic_server.cc
+++ b/osp/impl/quic/quic_server.cc
@@ -141,9 +141,9 @@ void QuicServer::OnConnectionClosed(uint64_t endpoint_id,
 
   delete_connections_.emplace_back(connection_entry);
 
-  // TODO(issue/42): If we reset request IDs when a connection is closed, we
-  // might end up re-using request IDs when a new connection is created to the
-  // same endpoint.
+  // TODO(crbug.com/openscreen/42): If we reset request IDs when a connection is
+  // closed, we might end up re-using request IDs when a new connection is
+  // created to the same endpoint.
   endpoint_request_ids_.ResetRequestId(endpoint_id);
 }
 
diff --git a/osp/public/endpoint_request_ids.cc b/osp/public/endpoint_request_ids.cc
index 15e9be1e..69fd275f 100644
--- a/osp/public/endpoint_request_ids.cc
+++ b/osp/public/endpoint_request_ids.cc
@@ -17,8 +17,8 @@ uint64_t EndpointRequestIds::GetNextRequestId(uint64_t endpoint_id) {
 }
 
 void EndpointRequestIds::ResetRequestId(uint64_t endpoint_id) {
-  // TODO(issue/42): Consider using a timeout to drop the request id counter,
-  // and/or possibly set the initial value as part of the handshake.
+  // TODO(crbug.com/openscreen/42): Consider using a timeout to drop the request
+  // id counter, and/or possibly set the initial value as part of the handshake.
   request_ids_by_endpoint_id_.erase(endpoint_id);
 }
 
diff --git a/osp/public/presentation/presentation_receiver.h b/osp/public/presentation/presentation_receiver.h
index d12bbd89..5f5d5e15 100644
--- a/osp/public/presentation/presentation_receiver.h
+++ b/osp/public/presentation/presentation_receiver.h
@@ -61,8 +61,8 @@ class ReceiverDelegate {
 class Receiver final : public MessageDemuxer::MessageCallback,
                        public Connection::ParentDelegate {
  public:
-  // TODO(issue/31): Remove singletons in the embedder API and protocol
-  // implementation layers
+  // TODO(crbug.com/openscreen/31): Remove singletons in the embedder API and
+  // protocol implementation layers.
   static Receiver* Get();
   void Init();
   void Deinit();
diff --git a/platform/api/internal/trace_logging_internal_unittest.cc b/platform/api/internal/trace_logging_internal_unittest.cc
index b8e65079..9cbce709 100644
--- a/platform/api/internal/trace_logging_internal_unittest.cc
+++ b/platform/api/internal/trace_logging_internal_unittest.cc
@@ -12,7 +12,8 @@
 #include "platform/api/trace_logging.h"
 #include "platform/test/trace_logging_helpers.h"
 
-// TODO(issue/52): Remove duplicate code from trace logging+internal unit tests
+// TODO(crbug.com/openscreen/52): Remove duplicate code from trace
+// logging+internal unit tests
 namespace openscreen {
 namespace platform {
 namespace internal {
diff --git a/platform/api/tls_connection.cc b/platform/api/tls_connection.cc
index ee0258c2..e233a001 100644
--- a/platform/api/tls_connection.cc
+++ b/platform/api/tls_connection.cc
@@ -15,7 +15,7 @@ void TlsConnection::OnWriteBlocked() {
   }
 
   task_runner_->PostTask([this]() {
-    // TODO(issues/71): |this| may be invalid at this point.
+    // TODO(crbug.com/openscreen/71): |this| may be invalid at this point.
     this->client_->OnWriteBlocked(this);
   });
 }
@@ -26,7 +26,7 @@ void TlsConnection::OnWriteUnblocked() {
   }
 
   task_runner_->PostTask([this]() {
-    // TODO(issues/71): |this| may be invalid at this point.
+    // TODO(crbug.com/openscreen/71): |this| may be invalid at this point.
     this->client_->OnWriteUnblocked(this);
   });
 }
@@ -37,7 +37,7 @@ void TlsConnection::OnError(Error error) {
   }
 
   task_runner_->PostTask([e = std::move(error), this]() mutable {
-    // TODO(issues/71): |this| may be invalid at this point.
+    // TODO(crbug.com/openscreen/71): |this| may be invalid at this point.
     this->client_->OnError(this, std::move(e));
   });
 }
@@ -48,7 +48,7 @@ void TlsConnection::OnRead(std::vector<uint8_t> block) {
   }
 
   task_runner_->PostTask([b = std::move(block), this]() mutable {
-    // TODO(issues/71): |this| may be invalid at this point.
+    // TODO(crbug.com/openscreen/71): |this| may be invalid at this point.
     this->client_->OnRead(this, std::move(b));
   });
 }
diff --git a/platform/api/tls_connection_factory.cc b/platform/api/tls_connection_factory.cc
index 8a74b1e4..ee1f9abb 100644
--- a/platform/api/tls_connection_factory.cc
+++ b/platform/api/tls_connection_factory.cc
@@ -12,7 +12,7 @@ void TlsConnectionFactory::OnAccepted(
     std::unique_ptr<TlsConnection> connection) {
   task_runner_->PostTask(
       [peer_cert, c = std::move(connection), this]() mutable {
-        // TODO(issues/71): |this| may be invalid at this point.
+        // TODO(crbug.com/openscreen/71): |this| may be invalid at this point.
         this->client_->OnAccepted(this, peer_cert, std::move(c));
       });
 }
@@ -22,7 +22,7 @@ void TlsConnectionFactory::OnConnected(
     std::unique_ptr<TlsConnection> connection) {
   task_runner_->PostTask(
       [peer_cert, c = std::move(connection), this]() mutable {
-        // TODO(issues/71): |this| may be invalid at this point.
+        // TODO(crbug.com/openscreen/71): |this| may be invalid at this point.
         this->client_->OnConnected(this, peer_cert, std::move(c));
       });
 }
@@ -30,14 +30,14 @@ void TlsConnectionFactory::OnConnected(
 void TlsConnectionFactory::OnConnectionFailed(
     const IPEndpoint& remote_address) {
   task_runner_->PostTask([remote_address, this]() {
-    // TODO(issues/71): |this| may be invalid at this point.
+    // TODO(crbug.com/openscreen/71): |this| may be invalid at this point.
     this->client_->OnConnectionFailed(this, remote_address);
   });
 }
 
 void TlsConnectionFactory::OnError(Error error) {
   task_runner_->PostTask([e = std::move(error), this]() mutable {
-    // TODO(issues/71): |this| may be invalid at this point.
+    // TODO(crbug.com/openscreen/71): |this| may be invalid at this point.
     this->client_->OnError(this, std::move(e));
   });
 }
diff --git a/platform/api/trace_logging_unittest.cc b/platform/api/trace_logging_unittest.cc
index 05121f5e..6a6e3658 100644
--- a/platform/api/trace_logging_unittest.cc
+++ b/platform/api/trace_logging_unittest.cc
@@ -14,7 +14,8 @@
 #include "platform/api/trace_logging.h"
 #include "platform/test/trace_logging_helpers.h"
 
-// TODO(issue/52): Remove duplicate code from trace logging+internal unit tests
+// TODO(crbug.com/openscreen/52): Remove duplicate code from trace
+// logging+internal unit tests
 namespace openscreen {
 namespace platform {
 namespace {
diff --git a/platform/api/udp_socket.cc b/platform/api/udp_socket.cc
index 263d300d..3c75b188 100644
--- a/platform/api/udp_socket.cc
+++ b/platform/api/udp_socket.cc
@@ -38,7 +38,7 @@ void UdpSocket::OnError(Error error) {
   }
 
   task_runner_->PostTask([e = std::move(error), this]() mutable {
-    // TODO(issues/71): |this| may be invalid at this point.
+    // TODO(crbug.com/openscreen/71): |this| may be invalid at this point.
     this->client_->OnError(this, std::move(e));
   });
 }
@@ -49,7 +49,7 @@ void UdpSocket::OnSendError(Error error) {
   }
 
   task_runner_->PostTask([e = std::move(error), this]() mutable {
-    // TODO(issues/71): |this| may be invalid at this point.
+    // TODO(crbug.com/openscreen/71): |this| may be invalid at this point.
     this->client_->OnSendError(this, std::move(e));
   });
 }
@@ -60,7 +60,7 @@ void UdpSocket::OnRead(ErrorOr<UdpPacket> read_data) {
   }
 
   task_runner_->PostTask([data = std::move(read_data), this]() mutable {
-    // TODO(issues/71): |this| may be invalid at this point.
+    // TODO(crbug.com/openscreen/71): |this| may be invalid at this point.
     this->client_->OnRead(this, std::move(data));
   });
 }
diff --git a/platform/base/error.h b/platform/base/error.h
index 11901cd1..aedbf29a 100644
--- a/platform/base/error.h
+++ b/platform/base/error.h
@@ -18,7 +18,7 @@ namespace openscreen {
 // code and an optional message.
 class Error {
  public:
-  // TODO(issue/65): Group/rename OSP-specific errors
+  // TODO(crbug.com/openscreen/65): Group/rename OSP-specific errors
   enum class Code : int8_t {
     // No error occurred.
     kNone = 0,
diff --git a/platform/impl/tls_connection_factory_posix.cc b/platform/impl/tls_connection_factory_posix.cc
index 38159967..0ee528f0 100644
--- a/platform/impl/tls_connection_factory_posix.cc
+++ b/platform/impl/tls_connection_factory_posix.cc
@@ -117,7 +117,8 @@ void TlsConnectionFactoryPosix::Listen(const IPEndpoint& local_address,
 
 void TlsConnectionFactoryPosix::OnConnectionPending(StreamSocketPosix* socket) {
   task_runner_->PostTask([socket, this]() mutable {
-    // TODO(issues/71): |this|, |socket| may be invalid at this point.
+    // TODO(crbug.com/openscreen/71): |this|, |socket| may be invalid at this
+    // point.
     ErrorOr<std::unique_ptr<StreamSocket>> accepted = socket->Accept();
     if (accepted.is_error()) {
       // Check for special error code. Because this call doesn't get executed
diff --git a/third_party/googletest/BUILD.gn b/third_party/googletest/BUILD.gn
index be551bcb..110f5ae9 100644
--- a/third_party/googletest/BUILD.gn
+++ b/third_party/googletest/BUILD.gn
@@ -34,7 +34,8 @@ if (build_with_chromium) {
 
     cflags_cc = []
     if (is_clang) {
-      # issue/15: GMock does not support the override keyword.
+      # NOTE(crbug.com/openscreen/15): GMock does not support the override
+      # keyword.
       cflags_cc += [
         "-Wno-exit-time-destructors",
         "-Wno-inconsistent-missing-override",
diff --git a/tools/cddl/logging.h b/tools/cddl/logging.h
index c6b5b8f3..fc76a427 100644
--- a/tools/cddl/logging.h
+++ b/tools/cddl/logging.h
@@ -22,7 +22,7 @@
 #define CHECK_GT(a, b) CHECK((a) > (b))
 #define CHECK_GE(a, b) CHECK((a) >= (b))
 
-// TODO(openscreen:75):
+// TODO(crbug.com/openscreen/75):
 // #1: This class has no state, so it doesn't need to be a singleton, just
 // a collection of static functions.
 //
diff --git a/util/yet_another_bit_vector.cc b/util/yet_another_bit_vector.cc
index ff4b1316..a581a974 100644
--- a/util/yet_another_bit_vector.cc
+++ b/util/yet_another_bit_vector.cc
@@ -269,7 +269,7 @@ const uint64_t* YetAnotherBitVector::Select(int* pos) const {
 // constexpr members have storage (against the C++14 spec), and this confuses
 // the linker.
 //
-// TODO(issues/40): Remove these once toolchains are upgraded.
+// TODO(crbug.com/openscreen/40): Remove these once toolchains are upgraded.
 constexpr int YetAnotherBitVector::kBitsPerInteger;
 constexpr uint64_t YetAnotherBitVector::kAllBitsSet;
 constexpr uint64_t YetAnotherBitVector::kNoBitsSet;