[Open Screen] Remove obsolete TODOs.

- openscreen::Alarm is a cancelable Task.
- None of the existing callers of UdpSocket::SendMessage would benefit
  by sending a UdpPacket instead.


Bug: b/153658616
Change-Id: Ie7017d23d0195448295d16f660fd9b54abc6ae34
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2402238
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Jordan Bayles <jophba@chromium.org>

2 files changed, 7 insertions, 5 deletions

diff --git a/discovery/mdns/mdns_reader.cc b/discovery/mdns/mdns_reader.cc
index c6aa926b..ec122e70 100644
--- a/discovery/mdns/mdns_reader.cc
+++ b/discovery/mdns/mdns_reader.cc
@@ -334,10 +334,11 @@ bool MdnsReader::Read(MdnsMessage* out) {
       Read(header.answer_count, &answers) &&
       Read(header.authority_record_count, &authority_records) &&
       Read(header.additional_record_count, &additional_records)) {
-    // TODO(yakimakha): Skip messages with non-zero opcode and rcode.
-    // One way to do this is to change the method signature to return
-    // ErrorOr<MdnsMessage> and return different error codes for failure to read
-    // and for messages that were read successfully but are non-conforming.
+    // TODO(issuetracker.google.com/168240264): Skip messages with non-zero
+    // opcode and rcode.  One way to do this is to change the method signature
+    // to return ErrorOr<MdnsMessage> and return different error codes for
+    // failure to read and for messages that were read successfully but are
+    // non-conforming.
     ErrorOr<MdnsMessage> message = MdnsMessage::TryCreate(
         header.id, GetMessageType(header.flags), questions, answers,
         authority_records, additional_records);
diff --git a/discovery/mdns/mdns_trackers.h b/discovery/mdns/mdns_trackers.h
index 6cb863a9..58e0ccdc 100644
--- a/discovery/mdns/mdns_trackers.h
+++ b/discovery/mdns/mdns_trackers.h
@@ -5,6 +5,7 @@
 #ifndef DISCOVERY_MDNS_MDNS_TRACKERS_H_
 #define DISCOVERY_MDNS_MDNS_TRACKERS_H_
 
+#include <tuple>
 #include <unordered_map>
 #include <vector>
 
@@ -82,7 +83,7 @@ class MdnsTracker {
   MdnsSender* const sender_;
   TaskRunner* const task_runner_;
   const ClockNowFunctionPtr now_function_;
-  Alarm send_alarm_;  // TODO(yakimakha): Use cancelable task when available
+  Alarm send_alarm_;
   MdnsRandom* const random_delay_;
   TrackerType tracker_type_;