diff options
| author | Android Build Coastguard Worker <android-build-coastguard-worker@google.com> | 2023-11-23 00:09:38 +0000 |
|---|---|---|
| committer | Android Build Coastguard Worker <android-build-coastguard-worker@google.com> | 2023-11-23 00:09:38 +0000 |
| commit | aff67b6bbc28eba4d1f4a4a12e116e63ab4813ea (patch) | |
| tree | b7892405559e1714c330ffb8ac9de9104296f4e3 /docs/code_reviews.rst | |
| parent | 13960e09d00c4e8612da0a9084e0e051603f072b (diff) | |
| parent | f054515492af5132f685cb23fe11891ee77104c9 (diff) | |
| download | pigweed-android14-qpr2-s3-release.tar.gz | |
Snap for 11135477 from f054515492af5132f685cb23fe11891ee77104c9 to 24Q1-releaseandroid-14.0.0_r37android-14.0.0_r36android-14.0.0_r35android-14.0.0_r34android-14.0.0_r33android-14.0.0_r32android-14.0.0_r31android-14.0.0_r30android-14.0.0_r29android14-qpr2-s5-releaseandroid14-qpr2-s4-releaseandroid14-qpr2-s3-releaseandroid14-qpr2-s2-releaseandroid14-qpr2-s1-releaseandroid14-qpr2-release
Change-Id: I018123259cd231d0e74933e492391999e36650e8
Diffstat (limited to 'docs/code_reviews.rst')
| -rw-r--r-- | docs/code_reviews.rst | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/docs/code_reviews.rst b/docs/code_reviews.rst index 742a02b99..fcd42082c 100644 --- a/docs/code_reviews.rst +++ b/docs/code_reviews.rst @@ -24,6 +24,17 @@ Small changes Please follow the guidance in `Google's Eng-Practices Small CLs <https://google.github.io/eng-practices/review/developer/small-cls.html>`_. +Complete changes +================ +Please follow the guidance in :ref:`docs-contributing-contribution-standards`. +In summary, CLs must be complete, tested, and include documentation and unit +tests for new code, bug fixes, and any code changes that merit it. However, to +enable iterative work and small changes, ``TODO`` comments are acceptable. They +must include an explanation of the problem and an action to take. + +We will not take over incomplete changes to avoid shifting our focus. We may +reject changes that do not meet the criteria above. + ------------- For reviewers ------------- |