diff options
| author | Ted Pudlik <tpudlik@google.com> | 2023-11-06 22:36:00 +0000 |
|---|---|---|
| committer | CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2023-11-06 22:36:00 +0000 |
| commit | a1d2da971f308ed305e60a62e3106a4f37fcbb31 (patch) | |
| tree | 6f1572201ce290aa21704a06c785eba41ee7e399 /pw_build | |
| parent | 741063cb923f5794b3724d10e1968dcb1e72bc84 (diff) | |
| download | pigweed-a1d2da971f308ed305e60a62e3106a4f37fcbb31.tar.gz | |
bazel: Don't disable use_header_modules
There were some old reports that this feature doesn't work with
`-fno-rtti` (b/137799263), but nothing breaks if it's not disabled.
Tested this internally, too (cl/578609723).
Bug: b/267498492
Change-Id: I45c3145dab6b37285760a0cc4b065ed592a611bc
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/178565
Commit-Queue: Ted Pudlik <tpudlik@google.com>
Reviewed-by: Erik Gilling <konkers@google.com>
Diffstat (limited to 'pw_build')
| -rw-r--r-- | pw_build/bazel_internal/pigweed_internal.bzl | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/pw_build/bazel_internal/pigweed_internal.bzl b/pw_build/bazel_internal/pigweed_internal.bzl index fbada31ce..0276fcd6a 100644 --- a/pw_build/bazel_internal/pigweed_internal.bzl +++ b/pw_build/bazel_internal/pigweed_internal.bzl @@ -27,13 +27,6 @@ def add_defaults(kwargs): # Set linkstatic to avoid building .so files. kwargs["linkstatic"] = True - kwargs.setdefault("features", []) - - # Crosstool--adding this line to features disables header modules, which - # don't work with -fno-rtti. Note: this is not a command-line argument, - # it's "minus use_header_modules". - kwargs["features"].append("-use_header_modules") - def _print_platform_impl(_, ctx): if hasattr(ctx.rule.attr, "constraint_values"): for cv in ctx.rule.attr.constraint_values: |