aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristian Heimes <christian@python.org>2022-09-13 13:00:45 +0200
committerGitHub <noreply@github.com>2022-09-13 13:00:45 +0200
commitbc337a77666055283feeb3efbe17510dd038fb34 (patch)
tree2f9867cab326bd97dbbf6cdbc58306a4f23f1380
parentc4cf745c723f19dbc5b304bfb21cf77ac9aa40b8 (diff)
downloadcpython3-bc337a77666055283feeb3efbe17510dd038fb34.tar.gz
[3.11] gh-96005: Handle WASI ENOTCAPABLE in getpath (GH-96006) (GH-96034) (GH-96038)
- On WASI `ENOTCAPABLE` is now mapped to `PermissionError`. - The `errno` modules exposes the new error number. - `getpath.py` now ignores `PermissionError` when it cannot open landmark files `pybuilddir.txt` and `pyenv.cfg`.
-rw-r--r--Doc/library/errno.rst9
-rw-r--r--Doc/library/exceptions.rst7
-rw-r--r--Lib/test/test_exception_hierarchy.py6
-rw-r--r--Misc/NEWS.d/next/Core and Builtins/2022-08-15-21-08-11.gh-issue-96005.6eoc8k.rst4
-rw-r--r--Modules/errnomodule.c4
-rw-r--r--Modules/getpath.py6
-rw-r--r--Objects/exceptions.c5
7 files changed, 35 insertions, 6 deletions
diff --git a/Doc/library/errno.rst b/Doc/library/errno.rst
index 035340e256..5122c69697 100644
--- a/Doc/library/errno.rst
+++ b/Doc/library/errno.rst
@@ -657,3 +657,12 @@ defined by the module. The specific list of defined symbols is available as
Interface output queue is full
.. versionadded:: 3.11
+
+.. data:: ENOTCAPABLE
+
+ Capabilities insufficient. This error is mapped to the exception
+ :exc:`PermissionError`.
+
+ .. availability:: WASI, FreeBSD
+
+ .. versionadded:: 3.11.1
diff --git a/Doc/library/exceptions.rst b/Doc/library/exceptions.rst
index 2eccbd17c4..fc856277d6 100644
--- a/Doc/library/exceptions.rst
+++ b/Doc/library/exceptions.rst
@@ -746,7 +746,12 @@ depending on the system error code.
Raised when trying to run an operation without the adequate access
rights - for example filesystem permissions.
- Corresponds to :c:data:`errno` :py:data:`~errno.EACCES` and :py:data:`~errno.EPERM`.
+ Corresponds to :c:data:`errno` :py:data:`~errno.EACCES`,
+ :py:data:`~errno.EPERM`, and :py:data:`~errno.ENOTCAPABLE`.
+
+ .. versionchanged:: 3.11.1
+ WASI's :py:data:`~errno.ENOTCAPABLE` is now mapped to
+ :exc:`PermissionError`.
.. exception:: ProcessLookupError
diff --git a/Lib/test/test_exception_hierarchy.py b/Lib/test/test_exception_hierarchy.py
index 89fe9ddcef..3318fa8e77 100644
--- a/Lib/test/test_exception_hierarchy.py
+++ b/Lib/test/test_exception_hierarchy.py
@@ -63,7 +63,7 @@ class HierarchyTest(unittest.TestCase):
+-- InterruptedError EINTR
+-- IsADirectoryError EISDIR
+-- NotADirectoryError ENOTDIR
- +-- PermissionError EACCES, EPERM
+ +-- PermissionError EACCES, EPERM, ENOTCAPABLE
+-- ProcessLookupError ESRCH
+-- TimeoutError ETIMEDOUT
"""
@@ -75,6 +75,8 @@ class HierarchyTest(unittest.TestCase):
continue
excname, _, errnames = line.partition(' ')
for errname in filter(None, errnames.strip().split(', ')):
+ if errname == "ENOTCAPABLE" and not hasattr(errno, errname):
+ continue
_map[getattr(errno, errname)] = getattr(builtins, excname)
return _map
_map = _make_map(_pep_map)
@@ -91,7 +93,7 @@ class HierarchyTest(unittest.TestCase):
othercodes = set(errno.errorcode) - set(self._map)
for errcode in othercodes:
e = OSError(errcode, "Some message")
- self.assertIs(type(e), OSError)
+ self.assertIs(type(e), OSError, repr(e))
def test_try_except(self):
filename = "some_hopefully_non_existing_file"
diff --git a/Misc/NEWS.d/next/Core and Builtins/2022-08-15-21-08-11.gh-issue-96005.6eoc8k.rst b/Misc/NEWS.d/next/Core and Builtins/2022-08-15-21-08-11.gh-issue-96005.6eoc8k.rst
new file mode 100644
index 0000000000..06e414bca0
--- /dev/null
+++ b/Misc/NEWS.d/next/Core and Builtins/2022-08-15-21-08-11.gh-issue-96005.6eoc8k.rst
@@ -0,0 +1,4 @@
+On WASI :data:`~errno.ENOTCAPABLE` is now mapped to :exc:`PermissionError`.
+The :mod:`errno` modules exposes the new error number. ``getpath.py`` now
+ignores :exc:`PermissionError` when it cannot open landmark files
+``pybuilddir.txt`` and ``pyenv.cfg``.
diff --git a/Modules/errnomodule.c b/Modules/errnomodule.c
index 0516e73670..4de4144520 100644
--- a/Modules/errnomodule.c
+++ b/Modules/errnomodule.c
@@ -927,6 +927,10 @@ errno_exec(PyObject *module)
#ifdef EQFULL
add_errcode("EQFULL", EQFULL, "Interface output queue is full");
#endif
+#ifdef ENOTCAPABLE
+ // WASI extension
+ add_errcode("ENOTCAPABLE", ENOTCAPABLE, "Capabilities insufficient");
+#endif
Py_DECREF(error_dict);
return 0;
diff --git a/Modules/getpath.py b/Modules/getpath.py
index dceeed7702..e09fda9eb3 100644
--- a/Modules/getpath.py
+++ b/Modules/getpath.py
@@ -351,11 +351,11 @@ if not home and not py_setpath:
try:
# Read pyvenv.cfg from one level above executable
pyvenvcfg = readlines(joinpath(venv_prefix, VENV_LANDMARK))
- except FileNotFoundError:
+ except (FileNotFoundError, PermissionError):
# Try the same directory as executable
pyvenvcfg = readlines(joinpath(venv_prefix2, VENV_LANDMARK))
venv_prefix = venv_prefix2
- except FileNotFoundError:
+ except (FileNotFoundError, PermissionError):
venv_prefix = None
pyvenvcfg = []
@@ -475,7 +475,7 @@ if ((not home_was_set and real_executable_dir and not py_setpath)
# File exists but is empty
platstdlib_dir = real_executable_dir
build_prefix = joinpath(real_executable_dir, VPATH)
- except FileNotFoundError:
+ except (FileNotFoundError, PermissionError):
if isfile(joinpath(real_executable_dir, BUILD_LANDMARK)):
build_prefix = joinpath(real_executable_dir, VPATH)
if os_name == 'nt':
diff --git a/Objects/exceptions.c b/Objects/exceptions.c
index 3c4df2facf..319eb238ec 100644
--- a/Objects/exceptions.c
+++ b/Objects/exceptions.c
@@ -3644,6 +3644,11 @@ _PyExc_InitState(PyInterpreterState *interp)
ADD_ERRNO(InterruptedError, EINTR);
ADD_ERRNO(PermissionError, EACCES);
ADD_ERRNO(PermissionError, EPERM);
+#ifdef ENOTCAPABLE
+ // Extension for WASI capability-based security. Process lacks
+ // capability to access a resource.
+ ADD_ERRNO(PermissionError, ENOTCAPABLE);
+#endif
ADD_ERRNO(ProcessLookupError, ESRCH);
ADD_ERRNO(TimeoutError, ETIMEDOUT);