aboutsummaryrefslogtreecommitdiff
path: root/libshaderc/src
diff options
context:
space:
mode:
authorqining <qining@google.com>2016-01-12 14:00:34 -0500
committerqining <qining@google.com>2016-01-12 14:00:34 -0500
commit50dd8b2b78316a33ef98832bea08281a6fe19d9e (patch)
tree9a52f8375ca1e4f352ea3f8e02c66ee95a122392 /libshaderc/src
parenta3c61eaa98851ed5872aea4686009ea2af5a66ef (diff)
downloadshaderc-50dd8b2b78316a33ef98832bea08281a6fe19d9e.tar.gz
bug fix: comparing signed with unsigned.
Diffstat (limited to 'libshaderc/src')
-rw-r--r--libshaderc/src/shaderc_cpp_test.cc10
-rw-r--r--libshaderc/src/shaderc_test.cc12
2 files changed, 12 insertions, 10 deletions
diff --git a/libshaderc/src/shaderc_cpp_test.cc b/libshaderc/src/shaderc_cpp_test.cc
index 1c65ef8..f24790b 100644
--- a/libshaderc/src/shaderc_cpp_test.cc
+++ b/libshaderc/src/shaderc_cpp_test.cc
@@ -439,7 +439,8 @@ TEST_F(CppInterface, GetNumErrors) {
kTwoErrorsShader, strlen(kTwoErrorsShader),
shaderc_glsl_vertex_shader);
EXPECT_FALSE(module.GetSuccess());
- EXPECT_EQ(2, module.GetNumErrors());
+ EXPECT_EQ(2u, module.GetNumErrors());
+ EXPECT_EQ(0u, module.GetNumWarnings());
}
TEST_F(CppInterface, GetNumWarnings) {
@@ -447,7 +448,8 @@ TEST_F(CppInterface, GetNumWarnings) {
kTwoWarningsShader, strlen(kTwoWarningsShader),
shaderc_glsl_vertex_shader);
EXPECT_TRUE(module.GetSuccess());
- EXPECT_EQ(2, module.GetNumWarnings());
+ EXPECT_EQ(2u, module.GetNumWarnings());
+ EXPECT_EQ(0u, module.GetNumErrors());
}
TEST_F(CppInterface, ZeroErrorsZeroWarnings) {
@@ -455,8 +457,8 @@ TEST_F(CppInterface, ZeroErrorsZeroWarnings) {
kMinimalShader, strlen(kMinimalShader),
shaderc_glsl_vertex_shader);
EXPECT_TRUE(module.GetSuccess());
- EXPECT_EQ(0, module.GetNumErrors());
- EXPECT_EQ(0, module.GetNumWarnings());
+ EXPECT_EQ(0u, module.GetNumErrors());
+ EXPECT_EQ(0u, module.GetNumWarnings());
}
TEST_F(CppInterface, PreprocessingOnlyOption) {
diff --git a/libshaderc/src/shaderc_test.cc b/libshaderc/src/shaderc_test.cc
index 2f49f93..cccd773 100644
--- a/libshaderc/src/shaderc_test.cc
+++ b/libshaderc/src/shaderc_test.cc
@@ -436,9 +436,9 @@ TEST_F(CompileStringWithOptionsTest, GetNumErrors) {
shaderc_glsl_vertex_shader, options_.get());
// Expects compilation failure and two errors.
EXPECT_FALSE(shaderc_module_get_success(comp.result()));
- EXPECT_EQ(2, shaderc_module_get_num_errors(comp.result()));
+ EXPECT_EQ(2u, shaderc_module_get_num_errors(comp.result()));
// Expects the number of warnings to be zero.
- EXPECT_EQ(0, shaderc_module_get_num_warnings(comp.result()));
+ EXPECT_EQ(0u, shaderc_module_get_num_warnings(comp.result()));
}
TEST_F(CompileStringWithOptionsTest, GetNumWarnings) {
@@ -446,9 +446,9 @@ TEST_F(CompileStringWithOptionsTest, GetNumWarnings) {
shaderc_glsl_vertex_shader, options_.get());
// Expects compilation success with two warnings.
EXPECT_TRUE(shaderc_module_get_success(comp.result()));
- EXPECT_EQ(2, shaderc_module_get_num_warnings(comp.result()));
+ EXPECT_EQ(2u, shaderc_module_get_num_warnings(comp.result()));
// Expects the number of errors to be zero.
- EXPECT_EQ(0, shaderc_module_get_num_errors(comp.result()));
+ EXPECT_EQ(0u, shaderc_module_get_num_errors(comp.result()));
}
TEST_F(CompileStringWithOptionsTest, ZeroErrorsZeroWarnings) {
@@ -456,9 +456,9 @@ TEST_F(CompileStringWithOptionsTest, ZeroErrorsZeroWarnings) {
shaderc_glsl_vertex_shader);
// Expects compilation success with zero warnings.
EXPECT_TRUE(shaderc_module_get_success(comp.result()));
- EXPECT_EQ(0, shaderc_module_get_num_warnings(comp.result()));
+ EXPECT_EQ(0u, shaderc_module_get_num_warnings(comp.result()));
// Expects the number of errors to be zero.
- EXPECT_EQ(0, shaderc_module_get_num_errors(comp.result()));
+ EXPECT_EQ(0u, shaderc_module_get_num_errors(comp.result()));
}
TEST_F(CompileStringWithOptionsTest, PreprocessingOnlyOption) {