diff options
author | Kevin Lubick <kjlubick@google.com> | 2023-09-27 16:09:30 -0400 |
---|---|---|
committer | SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> | 2023-09-28 12:18:21 +0000 |
commit | cfac8410d773b9098677608a8fd0f5f2832192a5 (patch) | |
tree | 4bfc4b5dd1222a2ac192c05265f9aed5e05cdb7f /bazel/exporter_tool | |
parent | d410e03a6b9b0e7f77fe4bb562f396a97345d070 (diff) | |
download | skia-cfac8410d773b9098677608a8fd0f5f2832192a5.tar.gz |
Expand //:core and introduce //:png_decode_codec et al
This adds hopefully all the pieces needed to use the "core" aspects
of Skia. In this sense, the "core" module refers to more than just
the .cpp files that are in //src/core and exposed from //include/core.
Specifically, we have decided the following things are "core":
- include/core (e.g. SkPaint, SkCanvas, SkImage, SkFonts)
- include/effects
- include/sksl
- include/utils (currently a subset, may grow)
To make the above things work, we must pull in files from
various subfolders of //src (see //src/core:core for more details),
including:
- RasterPipeline (e.g. the CPU backend)
- Raster-backed SkImages
- Shaders (powered by sksl)
We could perhaps decouple core and RasterPipeline a bit more
in the future, making most of the CPU backend an optional add-in,
but that is beyond the scope of the project for now.
Follow-on CLs will:
- Add CI jobs to test these modules (both using the Skia toolchain
and a default toolchain)
- Move test binaries to use the modules and run these on the CI.
- Add more modules (e.g. more Font Manager options, GPU backends)
Suggested review order:
- example/external_client/ to see the sample code and how it looks
from the client POV
- src/core/BUILD.bazel to see all the pieces
- SkOpts related code to see some minor tweaks to how skopts is
built (had to disconnect it from the legacy build's include rules)
- All other BUILD.bazel files in any order.
- bazel/ to see dependency-related minor changes.
Change-Id: I13eca3e4aa73016524533e653c1259c69063b381
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/753176
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Diffstat (limited to 'bazel/exporter_tool')
-rw-r--r-- | bazel/exporter_tool/main.go | 24 |
1 files changed, 12 insertions, 12 deletions
diff --git a/bazel/exporter_tool/main.go b/bazel/exporter_tool/main.go index 5b6a6d5b06..ab36166d87 100644 --- a/bazel/exporter_tool/main.go +++ b/bazel/exporter_tool/main.go @@ -59,13 +59,13 @@ var gniExportDescs = []exporter.GNIExportDesc{ "//src/base:private_hdrs", "//src/base:skslc_srcs", "//src/base:srcs", - "//src/core:_core_hdrs", - "//src/core:_core_srcs", + "//src/core:legacy_core_hdrs", + "//src/core:legacy_core_srcs", "//src/core:core_skslc_hdrs", "//src/core:core_skslc_srcs", "//src/core:legacy_draw_looper", - "//src/image:core_hdrs", - "//src/image:core_srcs", + "//src/image:image_hdrs", + "//src/image:image_srcs", "//src/lazy:lazy_hdrs", "//src/lazy:lazy_srcs", "//src/opts:private_hdrs", @@ -174,8 +174,8 @@ var gniExportDescs = []exporter.GNIExportDesc{ "//src/sksl/tracing:srcs", "//src/sksl/transform:transform_hdrs", "//src/sksl/transform:transform_srcs", - "//src/sksl:core_hdrs", - "//src/sksl:core_srcs", + "//src/sksl:sksl_hdrs", + "//src/sksl:sksl_srcs", }}, {Var: "skia_sksl_tracing_sources", Rules: []string{ @@ -196,8 +196,8 @@ var gniExportDescs = []exporter.GNIExportDesc{ "//src/gpu/ganesh:core_skslc_srcs", "//src/ports:malloc", "//src/ports:osfile", - "//src/utils:core_skslc_hdrs", - "//src/utils:core_skslc_srcs", + "//src/utils:utils_skslc_hdrs", + "//src/utils:utils_skslc_srcs", "//src/utils:json_srcs", }}}, }, @@ -229,10 +229,10 @@ var gniExportDescs = []exporter.GNIExportDesc{ "//src/utils:chromium_hdrs"}}, {Var: "skia_utils_private", Rules: []string{ - "//src/utils:core_hdrs", - "//src/utils:core_skslc_hdrs", - "//src/utils:core_skslc_srcs", - "//src/utils:core_srcs", + "//src/utils:utils_hdrs", + "//src/utils:utils_skslc_hdrs", + "//src/utils:utils_skslc_srcs", + "//src/utils:utils_srcs", "//src/utils:json_hdrs", "//src/utils:json_srcs", "//src/utils/mac:core_hdrs", |