diff options
| author | Dmitry V. Levin <ldv@altlinux.org> | 2015-11-30 00:57:14 +0000 |
|---|---|---|
| committer | Dmitry V. Levin <ldv@altlinux.org> | 2015-11-30 00:57:14 +0000 |
| commit | 64672a6526f041b3c35bf1d801a8f3f5457eca51 (patch) | |
| tree | 506303c748a39a1336d3baedb6c29a1de227449d /linux/mips | |
| parent | f51aec6abfad5dae5f3dd77365c2f8275e37437d (diff) | |
| download | strace-64672a6526f041b3c35bf1d801a8f3f5457eca51.tar.gz | |
cleanup: make get_syscall_args.c files more readable
Make get_syscall_args.c files more self-contained. While they are
still being included by syscall.c, the latter no longer defines
get_syscall_args function.
* linux/aarch64/get_syscall_args.c: Include "arm/get_syscall_args.c"
with get_syscall_args temporarily defined to arm_get_syscall_args.
(get_syscall_args): Define.
* linux/alpha/get_syscall_args.c (get_syscall_args): Define.
* linux/arc/get_syscall_args.c: Likewise.
* linux/arm/get_syscall_args.c: Likewise.
* linux/avr32/get_syscall_args.c: Likewise.
* linux/bfin/get_syscall_args.c: Likewise.
* linux/crisv10/get_syscall_args.c: Likewise.
* linux/hppa/get_syscall_args.c: Likewise.
* linux/i386/get_syscall_args.c: Likewise.
* linux/ia64/get_syscall_args.c: Likewise.
* linux/m68k/get_syscall_args.c: Likewise.
* linux/metag/get_syscall_args.c: Likewise.
* linux/microblaze/get_syscall_args.c: Likewise.
* linux/mips/get_syscall_args.c: Likewise.
* linux/nios2/get_syscall_args.c: Likewise.
* linux/or1k/get_syscall_args.c: Likewise.
* linux/powerpc/get_syscall_args.c: Likewise.
* linux/s390/get_syscall_args.c: Likewise.
* linux/sh/get_syscall_args.c: Likewise.
* linux/sh64/get_syscall_args.c: Likewise.
* linux/sparc/get_syscall_args.c: Likewise.
* linux/tile/get_syscall_args.c: Likewise.
* linux/x86_64/get_syscall_args.c: Likewise.
* linux/xtensa/get_syscall_args.c: Likewise.
* syscall.c (get_syscall_args): Remove.
Include "get_syscall_args.c" in file scope.
Requested-by: Denys Vlasenko <dvlasenk@redhat.com>
Diffstat (limited to 'linux/mips')
| -rw-r--r-- | linux/mips/get_syscall_args.c | 13 |
1 files changed, 10 insertions, 3 deletions
diff --git a/linux/mips/get_syscall_args.c b/linux/mips/get_syscall_args.c index 4e4a22b7..a20be8de 100644 --- a/linux/mips/get_syscall_args.c +++ b/linux/mips/get_syscall_args.c @@ -1,3 +1,7 @@ +/* Return -1 on error or 1 on success (never 0!). */ +static int +get_syscall_args(struct tcb *tcp) +{ #if defined LINUX_MIPSN64 tcp->u_arg[0] = mips_REG_A0; tcp->u_arg[1] = mips_REG_A1; @@ -18,10 +22,13 @@ tcp->u_arg[2] = mips_REG_A2; tcp->u_arg[3] = mips_REG_A3; if (tcp->s_ent->nargs > 4) { - umoven(tcp, mips_REG_SP + 4 * 4, - (tcp->s_ent->nargs - 4) * sizeof(tcp->u_arg[0]), - &tcp->u_arg[4]); + if (umoven(tcp, mips_REG_SP + 4 * 4, + (tcp->s_ent->nargs - 4) * sizeof(tcp->u_arg[0]), + &tcp->u_arg[4]) < 0) + return -1; } #else # error unsupported mips abi #endif + return 1; +} |